[PATCH v2] conf: virDomainGraphicsDefValidate: validate attribute 'network' for listen type 'network'

2022-04-13 Thread Amneesh Singh
Related: https://gitlab.com/libvirt/libvirt/-/issues/93 Signed-off-by: Amneesh Singh --- v1 PATCH: https://listman.redhat.com/archives/libvir-list/2022-April/230021.html src/conf/domain_validate.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/conf/domain_vali

Re: [PATCH 00/14] docs: Convert some pages to rST and clean up (part 5)

2022-04-13 Thread Peter Krempa
On Wed, Apr 13, 2022 at 18:02:01 +0200, Peter Krempa wrote: > This series corrects some mistakes from previous conversions (local > anchor links, ordering of input files) and finishes the conversion of > format* documents. Output of the CI pipeline for the converted documents: https://pipo.sk.git

[PATCH 00/14] docs: Convert some pages to rST and clean up (part 5)

2022-04-13 Thread Peter Krempa
This series corrects some mistakes from previous conversions (local anchor links, ordering of input files) and finishes the conversion of format* documents. Pavel Hrdina (1): docs: Convert 'formatnwfilter' page to rst Peter Krempa (13): docs: meson: Sort list of RST files to build docs: api

[PATCH 13/14] docs: Convert 'formatnetwork' page to rst

2022-04-13 Thread Peter Krempa
Additionally hyperlinks in other parts of the documentation are updated to match. Signed-off-by: Peter Krempa --- docs/formatdomain.rst |4 +- docs/formatnetwork.html.in | 1479 docs/formatnetwork.rst | 1144 docs/for

[PATCH 07/14] docs: drvsecret: Fix local anchor links

2022-04-13 Thread Peter Krempa
Original conversion didn't properly convert local links. Fix them by pointing to the section name. In certain cases this requires reformulation of the text. Signed-off-by: Peter Krempa --- docs/formatsecret.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/

[PATCH 14/14] docs: Convert 'formatnode' page to rst

2022-04-13 Thread Peter Krempa
The conversion also included a change to the layout of the document. Specifically the individual 'capabilty' types are now separated under individual headings rather than part of the original definition list. This reduces nesting but also esures that proper anchors are generated automatically. Si

[PATCH 03/14] docs: drivers: Fix local anchor links

2022-04-13 Thread Peter Krempa
Original conversion didn't properly convert local links. Fix them by pointing to the section name. In certain cases this requires reformulation of the text. Signed-off-by: Peter Krempa --- docs/drivers.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drivers.rst b/doc

[PATCH 12/14] docs: Convert 'formatcaps' page to rst

2022-04-13 Thread Peter Krempa
binB2_5OJ2HXO.bin Description: Binary data

[PATCH 05/14] docs: drvesx: Fix local anchor links

2022-04-13 Thread Peter Krempa
Original conversion didn't properly convert local links. Fix them by pointing to the section name. In certain cases this requires reformulation of the text. Signed-off-by: Peter Krempa --- docs/drvesx.rst | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/do

[PATCH 06/14] docs: drvnodedev: Fix local anchor links

2022-04-13 Thread Peter Krempa
Original conversion didn't properly convert local links. Fix them by pointing to the section name. In certain cases this requires reformulation of the text. Signed-off-by: Peter Krempa --- docs/drvnodedev.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/do

[PATCH 09/14] docs: kbase/tlscerts: Fix local anchor links

2022-04-13 Thread Peter Krempa
Original conversion didn't properly convert local links. Fix them by pointing to the section name. In certain cases this requires reformulation of the text. Signed-off-by: Peter Krempa --- docs/kbase/tlscerts.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/kba

[PATCH 01/14] docs: meson: Sort list of RST files to build

2022-04-13 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/meson.build b/docs/meson.build index a0e69f3119..a8e360c8a4 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -72,13 +72,13 @@ docs_rst_files = [ 'formatbackup',

[PATCH 02/14] docs: api: Fix local anchor links

2022-04-13 Thread Peter Krempa
Original conversion didn't properly convert local links. Fix them by pointing to the section name. In certain cases this requires reformulation of the text. Signed-off-by: Peter Krempa --- docs/api.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/api.rst b/docs/a

[PATCH 04/14] docs: drvbhve: Fix local anchor links

2022-04-13 Thread Peter Krempa
Original conversion didn't properly convert local links. Fix them by pointing to the section name. In certain cases this requires reformulation of the text. Signed-off-by: Peter Krempa --- docs/drvbhyve.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/drvbhyve.r

[PATCH 10/14] docs: pci-hotplug: Fix local anchor links

2022-04-13 Thread Peter Krempa
Original conversion didn't properly convert local links. Fix them by pointing to the section name. In certain cases this requires reformulation of the text. Signed-off-by: Peter Krempa --- docs/pci-hotplug.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/pci-hotp

[PATCH 08/14] docs: kbase/launch_security_sev: Fix local anchor links

2022-04-13 Thread Peter Krempa
Original conversion didn't properly convert local links. Fix them by pointing to the section name. In certain cases this requires reformulation of the text. Signed-off-by: Peter Krempa --- docs/kbase/launch_security_sev.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs

[libvirt PATCH 1/1] ci: integration: Expose installed packages on failure

2022-04-13 Thread Erik Skultety
Since the VM template images are updated only once during the libvirt release cycle in order to keep a stable/reproducible environment for the test suite, it's necessary to dump the list of installed packages on failure, so that anyone can then see what package versions were installed in the enviro

[libvirt PATCH 0/1] ci: integration: Expose list of installed packages on failure

2022-04-13 Thread Erik Skultety
Erik Skultety (1): ci: integration: Expose installed packages on failure ci/integration.yml | 1 + 1 file changed, 1 insertion(+) -- 2.34.1

Re: [PATCH 2/2] qemu: fix one more race on undefining and create

2022-04-13 Thread Nikolay Shirokovskiy
ср, 13 апр. 2022 г. в 17:33, Martin Kletzander : > > On Wed, Apr 13, 2022 at 11:43:32AM +0300, Nikolay Shirokovskiy wrote: > >[1] closes gap in virDomainObjListRemove so that concurrent thread can > >not step in and obtain the domain while domain is temporary unlocked. But > >there is another gap e

Re: [PATCH 2/2] qemu: fix one more race on undefining and create

2022-04-13 Thread Martin Kletzander
On Wed, Apr 13, 2022 at 11:43:32AM +0300, Nikolay Shirokovskiy wrote: [1] closes gap in virDomainObjListRemove so that concurrent thread can not step in and obtain the domain while domain is temporary unlocked. But there is another gap exist: thread B - executes create API thread C - executes un

Re: [PATCH 1/2] qemu: drop needless acquiring job on removing domain

2022-04-13 Thread Martin Kletzander
On Wed, Apr 13, 2022 at 11:43:31AM +0300, Nikolay Shirokovskiy wrote: Acquiring job introduced in commit [1] to fix a race described in the commit. Actually it does not help because we get domain in create API before acuiring job. Wow, this is a blast from the past =D But anyway, I'm honestly

Re: [PATCH] virDomainGraphicsListenDefParseXML: validate attribute 'network' for listen type 'network'

2022-04-13 Thread Martin Kletzander
On Tue, Apr 12, 2022 at 06:40:24PM +0530, Amneesh Singh wrote: Related: https://gitlab.com/libvirt/libvirt/-/issues/93 Signed-off-by: Amneesh Singh --- src/conf/domain_conf.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index bd28840..

Re: [PATCH 0/4] qemu: a bugfix and a few cleanups of graphics port releasing

2022-04-13 Thread Martin Kletzander
On Tue, Apr 12, 2022 at 10:31:26AM +0300, Nikolay Shirokovskiy wrote: Nikolay Shirokovskiy (4): qemu: cleanup code to release VNC port qemu: fix releasing VNC websocket port domain does not own qemu: cleanup code to release VNC websocket port qemu: cleanup code to relece SPICE ports Review

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-04-13 Thread Ani Sinha
On Tue, Apr 12, 2022 at 12:41 PM Michael S. Tsirkin wrote: > > On Tue, Apr 12, 2022 at 09:52:26AM +0530, Ani Sinha wrote: > > On Tue, Apr 12, 2022 at 9:50 AM Ani Sinha wrote: > > > > > > On Tue, Mar 8, 2022 at 10:28 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Mar 08, 2022 at 10:1

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-04-13 Thread Ani Sinha
On Tue, Apr 12, 2022 at 12:34 PM Michael S. Tsirkin wrote: > > On Tue, Apr 12, 2022 at 09:50:15AM +0530, Ani Sinha wrote: > > On Tue, Mar 8, 2022 at 10:28 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Mar 08, 2022 at 10:15:49PM +0530, Ani Sinha wrote: > > > > > > > > Change log: > > > > v2: re

Re: Help - Troubleshoot libvirt

2022-04-13 Thread Martin Kletzander
On Wed, Apr 06, 2022 at 10:13:38AM +, Eduardo Kiassucumuca wrote: Good morning I'm Eduardo, a computer science student and I'm doing a final course work focused on virtualization. The work consists of creating virtual machines on a server and allowing ssh access to the virtual machines that a

Help - Troubleshoot libvirt

2022-04-13 Thread Eduardo Kiassucumuca
Good morning I'm Eduardo, a computer science student and I'm doing a final course work focused on virtualization. The work consists of creating virtual machines on a server and allowing ssh access to the virtual machines that are on the server containing qemu/kvm/libvirt. The problem is that I c

Re: [PATCH 0/2] docs: Adapt XSL/CSS to docutils-0.17 and later

2022-04-13 Thread Martin Kletzander
On Tue, Apr 12, 2022 at 01:53:03PM +0200, Peter Krempa wrote: The breakage will be visible only when you build with newer docutils such as is in fedora rawhide. Alternatively you can install one locally for your user via 'pip install docutils --force' and then build the tree via: export PYTHON

Re: [PATCH 0/2] docs: Adapt XSL/CSS to docutils-0.17 and later

2022-04-13 Thread Jiri Denemark
On Tue, Apr 12, 2022 at 13:53:03 +0200, Peter Krempa wrote: > The breakage will be visible only when you build with newer docutils > such as is in fedora rawhide. > > Alternatively you can install one locally for your user via 'pip install > docutils --force' and then build the tree via: > > ex

[PATCH 1/2] qemu: drop needless acquiring job on removing domain

2022-04-13 Thread Nikolay Shirokovskiy
Acquiring job introduced in commit [1] to fix a race described in the commit. Actually it does not help because we get domain in create API before acuiring job. Then [2] fix the race but [1] was not reverted even is does not required by [2] to work properly. [1] commit b629c64e5e0a32ef439b8eeb3a69

[PATCH 2/2] qemu: fix one more race on undefining and create

2022-04-13 Thread Nikolay Shirokovskiy
[1] closes gap in virDomainObjListRemove so that concurrent thread can not step in and obtain the domain while domain is temporary unlocked. But there is another gap exist: thread B - executes create API thread C - executes undefine API - thread A executes some job on domain - threads B and C obt

[PATCH 0/2] qemu: fix and cleanup for a race on undefine and create

2022-04-13 Thread Nikolay Shirokovskiy
Nikolay Shirokovskiy (2): qemu: drop needless acquiring job on removing domain qemu: fix one more race on undefining and create src/qemu/qemu_domain.c| 45 +-- src/qemu/qemu_domain.h| 10 - src/qemu/qemu_domainjob.c | 10 + src/qemu/

Re: [libvirt RFC] qemu_saveimage: only use wrapper when using --bypass-cache

2022-04-13 Thread Claudio Fontana
On 4/13/22 8:57 AM, Ani Sinha wrote: > On Wed, Apr 13, 2022 at 11:57 AM Claudio Fontana wrote: >> >> On 4/13/22 6:13 AM, Ani Sinha wrote: >>> On Wed, Apr 13, 2022 at 12:49 AM Claudio Fontana wrote: On 4/12/22 7:23 PM, Ani Sinha wrote: > On Tue, Apr 12, 2022 at 10:09 PM Ani Sinha wr

Re: [PATCH 0/2] docs: Adapt XSL/CSS to docutils-0.17 and later

2022-04-13 Thread Michal Prívozník
On 4/12/22 13:53, Peter Krempa wrote: > The breakage will be visible only when you build with newer docutils > such as is in fedora rawhide. > > Alternatively you can install one locally for your user via 'pip install > docutils --force' and then build the tree via: > > export PYTHONPATH=~/.loc

Re: [libvirt RFC] qemu_saveimage: only use wrapper when using --bypass-cache

2022-04-13 Thread Ani Sinha
On Tue, Apr 12, 2022 at 2:48 PM Claudio Fontana wrote: > > align the "save" with the "restore" code, > by only using the wrapper when using --bypass-cache. > > This avoids a copy, resulting in better performance. > > Signed-off-by: Claudio Fontana Reviewed-by: Ani Sinha > --- > src/qemu/qemu_