Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Richard W.M. Jones
On Tue, Apr 19, 2022 at 03:00:58PM -0500, Jonathon Jongsma wrote: > On 4/19/22 12:31 PM, Richard W.M. Jones wrote: > >On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote: > >>And now I notice that we do not actually have support for 'ssh' > >>network disks in our xml schema either

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Jonathon Jongsma
On 4/19/22 12:31 PM, Richard W.M. Jones wrote: On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote: Well, As far as I can tell, there is no valid XML for exercising http auth. The schema for http(s) sources does not include any element [1]. And the schema for the element [2]

Re: [PATCH] domain_cgroup: Fix a condition in virDomainCgroupConnectCgroup()

2022-04-19 Thread Ján Tomko
On a Tuesday in 2022, Michal Privoznik wrote: While parts of QEMU's CGroup code were moved under hypervisor agnostic location (src/hypervisor/) a typo sneaked in. The inspiration for virDomainCgroupConnectCgroup() comes from qemuConnectCgroup(). The former is called upon reconnecting to a

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Daniel P . Berrangé
On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote: > On 4/19/22 9:05 AM, Daniel P. Berrangé wrote: > > On Thu, Apr 14, 2022 at 05:02:46PM -0500, Jonathon Jongsma wrote: > > > As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=2016527, RHEL > > > is > > > planning to remove

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Richard W.M. Jones
On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote: > Well, As far as I can tell, there is no valid XML for exercising > http auth. The schema for http(s) sources does not include any > element [1]. And the schema for the element [2] > requires a element with a required 'type'

[PATCH] apparmor: Allow swtpm to use its own apparmor profile

2022-04-19 Thread Lena Voytek
Signed-off-by: Lena Voytek --- src/security/apparmor/libvirt-qemu | 3 ++- src/security/apparmor/usr.sbin.libvirtd.in | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index 250ba4ea58..c29168da27

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Jonathon Jongsma
On 4/19/22 9:05 AM, Daniel P. Berrangé wrote: On Thu, Apr 14, 2022 at 05:02:46PM -0500, Jonathon Jongsma wrote: As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=2016527, RHEL is planning to remove dependencies on the qemu-block-curl and qemu-block-ssh plugins from the main qemu

[PATCH] domain_cgroup: Fix a condition in virDomainCgroupConnectCgroup()

2022-04-19 Thread Michal Privoznik
While parts of QEMU's CGroup code were moved under hypervisor agnostic location (src/hypervisor/) a typo sneaked in. The inspiration for virDomainCgroupConnectCgroup() comes from qemuConnectCgroup(). The former is called upon reconnecting to a running domain (after daemon restart). While the

Re: [libvirt PATCH] Fix copy-paste error in virNetServerSetClientAuthenticated

2022-04-19 Thread Michal Prívozník
On 4/19/22 17:11, Tim Wiederhake wrote: > Fixes: db16792aa90cab5c9886fc2990ec13fbb20a3fb5 > Signed-off-by: Tim Wiederhake > --- > src/rpc/virnetserver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c > index

[libvirt PATCH] Fix copy-paste error in virNetServerSetClientAuthenticated

2022-04-19 Thread Tim Wiederhake
Fixes: db16792aa90cab5c9886fc2990ec13fbb20a3fb5 Signed-off-by: Tim Wiederhake --- src/rpc/virnetserver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index 9b333f1a6c..371b72c8d6 100644 --- a/src/rpc/virnetserver.c +++

Re: [RFC PATCH v1 0/5] Add virDomainGetSevAttestationReport API

2022-04-19 Thread Cole Robinson
On 4/14/22 2:46 PM, Tyler Fanelli wrote: > On 4/11/22 10:57 AM, Cole Robinson wrote: >> On 3/23/22 3:36 PM, Tyler Fanelli wrote: >>> This an RFC discussing a new API, virDomainGetSevAttestationReport >>> (along with a >>> virsh command "domgetsevreport"), with initial QEMU support via the >>>

Re: Network disks and replacing qemu-block-curl|ssh with nbdkit

2022-04-19 Thread Daniel P . Berrangé
On Thu, Apr 14, 2022 at 05:02:46PM -0500, Jonathon Jongsma wrote: > As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=2016527, RHEL is > planning to remove dependencies on the qemu-block-curl and qemu-block-ssh > plugins from the main qemu package. This creates issues for libvirt for >

Re: [PATCH v2 00/34] Add 'version' to other exported types

2022-04-19 Thread Peter Krempa
On Tue, Apr 19, 2022 at 15:23:07 +0200, Victor Toso wrote: > Hi, > > On Tue, Apr 19, 2022 at 02:31:01PM +0200, Peter Krempa wrote: > > On Thu, Apr 14, 2022 at 22:47:11 +0200, Victor Toso wrote: > > > Hi, > > > > Couple of comments which I summarize on the top level rather than doing > >

Re: [PATCH v2 03/34] docs: generated: enums: libvirt: append 'Since version' metadata

2022-04-19 Thread Victor Toso
Hi, On Tue, Apr 19, 2022 at 06:37:19AM -0700, Andrea Bolognani wrote: > On Tue, Apr 19, 2022 at 03:30:12PM +0200, Peter Krempa wrote: > > On Tue, Apr 19, 2022 at 15:17:07 +0200, Victor Toso wrote: > > > On Tue, Apr 19, 2022 at 02:40:05PM +0200, Peter Krempa wrote: > > > > On Thu, Apr 14, 2022 at

Re: [PATCH v2 03/34] docs: generated: enums: libvirt: append 'Since version' metadata

2022-04-19 Thread Andrea Bolognani
On Tue, Apr 19, 2022 at 03:30:12PM +0200, Peter Krempa wrote: > On Tue, Apr 19, 2022 at 15:17:07 +0200, Victor Toso wrote: > > On Tue, Apr 19, 2022 at 02:40:05PM +0200, Peter Krempa wrote: > > > On Thu, Apr 14, 2022 at 22:47:14 +0200, Victor Toso wrote: > > > > typedef enum { > > > >

Re: [PATCH v2 03/34] docs: generated: enums: libvirt: append 'Since version' metadata

2022-04-19 Thread Peter Krempa
On Tue, Apr 19, 2022 at 15:17:07 +0200, Victor Toso wrote: > Hi, > > On Tue, Apr 19, 2022 at 02:40:05PM +0200, Peter Krempa wrote: > > On Thu, Apr 14, 2022 at 22:47:14 +0200, Victor Toso wrote: > > > Minor hand adjustments around syntax, not the metadata per se. > > > > > > Signed-off-by: Victor

Re: [PATCH v2 33/34] syms: libvirt: move virDomainSetBlockThreshold to 3.2.0

2022-04-19 Thread Peter Krempa
On Thu, Apr 14, 2022 at 22:47:44 +0200, Victor Toso wrote: > Found thanks to scripts/apibuild.py complain: > > | Function virDomainSetBlockThreshold has symversion 3.1.0 but docstring > says 3.2.0 > > Add in bb09798fbe "lib: Add API for setting the threshold size for >

Re: [PATCH v2 32/34] syms: admin: Add sections to match when API was introduced

2022-04-19 Thread Peter Krempa
On Thu, Apr 14, 2022 at 22:47:43 +0200, Victor Toso wrote: > Discover this mismatch with the docstring work. > scripts/apibuild.py complained. > > Signed-off-by: Victor Toso > --- > src/admin/libvirt_admin_public.syms | 58 ++--- > 1 file changed, 45 insertions(+), 13

Re: [PATCH v2 00/34] Add 'version' to other exported types

2022-04-19 Thread Victor Toso
Hi, On Tue, Apr 19, 2022 at 02:31:01PM +0200, Peter Krempa wrote: > On Thu, Apr 14, 2022 at 22:47:11 +0200, Victor Toso wrote: > > Hi, > > Couple of comments which I summarize on the top level rather than doing > specifics since they might need a reorg of the series: > > > > > The goal of this

Re: [PATCH v2 03/34] docs: generated: enums: libvirt: append 'Since version' metadata

2022-04-19 Thread Victor Toso
Hi, On Tue, Apr 19, 2022 at 02:40:05PM +0200, Peter Krempa wrote: > On Thu, Apr 14, 2022 at 22:47:14 +0200, Victor Toso wrote: > > Minor hand adjustments around syntax, not the metadata per se. > > > > Signed-off-by: Victor Toso > > --- > > include/libvirt/libvirt-domain-checkpoint.h | 28 +-

Re: [PATCH v2 03/34] docs: generated: enums: libvirt: append 'Since version' metadata

2022-04-19 Thread Peter Krempa
On Thu, Apr 14, 2022 at 22:47:14 +0200, Victor Toso wrote: > Minor hand adjustments around syntax, not the metadata per se. > > Signed-off-by: Victor Toso > --- > include/libvirt/libvirt-domain-checkpoint.h | 28 +- > include/libvirt/libvirt-domain-snapshot.h | 60 +- >

Re: [PATCH v2 02/34] docs: variable: Move docstring from source to header file

2022-04-19 Thread Peter Krempa
On Thu, Apr 14, 2022 at 22:47:13 +0200, Victor Toso wrote: > virConnectAuthPtrDefault is the only variable that we export and with > the documentation being at the C file, it makes harder to find it. > > With this patch, the documentation of this variable can be found by > those who look at the

Re: [PATCH v2 00/34] Add 'version' to other exported types

2022-04-19 Thread Peter Krempa
On Thu, Apr 14, 2022 at 22:47:11 +0200, Victor Toso wrote: > Hi, Couple of comments which I summarize on the top level rather than doing specifics since they might need a reorg of the series: > > The goal of this patch series is to provide 'since' version to all > exported types. > > This is

Re: [libvirt PATCH 0/7] qemu: Retire two ppc64-specific capabilities

2022-04-19 Thread Peter Krempa
On Fri, Apr 15, 2022 at 15:29:59 +0200, Andrea Bolognani wrote: > All QEMU versions we support have the corresponding features. > > Andrea Bolognani (7): > tests: Drop pseries-machine-max-cpu-compat > qemu: Assume QEMU_CAPS_MACHINE_PSERIES_MAX_CPU_COMPAT > qemu: Stop setting

Re: [libvirt PATCH] qemu: Shorten domain name in virtiofsd log path

2022-04-19 Thread Daniel P . Berrangé
On Thu, Apr 07, 2022 at 03:19:27PM +0200, Martin Kletzander wrote: > On Thu, Apr 07, 2022 at 02:14:30PM +0200, Ján Tomko wrote: > > On a Thursday in 2022, Martin Kletzander wrote: > > > This helps when starting domains with long names which could possibly end > > > up > > > creating too long of a

Re: what is virtunixd ? Is there such a daemon?

2022-04-19 Thread Daniel P . Berrangé
On Thu, Apr 07, 2022 at 10:19:13AM +0200, Claudio Fontana wrote: > Hello, > > as I experiment with virsh migration commands (and probably I do things that > don't make sense), > > I got an error I could not understand: > > # virsh migrate centos7 unix:///tmp/netcat.sock > error: Failed to

Re: [PATCH] qemu: Fetch info on NVDIMM-s too when updating memory devices

2022-04-19 Thread Ján Tomko
On a Tuesday in 2022, Michal Privoznik wrote: Sometimes it may come handy to learn what address is a NVDIMM mapped to inside a guest. While users can provide an address they want to have NVDIMM mapped to, it's optional. Fortunately, when a domain is being started we issue the

[PATCH] qemu: Fetch info on NVDIMM-s too when updating memory devices

2022-04-19 Thread Michal Privoznik
Sometimes it may come handy to learn what address is a NVDIMM mapped to inside a guest. While users can provide an address they want to have NVDIMM mapped to, it's optional. Fortunately, when a domain is being started we issue the 'query-memory-devices' monitor command and the reply is the same

Re: [libvirt PATCH] util: Fix stubs for virProcessGet{Stat,Sched}Info()

2022-04-19 Thread Ján Tomko
On a Friday in 2022, Andrea Bolognani wrote: Commit d73852c49962 moved the original QEMU-specific helpers to the utils module, which resulted in build failures on non-Unix platforms due to the unconditional use of Unix-only symbols such as _SC_CLK_TCK. To deal with that situation, commit