Re: [libvirt PATCH v2 0/4] Enable copy/paste for vnc displays

2022-05-09 Thread Jonathon Jongsma
On 5/9/22 11:06 AM, Marc-André Lureau wrote: Hi Jonathon On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma > wrote: This patch series enables support for the qemu-vdagent character device which enables copy/paste support between guest and client when

Re: [libvirt PATCH v2 0/4] Enable copy/paste for vnc displays

2022-05-09 Thread Marc-André Lureau
Hi Jonathon On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma wrote: > This patch series enables support for the qemu-vdagent character device > which > enables copy/paste support between guest and client when using vnc > graphics. > > The guest must be configured with something like the

Re: [libvirt PATCH 0/5] ci: Add an integration test job utilizing upstream QEMU

2022-05-09 Thread Michal Prívozník
On 5/6/22 17:35, Erik Skultety wrote: > Since QEMU doesn't maintain a spec file in upstream, we cannot build RPM > artifacts as part of the CI as we do for libvirt. Instead of hard-coding the > build steps for QEMU though patch 3/5 pulls in QEMU's CI job template which > means we'll remain in sync

[PATCH RFC 00/10] qemu: Enable SCHED_CORE for domains and helper processes

2022-05-09 Thread Michal Privoznik
The Linux kernel offers a way to mitigate side channel attacks on Hyper Threads (e.g. MDS and L1TF). Long story short, userspace can define groups of processes (aka trusted groups) and only processes within one group can run on sibling Hyper Threads. The group membership is automatically preserved

[PATCH RFC 10/10] qemu: Place helper processes into the same trusted group

2022-05-09 Thread Michal Privoznik
Since the level of trust that QEMU has is the same level of trust that helper processes have there's no harm in placing all of them into the same group. Unfortunately, since these processes are started before QEMU we can't use brand new virCommand*() APIs (those are used on hotplug though) and

[PATCH RFC 03/10] qemu_vhost_user_gpu: Export qemuVhostUserGPUGetPid()

2022-05-09 Thread Michal Privoznik
In near future it will be necessary to know the PID of vhost-user-gpu process for QEMU. Export the function that does just that (qemuVhostUserGPUGetPid()). Signed-off-by: Michal Privoznik --- src/qemu/qemu_vhost_user_gpu.c | 2 +- src/qemu/qemu_vhost_user_gpu.h | 8 2 files changed, 9

[PATCH RFC 08/10] qemu_conf: Introduce a knob to turn off SCHED_CORE

2022-05-09 Thread Michal Privoznik
Ideally, we would just pick the best default and users wouldn't have to intervene at all. But in some cases it may be handy to not bother with SCHED_CORE at all and thus let users turn the feature off in qemu.conf. Signed-off-by: Michal Privoznik --- src/qemu/libvirtd_qemu.aug | 1 +

[PATCH RFC 06/10] virprocess: Core Scheduling support

2022-05-09 Thread Michal Privoznik
Since its 5.14 release the Linux kernel allows userspace to define trusted groups of processes/threads that can run on sibling Hyper Threads (HT) at the same time. This is to mitigate side channel attacks like L1TF or MDS. If there are no tasks to fully utilize all HTs, then a HT will idle instead

[PATCH RFC 05/10] qemu_virtiofs: Separate PID read code into qemuVirtioFSGetPid

2022-05-09 Thread Michal Privoznik
In near future it will be necessary to know the PID of virtiofsd started for QEMU. Move the code into a separate function (qemuVirtioFSGetPid()) and export it in the header file. Signed-off-by: Michal Privoznik --- src/qemu/qemu_virtiofs.c | 38 +-

[PATCH RFC 09/10] qemu: Enable SCHED_CORE for domains and helper processes

2022-05-09 Thread Michal Privoznik
Despite all mitigations, side channel attacks when two processes run at two Hyper Threads of the same core are still possible. Fortunately, the Linux kernel came up with a solution: userspace can create so called trusted groups, which are sets of processes and only processes of the same group can

[PATCH RFC 07/10] virCommand: Introduce APIs for core scheduling

2022-05-09 Thread Michal Privoznik
There are two modes of core scheduling that are handy wrt virCommand: 1) create new trusted group when executing a virCommand 2) place freshly executed virCommand into the trusted group of another process. Therefore, implement these two new operations as new APIs: virCommandSetRunAlone() and

[PATCH RFC 04/10] qemu_tpm: Expose qemuTPMEmulatorGetPid()

2022-05-09 Thread Michal Privoznik
In near future it will be necessary to know the PID of swtpm process for QEMU. Export the function that does just that (qemuTPMEmulatorGetPid()). Signed-off-by: Michal Privoznik --- src/qemu/qemu_tpm.c | 2 +- src/qemu/qemu_tpm.h | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-)

[PATCH RFC 02/10] qemu_dbus: Separate PID read code into qemuDBusGetPID

2022-05-09 Thread Michal Privoznik
In near future it will be necessary to know the PID of DBus daemon started for QEMU. Move the code into a separate function (qemuDBusGetPID()) and export it in the header file. Signed-off-by: Michal Privoznik --- src/qemu/qemu_dbus.c | 42 +-

[PATCH RFC 01/10] qemu_tpm: Make APIs work over a single virDomainTPMDef

2022-05-09 Thread Michal Privoznik
In qemu_extdevice.c lives code that handles helper daemons that are required for some types of devices (e.g. virtiofsd, vhost-user-gpu, swtpm, etc.). These devices have their own handling code in separate files, with only a very basic functions exposed (e.g. for starting/stopping helper process,

Re: [PATCH] qemu_security: Drop qemuSecurityStartVhostUserGPU()

2022-05-09 Thread Ján Tomko
On a Monday in 2022, Michal Privoznik wrote: There's no real difference between qemuSecurityStartVhostUserGPU() and qemuSecurityCommandRun(). The latter is used more frequently while the former has just one user. Therefore, drop the less frequently used one. Signed-off-by: Michal Privoznik ---

[PATCH] qemu_security: Drop qemuSecurityStartVhostUserGPU()

2022-05-09 Thread Michal Privoznik
There's no real difference between qemuSecurityStartVhostUserGPU() and qemuSecurityCommandRun(). The latter is used more frequently while the former has just one user. Therefore, drop the less frequently used one. Signed-off-by: Michal Privoznik --- src/qemu/qemu_security.c | 40

Re: [PATCH v2 1/1] tests: qemucapabilities: update ppc64 qemu caps for 7.0.0 release

2022-05-09 Thread Daniel Henrique Barboza
On 5/9/22 10:30, Andrea Bolognani wrote: On Mon, May 09, 2022 at 07:27:57AM -0300, Daniel Henrique Barboza wrote: On 5/9/22 07:00, Andrea Bolognani wrote: Would you be okay with something like There are no major changes since 7.0.0-rc2, but a few additional features are enabled in

Re: [PATCH v2 1/1] tests: qemucapabilities: update ppc64 qemu caps for 7.0.0 release

2022-05-09 Thread Andrea Bolognani
On Mon, May 09, 2022 at 07:27:57AM -0300, Daniel Henrique Barboza wrote: > On 5/9/22 07:00, Andrea Bolognani wrote: > > Would you be okay with something like > > > >There are no major changes since 7.0.0-rc2, but a few additional > >features are enabled in this build. > > > > ? If so, I

Re: [PATCH RESEND] apibuild: Fix self.waring method call

2022-05-09 Thread Martin Kletzander
On Sat, May 07, 2022 at 09:17:31AM +0800, luzhipeng wrote: The parameters of self.warning is inconsistent with it's definition, So fix it. Signed-off-by: luzhipeng Reviewed-by: Martin Kletzander and pushed. --- scripts/apibuild.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 1/1] tests: qemucapabilities: update ppc64 qemu caps for 7.0.0 release

2022-05-09 Thread Daniel Henrique Barboza
On 5/9/22 07:00, Andrea Bolognani wrote: On Fri, May 06, 2022 at 04:54:22PM -0300, Daniel Henrique Barboza wrote: No relevant changes since the last update from 7.0.0-rc2. Sending it so we're sure that we don't need to worry about ppc64 caps for the 7.0.0 release anymore. There are

Re: [PATCH v2 1/1] tests: qemucapabilities: update ppc64 qemu caps for 7.0.0 release

2022-05-09 Thread Andrea Bolognani
On Fri, May 06, 2022 at 04:54:22PM -0300, Daniel Henrique Barboza wrote: > No relevant changes since the last update from 7.0.0-rc2. Sending it so > we're sure that we don't need to worry about ppc64 caps for the 7.0.0 > release anymore. There are actually a few additional features available in

Re: [PATCH 0/3] Add a retry procedure after failing to do post parsing

2022-05-09 Thread Daniel P . Berrangé
On Mon, May 09, 2022 at 10:22:56AM +0200, Peter Krempa wrote: > On Mon, May 09, 2022 at 09:12:51 +0100, Daniel P. Berrangé wrote: > > On Sat, May 07, 2022 at 05:40:13PM +0800, zhangjl02 wrote: > > > Get default emulator based on guest's arch, and replace it in domain's > > > definition after

Re: [PATCH 0/3] Add a retry procedure after failing to do post parsing

2022-05-09 Thread Peter Krempa
On Mon, May 09, 2022 at 09:12:51 +0100, Daniel P. Berrangé wrote: > On Sat, May 07, 2022 at 05:40:13PM +0800, zhangjl02 wrote: > > Get default emulator based on guest's arch, and replace it in domain's > > definition after domainPostParseDataAlloc's failure, then alloc again. > > This will solve

Re: [PATCH 0/3] Add a retry procedure after failing to do post parsing

2022-05-09 Thread Daniel P . Berrangé
On Sat, May 07, 2022 at 05:40:13PM +0800, zhangjl02 wrote: > Get default emulator based on guest's arch, and replace it in domain's > definition after domainPostParseDataAlloc's failure, then alloc again. > This will solve the migration problem because of qemu emulator location error, >

[PATCH] docs: apps: Add the app cockpit

2022-05-09 Thread Han Han
Signed-off-by: Han Han --- docs/apps.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/apps.rst b/docs/apps.rst index a21e2249ea..d01ad33f37 100644 --- a/docs/apps.rst +++ b/docs/apps.rst @@ -331,6 +331,10 @@ Web applications Secrets - Create and launch VMs -

Re: [PATCH 3/3] domain_conf: set default emulator into def if it fails to alloc

2022-05-09 Thread Peter Krempa
On Sat, May 07, 2022 at 17:40:16 +0800, zhangjl02 wrote: > From: zhangjl02 > > When emulator is not found on host, domainPostParseDataAlloc will return 1, > and the domain will fail to start. Call domainPostParseDataDefEmulator to > replace emulator with the default one of guest's arch, and try

Re: [PATCH v3 0/5] Introduce network backed NVRAM

2022-05-09 Thread Rohit Kumar
Ping. Hi, requesting review on this patchset. Thanks! On 04/05/22 10:21 pm, Rohit Kumar wrote: Libvirt domain XML currently allows only local filepaths that can be used to specify a NVRAM disk. It should be possible to support NVRAM disks on network storage as it would give flexibility to start

Re: [libvirt RFCv8 12/27] qemu: capabilities: add multifd to the probed migration capabilities

2022-05-09 Thread Ani Sinha
Qemu folks, It seems we do officially support multifd from version 4.0 : commit cbfd6c957a4437d4759ca660e621daa381bf2898 Author: Juan Quintela Date: Wed Feb 6 13:54:06 2019 +0100 multifd: Drop x- We make it supported from now on. Reviewed-by: Dr. David Alan Gilbert