RE: [libvirt][PATCH v11 1/4] qemu: provide support to query the SGX capability

> -Original Message- > From: Peter Krempa > Sent: Thursday, May 12, 2022 12:05 AM > To: Yang, Lin A > Cc: libvir-list@redhat.com; Huang, Haibin ; Ding, > Jian-feng ; Zhong, Yang > Subject: Re: [libvirt][PATCH v11 1/4] qemu: provide support to query the SGX > capability > > On Tue,

Re: [libvirt PATCH v3 4/6] conf: add support for 'blob' in virtio video device

On Thu, May 12, 2022 at 2:28 AM Jonathon Jongsma wrote: > On 5/11/22 9:56 AM, Han Han wrote: > > > > > > On Wed, May 11, 2022 at 12:26 AM Jonathon Jongsma > > wrote: > > > > Add the ability to enable blob resources for the virtio video device. > > This will

Re: [libvirt PATCH v3 4/6] conf: add support for 'blob' in virtio video device

On 5/11/22 9:56 AM, Han Han wrote: On Wed, May 11, 2022 at 12:26 AM Jonathon Jongsma > wrote: Add the ability to enable blob resources for the virtio video device. This will accelerate the display path due to less or no copying of pixel data. Blob

[PATCH 0/3] ui: Remove deprecated sdl parameters and switch to QAPI parser

The "-display sdl" option still uses a hand-crafted parser for its parameters since some of them used underscores which is forbidden in QAPI. Now that they've been deprecated and the deprecation period is over, we can remove the problematic parameters and switch to use the QAPI parser instead.

[PATCH 3/3] ui: Remove deprecated options "-sdl" and "-curses"

We have "-sdl" and "-curses", but no "-gtk" and no "-cocoa" ... these old-style options are rather confusing than helpful nowadays. Now that the deprecation period is over, let's remove them, so we get a cleaner interface (where "-display" is the only way to select the user interface).

[PATCH 1/3] ui: Remove deprecated parameters of the "-display sdl" option

These parameters are in the way for further refactoring (since they use an underscore in the name which is forbidden in QAPI), so let's remove these now that their deprecation period is over. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 16 -

[PATCH 2/3] ui: Switch "-display sdl" to use the QAPI parser

The "-display sdl" option still uses a hand-crafted parser for its parameters since some of them used underscores which is forbidden in QAPI. Now that the problematic parameters have been removed, we can switch to use the QAPI parser instead. This introduces the new "DisplaySDL" QAPI struct that

Re: [libvirt RFCv8 00/27] multifd save restore prototype

On Wed, May 11, 2022 at 07:31:45PM +0200, Claudio Fontana wrote: > That's great, I love when things are simple. > > If indeed we want to remove the copy in libvirt (which will also mean > explicitly fsyncing elsewhere, as the iohelper would not be there anymore to > do that for us on image

Re: [libvirt RFCv8 00/27] multifd save restore prototype

On 5/11/22 2:02 PM, Daniel P. Berrangé wrote: > On Wed, May 11, 2022 at 01:52:05PM +0200, Claudio Fontana wrote: >> On 5/11/22 11:51 AM, Daniel P. Berrangé wrote: >>> On Wed, May 11, 2022 at 09:26:10AM +0200, Claudio Fontana wrote: Hi Daniel, thanks for looking at this, On

Re: [PATCH 00/29] Remove some unused includes

On Thu, May 12, 2022 at 01:25:01AM +0800, Adam Tao wrote: > On 5/12/2022 12:25 AM, Daniel P. Berrangé wrote: > > On Wed, May 11, 2022 at 09:55:01PM +0800, Peng Liang wrote: > >> Recently, I update the toolchain in my dev machine from LLVM13 to LLVM14, > >> and I find that there are many unsed

Re: [PATCH 00/29] Remove some unused includes

On 5/12/2022 12:25 AM, Daniel P. Berrangé wrote: > On Wed, May 11, 2022 at 09:55:01PM +0800, Peng Liang wrote: >> Recently, I update the toolchain in my dev machine from LLVM13 to LLVM14, >> and I find that there are many unsed include headers in the libvirt. So >> I try to remove them in this

Re: [PATCH 00/29] Remove some unused includes

On Wed, May 11, 2022 at 09:55:01PM +0800, Peng Liang wrote: > Recently, I update the toolchain in my dev machine from LLVM13 to LLVM14, > and I find that there are many unsed include headers in the libvirt. So > I try to remove them in this series. So is clang actually reporting that the headers

Re: [PATCH 1/4] network: firewalld: convert to policies

On Wed, May 11, 2022 at 11:41:52AM -0400, Eric Garver wrote: > Convert the existing behavior into policies. Has this split of .zone vs .policy been something firewalld always supported, or is it a "new" feature for some value of "new" ? Essentially wonder if this has any historical back compat

[PATCH 3/4] network: firewalld: add policies for routed networks

Signed-off-by: Eric Garver --- src/network/libvirt-routed-in.policy | 11 +++ src/network/libvirt-routed-out.policy | 12 src/network/meson.build | 10 ++ 3 files changed, 33 insertions(+) create mode 100644 src/network/libvirt-routed-in.policy

[PATCH 3/4] network: firewalld: add policy for routed networks

Signed-off-by: Eric Garver --- src/network/libvirt-routed-out.policy | 12 src/network/meson.build | 5 + 2 files changed, 17 insertions(+) create mode 100644 src/network/libvirt-routed-out.policy diff --git a/src/network/libvirt-routed-out.policy

[PATCH 4/4] network: firewalld: add support for routed networks

Signed-off-by: Eric Garver --- src/network/bridge_driver_linux.c | 6 +- src/network/libvirt-to-host.policy | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index 98d2a33a1da0..2c8e43b427cb 100644 ---

[PATCH 1/4] network: firewalld: convert to policies

Convert the existing behavior into policies. This commit has no functional changes. Signed-off-by: Eric Garver --- src/network/libvirt-nat-out.policy | 12 src/network/libvirt-to-host.policy | 20 src/network/libvirt.zone | 23 +--

[PATCH 2/4] network: firewalld: add zone for routed networks

This zone will be used for the routed network by default. Signed-off-by: Eric Garver --- src/network/libvirt-routed.zone | 12 src/network/meson.build | 5 + 2 files changed, 17 insertions(+) create mode 100644 src/network/libvirt-routed.zone diff --git

[PATCH 0/4] network: firewalld: fix routed network

This series fixes routed networks when a newer firewalld (>= 1.0.0) is present [1]. Firewalld 1.0.0 included a change that disallows implicit forwarding between zones [2]. libvirt was relying on this behavior to allow routed networks to function. New firewalld policies are added. This is done to

Re: [libvirt][PATCH v11 1/4] qemu: provide support to query the SGX capability

On Tue, May 10, 2022 at 23:11:09 -0700, Lin Yang wrote: > From: Haibin Huang > > QEMU version >= 6.2.0 provides support for creating enclave on > SGX x86 platform using Software Guard Extensions (SGX) feature. > This patch adds support to query the SGX capability from the qemu. > >

Re: [PATCH 0/4] qemu: Move originalMemlock

On Wed, May 11, 2022 at 17:03:15 +0200, Michal Privoznik wrote: > As I tried to explain the purpose of virDomainObj to somebody I've > came across this very weirdly placed member: originalMemlock. Let's move > it into qemuDomainObjPrivate. But after I've done so I've realized the > error label is

Re: [PATCH 2/4] qemu_domain: Format qemuDomainObjPrivate::originalMemlock

On Wed, May 11, 2022 at 17:03:17 +0200, Michal Privoznik wrote: > Now that qemuDomainObjPrivate struct gained new member format it > into XML and parse it so that the value is preserved across > daemon restarts. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 13

Re: [libvirt PATCH 41/80] qemu: Ignore missing memory statistics in query-migrate

On Tue, May 10, 2022 at 17:21:02 +0200, Jiri Denemark wrote: > We want to use query-migrate QMP command to check the current migration > state when reconnecting to active domains, but the reply we get to this > command may not contain any statistics at all if called on the > destination host. > >

Re: [libvirt PATCH 40/80] qemu: Finish completed unattended migration

On Tue, May 10, 2022 at 17:21:01 +0200, Jiri Denemark wrote: > So far migration could only be completed while a migration API was > running and waiting for the migration to finish. In case such API could > not be called (the connection that initiated the migration is broken) > the migration would

Re: [libvirt PATCH 39/80] qemu: Pass qemuDomainJobObj to qemuMigrationDstComplete

On Tue, May 10, 2022 at 17:21:00 +0200, Jiri Denemark wrote: > When reconnecting to an active domains we need to use a different job s/domains/domain/ > structure than the one referenced from the VM object. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 11 ++- >

Re: [libvirt PATCH 38/80] qemu: Make sure migrationPort is released even in callbacks

On Tue, May 10, 2022 at 17:20:59 +0200, Jiri Denemark wrote: > Normally migrationPort is released in the Finish phase, but we need to > make sure it is properly released also in case qemuMigrationDstFinish is > not called at all. Currently the only callback which is called in this > situation

Re: [libvirt][PATCH v11 3/4] conf: Introduce SGX EPC element into device memory xml

On Wed, May 11, 2022 at 2:12 PM Lin Yang wrote: > > ... > > > 512 > > > ... > > > Signed-off-by: Lin Yang > --- > docs/formatdomain.rst | 9 +++- > src/conf/domain_conf.c| 6 +++ > src/conf/domain_conf.h

Re: [libvirt PATCH 34/80] qemu: Separate cookie parsing for qemuMigrationDstFinishOffline

On Tue, May 10, 2022 at 17:20:55 +0200, Jiri Denemark wrote: > To keep all cookie handling (parsing and formatting) in the same > function. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 22 -- > 1 file changed, 16 insertions(+), 6 deletions(-)

Re: [libvirt PATCH 37/80] qemu: Make final part of migration Confirm phase reusable

On Tue, May 10, 2022 at 17:20:58 +0200, Jiri Denemark wrote: > By separating it into a dedicated qemuMigrationSrcComplete function > which can be later called in other places. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 70 --- >

Re: [libvirt PATCH 36/80] qemu: Handle migration job in qemuMigrationDstFinish

On Tue, May 10, 2022 at 17:20:57 +0200, Jiri Denemark wrote: > The function which started a migration phase should also finish it by > calling qemuMigrationJobFinish/qemuMigrationJobContinue so that the code > is easier to follow. [1] > > Signed-off-by: Jiri Denemark > --- >

[PATCH 3/4] qemu_domain: Drop needless free from qemuDomainObjPrivateXMLParse()

The qemuDomainObjPrivateXMLParse() is responsible for parsing given XML into qemuDomainObjPrivate struct. As it does so, memory might be allocated for some members. If an error occurs during parsing the control jumps onto 'error' label where only some of previously allocated memory is freed. The

[PATCH 2/4] qemu_domain: Format qemuDomainObjPrivate::originalMemlock

Now that qemuDomainObjPrivate struct gained new member format it into XML and parse it so that the value is preserved across daemon restarts. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/qemu/qemu_domain.c

[PATCH 4/4] qemu_domain: Drop needless 'error' label in qemuDomainObjPrivateXMLParse()

After previous cleanup the 'error' label in qemuDomainObjPrivateXMLParse() contains nothing but a return statement. Well, the label can be dropped and all 'goto'-s can be replaced with the return statement directly. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 53

[PATCH 1/4] conf: Move virDomainObj::originalMemlock into qemuDomainObjPrivate

Since v1.3.0-90-gafbe1d4c56 the original value of memlock limit is stored inside virDomainObj struct directly (under originalMemlock member). This is needless because the value is used only inside QEMU driver and thus can reside in qemuDomainObjPrivate struct. Signed-off-by: Michal Privoznik ---

[PATCH 0/4] qemu: Move originalMemlock

As I tried to explain the purpose of virDomainObj to somebody I've came across this very weirdly placed member: originalMemlock. Let's move it into qemuDomainObjPrivate. But after I've done so I've realized the error label is needless. So that's dropped too. Michal Prívozník (4): conf: Move

Re: [libvirt PATCH 35/80] qemu: Introduce qemuMigrationDstFinishActive

On Tue, May 10, 2022 at 17:20:56 +0200, Jiri Denemark wrote: > Refactors qemuMigrationDstFinish by moving some parts to a dedicated > function for easier introduction of postcopy resume code without > duplicating common parts of the Finish phase. The goal is to have the > following call graph: >

Re: [libvirt PATCH 32/80] qemu: Introduce qemuMigrationDstFinishFresh

On Tue, May 10, 2022 at 17:20:53 +0200, Jiri Denemark wrote: > Refactors qemuMigrationDstFinish by moving some parts to a dedicated > function for easier introduction of postcopy resume code without > duplicating common parts of the Finish phase. The goal is to have the > following call graph: >

Re: [libvirt PATCH v3 4/6] conf: add support for 'blob' in virtio video device

On Wed, May 11, 2022 at 12:26 AM Jonathon Jongsma wrote: > Add the ability to enable blob resources for the virtio video device. > This will accelerate the display path due to less or no copying of pixel > data. > > Blob resource support can be enabled with e.g.: > > > > > >

Re: [libvirt PATCH 33/80] qemu: Introduce qemuMigrationDstFinishOffline

On Tue, May 10, 2022 at 17:20:54 +0200, Jiri Denemark wrote: > Refactors qemuMigrationDstFinish by moving some parts to a dedicated > function for easier introduction of postcopy resume code without > duplicating common parts of the Finish phase. The goal is to have the > following call graph: >

Re: [libvirt PATCH 4/5] ci: Add a new integration job template for the upstream QEMU scenario

On Wed, May 11, 2022 at 04:36:48PM +0200, Erik Skultety wrote: > On Wed, May 11, 2022 at 03:03:18PM +0100, Daniel P. Berrangé wrote: > > On Fri, May 06, 2022 at 05:35:19PM +0200, Erik Skultety wrote: > > > YAML anchors don't work with Shell conditions structures, so we cannot > > > simply pull in

Re: [libvirt PATCH 31/80] qemu: Preserve error in qemuMigrationDstFinish

On Tue, May 10, 2022 at 17:20:52 +0200, Jiri Denemark wrote: > We want to prevent our error path that can potentially kill the domain > on the destination host from overwriting an error reported earlier, but > we were only doing so in one specific path when starting vCPUs fails. > Let's do it in

Re: [libvirt PATCH 30/80] qemu: Drop obsolete comment in qemuMigrationDstFinish

On Tue, May 10, 2022 at 17:20:51 +0200, Jiri Denemark wrote: > The comment about QEMU < 0.10.6 has been irrelevant for years. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 4 Reviewed-by: Peter Krempa

Re: [libvirt PATCH 4/5] ci: Add a new integration job template for the upstream QEMU scenario

On Wed, May 11, 2022 at 03:03:18PM +0100, Daniel P. Berrangé wrote: > On Fri, May 06, 2022 at 05:35:19PM +0200, Erik Skultety wrote: > > YAML anchors don't work with Shell conditions structures, so we cannot > > simply pull in the QEMU build template conditionally like we do for > > the other

Re: [libvirt PATCH 29/80] qemu: Make final part of migration Finish phase reusable

On Tue, May 10, 2022 at 17:20:50 +0200, Jiri Denemark wrote: > By separating it into a dedicated qemuMigrationDstComplete function > which can be later called in other places. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 99 ++- >

Re: [libvirt PATCH 3/5] ci: Introduce a template for upstream QEMU build

On Wed, May 11, 2022 at 03:11:01PM +0100, Daniel P. Berrangé wrote: > On Wed, May 11, 2022 at 03:07:43PM +0100, Daniel P. Berrangé wrote: > > On Wed, May 11, 2022 at 04:04:54PM +0200, Erik Skultety wrote: > > > On Wed, May 11, 2022 at 03:01:51PM +0100, Daniel P. Berrangé wrote: > > > > On Fri, May

Re: [PATCH 13/37] qemu: command: Introduce 'qemuBuildInterfaceConnect' helper

On a Tuesday in 2022, Peter Krempa wrote: The helper will aggregate code that is used to connect the network backend to the corresponding host portion. This will be used to refactor the duplicated code between the cold-start and hotplug helper functions. Signed-off-by: Peter Krempa ---

Re: [libvirt PATCH 28/80] qemu: Generate migration cookie in Finish phase earlier

On Tue, May 10, 2022 at 17:20:49 +0200, Jiri Denemark wrote: > The final part of Finish phase will be refactored into a dedicated > function and we don't want to generate the cookie there. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 38

Re: [libvirt PATCH 3/5] ci: Introduce a template for upstream QEMU build

On Wed, May 11, 2022 at 03:07:43PM +0100, Daniel P. Berrangé wrote: > On Wed, May 11, 2022 at 04:04:54PM +0200, Erik Skultety wrote: > > On Wed, May 11, 2022 at 03:01:51PM +0100, Daniel P. Berrangé wrote: > > > On Fri, May 06, 2022 at 05:35:18PM +0200, Erik Skultety wrote: > > > > Rather than

Re: [libvirt PATCH 3/5] ci: Introduce a template for upstream QEMU build

On Wed, May 11, 2022 at 04:04:54PM +0200, Erik Skultety wrote: > On Wed, May 11, 2022 at 03:01:51PM +0100, Daniel P. Berrangé wrote: > > On Fri, May 06, 2022 at 05:35:18PM +0200, Erik Skultety wrote: > > > Rather than writing down the steps to build QEMU from source ourselves > > > let's recycle

Re: [libvirt PATCH 3/5] ci: Introduce a template for upstream QEMU build

On Wed, May 11, 2022 at 03:01:51PM +0100, Daniel P. Berrangé wrote: > On Fri, May 06, 2022 at 05:35:18PM +0200, Erik Skultety wrote: > > Rather than writing down the steps to build QEMU from source ourselves > > let's recycle what upstream QEMU uses in their CI. This has the obvious > > advantage

Re: [libvirt PATCH 5/5] ci: Add a Fedora integration test job utilizing upstream QEMU

On Fri, May 06, 2022 at 05:35:20PM +0200, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > ci/integration.yml | 16 > 1 file changed, 16 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt PATCH 4/5] ci: Add a new integration job template for the upstream QEMU scenario

On Fri, May 06, 2022 at 05:35:19PM +0200, Erik Skultety wrote: > YAML anchors don't work with Shell conditions structures, so we cannot > simply pull in the QEMU build template conditionally like we do for > the other anchors. Instead we have to 'subclass' the .integration_tests > template and

Re: [libvirt PATCH 3/5] ci: Introduce a template for upstream QEMU build

On Fri, May 06, 2022 at 05:35:18PM +0200, Erik Skultety wrote: > Rather than writing down the steps to build QEMU from source ourselves > let's recycle what upstream QEMU uses in their CI. This has the obvious > advantage that if QEMU changes something in their upstream CI build > process we'll

Re: [libvirt PATCH 2/5] ci: Break off the integration_tests template into more templates

On Fri, May 06, 2022 at 05:35:17PM +0200, Erik Skultety wrote: > There's quite a lot happening int the .integration_tests template > already even without adding upstream QEMU build to the mix. Let's break > the template into more pieces which can be put together using the YAML > anchors. > >

Re: [libvirt PATCH 27/80] qemu: Rename "endjob" label in qemuMigrationDstFinish

On Tue, May 10, 2022 at 17:20:48 +0200, Jiri Denemark wrote: > Let's call it "error" so that it's clear the label is only used in > failure path. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 26 +- > 1 file changed, 13 insertions(+), 13

Re: [libvirt PATCH 26/80] qemu: Separate success and failure path in qemuMigrationDstFinish

On Tue, May 10, 2022 at 17:20:47 +0200, Jiri Denemark wrote: > Most of the code in "endjob" label is executed only on failure. Let's > duplicate the rest so that the label can be used only in error path > making the success path easier to follow and refactor. > > Signed-off-by: Jiri Denemark >

[PATCH 28/29] tools: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- tools/virsh-checkpoint.c | 2 -- tools/virsh-completer-checkpoint.c | 2 -- tools/virsh-completer-domain.c | 1 - tools/virsh-completer-host.c | 1 - tools/virsh-completer-interface.c | 2 -- tools/virsh-completer-network.c|

[PATCH 29/29] tests: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- tests/commandtest.c | 2 -- tests/cputest.c | 2 -- tests/domainconftest.c | 2 -- tests/esxutilstest.c| 1 - tests/eventtest.c | 2 --

[PATCH 26/29] vmx: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/vmx/vmx.c | 1 - src/vmx/vmx.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 8150bbfaa9..ac4f068a67 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -24,7 +24,6 @@ #include "internal.h" #include

[PATCH 21/29] storage: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/storage/parthelper.c | 1 - src/storage/storage_backend.c | 3 --- src/storage/storage_backend.h | 1 - src/storage/storage_backend_fs.c | 1 - src/storage/storage_backend_gluster.c | 1

[PATCH 27/29] test_driver: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/test/test_driver.c | 2 -- src/test/test_driver.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a824ef0186..24ff6e8967 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt PATCH 1/5] ci: Separate the integration job template to a separate file

On Fri, May 06, 2022 at 05:35:16PM +0200, Erik Skultety wrote: > Future patches will do more code extraction to the template using YAML > anchors so it's better that templates would live separately from the > job definitions. > > Signed-off-by: Erik Skultety > --- > ci/integration-template.yml

[PATCH 24/29] vbox: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/vbox/vbox_XPCOMCGlue.c| 3 --- src/vbox/vbox_common.h| 1 - src/vbox/vbox_driver.c| 2 -- src/vbox/vbox_driver.h| 2 -- src/vbox/vbox_get_driver.h| 2 -- src/vbox/vbox_network.c | 2 --

[PATCH 25/29] vmware: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/vmware/vmware_conf.c | 1 - src/vmware/vmware_conf.h | 1 - src/vmware/vmware_driver.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c index ebba435cc4..80a85f4d0f 100644 ---

[PATCH 22/29] storage_file: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/storage_file/storage_file_backend.c | 2 -- src/storage_file/storage_file_backend_fs.c | 5 - src/storage_file/storage_file_backend_gluster.c | 2 -- src/storage_file/storage_source.c | 3 --- 4 files changed, 12

[PATCH 23/29] util: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/util/iohelper.c | 3 --- src/util/virarch.h | 2 -- src/util/virarptable.c | 2 -- src/util/virarptable.h | 2 -- src/util/viraudit.h | 1 - src/util/virauth.c | 1 -

[PATCH 19/29] secret: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/secret/secret_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 09782b38d3..080ed962a9 100644 --- a/src/secret/secret_driver.c +++ b/src/secret/secret_driver.c @@ -35,11

[PATCH 14/29] nwfilter: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/nwfilter/nwfilter_dhcpsnoop.c | 3 --- src/nwfilter/nwfilter_driver.c| 5 - src/nwfilter/nwfilter_driver.h| 3 --- src/nwfilter/nwfilter_ebiptables_driver.c | 4 src/nwfilter/nwfilter_gentech_driver.c

[PATCH 13/29] node_device: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/node_device/node_device_driver.c | 3 --- src/node_device/node_device_driver.h | 1 - src/node_device/node_device_udev.c | 3 --- 3 files changed, 7 deletions(-) diff --git a/src/node_device/node_device_driver.c

[PATCH 18/29] rpc: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/rpc/virkeepalive.c| 3 --- src/rpc/virnetclient.c| 1 - src/rpc/virnetclient.h| 1 - src/rpc/virnetclientprogram.h | 1 - src/rpc/virnetclientstream.c | 1 - src/rpc/virnetclientstream.h | 1 - src/rpc/virnetdaemon.c

[PATCH 17/29] remote: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/remote/remote_daemon.c | 3 --- src/remote/remote_daemon.h | 1 - src/remote/remote_daemon_config.c | 1 - src/remote/remote_daemon_dispatch.c | 5 - src/remote/remote_daemon_dispatch.h | 1 -

[PATCH 20/29] security: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/security/security_dac.c | 1 - src/security/security_manager.h | 1 - src/security/security_nop.c | 2 -- src/security/security_selinux.c | 2 -- src/security/security_stack.c | 1 - src/security/security_util.c| 1 - 6 files

[PATCH 16/29] qemu: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/qemu/qemu_agent.c| 2 -- src/qemu/qemu_agent.h| 1 - src/qemu/qemu_alias.c| 1 - src/qemu/qemu_alias.h| 2 -- src/qemu/qemu_backup.c | 5 - src/qemu/qemu_block.c| 1 -

[PATCH 15/29] openvz: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/openvz/openvz_conf.c | 1 - src/openvz/openvz_conf.h | 1 - src/openvz/openvz_driver.h | 2 -- src/openvz/openvz_util.c | 1 - 4 files changed, 5 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index

[PATCH 10/29] locking: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/locking/domain_lock.c | 3 --- src/locking/domain_lock.h | 2 -- src/locking/lock_daemon.c | 2 -- src/locking/lock_daemon_config.c | 4 src/locking/lock_daemon_dispatch.c | 1 - src/locking/lock_driver.h

[PATCH 07/29] hyperv: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/hyperv/hyperv_private.h | 3 --- src/hyperv/hyperv_util.c| 3 --- src/hyperv/hyperv_util.h| 1 - 3 files changed, 7 deletions(-) diff --git a/src/hyperv/hyperv_private.h b/src/hyperv/hyperv_private.h index da37a8fd20..3d0606bac3 100644

[PATCH 04/29] conf: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/conf/backup_conf.c| 3 --- src/conf/capabilities.c | 1 - src/conf/capabilities.h | 3 --- src/conf/checkpoint_conf.c| 4 src/conf/checkpoint_conf.h| 1 -

[PATCH 11/29] logging: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/logging/log_daemon.c | 5 - src/logging/log_daemon_config.c | 4 src/logging/log_daemon_dispatch.c | 1 - src/logging/log_handler.c | 1 - src/logging/log_handler.h | 1 - src/logging/log_manager.c | 1

[PATCH 12/29] network: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/network/bridge_driver.c | 5 - src/network/bridge_driver.h | 3 --- src/network/bridge_driver_linux.c| 1 - src/network/bridge_driver_platform.h | 1 - src/network/leaseshelper.c | 4 5 files changed, 14

[PATCH 09/29] libxl: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/libxl/libxl_capabilities.c | 1 - src/libxl/libxl_capabilities.h | 2 -- src/libxl/libxl_conf.c | 3 --- src/libxl/libxl_conf.h | 3 --- src/libxl/libxl_domain.c | 1 - src/libxl/libxl_domain.h | 2 --

[PATCH 06/29] esx: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/esx/esx_driver.c| 1 - src/esx/esx_interface_driver.c | 6 -- src/esx/esx_network_driver.c| 2 -- src/esx/esx_private.h | 3 --- src/esx/esx_storage_backend_iscsi.c | 2 --

[PATCH 08/29] interface: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/interface/interface_backend_netcf.c | 2 -- src/interface/interface_backend_udev.c | 1 - 2 files changed, 3 deletions(-) diff --git a/src/interface/interface_backend_netcf.c b/src/interface/interface_backend_netcf.c index

[PATCH 03/29] ch: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/ch/ch_conf.c| 1 - src/ch/ch_domain.c | 1 - src/ch/ch_driver.c | 7 --- src/ch/ch_monitor.c | 2 -- src/ch/ch_process.c | 2 -- src/ch/ch_process.h | 1 - 6 files changed, 14 deletions(-) diff --git a/src/ch/ch_conf.c

[PATCH 05/29] cpu: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/cpu/cpu.c | 3 --- src/cpu/cpu.h | 1 - src/cpu/cpu_arm.c | 1 - src/cpu/cpu_map.c | 2 -- src/cpu/cpu_ppc64.c | 1 - src/cpu/cpu_s390.c | 2 -- src/cpu/cpu_x86.c | 1 - 7 files changed, 11 deletions(-) diff --git

[PATCH 02/29] admin: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/admin/admin_server.c | 4 src/admin/admin_server.h | 1 - src/admin/admin_server_dispatch.c | 4 src/admin/libvirt-admin.c | 2 -- 4 files changed, 11 deletions(-) diff --git a/src/admin/admin_server.c

[PATCH 01/29] access: Remove unused includes

From: Adam Tao Signed-off-by: Peng Liang --- src/access/viraccessdriver.h | 1 - src/access/viraccessdriverpolkit.c | 4 src/access/viraccessdriverstack.c | 1 - src/access/viraccessmanager.h | 1 - src/access/viraccessperm.h | 1 - 5 files changed, 8 deletions(-)

[PATCH 00/29] Remove some unused includes

Recently, I update the toolchain in my dev machine from LLVM13 to LLVM14, and I find that there are many unsed include headers in the libvirt. So I try to remove them in this series. Besides, I also find that: 1. some header files are not self-contained, which means if you want to include one

Re: [libvirt RFCv8 12/27] qemu: capabilities: add multifd to the probed migration capabilities

On Wed, May 11, 2022 at 15:25:49 +0200, Claudio Fontana wrote: > On 5/11/22 3:17 PM, Peter Krempa wrote: > > On Wed, May 11, 2022 at 14:56:35 +0200, Claudio Fontana wrote: > >> Hi Daniel, > >> > >> is this patch specifically controversial? > >> > >> I ask because this is likely to be painful to

Re: [libvirt PATCH 25/80] qemu: Move success-only code out of endjob in qemuMigrationDstFinish

On Tue, May 10, 2022 at 17:20:46 +0200, Jiri Denemark wrote: > Code executed only when dom != NULL can be moved before "endjob" label, > to the only place where dom is set. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 50 ++- > 1 file

Re: [libvirt PATCH 24/80] qemu: Create domain object at the end of qemuMigrationDstFinish

On Tue, May 10, 2022 at 17:20:45 +0200, Jiri Denemark wrote: > We don't need the object until we get to the "endjob" label. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Peter Krempa

Re: [libvirt PATCH 23/80] qemu: Add support for postcopy-recover QEMU migration state

On Tue, May 10, 2022 at 17:20:44 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c| 1 + > src/qemu/qemu_monitor.c | 2 +- > src/qemu/qemu_monitor.h | 1 + > src/qemu/qemu_monitor_json.c | 1 + > src/qemu/qemu_process.c | 31

Re: [libvirt PATCH 22/80] qemu: Handle 'postcopy-paused' migration state

On Tue, May 10, 2022 at 17:20:43 +0200, Jiri Denemark wrote: > When connection breaks during post-copy migration, QEMU enters > 'postcopy-paused' state. We need to handle this state and make the > situation visible to upper layers. > > Signed-off-by: Jiri Denemark > --- >

Re: [libvirt RFCv8 12/27] qemu: capabilities: add multifd to the probed migration capabilities

On 5/11/22 3:17 PM, Peter Krempa wrote: > On Wed, May 11, 2022 at 14:56:35 +0200, Claudio Fontana wrote: >> Hi Daniel, >> >> is this patch specifically controversial? >> >> I ask because this is likely to be painful to maintain. > > Note that in August of this year it will become obsolete. In

Re: [libvirt PATCH 20/80] qemu: Use switch in qemuDomainGetJobInfoMigrationStats

On Tue, May 10, 2022 at 17:20:41 +0200, Jiri Denemark wrote: > To make sure all job states are properly handled. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_driver.c | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) Reviewed-by: Peter Krempa

Re: [libvirt PATCH 21/80] qemu: Fetch paused migration stats

On Tue, May 10, 2022 at 17:20:42 +0200, Jiri Denemark wrote: > Even though a migration is paused, we still want to see the amount of > data transferred so far and that the migration is indeed not progressing > any further. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_driver.c | 2 +- >

Re: [libvirt PATCH 19/80] qemu: Don't wait for migration job when migration is running

On Tue, May 10, 2022 at 17:20:40 +0200, Jiri Denemark wrote: > Migration is a job which takes some time and if it succeeds, there's > nothing to call another migration on. If a migration fails, it might > make sense to rerun it with different arguments, but this would only be > done once the first

Re: [libvirt RFCv8 12/27] qemu: capabilities: add multifd to the probed migration capabilities

On Wed, May 11, 2022 at 14:56:35 +0200, Claudio Fontana wrote: > Hi Daniel, > > is this patch specifically controversial? > > I ask because this is likely to be painful to maintain. Note that in August of this year it will become obsolete. In august we'll be dropping support for debian-10 old

Re: [libvirt PATCH 18/80] qemu: Drop forward declarations in migration code

On Tue, May 10, 2022 at 17:20:39 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_migration.c | 176 -- > 1 file changed, 76 insertions(+), 100 deletions(-) Reviewed-by: Peter Krempa

Re: [libvirt PATCH 17/80] qemu: Restore async job start timestamp on reconnect

On Tue, May 10, 2022 at 17:20:38 +0200, Jiri Denemark wrote: > Jobs that are supposed to remain active even when libvirt daemon > restarts were reported as started at the time the daemon was restarted. > This is not very helpful, we should restore the original timestamp. > > Signed-off-by: Jiri

Re: [libvirt PATCH 16/80] qemu: Restore failed migration job on reconnect

On Tue, May 10, 2022 at 17:20:37 +0200, Jiri Denemark wrote: > Since we keep the migration job active when post-copy migration fails, > we need to restore it when reconnecting to running domains. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_process.c | 128

  1   2   >