On Thu, May 19, 2022 at 2:01 AM Andrea Bolognani
wrote:
> On Wed, May 11, 2022 at 10:16:58AM +0800, Han Han wrote:
> > Han Han (16):
> > news: make SEV attrs 'cbitpos' & 'reducedPhysBits' optional
> > news: support device stats collection for SR-IOV VF hostdev
> > news: cpu_map: Add
On 5/11/22 7:06 AM, Peter Krempa wrote:
On Tue, May 10, 2022 at 11:24:31 -0500, Jonathon Jongsma wrote:
This can improve performance for some guests since it reduces copying of
display data between host and guest. Requires udmabuf on the host.
Signed-off-by: Jonathon Jongsma
---
On Wed, May 11, 2022 at 10:16:58AM +0800, Han Han wrote:
> Han Han (16):
> news: make SEV attrs 'cbitpos' & 'reducedPhysBits' optional
> news: support device stats collection for SR-IOV VF hostdev
> news: cpu_map: Add EPYC-Rome cpu model
> news: cpu: Support for XML validation in cpu
On Wed, May 18, 2022 at 16:00:55 +0200, Ján Tomko wrote:
> Ján Tomko (5):
> Do not check if unsigned vars are less than zero
> src: QemuMonitorCommandWithFiles: report error when fd passing is
> unsupported
> apparmor: report error when removing profile failed
> vbox:
On Wed, May 18, 2022 at 03:44:45PM +0200, Thomas Huth wrote:
> The "-display sdl" option still uses a hand-crafted parser for its
> parameters since we didn't want to drag an interface we considered
> somewhat flawed into the QAPI schema. Since the flaws are gone now,
> it's time to QAPIfy.
>
>
On Wed, May 18, 2022 at 15:59:46 +0200, Peter Krempa wrote:
> On Wed, May 18, 2022 at 15:40:18 +0200, Jiri Denemark wrote:
> > On Thu, May 12, 2022 at 14:14:15 +0200, Peter Krempa wrote:
> > > > +static char *
> > > > +qemuMigrationSrcBeginResume(virQEMUDriver *driver,
> > > > +
Thomas Huth writes:
> These parameters are in the way for further refactoring (since they
> use an underscore in the name which is forbidden in QAPI), so let's
> remove these now that their deprecation period is over.
Forbidden, but there's an exception mechanism, so this reason isn't
Thomas Huth writes:
> The "-display sdl" option still uses a hand-crafted parser for its
> parameters since we didn't want to drag an interface we considered
> somewhat flawed into the QAPI schema. Since the flaws are gone now,
> it's time to QAPIfy.
>
> This introduces the new "DisplaySDL" QAPI
On Wed, May 18, 2022 at 14:53:50 +0200, Jiri Denemark wrote:
> On Thu, May 12, 2022 at 13:50:08 +0200, Peter Krempa wrote:
> > On Tue, May 10, 2022 at 17:21:11 +0200, Jiri Denemark wrote:
> > > This phase marks a migration protocol as broken in a post-copy phase.
> > > Libvirt is no longer
Signed-off-by: Ján Tomko
---
src/esx/esx_stream.c | 2 +-
src/libvirt-qemu.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/esx/esx_stream.c b/src/esx/esx_stream.c
index b356fbed70..51c96ff0e0 100644
--- a/src/esx/esx_stream.c
+++ b/src/esx/esx_stream.c
@@ -287,7
Signed-off-by: Ján Tomko
---
src/vbox/vbox_snapshot_conf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c
index 6b47893b5e..90afac179e 100644
--- a/src/vbox/vbox_snapshot_conf.c
+++
Ján Tomko (5):
Do not check if unsigned vars are less than zero
src: QemuMonitorCommandWithFiles: report error when fd passing is
unsupported
apparmor: report error when removing profile failed
vbox: SnapshotConfAllChildren: reduce scope of tempSize
storagefile: set size field of
The result of the <= 0 comparison was assigned to 'rc', rendering the
if (rc == 0) condition dead code.
Signed-off-by: Ján Tomko
---
src/libvirt-qemu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c
index 5020b5dc1b..ace91e8ada 100644
Signed-off-by: Ján Tomko
---
src/storage_file/storage_file_probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/storage_file/storage_file_probe.c
b/src/storage_file/storage_file_probe.c
index 54e095ffd3..9465af5d96 100644
--- a/src/storage_file/storage_file_probe.c
Assign the return value to 'rc' before comparing it.
Signed-off-by: Ján Tomko
---
src/security/virt-aa-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
index 1f1cce8b3d..5dc941f79a 100644
---
On Wed, May 18, 2022 at 15:40:18 +0200, Jiri Denemark wrote:
> On Thu, May 12, 2022 at 14:14:15 +0200, Peter Krempa wrote:
> > On Tue, May 10, 2022 at 17:21:15 +0200, Jiri Denemark wrote:
> > > Mostly we just need to check whether the domain is in a failed post-copy
> > > migration that can be
The "-display sdl" option still uses a hand-crafted parser for its
parameters since we didn't want to drag an interface we considered
somewhat flawed into the QAPI schema. Since the flaws are gone now,
it's time to QAPIfy.
This introduces the new "DisplaySDL" QAPI struct that is used to hold
the
We have "-sdl" and "-curses", but no "-gtk" and no "-cocoa" ...
these old-style options are rather confusing than helpful nowadays.
Now that the deprecation period is over, let's remove them, so we
get a cleaner interface (where "-display" is the only way to select
the user interface).
These parameters are in the way for further refactoring (since they
use an underscore in the name which is forbidden in QAPI), so let's
remove these now that their deprecation period is over.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
docs/about/deprecated.rst | 16
The "-display sdl" option still uses a hand-crafted parser for its
parameters since some of them used underscores which is forbidden
in QAPI. Now that they've been deprecated and the deprecation period
is over, we can remove the problematic parameters and switch to use
the QAPI parser instead.
On Thu, May 12, 2022 at 14:14:15 +0200, Peter Krempa wrote:
> On Tue, May 10, 2022 at 17:21:15 +0200, Jiri Denemark wrote:
> > Mostly we just need to check whether the domain is in a failed post-copy
> > migration that can be resumed.
> >
> > Signed-off-by: Jiri Denemark
> > ---
> >
On Thu, May 12, 2022 at 13:50:08 +0200, Peter Krempa wrote:
> On Tue, May 10, 2022 at 17:21:11 +0200, Jiri Denemark wrote:
> > This phase marks a migration protocol as broken in a post-copy phase.
> > Libvirt is no longer actively watching the migration in this phase as
> > the migration API that
On 5/5/22 13:10, Michal Prívozník wrote:
> On 4/25/22 11:06, Michal Privoznik wrote:
>> When a SIGHUP is received a thread is spawned that runs
>> virStateReload(). However, if SIGINT is received while the former
>> thread is still running then we may get into problematic
>> situation: the cleanup
On 5/9/22 17:02, Michal Privoznik wrote:
>
Polite ping.
Michal
On Thu, May 12, 2022 at 13:26:01 +0200, Peter Krempa wrote:
> On Tue, May 10, 2022 at 17:21:10 +0200, Jiri Denemark wrote:
> > Both qemuMigrationJobSetPhase and qemuMigrationJobStartPhase were doing
> > the same thing, which made little sense. Let's follow the difference
> > between
KVM Forum 2022
September 12-14, 2022
Dublin, Ireland & Virtual
All submissions must be received before
*** Friday June 3rd, 2022 at 23:59 PDT ***
KVM Forum is an
On Wed, May 11, 2022 at 16:53:48 +0200, Peter Krempa wrote:
> On Tue, May 10, 2022 at 17:20:54 +0200, Jiri Denemark wrote:
> > Refactors qemuMigrationDstFinish by moving some parts to a dedicated
> > function for easier introduction of postcopy resume code without
> > duplicating common parts of
On Wed, May 11, 2022 at 15:40:58 +0200, Peter Krempa wrote:
> On Tue, May 10, 2022 at 17:20:46 +0200, Jiri Denemark wrote:
> > Code executed only when dom != NULL can be moved before "endjob" label,
> > to the only place where dom is set.
> >
> > Signed-off-by: Jiri Denemark
> > ---
> >
On Thu, May 12, 2022 at 10:39:50 +0200, Peter Krempa wrote:
> On Tue, May 10, 2022 at 17:21:08 +0200, Jiri Denemark wrote:
> > The check can reveal a serious bug in our migration code and we should
> > not silently ignore it.
> >
> > Signed-off-by: Jiri Denemark
> > ---
> >
This is something that certainly made sense in the context of
gnulib, but we don't have a use for it.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index
Now that we have dropped prefixes from the file, it no longer
needs to go through configure_file() and we can use it directly.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk| 6 +++---
po/{POTFILES.in => POTFILES} | 0
po/meson.build | 13 +
3
Make sure LINGUAS remains sorted correctly.
Signed-off-by: Andrea Bolognani
---
build-aux/syntax-check.mk | 8
1 file changed, 8 insertions(+)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 513c147cec..6b54f830f1 100644
--- a/build-aux/syntax-check.mk
+++
Signed-off-by: Andrea Bolognani
---
po/LINGUAS | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/po/LINGUAS b/po/LINGUAS
index 889ef80aba..35acd33a87 100644
--- a/po/LINGUAS
+++ b/po/LINGUAS
@@ -28,17 +28,17 @@ nl
or
pa
pl
-pt_BR
pt
+pt_BR
ru
-sr@latin
+si
sr
Commit 8beb7fdd0e23 changed the handling of POTFILES so that it
could cope with files being located in either the source or build
directory: it did so by adding @SRCDIR@ and @BUILDDIR@
respectively at the beginning of each line, and then converting
them back to the actual values when generating
Changes from [v1]
* instead of checking that the potfile doesn't contain unwanted
comments at syntax-check time, prevent them from being added by
passing all xgettext options explicitly ourselves.
[v1] https://listman.redhat.com/archives/libvir-list/2022-May/231526.html
Andrea
Due to a bug in meson versions earlier than 0.60, the
--add-comments that's part of the 'glib' preset and the
--add-comments=TRANSLATORS: that we add ourselves might be
passed to xgettext in the wrong order, resulting in a bunch of
comments that we don't care about being added to the potfile.
These managed to sneak in as part of ec02f5719a87, when the
potfile was last refreshed, but are not supposed to be there.
Signed-off-by: Andrea Bolognani
---
po/libvirt.pot | 216 -
1 file changed, 216 deletions(-)
diff --git a/po/libvirt.pot
On Wed, May 18, 2022 at 11:22:09AM +0200, Peter Krempa wrote:
> Fix a memleak and make the code a bit neater.
>
> Peter Krempa (4):
> util: typedparam: Introduce virTypedParamListFromParams
> virGetConnectGeneric: Fix memleak of 'identparams' when connecting
> between split daemons
>
Use a temporary variable 'newconn' to hold the newly opened connection
until we are ready to pass it back instead of the original connection.
This way we can avoid complicated 'error'/'cleanup' sections.
Signed-off-by: Peter Krempa
---
src/remote/remote_daemon_dispatch.c | 28
The helper constructs a virTypedParamList from loose params.
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
src/util/virtypedparam.c | 13 +
src/util/virtypedparam.h | 4
3 files changed, 18 insertions(+)
diff --git a/src/libvirt_private.syms
The 'identparams' typed parameter list obtained from
virIdentityGetParameters is leaked when called from
'virGetConnectGeneric'.
Use 'virTypedParamListFromParams' to absorb it into a virTypedParamList
which can be autofreed.
Note that the memleak is observable only when running in split-daemon
Fix a memleak and make the code a bit neater.
Peter Krempa (4):
util: typedparam: Introduce virTypedParamListFromParams
virGetConnectGeneric: Fix memleak of 'identparams' when connecting
between split daemons
virIdentityGetParameters: Return 'virTypedParamList'
doRemoteOpen: Refactor
Refactor the code to use virTypedParamList which simplifies cleanup.
Signed-off-by: Peter Krempa
---
src/driver.c| 10 +++---
src/remote/remote_daemon_dispatch.c | 8 +++-
src/util/viridentity.c | 15 +--
src/util/viridentity.h
On Wed, May 18, 2022 at 10:08:23AM +0200, Jiri Denemark wrote:
> If the port allocator bitmap does not have enough bits to keep the state
> of the port we're going to release, the port is not reserved and thus is
> trivially released without doing anything. No need to report an error in
> such
If the port allocator bitmap does not have enough bits to keep the state
of the port we're going to release, the port is not reserved and thus is
trivially released without doing anything. No need to report an error in
such case.
Signed-off-by: Jiri Denemark
---
src/util/virportallocator.c | 7
This patch series provides support for enabling Intel's Software Guard
Extensions (SGX) feature in guest VM.
Giving the SGX support in QEMU had been merged. Intel SGX is a set of
instructions that increases the security of application code and data, giving
them more protection from disclosure
From: Lin Yang
...
512
...
Signed-off-by: Lin Yang
Signed-off-by: Haibin Huang
---
docs/formatdomain.rst | 9 +++-
src/conf/domain_conf.c| 6 +++
src/conf/domain_conf.h| 1 +
From: Lin Yang
According to the result parsing from xml, add the argument of
SGX EPC memory backend into QEMU command line:
#qemu-system-x86_64 \
.. \
-object memory-backend-epc,id=memepc0,size=64M,prealloc=on \
-object memory-backend-epc,id=memepc1,size=28M \
Extend hypervisor capabilities to include sgx feature. When available,
the hypervisor supports launching an VM with SGX on Intel platfrom.
The SGX feature tag privides additional details like section size and
sgx1 or sgx2.
Signed-off-by: Haibin Huang
---
docs/formatdomaincaps.rst
the QMP capabilities:
{"return":
{
"sgx": true,
"section-size": 1024,
"flc": true
}
}
the domain capabilities:
yes
1
Signed-off-by: Haibin Huang
---
src/conf/schemas/domaincaps.rng | 22 +++-
src/qemu/qemu_capabilities.c
Generate the QMP command for query-sgx-capabilities and the command
return sgx capabilities from QMP.
{"execute":"query-sgx-capabilities"}
the right reply:
{"return":
{
"sgx": true,
"section-size": 197132288,
"flc": true
}
}
the error reply:
{"error":
Signed-off-by: Haibin Huang
---
src/conf/domain_capabilities.c | 10 ++
src/conf/domain_capabilities.h | 13 +
src/libvirt_private.syms | 1 +
3 files changed, 24 insertions(+)
diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
index
On 5/11/22 2:02 PM, Daniel P. Berrangé wrote:
> On Wed, May 11, 2022 at 01:52:05PM +0200, Claudio Fontana wrote:
>> On 5/11/22 11:51 AM, Daniel P. Berrangé wrote:
>>> On Wed, May 11, 2022 at 09:26:10AM +0200, Claudio Fontana wrote:
Hi Daniel,
thanks for looking at this,
On
53 matches
Mail list logo
