Entering freeze for libvirt-8.4.0

2022-05-25 Thread Jiri Denemark
I have just tagged v8.4.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

Re: [PATCH 0/2] Avoid memcpy with NULL argument

2022-05-25 Thread Michal Prívozník
On 5/25/22 13:01, Peter Krempa wrote: > Behaviour is undefined per C standard. > > Peter Krempa (2): > virNetMessageEncodePayloadRaw: Tolerate empty 'data' > virNetMessageEncodePayloadEmpty: Replace by > virNetMessageEncodePayloadRaw(msg, NULL, 0) > > src/rpc/virkeepalive.c| 2 +

Re: [PATCH 0/2] Avoid memcpy with NULL argument

2022-05-25 Thread Claudio Fontana
On 5/25/22 1:01 PM, Peter Krempa wrote: > Behaviour is undefined per C standard. > > Peter Krempa (2): > virNetMessageEncodePayloadRaw: Tolerate empty 'data' > virNetMessageEncodePayloadEmpty: Replace by > virNetMessageEncodePayloadRaw(msg, NULL, 0) > > src/rpc/virkeepalive.c| 2

[PATCH 0/2] Avoid memcpy with NULL argument

2022-05-25 Thread Peter Krempa
Behaviour is undefined per C standard. Peter Krempa (2): virNetMessageEncodePayloadRaw: Tolerate empty 'data' virNetMessageEncodePayloadEmpty: Replace by virNetMessageEncodePayloadRaw(msg, NULL, 0) src/rpc/virkeepalive.c| 2 +- src/rpc/virnetmessage.c | 76 ++--

[PATCH 1/2] virNetMessageEncodePayloadRaw: Tolerate empty 'data'

2022-05-25 Thread Peter Krempa
'virNetMessageEncodePayloadRaw' is not supposed to be called with 'NULL' data, but the code path from 'virNetClientStreamSendPacket' does so. Now 'virNetMessageEncodePayloadEmpty' is intended for such case, but since it's just a sub-set of steps from 'virNetMessageEncodePayloadRaw' it's more strai

[PATCH 2/2] virNetMessageEncodePayloadEmpty: Replace by virNetMessageEncodePayloadRaw(msg, NULL, 0)

2022-05-25 Thread Peter Krempa
Replace the two outstanding invocations and remove the function. Signed-off-by: Peter Krempa --- src/rpc/virkeepalive.c| 2 +- src/rpc/virnetmessage.c | 25 - src/rpc/virnetmessage.h | 2 -- src/rpc/virnetserverprogram.c | 9 ++--- 4 files chang