[PATCH v2 1/2] news: Add qemu-vdagent

2022-05-30 Thread Han Han
Signed-off-by: Han Han --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e50010f9b2..bb2713f4e2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -33,6 +33,11 @@ v8.4.0 (unreleased) to be kept set to an arbitrary time for e.g. testing or working around

[PATCH v2 2/2] news: Add APIs virDomainSaveParams virDomainRestoreParams

2022-05-30 Thread Han Han
Signed-off-by: Han Han --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index bb2713f4e2..8a2073d800 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -38,6 +38,13 @@ v8.4.0 (unreleased) This paravirtualized qemu vdagent channel can enable copy and paste

[PATCH v2 0/2] 2 release notes for v8.4.0

2022-05-30 Thread Han Han
v1: https://listman.redhat.com/archives/libvir-list/2022-May/231901.html diff from v1: rebase to latest and resolve conflicts Han Han (2): news: Add qemu-vdagent news: Add APIs virDomainSaveParams virDomainRestoreParams NEWS.rst | 12 1 file changed, 12 insertions(+) --

Re: [PATCH] hw/nvme: deprecate the use-intel-id compatibility parameter

2022-05-30 Thread Klaus Jensen
On May 30 16:37, Philippe Mathieu-Daudé wrote: > On 29/4/22 07:41, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Since version 5.2 commit 6eb7a071292a ("hw/block/nvme: change controller > > pci id"), the emulated NVMe controller has defaulted to a non-Intel PCI > > identifier. > > > >

Re: [libvirt][PATCH RESEND v12 1/6] Define SGX capabilities structs

2022-05-30 Thread Michal Prívozník
On 5/18/22 09:59, Haibin Huang wrote: > Signed-off-by: Haibin Huang > --- > src/conf/domain_capabilities.c | 10 ++ > src/conf/domain_capabilities.h | 13 + > src/libvirt_private.syms | 1 + > 3 files changed, 24 insertions(+) > > diff --git

Re: [libvirt][PATCH RESEND v12 5/6] conf: Introduce SGX EPC element into device memory xml

2022-05-30 Thread Michal Prívozník
On 5/18/22 09:59, Haibin Huang wrote: > From: Lin Yang > > > ... > > > 512 > > > ... > > > Signed-off-by: Lin Yang > Signed-off-by: Haibin Huang > --- > docs/formatdomain.rst | 9 +++- > src/conf/domain_conf.c| 6

Re: [libvirt][PATCH RESEND v12 0/6] Support query and use SGX

2022-05-30 Thread Michal Prívozník
On 5/18/22 09:59, Haibin Huang wrote: > Overall, these patches work. I've raised couple of points and for your convenience you can find reworked patches here: https://gitlab.com/MichalPrivoznik/libvirt/-/commits/sgx_fixups/ Please see individual patches for comments. Michal

Re: [libvirt][PATCH RESEND v12 3/6] Convert QMP capabilities to domain capabilities

2022-05-30 Thread Michal Prívozník
On 5/18/22 09:59, Haibin Huang wrote: > the QMP capabilities: > {"return": > { > "sgx": true, > "section-size": 1024, > "flc": true > } > } > > the domain capabilities: > > yes > 1 > > > Signed-off-by: Haibin Huang > --- >

Re: [libvirt][PATCH RESEND v12 1/6] Define SGX capabilities structs

2022-05-30 Thread Michal Prívozník
On 5/18/22 09:59, Haibin Huang wrote: > Signed-off-by: Haibin Huang > --- > src/conf/domain_capabilities.c | 10 ++ > src/conf/domain_capabilities.h | 13 + > src/libvirt_private.syms | 1 + > 3 files changed, 24 insertions(+) > > diff --git

Re: [libvirt][PATCH RESEND v12 2/6] Get SGX capabilities form QMP

2022-05-30 Thread Michal Prívozník
On 5/18/22 09:59, Haibin Huang wrote: > Generate the QMP command for query-sgx-capabilities and the command > return sgx capabilities from QMP. > > {"execute":"query-sgx-capabilities"} > > the right reply: > {"return": > { > "sgx": true, > "section-size": 197132288, >

Re: [libvirt][PATCH RESEND v12 6/6] qemu: Add command-line to generate SGX EPC memory backend

2022-05-30 Thread Michal Prívozník
On 5/18/22 09:59, Haibin Huang wrote: > From: Lin Yang > > According to the result parsing from xml, add the argument of > SGX EPC memory backend into QEMU command line: > > #qemu-system-x86_64 \ > .. \ > -object memory-backend-epc,id=memepc0,size=64M,prealloc=on \ >

[PATCH] qemu_capspriv: Drop needless declarations

2022-05-30 Thread Michal Privoznik
There are two functions declared in qemu_capspriv.h: 1) virQEMUCapsInitHostCPUModel() which is not used anywhere but qemu_capabilities.c, 2) virQEMUCapsSetSEVCapabilities() which is my personal favorite but despite that it's never implemented nor called. Drop them. Signed-off-by: Michal

Re: [PATCH 0/2] virDomainInputDefValidate: Validate model

2022-05-30 Thread Martin Kletzander
On Thu, May 26, 2022 at 03:22:56PM +0200, Michal Privoznik wrote: *** BLURB HERE *** Michal Prívozník (2): virDomainInputDefValidate: Reformat virDomainInputDefValidate: Validate model Reviewed-by: Martin Kletzander src/conf/domain_validate.c | 84 +++---

Re: [PATCH] glibcompat: Provide proper override for 'g_hash_table_steal_extended'

2022-05-30 Thread Ján Tomko
On a Monday in 2022, Peter Krempa wrote: We've emulated the function in virHashSteal, with a note pointing to use the proper version. Move the code to glibcomapt.c and make it such that builds using newer glib already use the new function. Signed-off-by: Peter Krempa --- src/util/glibcompat.c

Re: [libvirt PATCH] virt-host-validate: Improve failure message when no HW virt is found

2022-05-30 Thread Ján Tomko
On a Monday in 2022, Martin Kletzander wrote: Make sure that more users understand that without HW virtualization you cannot have KVM working. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2086677 Signed-off-by: Martin Kletzander --- tools/virt-host-validate-qemu.c | 3 ++- 1 file

[PATCH] glibcompat: Provide proper override for 'g_hash_table_steal_extended'

2022-05-30 Thread Peter Krempa
We've emulated the function in virHashSteal, with a note pointing to use the proper version. Move the code to glibcomapt.c and make it such that builds using newer glib already use the new function. Signed-off-by: Peter Krempa --- src/util/glibcompat.c | 20

[libvirt PATCH] virt-host-validate: Improve failure message when no HW virt is found

2022-05-30 Thread Martin Kletzander
Make sure that more users understand that without HW virtualization you cannot have KVM working. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2086677 Signed-off-by: Martin Kletzander --- tools/virt-host-validate-qemu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

libvirt-8.4.0 release candidate 2

2022-05-30 Thread Jiri Denemark
I have just tagged v8.4.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

Re: [PATCH] qemuProcessStop: Don't try to remove QoS on already removed TAP

2022-05-30 Thread Ján Tomko
On a Friday in 2022, Michal Privoznik wrote: When cleaning up after stopped domain, one of the things we do is attempt to clear QoS settings on OVS type interfaces. Well, this is needless because they were removed just a couple of lines above. As a result, the attempt fails and a warning is

Re: [PATCH] docs: patches: Add a note about reviews and contacting developers

2022-05-30 Thread Erik Skultety
On Fri, May 27, 2022 at 03:36:12PM +0200, Peter Krempa wrote: > Add a note outling best practices around review and responding to it. > > Signed-off-by: Peter Krempa > --- > docs/submitting-patches.rst | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git