On 7/15/22 13:44, Peter Krempa wrote:
> We now only support qemu versions which already have the capability so
> we can remove this now unused code.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_validate.c | 86
> 1 file changed, 86 deletions(-)
>
On 7/15/22 13:44, Peter Krempa wrote:
> In August Debian 10 officially reaches EOL, thus we can bump minimum
> qemu version to 4.2 which is being limited by Ubuntu and RHEL/Centos 8.
>
> QEMU-4.2 allows us to remove a big bunch of old code though. Few
> examples which this series (and the next ite
On 7/15/22 14:31, Peter Krempa wrote:
> All qemu versions supported by libvirt allow setting everything via
> migration parameters which is also the preferred code path in libvirt.
>
> Remove the legacy code.
>
> Peter Krempa (7):
> qemu: Always assume support for QEMU_CAPS_MIGRATION_PARAM_BAND
The 'xbzrle-cache-size' parameter was added in qemu-2.11 thus all
supported qemu versions now use the new code path.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 56 +---
src/qemu/qemu_migration_params.c | 18 --
2 files changed, 16 inser
The parameter is supported since qemu-2.8.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 -
tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xm
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 -
tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.
The getters/setters for individual properties of migration
speed/downtime/cache size are unused once we switched to setting them
purely via migration parameters. Remove the unused helpers.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 55 -
src/qemu/qemu_moni
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 -
tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.
The 'max-bandwidth' field was added as argument of
'migrate-set-parameters' in qemu-2.8, thus all qemu version supported by
libvirt already use the new code path.
This patch assumes the presence and removes the legacy code paths.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c| 39 ++
The 'downtime-limit' field of 'migrate-set-parameters' was introduced in
qemu-2.8, thus all qemu versions supported by libvirt use the new code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 30 +-
1 file changed, 9 insertions(+), 21 deletions(-)
diff --gi
All qemu versions supported by libvirt allow setting everything via
migration parameters which is also the preferred code path in libvirt.
Remove the legacy code.
Peter Krempa (7):
qemu: Always assume support for QEMU_CAPS_MIGRATION_PARAM_BANDWIDTH
qemu: capabilities: Retire QEMU_CAPS_MIGRATI
On Fri, Jul 15, 2022 at 13:54:26 +0200, Claudio Fontana wrote:
> Hello Peter,
>
> can we retire as well support for migration_set_speed then?
>
> The "if (!bwParam)" branches with calls to qemuMonitorSetMigrationSpeed are
> overcomplicating qemu_migration.c and qemu_driver.c in my view.
Indeed.
On 7/15/22 13:54, Claudio Fontana wrote:
> Hello Peter,
>
> can we retire as well support for migration_set_speed then?
>
> The "if (!bwParam)" branches with calls to qemuMonitorSetMigrationSpeed are
> overcomplicating qemu_migration.c and qemu_driver.c in my view.
While there are only a few su
Hello Peter,
can we retire as well support for migration_set_speed then?
The "if (!bwParam)" branches with calls to qemuMonitorSetMigrationSpeed are
overcomplicating qemu_migration.c and qemu_driver.c in my view.
Thanks,
Claudio
On 7/15/22 13:44, Peter Krempa wrote:
> In August Debian 10 off
Signed-off-by: Peter Krempa
---
.../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 211
.../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 230 --
tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 138 ---
tests/domaincapsdata/qemu_3.1.0.x86_64.xml| 211 --
Per [1] the Debian 10 reaches EOL in August of 2022. This allows us to
bump the minimum supported qemu version to qemu-4.2 which will also
allow us to do significant cleanups.
This commit bumps the minimum qemu verison and updates the corresponding
docs.
[1]: https://wiki.debian.org/DebianRelease
Rename qemuBuildAudioCommandLineArgs to qemuBuildAudioCommandLine and
fix the arguments.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 57e8115db3
We now only support qemu versions which already have the capability so
we can remove this now unused code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 86
1 file changed, 86 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qem
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.
The code no longer uses the capability so the tests don't need to assert
it.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvtest.c | 2 +-
tests/qemuxml2xmltest.c | 20 +---
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/tests/qemuxml2argvtest.c b/tests/qem
Remove the old now unused code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 183
1 file changed, 183 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 4d9a0eb2e1..57e8115db3 100644
--- a/src/qemu/qemu_command
qemu-4.0 will no longer be supported.
Signed-off-by: Peter Krempa
---
.../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 211
.../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 230 -
.../qemu_4.0.0-virt.aarch64.xml | 179 -
tests/domaincapsda
qemu-4.0 will no longer be supported, remove the test data.
Signed-off-by: Peter Krempa
---
.../caps_4.0.0.aarch64.replies| 20893 -
.../caps_4.0.0.aarch64.xml| 363 -
.../caps_4.0.0.ppc64.replies | 24461 ---
.../qem
Signed-off-by: Peter Krempa
---
.../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 217
.../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 233 --
tests/domaincapsdata/qemu_4.1.0.x86_64.xml| 217
3 files changed, 667 deletions(-)
delete mode 100644
qemu-4.1 will not be supported any more.
Signed-off-by: Peter Krempa
---
.../caps_4.1.0.x86_64.replies | 25198
.../caps_4.1.0.x86_64.xml | 1971 --
2 files changed, 27169 deletions(-)
delete mode 100644 tests/qemucapabilitiesdata/caps_4.1.0
Upcoming patches will raise the minimum required qemu version to 4.2.
Signed-off-by: Peter Krempa
---
.../caps_3.1.0.ppc64.replies | 23732 ---
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1072 -
.../caps_3.1.0.x86_64.replies | 24428
Minimum qemu version is going to be bumped to qemu-4.2. Upgrading the
version of these tests don't make sense as the host cpu in the real
capabilities doesn't support the features the tests are attempting to
test.
Signed-off-by: Peter Krempa
---
.../cpu-host-model-cmt.x86_64-4.0.0.args | 33
Minimum qemu will be bumped to 4.2 so remove the older test cases.
Signed-off-by: Peter Krempa
---
.../cpu-host-model.x86_64-3.1.0.args | 36 ---
.../cpu-host-model.x86_64-4.0.0.args | 36 ---
.../cpu-host-model.x86_64-4.1.0.args | 36 --
Upcoming patches will bump minimum supported qemu version to 4.2 which
will use '-blockdev' with qemu so we can drop all the old test cases for
pre-blockdev configs.
Signed-off-by: Peter Krempa
---
.../blkdeviotune-group-num.x86_64-4.1.0.args | 37 --
.../blkdeviotune-max-length.x86
In August Debian 10 officially reaches EOL, thus we can bump minimum
qemu version to 4.2 which is being limited by Ubuntu and RHEL/Centos 8.
QEMU-4.2 allows us to remove a big bunch of old code though. Few
examples which this series (and the next iterations of it) will deal
with:
- old auidiodev
Starting from qemu-4.0 a new device model name is used instead of the
'disable_*' props. Since we are going to bump to qemu-4.2 as minimum
this test can be removed.
Signed-off-by: Peter Krempa
---
.../virtio-non-transitional.x86_64-3.1.0.args | 53 ---
.../virtio-transitional.x86
Minimum qemu will be bumped to 4.2 so this test no longer makes sense.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/aarch64-features-sve.aarch64-4.0.0.err | 1 -
tests/qemuxml2argvtest.c | 2 --
2 files changed, 3 deletions(-)
delete mode 100644
t
Minimum qemu version will be bumped to qemu-4.2 so we no longer need to
care about configuring audiodevs via the environment variables.
Signed-off-by: Peter Krempa
---
.../audio-alsa-best.x86_64-4.1.0.args | 46 -
.../audio-alsa-full.x86_64-4.1.0.err | 1 -
.../
Upcoming patches will bump minimum qemu version to 4.2. In this case we
the 'latest' case is suffuicient as with qemu-4.2 we already behave as
upstream ('qemu64' cpu is used instead of 'qemu32').
Signed-off-by: Peter Krempa
---
.../x86-kvm-32-on-64.x86_64-4.1.0.args| 31 -
Currently, the migration code denies migration as long as the VM has a
vhost-vDPA device.
While it's true that vhost-vDPA devices cannot be migrated at the moment, there
are plans to be able to migrate them soon.
Libvirt must treat it equal to vhost-kernel devices: Not all of them can
be migrate
On Thu, Jul 14, 2022 at 09:52:25AM -0500, Jonathon Jongsma wrote:
> These wrapper functions were used to adapt the virObjectUnref() function
> signature for different callbacks. But in commit 0d184072, the
> virObjectUnref() function was changed to return a void instead of a
> bool, so these adapte
On Wed, 2022-07-13 at 17:25 +0100, Daniel P. Berrangé wrote:
> It would need to use SCOPE_THREAD_GROUP, except even that is not
> sufficient
> as the helper may have fork+exec'd another helper by this point, and
> our
> call will only affect the first process.
>
> IOW, to set core scheduling cooki
37 matches
Mail list logo
