On 7/19/22 2:38 PM, Eugenio Perez Martin wrote:
On Tue, Jul 19, 2022 at 6:43 PM Laine Stump wrote:
On 7/19/22 12:01 PM, Laine Stump wrote:
On 7/19/22 11:09 AM, Eugenio Perez Martin wrote:
On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
On 7/18/22 11:15 AM, Jiri Denemark wrote:
On
On Tue, Jul 19, 2022 at 6:43 PM Laine Stump wrote:
>
> On 7/19/22 12:01 PM, Laine Stump wrote:
> > On 7/19/22 11:09 AM, Eugenio Perez Martin wrote:
> >> On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
> >>>
> >>> On 7/18/22 11:15 AM, Jiri Denemark wrote:
> On Mon, Jul 18, 2022 at
On 7/19/22 12:01 PM, Laine Stump wrote:
On 7/19/22 11:09 AM, Eugenio Perez Martin wrote:
On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
On 7/18/22 11:15 AM, Jiri Denemark wrote:
On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote:
On Mon, Jul 18, 2022 at 10:25 AM Jiri
It would be nice to be able to test the mediated device capabilities
without having physical hardware which supports it. The 'mtty' kernel
module presents a virtual parent device which is capable of creating
'fake' mediated devices, and as such it would be useful for testing.
However, the 'mtty'
On 7/19/22 11:09 AM, Eugenio Perez Martin wrote:
On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
On 7/18/22 11:15 AM, Jiri Denemark wrote:
On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote:
On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote:
Which in ideal case would
On Tue, Jul 19, 2022 at 10:40:46AM -0500, Jonathon Jongsma wrote:
> This was not causing any problems because all cases below were empty,
> but in order to avoid future misbehavior, add a break to this case.
FYI, future misbehaviour would have been prevented by -Wimplicit-fallthrough.
diff
On Tue, Jul 19, 2022 at 5:24 PM Jiri Denemark wrote:
>
> On Tue, Jul 19, 2022 at 17:09:29 +0200, Eugenio Perez Martin wrote:
> > On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
> > > Actually that's been on my todo list for a long time - for any qemu that
> > > supports the QMP command that
This was not causing any problems because all cases below were empty,
but in order to avoid future misbehavior, add a break to this case.
Signed-off-by: Jonathon Jongsma
---
src/conf/node_device_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Jul 19, 2022 at 17:09:29 +0200, Eugenio Perez Martin wrote:
> On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
> > Actually that's been on my todo list for a long time - for any qemu that
> > supports the QMP command that checks for migratability, we should be
> > calling this command
On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote:
>
> On 7/18/22 11:15 AM, Jiri Denemark wrote:
> > On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote:
> >> On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote:
> >>> Which in ideal case would mean only a QMP command (such as
>
meson already supports $DESTDIR natively, but in this case
we're using a custom script and so we have to do some extra
work ourselves.
Signed-off-by: Andrea Bolognani
---
scripts/meson-install-web.py | 13 +
1 file changed, 13 insertions(+)
diff --git a/scripts/meson-install-web.py
This will be useful later.
Signed-off-by: Andrea Bolognani
---
scripts/meson-install-web.py | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/scripts/meson-install-web.py b/scripts/meson-install-web.py
index a03f8523cd..fdf407ba33 100755
---
Right now we're setting the prefix to a custom path, which
results in paths like
/builds/libvirt/libvirt/vroot/etc/libvirt/virtqemud.conf
ending up in the generated HTML. In order to avoid that,
set the prefix and other installation paths to reasonable
default values by passing
Compare
https://abologna.gitlab.io/-/libvirt/-/jobs/2741293181/artifacts/website/manpages/virtqemud.html#files
with
https://libvirt.org/manpages/virtqemud.html#files
Andrea Bolognani (3):
scripts: Port meson-install-web.py to pathlib
scripts: Add $DESTDIR support to
On 7/18/22 11:15 AM, Jiri Denemark wrote:
On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote:
On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote:
Which in ideal case would mean only a QMP command (such as
hotplugging a non-migratable device) is the only way to add migration
This patch replaces struct libxlDomainJobObj with generalized
virDomainJobObj.
Signed-off-by: Kristina Hanicova
---
src/libxl/libxl_domain.c | 6 +++---
src/libxl/libxl_domain.h | 11 ++-
2 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_domain.c
This patch replaces struct virCHDomainJobObj with generalized
virDomainJobObj.
Signed-off-by: Kristina Hanicova
---
src/ch/ch_domain.c | 4 ++--
src/ch/ch_domain.h | 9 +
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c
index
This patch alters members of virDomainObjPrivateJobCallbacks to
make the code more consistent.
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.h | 4 ++--
src/qemu/qemu_domain.c | 4 ++--
src/qemu/qemu_domainjob.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
This patch replaces struct virLXCDomainJobObj with generalized
virDomainJobObj.
Signed-off-by: Kristina Hanicova
---
src/lxc/lxc_domain.c | 4 ++--
src/lxc/lxc_domain.h | 9 +
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/lxc/lxc_domain.c b/src/lxc/lxc_domain.c
This series moves generalized qemu job object into hypervisor/ and
replaces all other hypervisor-specific job objects.
Kristina Hanicova (5):
qemu & hypervisor: move job object into hypervisor
hypervisor: domain_job: rename members in
virDomainObjPrivateJobCallbacks
LXC: use
This patch moves qemuDomainJobObj into hypervisor/ as generalized
virDomainJobObj along with generalized private job callbacks as
virDomainObjPrivateJobCallbacks.
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.h | 62 ++
src/qemu/qemu_domain.c
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.c | 2 ++
src/hypervisor/domain_job.h | 5 -
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/hypervisor/domain_job.c b/src/hypervisor/domain_job.c
index 5939d93e47..6a0fbd42b3 100644
---
This patch removes variable 'async', which is used only once, and
replaces it with direct comparison with an enum member.
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_domainjob.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_domainjob.c
On Tue, 2022-07-19 at 12:45 +0200, Peter Krempa wrote:
> The end-goal is to remove 'virCloseCallbacksGetConn'.
>
> Peter Krempa (7):
> virLXCProcessStop: Add 'cleanupFlags' parameter
> virLXCProcessStart: Pass in virConnect object only when registering
> autodestroy
>
On Tue, 2022-07-19 at 14:04 +0200, Michal Privoznik wrote:
> *** BLURB HERE ***
>
> Michal Prívozník (2):
> qemu_capabilities: Indent properly
> domain_conf: Switch to virBufferAddLit for literal strings
>
> src/conf/domain_conf.c | 4 ++--
> src/qemu/qemu_capabilities.c | 2 +-
> 2
When formatting qemuCaps XML, the element is
misaligned. This is because it contains multiple lines and
virBufferAsprintf() does not expect that. Switch to
virBufferAddStr() which does.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_capabilities.c | 2 +-
1 file changed, 1 insertion(+), 1
There's no need to use virBufferAddStr() for literal strings
without any newline character as it's more expensive than
virBufferAddLit().
Signed-off-by: Michal Privoznik
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c
*** BLURB HERE ***
Michal Prívozník (2):
qemu_capabilities: Indent properly
domain_conf: Switch to virBufferAddLit for literal strings
src/conf/domain_conf.c | 4 ++--
src/qemu/qemu_capabilities.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--
2.35.1
We are getting close to the next release of libvirt. To aim for the
release on Aug 01 I suggest entering the freeze on Tuesday Jul 26 and
tagging RC2 on Friday Jul 29.
I hope this works for everyone.
Jirka
The end-goal is to remove 'virCloseCallbacksGetConn'.
Peter Krempa (7):
virLXCProcessStop: Add 'cleanupFlags' parameter
virLXCProcessStart: Pass in virConnect object only when registering
autodestroy
virLXCProcessReboot: Simplify cleanup
virLXCProcessAutostartAll: Remove unused 'conn'
Add a new flag VIR_LXC_PROCESS_CLEANUP_AUTODESTROY to
virLXCProcessCleanupFlags for skipping removal of the autodestroy
callback so that fake reboot of the container doesn't need to fetch the
connection and re-register it.
Since virLXCProcessReboot is defined before virLXCProcessCleanupFlags,
The connection object is not needed when autostarting containers so we
can remove the machinery for it.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_process.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index
Use automatic unlocking of the 'vm' object, so that we can return early
when no autostart is needed and avoid passing of the 'driver' object
which is already present in 'vm's' private data.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_process.c | 55 ---
1
Add possibility for the caller to set the flags for the call to
'virLXCProcessCleanup'.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_driver.c | 2 +-
src/lxc/lxc_process.c | 17 +
src/lxc/lxc_process.h | 3 ++-
3 files changed, 12 insertions(+), 10 deletions(-)
diff --git
Signed-off-by: Peter Krempa
---
src/hypervisor/virclosecallbacks.c | 24
src/hypervisor/virclosecallbacks.h | 3 ---
src/libvirt_private.syms | 1 -
3 files changed, 28 deletions(-)
diff --git a/src/hypervisor/virclosecallbacks.c
The function doesn't really need the connect object for anything besides
registering the autodestroy callback for it. If we merge it certain
callers can be simplified.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_driver.c | 15 +--
src/lxc/lxc_process.c | 31
Remove the pointless 'cleanup' section and 'ret' variable.
Signed-off-by: Peter Krempa
---
src/lxc/lxc_process.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
index 4934a96e0c..130c16aa04 100644
---
According to a9fe9569ab, the is only for PCI
devices. Remove the ref acpi from devices channel, smartcard, tpm,
redirdev, panic, hub because none of them has PCI address. And add the
ref acpi to iommu device.
Fixes: a9fe9569ab
Signed-off-by: Han Han
---
src/conf/schemas/domaincommon.rng | 21
38 matches
Mail list logo