RE: [libvirt][PATCH v13 4/6] conf: expose SGX feature in domain capabilities

2022-07-24 Thread Huang, Haibin
Ok, nice comments Thank you very much! > -Original Message- > From: Michal Prívozník > Sent: Wednesday, July 20, 2022 7:27 PM > To: Yang, Lin A ; libvir-list@redhat.com; Huang, Haibin > ; Ding, Jian-feng > Subject: Re: [libvirt][PATCH v13 4/6] conf: expose SGX feature in domain > capabi

RE: [libvirt][PATCH v13 3/6] Convert QMP capabilities to domain capabilities

2022-07-24 Thread Huang, Haibin
Hi Michal Peter, Thank you for your comments. Way 1: virBufferAsprintf(buf, "%s\n", sgx->flc ? "yes" : "no"); Way 2: if (sgx->flc) { virBufferAsprintf(buf, "yes\n"); } else { virBufferAsprintf(buf, "yes\n"); } For this section, both ways of writing work. Peter Kremp

RE: [libvirt][PATCH v13 2/6] Get SGX capabilities form QMP

2022-07-24 Thread Huang, Haibin
Nice comments, I accepted all comments. > -Original Message- > From: Michal Prívozník > Sent: Wednesday, July 20, 2022 7:27 PM > To: Yang, Lin A ; libvir-list@redhat.com; Huang, Haibin > ; Ding, Jian-feng > Subject: Re: [libvirt][PATCH v13 2/6] Get SGX capabilities form QMP > > On 7/1/2

Re: Qemu guest-reset option on device_add

2022-07-24 Thread Simon Fairweather
Awesome, thanks! On Tue, Jul 12, 2022 at 2:17 PM Michal Prívozník wrote: > On 7/6/22 17:55, Simon Fairweather wrote: > > Hi Michal, If you are able to implement the feature that would be great. > > > > Regards > > Simon. > > Hey, I've posted patches here: > > https://listman.redhat.com/archives/