From: Marc-André Lureau
As Ed Swierk explained back in 2006:
https://lists.nongnu.org/archive/html/qemu-devel/2006-12/msg00160.html
"When qemu writes into the pipe, it immediately reads back what it just
wrote and treats it as a monitor command, endlessly breathing its own
exhaust."
This is sim
On Tue, Jul 26, 2022 at 12:32:32PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> As Ed Swierk explained back in 2006:
> https://lists.nongnu.org/archive/html/qemu-devel/2006-12/msg00160.html
>
> "When qemu writes into the pipe, it immediately reads back what it just
> w
Add a note outling best practices around review and responding to it.
Signed-off-by: Peter Krempa
---
docs/submitting-patches.rst | 22 ++
1 file changed, 22 insertions(+)
diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst
index 7bc22323ee..965e381cc1 100
Outline how upstream issues are triaged and explain what the states of
the issue means.
Signed-off-by: Peter Krempa
---
docs/docs.rst | 3 +
docs/issue-handling.rst | 174
docs/meson.build| 1 +
3 files changed, 178 insertions(+)
cr
Following changes to the respective v1 versions of these patches:
Peter Krempa (2):
docs: patches: Add a note about reviews and contacting developers
- followed Erik's suggestion to add bulletpoint instead of a blob
of text
docs: Add article about handling upstream issues
(previ
I have just tagged v8.6.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
On Sun, Jul 24, 2022 at 10:50:36AM +0530, Amneesh Singh wrote:
On Fri, Jul 22, 2022 at 07:09:57PM +0200, Paolo Bonzini wrote:
On 7/22/22 17:43, Martin Kletzander wrote:
> As mentioned before, all these failures do not have to exit the
> function, but rather fallback to the old way. You can even
On Tue, Jul 26, 2022 at 10:52:50AM +0200, Peter Krempa wrote:
> Add a note outling best practices around review and responding to it.
>
> Signed-off-by: Peter Krempa
> ---
> docs/submitting-patches.rst | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --git a/docs/submitt
On Tue, Jul 26, 2022 at 10:52:51AM +0200, Peter Krempa wrote:
> Outline how upstream issues are triaged and explain what the states of
> the issue means.
>
> Signed-off-by: Peter Krempa
> ---
> docs/docs.rst | 3 +
> docs/issue-handling.rst | 174 +
On Mon, Jul 25, 2022 at 03:40:41PM +0200, Michal Prívozník wrote:
> On 7/22/22 18:23, Daniel P. Berrangé wrote:
> > This is to enable SEV builds of UEFI which provide only a single CODE.fd
> > file, with not VARS.fd.
> >
> > Daniel P. Berrangé (2):
> > conf: support stateless UEFI firmware
> >
On 7/26/22 16:16, Daniel P. Berrangé wrote:
> On Mon, Jul 25, 2022 at 03:40:41PM +0200, Michal Prívozník wrote:
>> On 7/22/22 18:23, Daniel P. Berrangé wrote:
>>> This is to enable SEV builds of UEFI which provide only a single CODE.fd
>>> file, with not VARS.fd.
>>>
>>> Daniel P. Berrangé (2):
>>>
The 'debug' level for the gluster driver was added in qemu-2.8
unconditionally so libvirt can always assume it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
Starting with libvirt-8.7.0 we'll support qemu-4.2 as minimum and thus
we'll only use -blockdev now. Remove the old cruft.
This series applies on top of the patches bumping minimum qemu version
to qemu-4.2 I've posted earlier.
The whole branch can be fetched at:
git fetch https://gitlab.com/pip
The 'change-backing-file' command is unconditionally supported since
qemu-2.1.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
tests/qemuc
Discard and zero-detection for disk sources is supported since qemu-2.1
so we can always assume it's support.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 1b23
The 'change-backing-file' command was added in qemu-2.1 and doesn't have
any dependancies. We use it as witness for using blockjobs with relative
backing paths. Always assume it's support.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 13 -
1 file changed, 13 deletions(-)
Active block commit is supported since qemu-2.0
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.2.0.ppc6
Active layer block commit is unconditionally supported since qemu-2.0.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 15742706fc..cfb02f7b0f 100644
--- a/src/qemu/qemu_driver.c
+
The cleanup of the code to always assume support for QEMU_CAPS_BLOCKDEV
will not be simple, so for now we hardcode the support and the code will
be cleaned up gradually.
We also disallow users to clear the flags via the namespace property or
qemu.conf configuration.
The change to the PPC64 test d
luks-encrypted QCOW2 files were introduced in qemu-2.6 unconditionally.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 8
1 file changed, 8 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 534de9e0ae..245cae9c60 100644
--- a/src/qemu/qemu_domain
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.
Modernize 'disk-nvme', 'encrypted-disk-usage', 'encrypted-disk', and
'user-aliases' cases to use DO_TEST_CAPS_LATEST.
This will remove all uses of QEMU_CAPS_QCOW2_LUKS from the test suite.
Since the output files are done via symlinks to input files, the input
files need to be modernized with few
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 4 ++--
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 2 --
tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 --
tests/qemucapabilitiesdata/
The code which fills 'qomName' does so only when the blockdev capability
is enabled so we don't have to check it separately as it can be only
non-NULL when blockdev is used.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 29 -
src/qemu/qemu_process.c | 3 +
The debug level of gluster backend became configurable in qemu-2.8.
This also removes the only old-style syntax for the 'blockdev-add'
command prior to stabilization.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 4 +---
src/qemu/qemu_capabilities.h
The 'device_id' property of 'scsi_disk' was added in qemu-4.0 and it's
unconditionally present, thus we can now always assume it's presence.
Update some fake-caps test which didn't yet assert the capability.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c |
Retire:
QEMU_CAPS_BLOCK_FILE_AUTO_READONLY_DYNAMIC
QEMU_CAPS_SCSI_DISK_DEVICE_ID
QEMU_CAPS_SAVEVM_MONITOR_NODES
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 9 +++--
src/qemu/qemu_capabilities.h | 6 +++---
tests/qemucap
In one of early iterations of the gluster driver 'tcp' was used instead
of 'inet' and 'socket' instead of 'path' for unix sockets. All of this
can be now removed.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 44 ++-
1 file changed, 10 insertions
We no longer need the arguments which were conditionally filled based on
presence of the QEMU_CAPS_BLOCKDEV feature.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu
Now that QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI is always set we can remove the
code which handled cases when the capability was not set.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 142 +++-
src/qemu/qemu_domain.c | 18 ++---
2 files changed, 43 inse
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 136 +--
1 file changed, 1 insertion(+), 135 deletions(-)
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index ed82ac5dc2..304008a31a 100644
--- a/src/qemu/qemu_blockjob.c
+++ b/src/q
We no longer need it as we use the more modern job events.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 14 --
src/qemu/qemu_monitor.h | 12 -
src/qemu/qemu_monitor_json.c | 90
3 files changed, 116 deletions(-)
diff --git a/sr
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 12
1 file changed, 12 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1e7f17b750..e7b0acd46f 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -19809,18 +19809,6 @@ qemuDomain
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c| 2 +-
src/qemu/qemu_block.c | 10 +-
src/qemu/qemu_block.h | 1 -
src/qemu/qemu_migration.c | 2 +-
4 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
index
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c| 20
src/qemu/qemu_block.h| 6 --
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 6 --
src/qemu/qemu_monitor_json.c | 22 --
src/qemu/qemu_monit
Previous patches removed the job submission for the handler so now even
the handler itself can be removed.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 1 -
src/qemu/qemu_domain.h | 1 -
src/qemu/qemu_driver.c | 45 --
3 files changed, 47 del
Assume that QEMU_CAPS_BLOCKDEV is present and remove all code executed
when it's not.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 116 +--
1 file changed, 15 insertions(+), 101 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 182 +---
1 file changed, 2 insertions(+), 180 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 980e06ce79..6083ee10d8 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qem
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_cookie.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_migration_cookie.c b/src/qemu/qemu_migration_cookie.c
index 0738ad430f..88c147e9fa 100644
--- a/src/qemu/qemu_migration_cookie.c
Assume that QEMU_CAPS_BLOCKDEV is present and remove all code executed
when it's not.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 127 --
1 file changed, 25 insertions(+), 102 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu
The migration code was using few blockdev bits before blockdev was
fully integrated to allow TLS with NBD.
Since we now always use blockdev we can remove the check.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration.c | 8
1 file changed, 8 deletions(-)
diff --git a/src/qemu/qemu
The top level API is unused so it can be removed but internally the JSON
version is called by other monitor commands which extract information
from the reply.
Thus qemuMonitorJSONQueryNamedBlockNodes is unexported and moved
appropriately.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 13 -
src/qemu/qemu_monitor.h | 3 ---
src/qemu/qemu_monitor_json.c | 23 ---
src/qemu/qemu_monitor_json.h | 5 -
tests/qemumonitorjsontest.c | 2 --
5 files changed, 46 deletions(-)
diff
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 60 +-
1 file changed, 13 insertions(+), 47 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index bae9558cfd..e8dc524186 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/q
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 171 -
1 file changed, 66 insertions(+), 105 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 811b4a610c..bae9558cfd 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 30 +++---
1 file changed, 3 insertions(+), 27 deletions(-)
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index 304008a31a..03c46923b3 100644
--- a/src/qemu/qemu_blockjob.c
+++ b/src/qemu/qemu_b
With blockdev we are generating the nodenames ourselves so all of this
infrastructrure became obsolete. Remove it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 274 ---
src/qemu/qemu_block.h | 9 -
...monitorjson-nodename-basic-blo
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 2 --
src/qemu/qemu_monitor.c | 15 +++
src/qemu/qemu_monitor.h | 2 --
src/qemu/qemu_monitor_json.c | 12 ++--
src/qemu/qemu_monitor_json.h | 2 --
tests/qemumonitorjsontest.c | 2 +-
6 files change
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 50 +++---
1 file changed, 22 insertions(+), 28 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e4caccfbd9..f1fc954f8c 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/q
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 14 ---
src/qemu/qemu_monitor.h | 5 ---
src/qemu/qemu_monitor_json.c | 77
src/qemu/qemu_monitor_json.h | 8
4 files changed, 104 deletions(-)
diff --git a/src/qemu/qemu_monitor.c
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_process.c | 6 ++
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
tests/qemucapabilitiesdata/ca
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 41 ++---
1 file changed, 14 insertions(+), 27 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index ac20d04353..7a2d8dde5e 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qe
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 40
src/qemu/qemu_block.h | 3 ---
2 files changed, 43 deletions(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index ea0b783bbb..6e643598bc 100644
--- a/src/qemu/qemu_block.c
+++ b/s
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.
With new qemu versions we setup floppies via -device.
Some legacy output tests were not modernized yet so the expected output
needs to be adjusted.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 50 +++--
1 file changed, 3 insertions(+), 47 deletio
Modernize the tests as they mostly care that the aliases are properly
propagated to qemu.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/user-aliases-usb.args | 41 --
.../user-aliases-usb.x86_64-latest.args | 44 +++
tests/qemuxml2argvdata/user-aliases.args |
The 'persistjob' is always true and 'top' and 'base' are always NULL.
Adjust the functions to drop the arguments.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 3 ---
src/qemu/qemu_monitor.c | 15 +--
src/qemu/qemu_monitor.h | 3 ---
src/qemu/qemu_monitor
The operation makes no sense regardless of the way how we specify disks.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f1fc954f8c..c2722c39da 100644
--
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 27 -
src/qemu/qemu_monitor.h | 9 --
src/qemu/qemu_monitor_json.c | 57
src/qemu/qemu_monitor_json.h | 10 ---
tests/qemumonitorjsontest.c | 4 ---
5 files changed,
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c| 33 +
src/qemu/qemu_block.h| 3 +--
src/qemu/qemu_blockjob.c | 4 ++--
src/qemu/qemu_hotplug.c | 2 +-
4 files changed, 17 insertions(+), 25 deletions(-)
diff --git a/src/qemu/qemu_block.c b/src/qe
Remove the generic frontend-less -drive code from qemuBuildDriveStr by
assuming that we support only blockdev-enabled qemus.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c| 20 ---
.../blockjob-mirror-in.xml| 1 +
.../migration-in-params-in.xml| 1 +
.../migration-out-nbd-out.xml | 1 +
.../migration-out-nbd-tls-out.x
While we assume that -blockdev is supported the validator had also some
corner cases for -drive. Since we use '-drive' exclusively for the
extremely rarely used SD cards it makes no sense to have the validation.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 60 +++-
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 14 --
src/qemu/qemu_block.h | 2 --
src/qemu/qemu_command.c | 3 +--
3 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index afdcca2813..f504d8bc4c 100644
--- a/sr
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 208
src/qemu/qemu_command.h | 4 -
2 files changed, 212 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 9fc3d91a42..a8c954edf6 100644
--- a/src/qemu/qemu_comman
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 10 --
src/qemu/qemu_domain.h | 3 +--
src/qemu/qemu_validate.c | 6 ++
tests/qemublocktest.c| 4 ++--
4 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
in
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 13 +
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_process.c | 10 --
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
tests/qemuc
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 8ac99a8cf7..d372381c74 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -7635,8 +7635,6 @@ qemuDom
The capability is checked when we validate the source in the first
place. Also it won't make sense any more.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 32319c1503..fb29135179 1006
The blockdev-backup QMP command was introduced in qemu-2.3.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c| 6 --
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilities
The event was introduced in qemu-2.3
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
src/qemu/qemu_driver.c| 6 --
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xm
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 26 --
src/qemu/qemu_block.h | 3 ---
2 files changed, 29 deletions(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 6e643598bc..a5d9f47ec4 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_b
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 21 --
src/qemu/qemu_monitor.h | 10 -
src/qemu/qemu_monitor_json.c | 41
src/qemu/qemu_monitor_json.h | 11 --
tests/qemumonitorjsontest.c | 2 --
5 files ch
SD card disks can't be detached, so it makes no sense to special case
them in the unplug code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index a57db12144..3c35a115e
All media are changed in blockdev-instantiated cdroms now, remove the
old code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 88 +
1 file changed, 1 insertion(+), 87 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 59d1caa053..1ecc9a71b3 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -9992,9 +9992,7 @@ qem
All callers pass 'true'.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 36 +++-
src/qemu/qemu_domain.h | 3 +--
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_hotplug.c | 4 ++--
src/qemu/qemu_process.c | 2 +-
5 files changed, 20 insertions(+), 27
Enable blockdev mode and convert the expected commands to the modern
equivalents in preparation for removing the old-style hotplug code
paths.
Signed-off-by: Peter Krempa
---
tests/qemuhotplugtest.c | 75 ---
.../qemuhotplug-base-ccw-live+ccw-virtio.xml |
Set it same way we set throttling for other disks in
qemuProcessSetupDiskThrottling.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 42 -
src/qemu/qemu_process.c | 20 +++-
2 files changed, 11 insertions(+), 51 deletions(-)
diff
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 33 ---
src/qemu/qemu_monitor.h | 6 ---
src/qemu/qemu_monitor_text.c | 82
src/qemu/qemu_monitor_text.h | 6 ---
4 files changed, 127 deletions(-)
diff --git a/src/qemu/qemu_mo
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 31 ---
1 file changed, 12 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index c2722c39da..59d1caa053 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 11 ---
src/qemu/qemu_monitor.h | 4 ---
src/qemu/qemu_monitor_json.c | 59
src/qemu/qemu_monitor_json.h | 3 --
4 files changed, 77 deletions(-)
diff --git a/src/qemu/qemu_monitor.c b/
All supported qemu versions now work with blockdev.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index b949e1aa42..4ce920152f 100644
--- a/src/qemu/qemu_validate.c
+
Since we know we have a modern qemu at hand which can interpret the
dotted syntax, we can format the -drive needed for SD cards via the
common infrastructure we have for all blockdev stuff.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 121 +++-
1
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 60 +++--
src/qemu/qemu_domain.c | 5 +---
2 files changed, 10 insertions(+), 55 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 5c90138c73..ed718eb81b 100644
--- a/s
The only instance in this file can be simplified to avoid checking the
capability.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_alias.c | 10 --
src/qemu/qemu_alias.h | 5 ++---
src/qemu/qemu_hotplug.c | 2 +-
src/qemu/qemu_process.c | 2 +-
tests/qemuhotplugtest.c | 2 +-
5 fil
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c | 2 +-
src/qemu/qemu_checkpoint.c | 2 +-
src/qemu/qemu_domain.c | 10 +++---
src/qemu/qemu_domain.h | 3 +--
src/qemu/qemu_driver.c | 6 +++---
src/qemu/qemu_snapshot.c | 13 +
6 files changed, 14 inser
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_domain.c | 11 ---
src/qemu/qemu_domain.h | 4 +---
src/qemu/qemu_hotplug.c | 2 +-
4 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index a8
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 20 +++-
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 3c35a115e3..d7f10d8277 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -6
This function and it's callees were a bit more entangled so remove the
pre-blockdev code separately.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 80 +++---
1 file changed, 12 insertions(+), 68 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/sr
91 matches
Mail list logo