Signed-off-by: Han Han
---
README.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README.rst b/README.rst
index eacbbf2..ee20e85 100644
--- a/README.rst
+++ b/README.rst
@@ -13,7 +13,7 @@ API better suited for dbus-based applications.
libvirt-dbus is Free Software and
On Wed, Aug 03, 2022 at 06:15:24PM +0200, Andrea Bolognani wrote:
> It should be enough to enable or disable the enrolled-keys feature
> to control whether Secure Boot is enforced, but there's a slight
> complication: many distro packages for edk2 include, in addition
> to general purpose firmware
It should be enough to enable or disable the enrolled-keys feature
to control whether Secure Boot is enforced, but there's a slight
complication: many distro packages for edk2 include, in addition
to general purpose firmware images, builds that are targeting the
Confidential Computing use case.
On Tue, Jul 26, 2022 at 04:36:59PM +0200, Peter Krempa wrote:
> Assume that QEMU_CAPS_BLOCKDEV is present and remove all code executed
> when it's not.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_migration.c | 127 --
> 1 file changed, 25
Thanks for the details and recommendations Daniel!!
On 8/2/2022 11:19 AM, Daniel P. Berrangé wrote:
On Mon, Aug 01, 2022 at 11:03:49AM -0500, Praveen K Paladugu wrote:
Folks,
We are implementing Live Migration support in "ch" driver of Libvirt. I'd
like to confirm if the approach we have
On 7/29/22 21:34, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig
> ---
> src/cpu/cpu_x86.c | 8 +++
> src/util/virhostcpu.c | 55 +++
> src/util/virhostcpu.h | 3 +++
> 3 files changed, 66 insertions(+)
>
> diff --git a/src/cpu/cpu_x86.c
On 7/29/22 21:34, Jim Fehlig wrote:
> From: Dario Faggioli
>
> This patch maps /domain/cpu/maxphysaddr into -cpu parameters:
>
> - becomes host-phys-bits=on
> - becomes phys-bits=42
>
> Passthrough mode can only be used if the chosen CPU model is
> 'host-passthrough'. Also validate that
On 7/29/22 21:34, Jim Fehlig wrote:
> From: Dario Faggioli
>
> This patch introduces the
>
>
>
>
> sub element of /domain/cpu, which allows specifying the guest virtual CPU
> address size. This can be useful if the guest needs to have a large amount
> of memory.
>
> If
On 7/29/22 21:34, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig
> ---
> src/conf/cpu_conf.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
> index e31c4ab467..8e75cdbb4f 100644
> --- a/src/conf/cpu_conf.c
> +++ b/src/conf/cpu_conf.c
>
On 7/29/22 21:34, Jim Fehlig wrote:
> Hi All,
>
> This is a V2 of Dario's old patches adding support for specifying the
> virtual CPU address size in bits
>
> https://listman.redhat.com/archives/libvir-list/2020-October/210901.html
>
> I've rebased those patches to latest master and tweaked
On 8/3/22 3:31 AM, Pavel Hrdina wrote:
On Tue, Jul 26, 2022 at 04:36:45PM +0200, Peter Krempa wrote:
Discard and zero-detection for disk sources is supported since qemu-2.1
so we can always assume it's support.
s/it's/its/
alternatively: "it's supported"
Signed-off-by: Peter Krempa
On Tue, Jul 26, 2022 at 04:36:58PM +0200, Peter Krempa wrote:
> In one of early iterations of the gluster driver 'tcp' was used instead
> of 'inet' and 'socket' instead of 'path' for unix sockets. All of this
> can be now removed.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_block.c |
On 8/3/22 3:16 AM, Pavel Hrdina wrote:
On Tue, Jul 26, 2022 at 04:36:39PM +0200, Peter Krempa wrote:
The 'change-backing-file' command was added in qemu-2.1 and doesn't have
any dependancies. We use it as witness for using blockjobs with relative
backing paths. Always assume it's support.
On Tue, Jul 26, 2022 at 04:36:57PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c | 3 +--
> src/qemu/qemu_capabilities.h | 2 +-
> src/qemu/qemu_process.c | 6 ++
>
On Tue, Jul 26, 2022 at 04:36:56PM +0200, Peter Krempa wrote:
> Now that QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI is always set we can remove the
> code which handled cases when the capability was not set.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_command.c | 142
On Wed, Aug 03, 2022 at 02:24:08PM +0200, Michal Privoznik wrote:
> The qemuDomainDefCPUPostParse() does a bit more than filling in
> missing info. It also validates CPU cache configuration. Move
> that code into qemuValidateDomainDefCpu() where the code fits
> better.
>
> And since I need to fix
On Wed, Aug 03, 2022 at 01:25:02PM +0200, Jiri Denemark wrote:
> When resetting private data after stopping QEMU process we should also
> reset the original memory locking limit (both normal and pre-migration)
> as they are not relevant anymore.
>
> Signed-off-by: Jiri Denemark
> ---
This patch moves qemuDomainObjClearJob() as
virDomainObjClearJob() into hypervisor in order to be used by
other hypervisors as well.
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.c | 14 ++
src/hypervisor/domain_job.h | 3 +++
src/libvirt_private.syms| 1 +
Signed-off-by: Kristina Hanicova
---
src/lxc/lxc_domain.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/lxc/lxc_domain.c b/src/lxc/lxc_domain.c
index 6f048a128a..654c35c640 100644
--- a/src/lxc/lxc_domain.c
+++ b/src/lxc/lxc_domain.c
@@ -35,11 +35,6 @@
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.c | 8
src/hypervisor/domain_job.h | 2 ++
src/libvirt_private.syms| 1 +
src/qemu/qemu_domainjob.c | 14 +++---
4 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/src/hypervisor/domain_job.c
This patch moves qemuDomainTrackJob() as virDomainTrackJob() into
hypervisor because it is called in begin job and end job
functions that will be generalized in the following series.
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.c | 6 ++
src/hypervisor/domain_job.h | 2
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.c | 11 +++
src/hypervisor/domain_job.h | 4
src/libvirt_private.syms| 1 +
src/qemu/qemu_domainjob.c | 13 +
4 files changed, 17 insertions(+), 12 deletions(-)
diff --git
Signed-off-by: Kristina Hanicova
---
src/ch/ch_domain.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c
index 499d31cf4a..817b1176d5 100644
--- a/src/ch/ch_domain.c
+++ b/src/ch/ch_domain.c
@@ -32,12 +32,6 @@
Signed-off-by: Kristina Hanicova
---
src/libxl/libxl_domain.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 467c1ee914..9a23598512 100644
--- a/src/libxl/libxl_domain.c
+++ b/src/libxl/libxl_domain.c
@@
This patch moves qemuDomainObjPreserveJob() as
virDomainObjPreserveJob() into hypervisor in order to be used by
other hypervisors as well.
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.c | 32
src/hypervisor/domain_job.h | 3 +++
This patch moves qemuDomainObjResetAsyncJob() as
virDomainObjResetAsyncJob() into hypervisor.
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.c | 19 +++
src/hypervisor/domain_job.h | 2 ++
src/libvirt_private.syms| 1 +
src/qemu/qemu_domainjob.c | 29
This patch moves qemuDomainObjResetAgentJob() as
virDomainObjResetAgentJob() into hypervisor.
Signed-off-by: Kristina Hanicova
---
src/hypervisor/domain_job.c | 9 +
src/hypervisor/domain_job.h | 2 ++
src/libvirt_private.syms| 1 +
src/qemu/qemu_domainjob.c | 14 ++
This series moves helper functions from qemu so that they can be used by
other hypervisors or BeginJob / EndJob functions which will be
generalized and moved in one of the following series as well.
Kristina Hanicova (11):
qemu & hypervisor: move qemuDomainObjResetAgentJob() into hypervisor
It does not make sense to propagate virDomainObj and get
qemuDomainObjPrivate from it, when it is already accessible in
the only function qemuDomainObjPreserveJob() is called from. That
being said, we can also propagate virDomainJobObj directly and
avoid using qemu private structure.
On Wed, Aug 03, 2022 at 01:52:41PM +0200, Jiri Denemark wrote:
> When we call qemuDomainSetMaxMemLock to reset memory locking limit back
> to its original value the domain can already be stopped (for example
> after the domain shuts down during migration) in which case it does not
> make sense to
The qemuDomainDefCPUPostParse() does a bit more than filling in
missing info. It also validates CPU cache configuration. Move
that code into qemuValidateDomainDefCpu() where the code fits
better.
And since I need to fix indentation of existing code in
qemuValidateDomainDefCpu(), I'm taking this
On Tue, Aug 2, 2022 at 12:28 PM Michal Privoznik
wrote:
> Technically, this is a v2 of:
>
> https://listman.redhat.com/archives/libvir-list/2022-July/233306.html
>
> but not really. Because I've discarded the 3/3 from original series and
> implemented Andrea's idea.
>
> Michal Prívozník (4):
>
When we call qemuDomainSetMaxMemLock to reset memory locking limit back
to its original value the domain can already be stopped (for example
after the domain shuts down during migration) in which case it does not
make sense to set any limit. Doing so can even be harmful as we may end
up setting
When resetting private data after stopping QEMU process we should also
reset the original memory locking limit (both normal and pre-migration)
as they are not relevant anymore.
Signed-off-by: Jiri Denemark
---
src/qemu/qemu_domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
On Tue, Jul 26, 2022 at 04:36:55PM +0200, Peter Krempa wrote:
> Retire:
> QEMU_CAPS_BLOCK_FILE_AUTO_READONLY_DYNAMIC
> QEMU_CAPS_SCSI_DISK_DEVICE_ID
> QEMU_CAPS_SAVEVM_MONITOR_NODES
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c | 9
On Tue, Jul 26, 2022 at 04:36:54PM +0200, Peter Krempa wrote:
> The 'device_id' property of 'scsi_disk' was added in qemu-4.0 and it's
> unconditionally present, thus we can now always assume it's presence.
s/it's presence/its presence/
> Update some fake-caps test which didn't yet assert the
On Tue, Jul 26, 2022 at 04:36:53PM +0200, Peter Krempa wrote:
> The code which fills 'qomName' does so only when the blockdev capability
> is enabled so we don't have to check it separately as it can be only
> non-NULL when blockdev is used.
>
> Signed-off-by: Peter Krempa
> ---
>
On Tue, Jul 26, 2022 at 04:36:52PM +0200, Peter Krempa wrote:
> Until we finish removing the capabilities we need to force them in the
> tests so that it's obvious that the code changes have no impact.
>
> Signed-off-by: Peter Krempa
> ---
> .../aarch64-aavmf-virtio-mmio.args| 5
On Tue, Jul 26, 2022 at 04:36:51PM +0200, Peter Krempa wrote:
> The cleanup of the code to always assume support for QEMU_CAPS_BLOCKDEV
> will not be simple, so for now we hardcode the support and the code will
> be cleaned up gradually.
>
> We also disallow users to clear the flags via the
On Tue, Jul 26, 2022 at 04:36:50PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c | 3 +--
> src/qemu/qemu_capabilities.h | 2 +-
> tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
>
On Tue, Jul 26, 2022 at 04:36:49PM +0200, Peter Krempa wrote:
> luks-encrypted QCOW2 files were introduced in qemu-2.6 unconditionally.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_domain.c | 8
> 1 file changed, 8 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
On Tue, Jul 26, 2022 at 04:36:48PM +0200, Peter Krempa wrote:
> Modernize 'disk-nvme', 'encrypted-disk-usage', 'encrypted-disk', and
> 'user-aliases' cases to use DO_TEST_CAPS_LATEST.
>
> This will remove all uses of QEMU_CAPS_QCOW2_LUKS from the test suite.
>
> Since the output files are done
On Tue, Jul 26, 2022 at 04:36:47PM +0200, Peter Krempa wrote:
> Modernize the tests as they mostly care that the aliases are properly
> propagated to qemu.
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemuxml2argvdata/user-aliases-usb.args | 41 --
>
On Tue, Jul 26, 2022 at 04:36:46PM +0200, Peter Krempa wrote:
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c | 6 ++
> src/qemu/qemu_capabilities.h | 4 ++--
> tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 2 --
>
On Tue, Jul 26, 2022 at 04:36:45PM +0200, Peter Krempa wrote:
> Discard and zero-detection for disk sources is supported since qemu-2.1
> so we can always assume it's support.
s/it's/its/
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_validate.c | 14 --
> 1 file changed, 14
On Tue, Jul 26, 2022 at 04:36:44PM +0200, Peter Krempa wrote:
> The debug level of gluster backend became configurable in qemu-2.8.
>
> This also removes the only old-style syntax for the 'blockdev-add'
> command prior to stabilization.
>
> Signed-off-by: Peter Krempa
> ---
>
On Tue, Jul 26, 2022 at 04:36:43PM +0200, Peter Krempa wrote:
> The 'debug' level for the gluster driver was added in qemu-2.8
> unconditionally so libvirt can always assume it.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_domain.c | 13 +
> 1 file changed, 5 insertions(+),
On Tue, Jul 26, 2022 at 04:36:42PM +0200, Peter Krempa wrote:
> Active block commit is supported since qemu-2.0
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c | 3 +--
> src/qemu/qemu_capabilities.h | 2 +-
>
On Tue, Jul 26, 2022 at 04:36:41PM +0200, Peter Krempa wrote:
> Active layer block commit is unconditionally supported since qemu-2.0.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_driver.c | 5 -
> 1 file changed, 5 deletions(-)
Reviewed-by: Pavel Hrdina
signature.asc
On Tue, Jul 26, 2022 at 04:36:40PM +0200, Peter Krempa wrote:
> The 'change-backing-file' command is unconditionally supported since
> qemu-2.1.
>
> Signed-off-by: Peter Krempa
> ---
> src/qemu/qemu_capabilities.c | 3 +--
> src/qemu/qemu_capabilities.h
On Tue, Jul 26, 2022 at 04:36:39PM +0200, Peter Krempa wrote:
> The 'change-backing-file' command was added in qemu-2.1 and doesn't have
> any dependancies. We use it as witness for using blockjobs with relative
> backing paths. Always assume it's support.
s/dependancies/dependencies/
>
51 matches
Mail list logo
