Re: [PATCH] remote: Make remote_daemon depend on qemu_protocol.h

On 8/8/22 22:59, Michal Prívozník wrote: > On 7/20/22 10:41, He Zhe wrote: >> We sometimes meet the following parallel compililation issue, since >> remote_daemon depends on remote_protocol.h qemu_protocol.h and >> lxc_protocol.h, >> which are usually generated due to remote_driver . >> >> |

Re: Test failures on macOS 12

> On 10 Jun 2022, at 11:34, Andrea Bolognani wrote: > > On Fri, May 06, 2022 at 03:00:14AM -0700, Andrea Bolognani wrote: >> I'm trying to enable CI coverage for macOS 12, but I'm running into a >> couple of issues that I'm not sure how to handle. >> >> Note that the test suite currently

Re: Test failures on macOS 12

Hi Andrea, I saw your call to Sergio and Marc-André on IRC, and I thought I would spend a few minutes inviestigating. > On 10 Jun 2022, at 11:34, Andrea Bolognani wrote: > > On Fri, May 06, 2022 at 03:00:14AM -0700, Andrea Bolognani wrote: >> I'm trying to enable CI coverage for macOS 12,

[libvirt PATCH] rpm: merge mingw sub-packages into native spec

One specfile containing both native and mingw builds is the new best practice for Fedora. This reduces the maint burden and ensures the mingw packages don't fall behind. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml| 2 +- libvirt.spec.in | 287

Re: [libvirt PATCH] conf: Simplify IOMMU device validation

On a Monday in 2022, Andrea Bolognani wrote: Instead of duplicating the list of attributes that are not allowed for some of the IOMMU models, use two separate switch statements: one for the attributes and one for the address. Signed-off-by: Andrea Bolognani --- src/conf/domain_validate.c | 22

Re: [libvirt PATCH] conf: Simplify IOMMU device validation

On Mon, Aug 08, 2022 at 05:41:16PM +0200, Andrea Bolognani wrote: > Instead of duplicating the list of attributes that are not > allowed for some of the IOMMU models, use two separate switch > statements: one for the attributes and one for the address. > > Signed-off-by: Andrea Bolognani > --- >

Re: [PATCH v2 0/7] qemu: remove support for query-cpus

On Mon, Aug 08, 2022 at 05:15:01PM +0200, Paolo Bonzini wrote: > The query-cpus-fast command was introduced in 2.12, therefore query-cpus > is never used on supported versions of QEMU. Remove the logic to parse > its output, as well as the parameters to choose between the two commands. > > Since

[libvirt PATCH] conf: Simplify IOMMU device validation

Instead of duplicating the list of attributes that are not allowed for some of the IOMMU models, use two separate switch statements: one for the attributes and one for the address. Signed-off-by: Andrea Bolognani --- src/conf/domain_validate.c | 22 +- 1 file changed, 9

Re: [PATCH v2 0/7] qemu: remove support for query-cpus

On Mon, Aug 08, 2022 at 17:15:01 +0200, Paolo Bonzini wrote: > The query-cpus-fast command was introduced in 2.12, therefore query-cpus > is never used on supported versions of QEMU. Remove the logic to parse > its output, as well as the parameters to choose between the two commands. > > Since

[PATCH v2 4/7] tests: convert x86_64 tests to query-cpus-fast

All supported versions of QEMU include the query-cpus-fast QMP command. In preparation for dropping support for the old "query-cpus" commands, convert the JSON output for x86 tests to the new format, and drop the "halted" field from the expected output as it is not available anymore. The CPU

[PATCH v2 5/7] tests: remove query-cpus tests

All tests now use query-cpus-fast. Since the QEMU driver will lose support for query-cpus soon, go ahead and remove support for testing it. Signed-off-by: Paolo Bonzini --- tests/qemumonitorjsontest.c | 117 +--- 1 file changed, 15 insertions(+), 102

[PATCH v2 7/7] qemu: deprecate query-cpus-fast capability

All supported versions of QEMU have the command. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 -

[PATCH v2 2/7] tests: drop "-fast" from query-cpus-fast tests

All supported versions of QEMU include the query-cpus-fast QMP command. In preparation for dropping support for the old "query-cpus" commands, remove the "-fast" suffix from both x86-full-fast and s390-fast. Signed-off-by: Paolo Bonzini --- ...-fast-cpus.json =>

[PATCH v2 6/7] qemu: remove support for query-cpus

The query-cpus-fast command was introduced in 2.12, therefore query-cpus is never used on supported versions of QEMU. Remove the logic to parse its output, as well as the parameters to choose between the two commands. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_domain.c | 22

[PATCH v2 0/7] qemu: remove support for query-cpus

The query-cpus-fast command was introduced in 2.12, therefore query-cpus is never used on supported versions of QEMU. Remove the logic to parse its output, as well as the parameters to choose between the two commands. Since most tests were still mocking the query-cpus command, the expected

[PATCH v2 1/7] tests: remove duplicate cpuinfo test

All supported versions of QEMU include the query-cpus-fast QMP command. In preparation for dropping support for the old "query-cpus" commands, remove the query-cpus version of the x86-full test. Signed-off-by: Paolo Bonzini --- ...qemumonitorjson-cpuinfo-x86-full-cpus.json | 104

[PATCH v2 3/7] tests: convert ppc64 tests to query-cpus-fast

All supported versions of QEMU include the query-cpus-fast QMP command. In preparation for dropping support for the old "query-cpus" commands, convert the JSON output for PPC tests to the new format, and drop the "halted" field from the expected output as it is not available anymore. The CPU

Re: [PATCH 3/7] tests: convert ppc64 tests to query-cpus-fast

On 8/8/22 16:44, Pavel Hrdina wrote: diff --git a/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json b/tests/qemumonitorjsondata/qemumonitorjson-cpuinfo-ppc64-no-threads-cpus.json index 31a3905e43..0ee53ae471 100644 ---

Re: [PATCH] remote: Make remote_daemon depend on qemu_protocol.h

On 7/20/22 10:41, He Zhe wrote: > We sometimes meet the following parallel compililation issue, since > remote_daemon depends on remote_protocol.h qemu_protocol.h and lxc_protocol.h, > which are usually generated due to remote_driver . > > | FAILED:

Re: [PATCH 7/7] qemu: deprecate query-cpus-fast capability

On Mon, Aug 08, 2022 at 15:06:08 +0200, Paolo Bonzini wrote: > All supported versions of QEMU have the command. > > Signed-off-by: Paolo Bonzini > --- > src/qemu/qemu_capabilities.c | 4 ++-- > src/qemu/qemu_capabilities.h | 2 +- > tests/qemuhotplugtest.c | 2 -- > 3 files changed, 3

Re: [PATCH 3/7] tests: convert ppc64 tests to query-cpus-fast

On Mon, Aug 08, 2022 at 03:06:04PM +0200, Paolo Bonzini wrote: > All supported versions of QEMU include the query-cpus-fast QMP command. > In preparation for dropping support for the old "query-cpus" commands, > convert the JSON output for PPC tests to the new format, and drop the > "halted" field

Re: [PATCH] conf: Check IOMMU for unsupported attributes

On a Monday in 2022, Michal Privoznik wrote: Currently, it's possible to pass various attributes to an IOMMU's element hoping that we enable them in underlying hypervisor. However, depending on the IOMMU model, some of these attributes can't be enabled and are simply ignored. This is suboptimal

[PATCH 5/7] tests: remove query-cpus tests

All tests now use query-cpus-fast. Since the QEMU driver will lose support for query-cpus soon, go ahead and remove support for testing it. Signed-off-by: Paolo Bonzini --- tests/qemumonitorjsontest.c | 117 +--- 1 file changed, 15 insertions(+), 102

[PATCH 6/7] qemu: remove support for query-cpus

The query-cpus-fast command was introduced in 2.12, therefore query-cpus is never used on supported versions of QEMU. Remove the logic to parse its output, as well as the parameters to choose between the two commands. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_domain.c | 22

[PATCH 7/7] qemu: deprecate query-cpus-fast capability

All supported versions of QEMU have the command. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_capabilities.c | 4 ++-- src/qemu/qemu_capabilities.h | 2 +- tests/qemuhotplugtest.c | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[PATCH 3/7] tests: convert ppc64 tests to query-cpus-fast

All supported versions of QEMU include the query-cpus-fast QMP command. In preparation for dropping support for the old "query-cpus" commands, convert the JSON output for PPC tests to the new format, and drop the "halted" field from the expected output as it is not available anymore. The CPU

[PATCH 4/7] tests: convert x86_64 tests to query-cpus-fast

All supported versions of QEMU include the query-cpus-fast QMP command. In preparation for dropping support for the old "query-cpus" commands, convert the JSON output for x86 tests to the new format, and drop the "halted" field from the expected output as it is not available anymore. The CPU

[PATCH 2/7] tests: drop "-fast" from query-cpus-fast tests

All supported versions of QEMU include the query-cpus-fast QMP command. In preparation for dropping support for the old "query-cpus" commands, remove the "-fast" suffix from both x86-full-fast and s390-fast. Signed-off-by: Paolo Bonzini --- ...-fast-cpus.json =>

[PATCH 1/7] tests: remove duplicate cpuinfo test

All supported versions of QEMU include the query-cpus-fast QMP command. In preparation for dropping support for the old "query-cpus" commands, remove the query-cpus version of the x86-full test. Signed-off-by: Paolo Bonzini --- ...qemumonitorjson-cpuinfo-x86-full-cpus.json | 104

[PATCH 0/7] qemu: remove support for query-cpus

The query-cpus-fast command was introduced in 2.12, therefore query-cpus is never used on supported versions of QEMU. Remove the logic to parse its output, as well as the parameters to choose between the two commands. Since most tests were still mocking the query-cpus command, the expected

[PATCH] conf: Check IOMMU for unsupported attributes

Currently, it's possible to pass various attributes to an IOMMU's element hoping that we enable them in underlying hypervisor. However, depending on the IOMMU model, some of these attributes can't be enabled and are simply ignored. This is suboptimal and we should reject such configuration in the

Re: [PATCH] news: qemu: Add support for zero-copy migration

On 7/22/22 10:49, Fangge Jin wrote: > Signed-off-by: Fangge Jin > --- > NEWS.rst | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 79aad652e8..0eb3299e3b 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -42,6 +42,11 @@ v8.5.0 (2022-07-01) > A new

Re: [PATCH 00/11] qemu & hypervisor: move helper job functions

On 8/3/22 14:43, Kristina Hanicova wrote: > This series moves helper functions from qemu so that they can be used by > other hypervisors or BeginJob / EndJob functions which will be > generalized and moved in one of the following series as well. > > Kristina Hanicova (11): > qemu & hypervisor: