Re: libvirtd: failed to connect to socket after installation

On Wed, Sep 07, 2022 at 10:28:17AM -0500, Carlos Bilbao wrote: > On 9/6/22 12:50, Carlos Bilbao wrote: > > So, what I did this time was: > > > > $ ninja -C build clean I would recommend nuking the build/ directory completely if you're going to reconfigure, just to be on the safe side. > > $ meson

Re: [PATCH] qemu_monitor_json: remove unnecessary variable 'rc'

On 9/7/22 8:13 AM, Kristina Hanicova wrote: Signed-off-by: Kristina Hanicova --- src/qemu/qemu_monitor_json.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 70fba50e6c..5f7c1a8db9 100644 --- a/src/

Re: [libvirt RFC 23/24] qemu_snapshot: when deleting snapshot invalidate parent snapshot

On Tue, Aug 23, 2022 at 18:32:26 +0200, Pavel Hrdina wrote: > When deleting external snapshots the operation may fail at any point > which could lead to situation that some disks finished the block commit > operation but for some disks it failed and the libvirt job ends. > > In order to make sure

[PATCH] qemu_monitor_json: remove unnecessary variable 'rc'

Signed-off-by: Kristina Hanicova --- src/qemu/qemu_monitor_json.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 70fba50e6c..5f7c1a8db9 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_mon

Re: [libvirt RFC 22/24] qemu_snapshot: update metadata when deleting snapshots

On Tue, Aug 23, 2022 at 18:32:25 +0200, Pavel Hrdina wrote: > With external snapshots we need to modify the metadata bit more then > what is required for internal snapshots. Mainly the storage source > location changes with every external snapshot. > > This means that if we delete non-leaf snapsho

Re: [PATCH] Revert "conf: clean up memory containing secrets before freeing"

On a Wednesday in 2022, Peter Krempa wrote: Adding supposedly secure cleanup for secrets in anything related to the XML parser is pointless because there are multiple other un-sanitized copies of the full XML and the XML parser state at the very least. Similarly in case RPC was used to transport

Re: [PATCH] Revert "conf: clean up memory containing secrets before freeing"

On Wed, Sep 07, 2022 at 01:13:23PM +0200, Peter Krempa wrote: Adding supposedly secure cleanup for secrets in anything related to the XML parser is pointless because there are multiple other un-sanitized copies of the full XML and the XML parser state at the very least. Similarly in case RPC was

Re: [RFC PATCH 1/6] qemu_monitor: add qemuMonitorQueryStatsSchema

On Wed, Sep 07, 2022 at 02:23:24PM +0200, Kristina Hanicova wrote: Hi, just a few notes on the code quality. On Wed, Sep 7, 2022 at 12:34 PM Amneesh Singh wrote: Related: https://gitlab.com/libvirt/libvirt/-/issues/276 This patch adds a simple API for "query-stats-schemas" QMP command Sign

Re: [libvirt RFC 21/24] qemu_snapshot: implement deletion of external snapshot

On Tue, Aug 23, 2022 at 18:32:24 +0200, Pavel Hrdina wrote: > When deleting snapshot we are starting block-commit job over all disks > that are part of the snapshot. > > This operation may fail as it writes data changes to the backing qcow2 > image so we need to wait for all the disks to finish th

Re: [RFC PATCH 1/6] qemu_monitor: add qemuMonitorQueryStatsSchema

Hi, just a few notes on the code quality. On Wed, Sep 7, 2022 at 12:34 PM Amneesh Singh wrote: > Related: https://gitlab.com/libvirt/libvirt/-/issues/276 > > This patch adds a simple API for "query-stats-schemas" QMP command > > Signed-off-by: Amneesh Singh > --- > src/qemu/qemu_monitor.c

Re: [PATCH] Revert "conf: clean up memory containing secrets before freeing"

On Wed, Sep 07, 2022 at 01:13:23PM +0200, Peter Krempa wrote: > Adding supposedly secure cleanup for secrets in anything related to the > XML parser is pointless because there are multiple other un-sanitized > copies of the full XML and the XML parser state at the very least. > > Similarly in case

[PATCH] Revert "conf: clean up memory containing secrets before freeing"

Adding supposedly secure cleanup for secrets in anything related to the XML parser is pointless because there are multiple other un-sanitized copies of the full XML and the XML parser state at the very least. Similarly in case RPC was used to transport the XML the RPC buffers are not sanitized. A

Re: [PATCH 1/3] conf: clean up memory containing secrets before freeing

On Wed, Sep 07, 2022 at 11:54:59 +0200, Michal Prívozník wrote: > On 9/6/22 15:48, Jiacheng Jiang wrote: > > From: jiangjiacheng > > > > The password may not be valid in the error branch, but for > > higher security, it's better to clean up the memory before > > freeing it. > > > > Signed-off-by

[RFC PATCH 5/6] qemu_driver: add the vCPU stats by KVM to the current stats

This patch adds the stats queried by qemuMonitorQueryStats for vCPU and add them according to their QOM device path Signed-off-by: Amneesh Singh --- src/qemu/qemu_driver.c | 86 ++ 1 file changed, 86 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src

[RFC PATCH 6/6] qemu_driver: add new stats worker qemuDomainGetStatsVm

This patch adds a new worker qemuDomainGetStatsVm which reports the stats returned by "query-stats" via qemuMonitorQueryStats for the VM target. Signed-off-by: Amneesh Singh --- include/libvirt/libvirt-domain.h | 1 + src/libvirt-domain.c | 3 +++ src/qemu/qemu_driver.c |

[RFC PATCH 3/6] qemu_domain: add statsSchema to qemuDomainObjPrivate

This patch adds a hashtable for storing the stats schema and a function to refresh it by querying "query-stats-schemas" using qemuMonitorQueryStatsSchema Signed-off-by: Amneesh Singh --- src/qemu/qemu_domain.c | 41 + src/qemu/qemu_domain.h | 5 + 2 f

[RFC PATCH 0/6] qemu: add support for query-stats-schemas

This patch adds an API for query-stats-schemas and uses it to work with the pre-existing API for query-stats to display those stats. [1/6]: This patch adds a simple API for query-stats-schemas and an extractor function to deserialise it into a GHashTable. The GHashTable here is a pair of the name

[RFC PATCH 2/6] qemu_capabilities: add "query-stats-schemas" QMP command to the QEMU capabilities

Related: https://gitlab.com/libvirt/libvirt/-/issues/276 Signed-off-by: Amneesh Singh --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml | 1 + 3 files changed, 4 insertions(+) dif

[RFC PATCH 4/6] qemu_monitor: add qemuMonitorGetStatsByQOMPath

This function returns the virJSONValue object which has the same qom_path as specified. Signed-off-by: Amneesh Singh --- src/qemu/qemu_monitor.c | 38 ++ src/qemu/qemu_monitor.h | 4 2 files changed, 42 insertions(+) diff --git a/src/qemu/qemu_monitor.c

[RFC PATCH 1/6] qemu_monitor: add qemuMonitorQueryStatsSchema

Related: https://gitlab.com/libvirt/libvirt/-/issues/276 This patch adds a simple API for "query-stats-schemas" QMP command Signed-off-by: Amneesh Singh --- src/qemu/qemu_monitor.c | 29 +++ src/qemu/qemu_monitor.h | 35 ++ src/qemu/qemu_monitor_json.c | 93 +++

Re: [PATCH 1/3] conf: clean up memory containing secrets before freeing

On 9/6/22 15:48, Jiacheng Jiang wrote: > From: jiangjiacheng > > The password may not be valid in the error branch, but for > higher security, it's better to clean up the memory before > freeing it. > > Signed-off-by: jiangjiacheng > --- > src/conf/domain_conf.c | 2 ++ > 1 file changed, 2 ins

Re: [PATCH 0/3] Fix some coding issues

On 9/6/22 18:26, Kristina Hanicova wrote: > > > On Tue, Sep 6, 2022 at 4:14 PM Jiacheng Jiang > wrote: > > From: jiangjiacheng > > > *** BLURB HERE *** > > jiangjiacheng (3): >   conf: clean up memory conta

Re: [PATCH 1/3] conf: clean up memory containing secrets before freeing

On Tue, Sep 06, 2022 at 21:48:29 +0800, Jiacheng Jiang wrote: > From: jiangjiacheng > > The password may not be valid in the error branch, but for > higher security, it's better to clean up the memory before > freeing it. > > Signed-off-by: jiangjiacheng > --- > src/conf/domain_conf.c | 2 ++ >