Re: [PATCH 37/37] virDomainNetDefParseXML: Drop prehistoric error workaround

On 9/19/22 4:55 AM, Peter Krempa wrote: Apart from it being a long time ago the 'openvz' driver is also rarely used. Signed-off-by: Peter Krempa As the person who added this hack, I approve. Reviewed-by: Laine Stump --- src/conf/domain_conf.c | 20 1 file changed,

Re: [PATCH 03/37] conf: domain: Remove 'error' label in virDomainNetDefParseXML

On a Monday in 2022, Peter Krempa wrote: The 'error' label was an alias to 'return NULL;'. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 155 - 1 file changed, 76 insertions(+), 79 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [PATCH 02/37] conf: domain: Automatically free 'def' and 'actual' in virDomainNetDefParseXML

On a Monday in 2022, Peter Krempa wrote: Convert the last two variables having inline cleanup to automatic cleanup. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [PATCH 01/37] conf: domain: Register automatic pointer freeing for virDomainActualNetDef

On a Monday in 2022, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/conf/domain_conf.h | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Ján Tomko Jano

[PATCH 3/3] tests: refactor pseries features parse failure tests

The qemuxml2argvtest pseries-feature parse failure tests uses a symlink to the pseries-features.xml test domain and control which feature it is supposed to fail by excluding it from the capabilities list. The advantage of this approach is that the same XML can be used in multiple tests. One

[PATCH 2/3] tests: change qemuxml2argv pseries tests to TEST_CAPS_LATEST

Eliminate most of the pseries tests that are using explicit qemu caps instead of CAPS_LATEST. The remaining tests will be handled in the next patch. The changes made are trivial: rename the .args/.err files to ppc64-latest.(args/err) and do the required changes to match the newest capabilities.

[PATCH 0/3] ppc64: QEMU 7.1 caps + use CAPS_LATEST in xml2argv

Hi, This series updates the remaining pseries tests in qemuxml2argvtest.c to use CAPS_LATEST instead of using a capability list for each test. First patch is the usual capability bump for the new QEMU release. Second patch converts the most simple cases of DO_TEST() to use DO_TEST_CAPS_LATEST().

Re: [PATCH] virdomainjob: virDomainObjInitJob: Store a copy of virDomainObjPrivateJobCallbacks

On a Monday in 2022, Peter Krempa wrote: 'virDomainObjPrivateJobCallbacks' is passed into the job object by copying a pointer from the 'virDomainXMLOption' struct passed in from the caller. Unfortunately the 'virdomainjob' module can't control the lifetime of the virDomainXMLOption, which in

Re: [PATCH v2] meson: Require libssh-0.8.1 or newer

On a Monday in 2022, Michal Privoznik wrote: According to repology.org: RHEL-8: 0.9.4 RHEL-9: 0.9.6 Debian 11: 0.9.5 openSUSE Leap 15.3: 0.8.7 Ubuntu 20.04: 0.9.3 And the rest of distros has something newer anyways. Requiring 0.8.1 or newer allows us

Plans for the next release

We are getting close to the next release of libvirt. To aim for the release on Oct 03 I suggest entering the freeze on Tuesday Sep 27 and tagging RC2 on Friday Sep 30. I hope this works for everyone. Jirka

Re: [libvirt PATCH v2 04/16] util: Allow virFileCache data to be any GObject

On Wed, Aug 31, 2022 at 13:40:49 -0500, Jonathon Jongsma wrote: > Since the libvirt documentation suggests to prefer GObject over > virObject, and since virObject is a GObject, change virFileCache to > allow GObjects as data. > > Signed-off-by: Jonathon Jongsma > --- > src/util/virfilecache.c |

Re: [libvirt PATCH v2 03/16] qemu: expand nbdkit capabilities

On Wed, Aug 31, 2022 at 13:40:48 -0500, Jonathon Jongsma wrote: > In order to add caching of the nbdkit capabilities, we will need to > compare against file modification times, etc. So look up this > information when creating the nbdkit caps. > > Add a nbdkit_moddir build option to allow the

Re: [libvirt PATCH v2 02/16] qemu: Add qemuNbdkitCaps to qemu driver

On Wed, Aug 31, 2022 at 13:40:47 -0500, Jonathon Jongsma wrote: > In future commits, we will optionally use nbdkit to serve some remote > disk sources. This patch queries to see whether nbdkit is installed on > the host and queries it for capabilities. These capabilities are stored > in the qemu

Re: [libvirt PATCH v2 01/16] schema: allow 'ssh' as a protocol for network disks

On Wed, Aug 31, 2022 at 13:40:46 -0500, Jonathon Jongsma wrote: > There was support in the code for parsing protocol='ssh' on network disk > sources, but it was not present in the xml schema. Add this to the > schema and mention it in the documentation. The problem here is that it doesn't really

Re: [libvirt PATCH v2 00/16] Use nbdkit for http/ftp/ssh network drives in libvirt

On Wed, Aug 31, 2022 at 13:40:45 -0500, Jonathon Jongsma wrote: > After a bit of a lengthy delay, this is the second version of this patch > series. See https://bugzilla.redhat.com/show_bug.cgi?id=2016527 for more > information about the goal, but the summary is that RHEL does not want to ship >

Re: [PATCH v2 08/11] vfio/migration: Remove VFIO migration protocol v1

On Mon, May 30, 2022 at 7:56 PM Avihai Horon wrote: > > Now that v2 protocol implementation has been added, remove the > deprecated v1 implementation. Worth a note in docs/about/deprecated.rst? > Signed-off-by: Avihai Horon > --- > hw/vfio/common.c | 19 +- > hw/vfio/migration.c

Re: [PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

On Mon, Sep 19, 2022 at 09:41:57 +0200, Peter Krempa wrote: > On Mon, Sep 19, 2022 at 09:28:28 +0200, Peter Krempa wrote: > > On Mon, Sep 19, 2022 at 09:24:47 +0200, Peter Krempa wrote: > > > On Fri, Sep 16, 2022 at 13:30:07 +0100, Daniel P. Berrangé wrote: > > > > On Mon, Sep 05, 2022 at

[PATCH 31/37] virDomainNetDefParseXML: Refactor parsing of

Base whether virtualport is supported for a given interface on a new variable named 'virtualport_flags' which also configures the parser for the virtualports subelement and fill it in the appropriate interface type branches. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 41

[PATCH 16/37] virDomainNetDefParseXML: Refactor parsing of data for VIR_DOMAIN_NET_TYPE_NETWORK

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 68 +++--- 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d75ce46a7f..de0a038526 100644 --- a/src/conf/domain_conf.c +++

[PATCH 23/37] virDomainNetDefParseXML: Extract network device model earlier

Move the code fetching the model of the net device before the main code parsing individual device types so that the data is available before the upcoming refactor. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH 32/37] virDomainNetDef: Use virTristateBool for 'managed_tap' instead of int

Convert the strut member to proper type. Signed-off-by: Peter Krempa --- src/conf/domain_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8fecf0566c..352b88eae5 100644 --- a/src/conf/domain_conf.h +++

[PATCH 15/37] virDomainNetDefParseXML: Convert parsing of 'source_node' to a switch() statement

Convert the individual 'if' clauses to a swtich statement. By moving the check that 'source_node' is non-null inside of each case rather we will be able to move more type specific code into the swithc statemen when it will be refactored in subsequent patches. Signed-off-by: Peter Krempa ---

[PATCH 12/37] util: xml: Introduce virXMLPropUUID

The helper function extracts an UUID with semantics similar to other helpers we have. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 45 src/util/virxml.h| 7 +++ 3 files changed, 53 insertions(+)

[PATCH 27/37] util: xml: Introduce VIR_XPATH_NODE_AUTORESTORE_NAME

VIR_XPATH_NODE_AUTORESTORE_NAME is a more generic version of the VIR_XPATH_NODE_AUTORESTORE macro used to save the 'node' inside a XPath context struct. The new macro allows specifying the name of the variable used to save the context so that it can be used multiple times inside a function's

[PATCH 33/37] virDomainNetDefParseXML: Refactor parsing of subelement

Specifically rework of parsing of the 'managed' attribute simplifies the code greatly. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[PATCH 28/37] virDomainNetDefParseXML: Refactor parsing of data for VIR_DOMAIN_NET_TYPE_UDP/MCAST/SERVER/CLIENT

This also removes the confusing use of variables named 'tmpNode' and 'tmp_node' right next to each other. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 101 + 1 file changed, 31 insertions(+), 70 deletions(-) diff --git

[PATCH 19/37] virDomainNetDefParseXML: Refactor parsing of data for VIR_DOMAIN_NET_TYPE_INTERNAL

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cdf94ac75d..0c97be1766 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8999,7

[PATCH 18/37] virDomainNetDefParseXML: Refactor parsing of data for VIR_DOMAIN_NET_TYPE_VDS

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 78 ++ 1 file changed, 18 insertions(+), 60 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index de0a038526..cdf94ac75d 100644 --- a/src/conf/domain_conf.c +++

[PATCH 37/37] virDomainNetDefParseXML: Drop prehistoric error workaround

Apart from it being a long time ago the 'openvz' driver is also rarely used. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 20 1 file changed, 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d3755547c7..b7be1bae06 100644 ---

[PATCH 35/37] virDomainNetDefParseXML: Don't overload 'node' variable when parsing

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c680d2bcc7..2a266ac6c9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8994,6 +8994,7 @@

[PATCH 36/37] virDomainNetDefParseXML: Parse attributes of only when present

Access the 'mac_node' variable only when it was filled. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 48 +- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[PATCH 09/37] virDomainNetIPInfoParseXML: Don't VIR_FREE and overwrite autofreed 'nodes'

Use two separate variables for the nodes and count instead. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5c91cbd0db..797914b7bc 100644 ---

[PATCH 34/37] virDomainNetDefParseXML: Refactor parsing of

Parse the element only when the network type requires it and assign it directly. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 45 +++--- 1 file changed, 11 insertions(+), 34 deletions(-) diff --git a/src/conf/domain_conf.c

[PATCH 30/37] conf: domain: Move prue validation code from virDomainNetDefParseXML to virDomainNetDefValidate

The moved code is pure validation of semantics of the definition and not actual parsed values. Move it to the validation code. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 38 -- src/conf/domain_validate.c | 34

[PATCH 29/37] virDomainNetDefParseXML: Refactor parsing of data for VIR_DOMAIN_NET_TYPE_HOSTDEV

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 44 -- 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cc28bc9684..3850684707 100644 --- a/src/conf/domain_conf.c +++

[PATCH 26/37] virDomainNetDefParseXML: Refactor parsing of data for VIR_DOMAIN_NET_TYPE_VDPA

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b41e1644a5..c14f3f2910 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9188,9

[PATCH 25/37] virDomainNetDefParseXML: Refactor parsing of data for VIR_DOMAIN_NET_TYPE_VHOSTUSER

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 130 + 1 file changed, 68 insertions(+), 62 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index dde34404f1..b41e1644a5 100644 --- a/src/conf/domain_conf.c +++

[PATCH 24/37] conf: domain: Move 'virDomainChrSourceReconnectDefParseXML'

Move the function in place of its forward declaration. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 48 ++ 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[PATCH 21/37] conf: domain: Convert 'mode' field of the 'direct' type of virDomainNetDef to proper type

Use 'virNetDevMacVLanMode'. Signed-off-by: Peter Krempa --- src/conf/domain_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 3d13c7a3de..8fecf0566c 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@

[PATCH 22/37] virDomainNetDefParseXML: Refactor parsing of data for VIR_DOMAIN_NET_TYPE_DIRECT

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 40 +--- 1 file changed, 13 insertions(+), 27 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 431fd7a255..77d3ef564e 100644 --- a/src/conf/domain_conf.c +++

[PATCH 20/37] virDomainNetDefParseXML: Refactor parsing of data for VIR_DOMAIN_NET_TYPE_BRIDGE

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0c97be1766..431fd7a255 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8990,7

[PATCH 17/37] util: xml: Introduce virXMLPropLongLong

Add a helper for parsing long long values from XML properties with semantics like virXMLPropInt. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 64 src/util/virxml.h| 9 ++ 3 files changed, 74

[PATCH 11/37] virDomainNetIPInfoParseXML: Don't force callers to set proper 'ctxt->node'

In certain cases it's inconvenient to move the XPAth's context current node in the caller. Add a 'node' argument and override it inside the function. VIR_XPATH_NODE_AUTORESTORE handles the cleanup. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 15 --- 1 file changed, 8

[PATCH 14/37] util: xml: Introduce virXMLPropStringRequired

Similarly to virXMLPropString it extracts a string but reports an errori similar to the newer virXMLProp helpers if the attribute is not present. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virxml.c| 27 +++ src/util/virxml.h

[PATCH 13/37] util: xml: Adjust documentation of virXMLPropString

All callers treat NULL as if the string is not present in the XML. Adjust the description so that it's implied that it's not an error and thus also no error reporting is expected. Signed-off-by: Peter Krempa --- src/util/virxml.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 10/37] virDomainNetIPInfoParseXML: Simplify cleanup

Do the XPath fetches first as they don't require cleanup and rename 'cleanup' to 'error' and take it only on failure. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/conf/domain_conf.c

[PATCH 05/37] virDomainNetDefParseXML: Separate and localize parsing of 'backend/@vhost'

Move it into an independent block and move temporary variables locally. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 390263d806..0e25d585c8 100644

[PATCH 07/37] virDomainNetDefParseXML: Use virXMLPropEnumDefault for parsing 'def->type'

Replace ad-hoc logic that fills the default by use of the proper helper function. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 621b1df6c8..745a7e428c 100644

[PATCH 08/37] virDomainNetIPInfoParseXML: Remove pointless automatic clearing of 'route' and 'ip'

The variables are only used in code paths which can't fail after they are allocated. Additionally decrease scope of the variables. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c

[PATCH 06/37] virDomainNetDefParseXML: Split out parsing of 'driver' subelement

Separate the code into virDomainNetDefParseXMLDriver. Some local variables were renamed and the scope decreased. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 238 ++--- 1 file changed, 126 insertions(+), 112 deletions(-) diff --git

[PATCH 03/37] conf: domain: Remove 'error' label in virDomainNetDefParseXML

The 'error' label was an alias to 'return NULL;'. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 155 - 1 file changed, 76 insertions(+), 79 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7f5efa205c..a544ab6ce4

[PATCH 04/37] virDomainNetDefParseXML: Remove unnecessary temporary variables

Some values were extracted into a temporary variable and then assigned to the definition later without a modification. Directly assign them instead. One slight modification was done to 'ifname' which was cleared in certain cases. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 45

[PATCH 02/37] conf: domain: Automatically free 'def' and 'actual' in virDomainNetDefParseXML

Convert the last two variables having inline cleanup to automatic cleanup. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 406c348a00..7f5efa205c 100644

[PATCH 01/37] conf: domain: Register automatic pointer freeing for virDomainActualNetDef

Signed-off-by: Peter Krempa --- src/conf/domain_conf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 42fa2a4400..3d13c7a3de 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3416,6 +3416,7 @@ bool

[PATCH 00/37] conf: Refactor virDomainNetDefParseXML

After the partial refactor in fdd06824e3a618ca33752e0439bbd5b2d9da1b0d the function was left in a halfway state between the old parser style and new one. Try to improve it a bit, although the result is still not ideal. Peter Krempa (37): conf: domain: Register automatic pointer freeing for

[PATCH] virdomainjob: virDomainObjInitJob: Store a copy of virDomainObjPrivateJobCallbacks

'virDomainObjPrivateJobCallbacks' is passed into the job object by copying a pointer from the 'virDomainXMLOption' struct passed in from the caller. Unfortunately the 'virdomainjob' module can't control the lifetime of the virDomainXMLOption, which in some cases is freed before the domain job

[PATCH v2] meson: Require libssh-0.8.1 or newer

According to repology.org: RHEL-8: 0.9.4 RHEL-9: 0.9.6 Debian 11: 0.9.5 openSUSE Leap 15.3: 0.8.7 Ubuntu 20.04: 0.9.3 And the rest of distros has something newer anyways. Requiring 0.8.1 or newer allows us to drop the terrible hack where we rename

Re: [PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

On Mon, Sep 19, 2022 at 09:28:28 +0200, Peter Krempa wrote: > On Mon, Sep 19, 2022 at 09:24:47 +0200, Peter Krempa wrote: > > On Fri, Sep 16, 2022 at 13:30:07 +0100, Daniel P. Berrangé wrote: > > > On Mon, Sep 05, 2022 at 03:57:03PM +0200, Kristina Hanicova wrote: > > [...] > > > A proper fix

Re: [PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

On Mon, Sep 19, 2022 at 09:24:47 +0200, Peter Krempa wrote: > On Fri, Sep 16, 2022 at 13:30:07 +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 05, 2022 at 03:57:03PM +0200, Kristina Hanicova wrote: [...] > A proper fix will be to not rely on stolen pointers though as doing this > is too fragile

Re: [PATCH v2 05/17] conf: extend xmlopt with job config & add job object into domain object

On Fri, Sep 16, 2022 at 13:30:07 +0100, Daniel P. Berrangé wrote: > On Mon, Sep 05, 2022 at 03:57:03PM +0200, Kristina Hanicova wrote: > > This patch adds the generalized job object into the domain object > > so that it can be used by all drivers without the need to extract > > it from the private