Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-09-30 Thread Peng Liang
On 09/29/2022 21:31, Michal Prívozník wrote: On 9/27/22 17:38, Jiang Jiacheng wrote: From: jiangjiacheng In virNetServerProgramDispatchCall, The arg is passed as a void* and used to point to a certain struct depended on the dispatcher, so I think it's the memory of the struct's member

Re: [PATCH] virt-aa-helper: allow common riscv64 loader paths

2022-09-30 Thread Jim Fehlig
On 9/29/22 23:43, Christian Ehrhardt wrote: On Thu, Sep 29, 2022 at 11:30 PM Jim Fehlig wrote: On 9/28/22 06:45, christian.ehrha...@canonical.com wrote: From: Christian Ehrhardt Riscv64 usually uses u-boot as external -kernel and a loader from the open implementation of RISC-V SBI. The

[libvirt PATCH 6/6] qemu: retire QEMU_CAPS_CCW

2022-09-30 Thread Ján Tomko
Now that we no longer use the capability, stop probing for existence of 'virtual-css-bridge' and its properties. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 9 +-- src/qemu/qemu_capabilities.h | 2 +- .../caps_4.2.0.s390x.replies

[libvirt PATCH 4/6] qemu: Assume QEMU_CAPS_CCW

2022-09-30 Thread Ján Tomko
Introduced in libvirt by: commit f245a9791c23ba08858f7cf7b16b1c449967ab35 qemu: introduce capability for virtual-css-bridge Which mentions that its support was in QEMU 2.7. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 7 --- src/qemu/qemu_domain_address.c

[libvirt PATCH 2/6] qemu: convert some s390x tests to use real capability data

2022-09-30 Thread Ján Tomko
Signed-off-by: Ján Tomko --- ... => balloon-ccw-deflate.s390x-latest.args} | 7 +++-- ...s => console-virtio-ccw.s390x-latest.args} | 9 --- ...ev-subsys-mdev-vfio-ccw.s390x-latest.args} | 7 +++-- ...fio-zpci-ccw-memballoon.s390x-latest.args} | 7 +++--

[libvirt PATCH 1/6] tests: qemuxml2argvdata: switch zpci address generation to real caps

2022-09-30 Thread Ján Tomko
Among the usual changes, this puts the virtio memballoon on the CCW bus. Signed-off-by: Ján Tomko --- ...-zpci-autogenerate-fids.s390x-latest.args} | 10 + ...-zpci-autogenerate-uids.s390x-latest.args} | 10 + ...-vfio-zpci-autogenerate.s390x-latest.args} | 10 +

[libvirt PATCH 5/6] qemu: retire QEMU_CAPS_CCW_CSSID_UNRESTRICTED

2022-09-30 Thread Ján Tomko
Now that it is no longer used, stop probing for it. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c| 3 +-- src/qemu/qemu_capabilities.h| 2 +- tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 -

[libvirt PATCH 0/6] qemu: s390x: retire some CCW capabilites

2022-09-30 Thread Ján Tomko
Now that we bumped the minimum QEMU version to 4.2.0, we can stop probing some capabilities. Ján Tomko (6): tests: qemuxml2argvdata: switch zpci address generation to real caps qemu: convert some s390x tests to use real capability data qemu: Assume QEMU_CAPS_CCW_CSSID_UNRESTRICTED qemu:

[libvirt PATCH 3/6] qemu: Assume QEMU_CAPS_CCW_CSSID_UNRESTRICTED

2022-09-30 Thread Ján Tomko
This capability was introduced by libvirt commit: commit 263e65fd204a27713db89064796c1d386bb541d8 qemu: introduce vfio-ccw capability It probes for the cssid-unrestricted property of virtual-css-bridge, which was introduced in QEMU v2.12 by: commit

[PATCH v2] docs: add firmware feature flags

2022-09-30 Thread Gerd Hoffmann
Add new firmware feature flags for the recently added confidential computing operating modes by amd and intel. While being at it also fix the path to the amd sev documentation. Signed-off-by: Gerd Hoffmann Reviewed-by: Kashyap Chamarthy --- docs/interop/firmware.json | 21

Re: [PATCH] virgdbusmock: Mock g_dbus_connection_call_with_unix_fd_list_sync() only on UNIX-like systems

2022-09-30 Thread Ján Tomko
On a Thursday in 2022, Michal Privoznik wrote: The g_dbus_connection_call_with_unix_fd_list_sync() function is not defined always, only when G_OS_UNIX condition is set. This is As of GLib commit c9874f817be51d3b652457daef3b10766b59db9a, relesed in GLib 2.73, the g_dbus_connection... also the

Re: [PATCH] virdomainjob: check if cb is not NULL before dereferencing

2022-09-30 Thread Ján Tomko
On a Friday in 2022, Kristina Hanicova wrote: The callback struct does not always have to be set which could cause a dereferencing of a NULL pointer. This patch adds check against NULL in missing places before dereferencing. Signed-off-by: Kristina Hanicova --- src/conf/virdomainjob.c | 4 ++--

[PATCH] virdomainjob: check if cb is not NULL before dereferencing

2022-09-30 Thread Kristina Hanicova
The callback struct does not always have to be set which could cause a dereferencing of a NULL pointer. This patch adds check against NULL in missing places before dereferencing. Signed-off-by: Kristina Hanicova --- src/conf/virdomainjob.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] NEWS: Document my contributions for upcoming release

2022-09-30 Thread Jiri Denemark
On Fri, Sep 30, 2022 at 12:53:09 +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 69c5b70c2f..81c95859ff 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@

[PATCH] NEWS: Document my contributions for upcoming release

2022-09-30 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- NEWS.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 69c5b70c2f..81c95859ff 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -25,6 +25,11 @@ v8.8.0 (unreleased) * **Improvements** + * qemu: Implement

Re: [PATCH] docs: add firmware feature flags

2022-09-30 Thread Kashyap Chamarthy
On Fri, Sep 30, 2022 at 11:18:33AM +0200, Gerd Hoffmann wrote: > Add new firmware feature flags for the recently added confidential > computing operating modes by amd and intel. > > Signed-off-by: Gerd Hoffmann > --- > docs/interop/firmware.json | 17 ++--- > 1 file changed, 14

[PATCH] docs: add firmware feature flags

2022-09-30 Thread Gerd Hoffmann
Add new firmware feature flags for the recently added confidential computing operating modes by amd and intel. Signed-off-by: Gerd Hoffmann --- docs/interop/firmware.json | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/docs/interop/firmware.json

libvirt-8.8.0 release candidate 2

2022-09-30 Thread Jiri Denemark
I have just tagged v8.8.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

Re: [PATCH] docs: compiling: Add link to latest openSUSE libvirt package

2022-09-30 Thread Ján Tomko
On a Thursday in 2022, Jim Fehlig wrote: This is a follow-up to fbd6b2480a, adding a link to the latest libvirt package for openSUSE. Signed-off-by: Jim Fehlig --- docs/compiling.rst | 4 1 file changed, 4 insertions(+) Reviewed-by: Ján Tomko Jano

Re: questions regarding modular daemons

2022-09-30 Thread Daniel P . Berrangé
On Thu, Sep 29, 2022 at 04:22:50PM -0600, Jim Fehlig wrote: > Hi All, > > I've procrastinated long enough and finally decided to switch to modular > daemons in openSUSE Factory libvirt package. For the most part, the Factory > spec file mimics the upstream one. I enabled with_modular_daemons and

Re: [PATCH] qemuNamespaceMknodOne: Call g_file_read_link() in async-signal-safe fashion

2022-09-30 Thread Jiri Denemark
On Fri, Sep 30, 2022 at 08:51:21 +0200, Michal Privoznik wrote: > When creating a node in QEMU's namespace the whole link chain is > created with it. Here, we use g_file_read_link() from the child > (running inside the namespace) to learn whether a link exists and > points to expected target. Now,

[PATCH v3] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-09-30 Thread Jiang Jiacheng
From: jiangjiacheng In virNetServerProgramDispatchCall, The arg is passed as a void* and used to point to a certain struct depended on the dispatcher, so I think it's the memory of the struct's member that leaks and this memory shuld be freed by xdr_free. In virNetServerClientNew, client->rx

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-09-30 Thread Michal Prívozník
On 9/30/22 04:32, Jiang Jiacheng wrote: > I see, maybe we could free dispatcher->arg_filter and > dispatcher->ret_filter together in error label like this: > error: > if (dispatcher) { > xdr_free(dispatcher->arg_filter, arg); > xdr_free(dispatcher->ret_filter, ret); > } >

[PATCH] qemuNamespaceMknodOne: Call g_file_read_link() in async-signal-safe fashion

2022-09-30 Thread Michal Privoznik
When creating a node in QEMU's namespace the whole link chain is created with it. Here, we use g_file_read_link() from the child (running inside the namespace) to learn whether a link exists and points to expected target. Now, when building the namespace there can't be any symlinks and this