Re: [PATCH 2/2] qemu: tpm: Remove TPM state after successful migration

2022-10-03 Thread Stefan Berger
On 10/3/22 11:20, Michal Prívozník wrote: On 8/23/22 18:28, Stefan Berger wrote: This patch 'fixes' the behavior of the persistent_state TPM domain XML attribute that intends to preserve the state of the TPM but should not keep the state around on all the hosts a VM has been migrated to. It

Re: [PATCH 1/2] qemu: Add UNDEFINE_TPM and UNDEFINE_KEEP_TPM flags

2022-10-03 Thread Stefan Berger
On 10/3/22 11:20, Michal Prívozník wrote: On 8/23/22 18:28, Stefan Berger wrote: Add UNDEFINE_TPM and UNDEFINE_KEEP_TPM flags to qemuDomainUndefineFlags() API and --tpm and --keep-tpm to 'virsh undefine'. Pass the virDomainUndefineFlagsValues via qemuDomainRemoveInactive() from

Re: [PATCH 1/2] qemu: Add UNDEFINE_TPM and UNDEFINE_KEEP_TPM flags

2022-10-03 Thread Michal Prívozník
On 8/23/22 18:28, Stefan Berger wrote: > Add UNDEFINE_TPM and UNDEFINE_KEEP_TPM flags to qemuDomainUndefineFlags() > API and --tpm and --keep-tpm to 'virsh undefine'. Pass the > virDomainUndefineFlagsValues via qemuDomainRemoveInactive() > from qemuDomainUndefineFlags() all the way down to >

Re: [PATCH 2/2] qemu: tpm: Remove TPM state after successful migration

2022-10-03 Thread Michal Prívozník
On 8/23/22 18:28, Stefan Berger wrote: > This patch 'fixes' the behavior of the persistent_state TPM domain XML > attribute that intends to preserve the state of the TPM but should not > keep the state around on all the hosts a VM has been migrated to. It > removes the TPM state directory

Re: [PATCH 0/2] qemu: tpm: Improve TPM state files management

2022-10-03 Thread Michal Prívozník
On 8/23/22 18:28, Stefan Berger wrote: > This series of patches adds the --keep-tpm and --tpm flags to virsh for > keeping and removing the TPM state directory structure when a VM is > undefined. It also fixes the removal of state when a VM is migrated so > that the state files are removed on the

Re: [PATCH v3] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-10-03 Thread Michal Prívozník
On 9/30/22 09:02, Jiang Jiacheng wrote: > From: jiangjiacheng > > In virNetServerProgramDispatchCall, The arg is passed as a void* and used to > point > to a certain struct depended on the dispatcher, so I think it's the memory of > the > struct's member that leaks and this memory shuld be

Re: [libvirt PATCH 0/6] qemu: s390x: retire some CCW capabilites

2022-10-03 Thread Michal Prívozník
On 9/30/22 16:38, Ján Tomko wrote: > Now that we bumped the minimum QEMU version to 4.2.0, we can stop > probing some capabilities. > > Ján Tomko (6): > tests: qemuxml2argvdata: switch zpci address generation to real caps > qemu: convert some s390x tests to use real capability data > qemu:

Re: [PATCH 0/2] util: xml: Clean up other instances of problems pointed out in review

2022-10-03 Thread Ján Tomko
On a Monday in 2022, Peter Krempa wrote: In review of my series which was adding new XML Property fetching helpers I was asked to change few things which were also present in other instances in existing code. Fix those too. Peter Krempa (2): util: xml: Fix declararation of 'const char *'

[PATCH 2/2] util: xml: Use common formatting of 'Bitwise-OR' in function param description

2022-10-03 Thread Peter Krempa
Our public API docs use the hyphenated version with capital OR. Fix the virXMLProp* helpers to use the same syntax. Signed-off-by: Peter Krempa --- src/util/virxml.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index

[PATCH 0/2] util: xml: Clean up other instances of problems pointed out in review

2022-10-03 Thread Peter Krempa
In review of my series which was adding new XML Property fetching helpers I was asked to change few things which were also present in other instances in existing code. Fix those too. Peter Krempa (2): util: xml: Fix declararation of 'const char *' parameters in virXMLProp* helpers util:

[PATCH 1/2] util: xml: Fix declararation of 'const char *' parameters in virXMLProp* helpers

2022-10-03 Thread Peter Krempa
We commonly use 'const char *name' instead of 'const char* name'. Signed-off-by: Peter Krempa --- src/util/virxml.c | 20 ++-- src/util/virxml.h | 12 ++-- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index

Release of libvirt-8.8.0

2022-10-03 Thread Jiri Denemark
The 8.8.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing

Re: [PATCH v2] rpc: fix memory leak in virNetServerClientNew and virNetServerProgramDispatchCall

2022-10-03 Thread Michal Prívozník
On 10/1/22 05:35, Peng Liang wrote: > > > On 09/29/2022 21:31, Michal Prívozník wrote: >> On 9/27/22 17:38, Jiang Jiacheng wrote: >>> From: jiangjiacheng >>> >>> In virNetServerProgramDispatchCall, The arg is passed as a void* and >>> used to point >>> to a certain struct depended on the