Re: [PATCH RFC v2 00/13] IOMMUFD Generic interface

On 10/6/2022 12:01 PM, Jason Gunthorpe wrote: > On Wed, Sep 21, 2022 at 08:09:54PM -0300, Jason Gunthorpe wrote: >> On Wed, Sep 21, 2022 at 03:30:55PM -0400, Steven Sistare wrote: >> If Steve wants to keep it then someone needs to fix the deadlock in the vfio implementation before any

[libvirt PATCH] conf: skip resource cache init if sysfs files are missing

On aarch64 the 'id' file is not present for CPU cache information in sysfs. This causes the local stateful hypervisor drivers to fail to initialize capabilities: virStateInitialize:657 : Initialisation of cloud-hypervisor state driver failed: no error The 'no error' is because the

Re: [PATCH] ci: Install python RPMs from libvirt/libvirt-python CI artifacts

On Mon, Oct 10, 2022 at 11:09:51 +0100, Daniel P. Berrangé wrote: > On Mon, Oct 10, 2022 at 11:46:43AM +0200, Peter Krempa wrote: > > After addition of the new libvirt-client-qemu sub-package which is using > > python bindings (thus creating a circular dependency between the libvirt > > and

[PATCH 0/3] fix some issue in concurrency scenarios

ping... Thanks. On 2022/9/28 21:53, Jiang Jiacheng wrote: > > Jiang Jiacheng (3): > qemu: Init address before qemuProcessShutdownOrReboot during reconnect > process > qemu: get the stackManager lock before getting nested lock > qemu: back up the path in qemuMonitorOpen > >

[PATCH] capabilities: use g_autofree in capabilities.c

Use g_autofree in capabilities.c for some pointers still using manual cleanup, and remove unnecessary cleanup. Signed-off-by: Jiang Jiacheng --- src/conf/capabilities.c | 44 + 1 file changed, 14 insertions(+), 30 deletions(-) diff --git

Re: [PATCH] qemu: Avoid memory leak in virQEMUCapsCPUDefsToModels

On Mon, Oct 10, 2022 at 15:39:35 +0200, Michal Privoznik wrote: > The @vendor variable inside virQEMUCapsCPUDefsToModels() is > allocated, but never freed. But there is actually no need for it > to be allocated, because it merely passes a retval of > virCPUGetVendorForModel() (which returns a

[PATCH] qemu: Avoid memory leak in virQEMUCapsCPUDefsToModels

The @vendor variable inside virQEMUCapsCPUDefsToModels() is allocated, but never freed. But there is actually no need for it to be allocated, because it merely passes a retval of virCPUGetVendorForModel() (which returns a const string) to virDomainCapsCPUModelsAdd() (which ten accepts the argument

Re: [PATCH 0/5] meson: Bump minimal required version

On a Friday in 2022, Michal Privoznik wrote: *** BLURB HERE *** Michal Prívozník (5): meson: Replace meson.build_root() with meson.project_build_root() meson: Replace meson.source_root() with meson.project_source_root() meson: Replace external_program.path() with

Re: [PATCH 3/5] meson: Replace external_program.path() with external_program.full_path()

On a Friday in 2022, Michal Privoznik wrote: The path() method is deprecated in 0.55.0 and we're recommended to use full_path() instead. Interestingly, we were already doing do in couple of place, but not all of them. *places Jano Signed-off-by: Michal Privoznik --- build-aux/meson.build

Re: [libvirt PATCH v2 12/14] virsh: Add --model option for hypervisor-cpu-baseline

On a Friday in 2022, Jiri Denemark wrote: This option can be used as a shortcut for creating a single XML with just a CPU model name and no features: $ virsh hypervisor-cpu-baseline --model Skylake-Server Skylake-Server Signed-off-by:

Re: [libvirt PATCH v2 09/14] docs: Enhance documentation of CPU models in domain caps

On a Friday in 2022, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 2: - new patch docs/formatdomaincaps.rst | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt PATCH v2 14/14] NEWS: Document CPU reporting improvements

On a Friday in 2022, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 2: - patch 10/11 from v1 and the corresponding section in NEWS dropped - mention --model for virsh hypervisor-cpu-baseline - mention CPU blockers translation bug - mention docs improvements

Re: [libvirt PATCH v2 13/14] virsh: Add completer for hypervisor-cpu-baseline --model

On a Friday in 2022, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Notes: Version 2: - new patch tools/virsh-completer-host.c | 50 tools/virsh-completer-host.h | 5 tools/virsh-host.c | 1 + 3 files changed, 56 insertions(+)

Re: [libvirt PATCH v2 11/14] qemu_capabilities: Translate CPU blockers

On a Friday in 2022, Jiri Denemark wrote: Since commit "cpu_x86: Disable blockers from unusable CPU models" (v3.8.0-99-g9c9620af1d) we explicitly disable CPU features reported by QEMU as usability blockers for a particular CPU model when creating baseline or host-model CPU definition. When QEMU

Re: [libvirt PATCH v2 10/14] Document specifics of virConnectBaselineHypervisorCPU

On a Friday in 2022, Jiri Denemark wrote: The API can be used to get usability blockers for an unusable CPU model, which is not obvious. Let's explicitly document this behavior as it is now mentioned in the documentation of domain capabilities XML. Signed-off-by: Jiri Denemark --- Notes:

Re: [PATCH] ci: Install python RPMs from libvirt/libvirt-python CI artifacts

On Mon, Oct 10, 2022 at 11:46:43AM +0200, Peter Krempa wrote: > After addition of the new libvirt-client-qemu sub-package which is using > python bindings (thus creating a circular dependency between the libvirt > and libvirt-python projects) the integration jobs fail with: > > Error: >

[PATCH] ci: Install python RPMs from libvirt/libvirt-python CI artifacts

After addition of the new libvirt-client-qemu sub-package which is using python bindings (thus creating a circular dependency between the libvirt and libvirt-python projects) the integration jobs fail with: Error: Problem: conflicting requests - nothing provides python3-libvirt >=