Re: [PATCH RFC v2 00/13] IOMMUFD Generic interface

2022-10-11 Thread Steven Sistare
On 10/11/2022 8:30 AM, Jason Gunthorpe wrote: > On Mon, Oct 10, 2022 at 04:54:50PM -0400, Steven Sistare wrote: >>> Do we have a solution to this? >>> >>> If not I would like to make a patch removing VFIO_DMA_UNMAP_FLAG_VADDR >>> >>> Aside from the approach to use the FD, another idea is to just

[PATCH] spec: change gettext requires to gettext-runtime for F37

2022-10-11 Thread Cole Robinson
From: Jens Petersen See https://fedoraproject.org/wiki/Changes/GettextRuntimeSubpackage Signed-off-by: Cole Robinson --- libvirt.spec.in | 4 1 file changed, 4 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5408aa3154..d946a8da48 100644 --- a/libvirt.spec.in +++

Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread manish.mishra
On 11/10/22 10:17 pm, Daniel P. Berrangé wrote: On Tue, Oct 11, 2022 at 10:11:29PM +0530, manish.mishra wrote: Thanks for review Jonathon, Daniel On 11/10/22 9:56 pm, Daniel P. Berrangé wrote: On Tue, Oct 11, 2022 at 11:20:00AM -0500, Jonathon Jongsma wrote: I believe that pidfd syscalls

Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread manish.mishra
Thanks for review Jonathon, Daniel On 11/10/22 9:56 pm, Daniel P. Berrangé wrote: On Tue, Oct 11, 2022 at 11:20:00AM -0500, Jonathon Jongsma wrote: I believe that pidfd syscalls were introduced in kernel 5.2. Judging by our CI build setup, the oldest distrubution that we support is Alma Linux

Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread Daniel P . Berrangé
On Tue, Oct 11, 2022 at 10:11:29PM +0530, manish.mishra wrote: > Thanks for review Jonathon, Daniel > > On 11/10/22 9:56 pm, Daniel P. Berrangé wrote: > > On Tue, Oct 11, 2022 at 11:20:00AM -0500, Jonathon Jongsma wrote: > > > I believe that pidfd syscalls were introduced in kernel 5.2. Judging

Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread Daniel P . Berrangé
On Tue, Oct 11, 2022 at 11:20:00AM -0500, Jonathon Jongsma wrote: > I believe that pidfd syscalls were introduced in kernel 5.2. Judging by our > CI build setup, the oldest distrubution that we support is Alma Linux 8, > which still has kernel version 4.18. We need to support FreeBSD / macOS for

Re: [RFC 0/1] Check for pid re-use before killing domain process

2022-10-11 Thread Jonathon Jongsma
I believe that pidfd syscalls were introduced in kernel 5.2. Judging by our CI build setup, the oldest distrubution that we support is Alma Linux 8, which still has kernel version 4.18. On 10/6/22 4:33 AM, manish.mishra wrote: Libvirt stores pid of domain(e.g Qemu) process when a domain

Re: [PATCH] capabilities: use g_autofree in capabilities.c

2022-10-11 Thread Jiang Jiacheng
Thanks for your review. So, it's may be better to don's use g_autofree if its content need to be freed manualy in cleanup? A similiar situation could be found in nwfilter_ebiptables_driver.c, function 'ebiptablesApplyNewRules' assigned subchains with g_autofree and freed its content using g_free

Re: [PATCH RFC v2 00/13] IOMMUFD Generic interface

2022-10-11 Thread Jason Gunthorpe
On Mon, Oct 10, 2022 at 04:54:50PM -0400, Steven Sistare wrote: > > Do we have a solution to this? > > > > If not I would like to make a patch removing VFIO_DMA_UNMAP_FLAG_VADDR > > > > Aside from the approach to use the FD, another idea is to just use > > fork. > > > > qemu would do something

Re: [libvirt PATCH v2 0/2] conf: fix handling of missing CPU cache info in sysfs

2022-10-11 Thread Ján Tomko
On a Tuesday in 2022, Daniel P. Berrangé wrote: Changed in v2: - Introduce g_autoptr support for virCapsHostCacheBank struct Daniel P. Berrangé (2): conf: define autoptr func for virCapsHostCacheBankFree conf: skip resource cache init if sysfs files are missing src/conf/capabilities.c | 90

Re: [libvirt PATCH v2 0/2] conf: fix handling of missing CPU cache info in sysfs

2022-10-11 Thread Alex Bennée
Daniel P. Berrangé writes: > Changed in v2: > > - Introduce g_autoptr support for virCapsHostCacheBank struct > > Daniel P. Berrangé (2): > conf: define autoptr func for virCapsHostCacheBankFree > conf: skip resource cache init if sysfs files are missing > > src/conf/capabilities.c | 90

Re: [libvirt RFC 11/24] qemu_snapshot: extract children snapshot deletion to separate function

2022-10-11 Thread Pavel Hrdina
On Thu, Sep 01, 2022 at 03:43:58PM +0200, Peter Krempa wrote: > On Tue, Aug 23, 2022 at 18:32:14 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/qemu/qemu_snapshot.c | 94 ++-- > > 1 file changed, 53 insertions(+), 41 deletions(-) >

Re: [libvirt RFC 10/24] qemu_snapshot: extract single snapshot deletion to separate function

2022-10-11 Thread Pavel Hrdina
On Thu, Sep 01, 2022 at 03:53:31PM +0200, Peter Krempa wrote: > On Tue, Aug 23, 2022 at 18:32:13 +0200, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/qemu/qemu_snapshot.c | 46 ++-- > > 1 file changed, 30 insertions(+), 16 deletions(-) >

[libvirt PATCH v2 2/2] conf: skip resource cache init if sysfs files are missing

2022-10-11 Thread Daniel P . Berrangé
On aarch64 the 'id' file is not present for CPU cache information in sysfs. This causes the local stateful hypervisor drivers to fail to initialize capabilities: virStateInitialize:657 : Initialisation of cloud-hypervisor state driver failed: no error The 'no error' is because the

[libvirt PATCH v2 1/2] conf: define autoptr func for virCapsHostCacheBankFree

2022-10-11 Thread Daniel P . Berrangé
This lets us simplify the cleanup paths when populating the host cache bank information in capabilities XML. Signed-off-by: Daniel P. Berrangé --- src/conf/capabilities.c | 34 ++ src/conf/capabilities.h | 3 +++ 2 files changed, 17 insertions(+), 20

[libvirt PATCH v2 0/2] conf: fix handling of missing CPU cache info in sysfs

2022-10-11 Thread Daniel P . Berrangé
Changed in v2: - Introduce g_autoptr support for virCapsHostCacheBank struct Daniel P. Berrangé (2): conf: define autoptr func for virCapsHostCacheBankFree conf: skip resource cache init if sysfs files are missing src/conf/capabilities.c | 90 +

Re: [PATCH] ci: potfiles: Add 'variables' to definition

2022-10-11 Thread Ján Tomko
On a Tuesday in 2022, Peter Krempa wrote: The 'potfiles' job is lacking the 'variables' section which defines the 'NAME' variable used by the 'image' property resulting in the 'potfiles' job failing with: Pulling docker image registry.gitlab.com/libvirt/libvirt/ci-:latest ... WARNING: Failed to

Re: [PATCH] ci: potfiles: Add 'variables' to definition

2022-10-11 Thread Peter Krempa
On Tue, Oct 11, 2022 at 09:38:17 +0200, Peter Krempa wrote: > The 'potfiles' job is lacking the 'variables' section which defines the > 'NAME' variable used by the 'image' property resulting in the 'potfiles' > job failing with: > > Pulling docker image

[PATCH] ci: potfiles: Add 'variables' to definition

2022-10-11 Thread Peter Krempa
The 'potfiles' job is lacking the 'variables' section which defines the 'NAME' variable used by the 'image' property resulting in the 'potfiles' job failing with: Pulling docker image registry.gitlab.com/libvirt/libvirt/ci-:latest ... WARNING: Failed to pull image with policy "always": invalid

Re: [PATCH] capabilities: use g_autofree in capabilities.c

2022-10-11 Thread Ján Tomko
On a Monday in 2022, Jiang Jiacheng wrote: Use g_autofree in capabilities.c for some pointers still using manual cleanup, and remove unnecessary cleanup. Signed-off-by: Jiang Jiacheng --- src/conf/capabilities.c | 44 + 1 file changed, 14 insertions(+),

Re: [libvirt PATCH] conf: skip resource cache init if sysfs files are missing

2022-10-11 Thread Ján Tomko
On a Monday in 2022, Daniel P. Berrangé wrote: On aarch64 the 'id' file is not present for CPU cache information in sysfs. This causes the local stateful hypervisor drivers to fail to initialize capabilities: virStateInitialize:657 : Initialisation of cloud-hypervisor state driver failed: no

Re: [libvirt PATCH] conf: skip resource cache init if sysfs files are missing

2022-10-11 Thread Alex Bennée
Daniel P. Berrangé writes: > On aarch64 the 'id' file is not present for CPU cache information in > sysfs. This causes the local stateful hypervisor drivers to fail to > initialize capabilities: > > virStateInitialize:657 : Initialisation of cloud-hypervisor state driver > failed: no error >