On 10/19/22 6:17 AM, Daniel P. Berrangé wrote:
> It is possible to build OVMF for SEV with an embedded Grub that can
> fetch LUKS disk secrets. This adds support for injecting secrets in
> the required format.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> diff --git a/tools/virt-qemu-sev-validat
On 10/17/22 3:42 AM, Michal Prívozník wrote:
> On 10/16/22 22:06, Cole Robinson wrote:
>> The value returned by qemu's query-sev-launch-measure comes
>> straight from the LAUNCH_MEASURE SEV firmware command. It's two
>> values packed together: first 32 bytes is the launch measurement,
>> last 16 by
On 10/19/22 6:17 AM, Daniel P. Berrangé wrote:
> The libvirt QEMU driver provides all the functionality required for
> launching a guest on AMD SEV(-ES) platforms, with a configuration
> that enables attestation of the launch measurement. The documentation
> for how to actually perform an attestati
On Tue, Oct 25, 2022 at 02:49:35PM +0200, Pavel Hrdina
wrote:
> Exactly, there is the same ordering issue, if cgroup v2 backend is
> enabled it is the only one used for cpuacct and devices within libvirt
> code.
Aha, I see what's the issue with the approach now.
> > BTW do you have any pointers
On 10/25/22 10:15 AM, Michal Privoznik wrote:
My aim is to move virNodeDeviceDriver declaration into
node_device_driver.c, eventually. BUT that's going to be more patches
and as I continue my work on that I've noticed couple of almost trivial
patches that can be merged regardless. Even during fre
Currently, udevNodeRegister() is forward declared in
node_device_driver.h even though the function is implemented in
node_device_udev.c which warrants node_device_udev.h header file.
Move the declaration into the correct file.
Signed-off-by: Michal Privoznik
---
src/node_device/node_device_drive
The DMI_DEVPATH macro is used exclusively within
node_device_udev.c. There's no need to expose it.
Signed-off-by: Michal Privoznik
---
src/node_device/node_device_udev.c | 2 ++
src/node_device/node_device_udev.h | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/node_dev
The node_device_driver.h declares nodeDeviceLock() and
nodeDeviceUnlock() functions which used to exist, but after
rework to automatic mutex management they exist no more. Their
last use was removed in v8.1.0-rc1~122.
Signed-off-by: Michal Privoznik
---
src/node_device/node_device_driver.h | 6 -
The SYSFS_DATA_SIZE macro is Unused since its introduction in
v0.7.3~48. Sorry Dave.
Signed-off-by: Michal Privoznik
---
src/node_device/node_device_udev.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/node_device/node_device_udev.h
b/src/node_device/node_device_udev.h
index eab22a9182
Nothing in the header file requires the include of libudev.h, as
the former header file is now empty.
Signed-off-by: Michal Privoznik
---
src/node_device/node_device_udev.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/node_device/node_device_udev.h
b/src/node_device/node_device_udev
My aim is to move virNodeDeviceDriver declaration into
node_device_driver.c, eventually. BUT that's going to be more patches
and as I continue my work on that I've noticed couple of almost trivial
patches that can be merged regardless. Even during freeze ;-)
Michal Prívozník (5):
node_device_ude
On Wed, Sep 07, 2022 at 03:06:51PM +0200, Peter Krempa wrote:
> On Tue, Aug 23, 2022 at 18:32:25 +0200, Pavel Hrdina wrote:
> > With external snapshots we need to modify the metadata bit more then
> > what is required for internal snapshots. Mainly the storage source
> > location changes with every
On Tue, Oct 25, 2022 at 02:31:21PM +0200, Michal Koutný wrote:
> Hello.
>
> On Tue, Oct 25, 2022 at 11:33:56AM +0200, Pavel Hrdina
> wrote:
> > Unfortunately this breaks a lot of things and we cannot use it even as
> > workaround. Libvirt code has few assumptions as that's how unified mode
> > w
On Tue, Oct 25, 2022 at 02:35:00PM +0200, Pavel Hrdina wrote:
> On Tue, Oct 25, 2022 at 01:13:44PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Oct 25, 2022 at 01:46:22PM +0200, Michal Prívozník wrote:
> > > On 10/25/22 13:43, Pavel Hrdina wrote:
> > > > This reverts commit e49313b54ed2a149c71f9073
On Tue, Oct 25, 2022 at 01:13:44PM +0100, Daniel P. Berrangé wrote:
> On Tue, Oct 25, 2022 at 01:46:22PM +0200, Michal Prívozník wrote:
> > On 10/25/22 13:43, Pavel Hrdina wrote:
> > > This reverts commit e49313b54ed2a149c71f9073659222742ff3ffb0.
> > > This reverts commit a0f37232b9c4296ca16955cc62
Hello.
On Tue, Oct 25, 2022 at 11:33:56AM +0200, Pavel Hrdina
wrote:
> Unfortunately this breaks a lot of things and we cannot use it even as
> workaround. Libvirt code has few assumptions as that's how unified mode
> works and when the cgroups v2 backend is enabled for hybrid topology we
> assu
On Tue, Oct 25, 2022 at 01:46:22PM +0200, Michal Prívozník wrote:
> On 10/25/22 13:43, Pavel Hrdina wrote:
> > This reverts commit e49313b54ed2a149c71f9073659222742ff3ffb0.
> > This reverts commit a0f37232b9c4296ca16955cc625f75eb848ace39.
> >
> > Revert them together to not break build.
> >
> > T
On 10/25/22 13:43, Pavel Hrdina wrote:
> This reverts commit e49313b54ed2a149c71f9073659222742ff3ffb0.
> This reverts commit a0f37232b9c4296ca16955cc625f75eb848ace39.
>
> Revert them together to not break build.
>
> This fix of the issue is incorrect and breaks usage of other controllers
> in hyb
This reverts commit e49313b54ed2a149c71f9073659222742ff3ffb0.
This reverts commit a0f37232b9c4296ca16955cc625f75eb848ace39.
Revert them together to not break build.
This fix of the issue is incorrect and breaks usage of other controllers
in hybrid mode that systemd creates, specifically usage of
I have just tagged v8.9.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
On Tue, Oct 25, 2022 at 11:40:42 +0200, Pavel Hrdina wrote:
> This reverts commit e49313b54ed2a149c71f9073659222742ff3ffb0.
>
> We are going to revert commit a0f37232b9c4296ca16955cc625f75eb848ace39
> as well so we need to revert this fix of that commit first.
>
> Signed-off-by: Pavel Hrdina
> -
This reverts commit a0f37232b9c4296ca16955cc625f75eb848ace39.
This fix of the issue is incorrect and breaks usage of other controllers
in hybrid mode that systemd creates, specifically usage of devices and
cpuacct controllers as they are now assumed to be part of the cgroup v2
topology which is no
This reverts commit e49313b54ed2a149c71f9073659222742ff3ffb0.
We are going to revert commit a0f37232b9c4296ca16955cc625f75eb848ace39
as well so we need to revert this fix of that commit first.
Signed-off-by: Pavel Hrdina
---
src/util/vircgroupv2.c | 3 +++
1 file changed, 3 insertions(+)
diff
Pavel Hrdina (2):
Revert "vircgroup: Remove unused variables in virCgroupV2Available"
Revert "cgroup/LXC: Do not condition availability of v2 by
controllers"
src/util/vircgroup.c | 6 ++
src/util/vircgroupv2.c | 15 +++
2 files changed, 17 insertions(+), 4 deletions(-)
On Mon, Oct 24, 2022 at 05:52:04PM +0200, Michal Koutný wrote:
> Hello.
>
> (Sorry for a stitched mail below, I'm not subscribed to the ML so this is
> what I got from public archives. Please, keep me Cced.)
>
> On 10/24/22 13:54, Pavel Hrdina wrote:
> > I don't like this at all and IMO this is i
On 10/23/22 18:57, Christopher Pereira wrote:
> Hi,
>
> We have a libvirt-qemu hook script that intercepts the "started" event
> and configures the virtual network interface (we set a private IP,
> remove the interface from the virtual bridge and set some custom iptable
> rules).
>
> After upgrad
On 10/25/22 01:07, jcfara...@gmail.com wrote:
> From: Julio Faracco
>
> The function nodedevRegister() (or all register functions) requires an
> integer as a return. That function is not returning a value when UDEV is
> not set. This commit just adds a generic return for that specific case.
>
>
27 matches
Mail list logo
