[libvirt] conf: Allow > UINT_MAX of cache for NUMA nodes

The high-bandwidth memory (HBM) in cache mode might be greater than UINT_MAX of cache per NUMA node, so change to unsigned long long. Signed-off-by: Lin Yang --- src/conf/capabilities.c | 70 +++-- src/conf/numa_conf.c| 2 +- src/conf/numa_conf.h| 2

Re: [libvirt PATCH] apparmor: Allow running /usr/libexec/qemu-kvm

On Thu, Nov 03, 2022 at 05:23:27PM +, Daniel P. Berrangé wrote: > On Thu, Nov 03, 2022 at 12:35:15PM -0400, Andrea Bolognani wrote: > > On Thu, Nov 03, 2022 at 03:39:44PM +0100, Peter Krempa wrote: > > > On Thu, Nov 03, 2022 at 12:13:53 +0100, Andrea Bolognani wrote: > > > > Distros that use

[libvirt PATCH v5 5/6] qemu: Add capability for virtio-gpu.blob

Capability to determine whether this qemu supports the 'blob' option for virtio-gpu. Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 +

[libvirt PATCH v5 2/6] conf: switch to virXMLProp* functions for parsing video

In virDomainVideoModelDefParseXML(), use the virXMLProp* functions rather than reimplementing them with virXPath* functions. Signed-off-by: Jonathon Jongsma --- src/conf/domain_conf.c | 78 +- 1 file changed, 23 insertions(+), 55 deletions(-) diff --git

[libvirt PATCH v5 6/6] qemu: Implement 'blob' support for virtio gpu

This can improve performance for some guests since it reduces copying of display data between host and guest. Requires udmabuf on the host. Signed-off-by: Jonathon Jongsma --- src/qemu/qemu_cgroup.c| 22 ++--- src/qemu/qemu_command.c | 3 ++

[libvirt PATCH v5 3/6] conf: use enum variable for video type

Rather than storing the video type as an integer, use the proper enum type within the struct. Signed-off-by: Jonathon Jongsma --- src/conf/domain_conf.c | 4 +--- src/conf/domain_conf.h | 2 +- src/libxl/libxl_conf.c | 10 ++ src/libxl/libxl_domain.c | 11

[libvirt PATCH v5 0/6] Add support for 'blob' to virtio video device

Add support to libvirt for the 'blob' option for virtio video devices in qemu. Also do a little preparatory refactoring of the video device xml parsing code. I sent this series out a couple times but didn't get much review. Trying again after rebasing. changes in v5: - rebased to latest master

[libvirt PATCH v5 4/6] conf: add support for 'blob' in virtio video device

Add the ability to enable blob resources for the virtio video device. This will accelerate the display path due to less or no copying of pixel data. Blob resource support can be enabled with e.g.: Some additional background information about blob resources:

[libvirt PATCH v5 1/6] conf: Refactor video model parsing

Factor out a separate function to parse out the element for video devices. Signed-off-by: Jonathon Jongsma --- src/conf/domain_conf.c | 95 ++ 1 file changed, 59 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

Re: [libvirt PATCH] apparmor: Allow running /usr/libexec/qemu-kvm

On Fri, Nov 04, 2022 at 10:21:53AM -0600, Jim Fehlig wrote: > On 11/3/22 11:23, Daniel P. Berrangé wrote: > > On Thu, Nov 03, 2022 at 12:35:15PM -0400, Andrea Bolognani wrote: > > > On Thu, Nov 03, 2022 at 03:39:44PM +0100, Peter Krempa wrote: > > > > On Thu, Nov 03, 2022 at 12:13:53 +0100, Andrea

Re: [libvirt PATCH] apparmor: Allow running /usr/libexec/qemu-kvm

On 11/3/22 11:23, Daniel P. Berrangé wrote: On Thu, Nov 03, 2022 at 12:35:15PM -0400, Andrea Bolognani wrote: On Thu, Nov 03, 2022 at 03:39:44PM +0100, Peter Krempa wrote: On Thu, Nov 03, 2022 at 12:13:53 +0100, Andrea Bolognani wrote: Distros that use AppArmor, such as Debian and Ubuntu,

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On Fri, Nov 04, 2022 at 11:51:47AM -0400, Laine Stump wrote: > You really should avoid *any* emulated device that is conventional PCI only > in a Q35 vm; fortunately I think the only type of device that doesn't have a > PCIe flavor is the watchdog timers (I could be remembering incorrectly, but >

Re: [libvirt PATCH] spec: libvirt-daemon: Add optional dependency on *-client

On 11/4/22 09:22, Martin Kletzander wrote: On Thu, Nov 03, 2022 at 05:24:18PM +0100, Jiri Denemark wrote: The libvirt-daemon subpackage contains libvirt-guests.sh script (used by libvirt-guests service), which requires virsh to actually work. But since dynamic libraries were separated from

Re: [libvirt PATCH] apparmor: Allow running /usr/libexec/qemu-kvm

On 11/3/22 09:02, Andrea Bolognani wrote: On Thu, Nov 03, 2022 at 08:24:37AM -0600, Jim Fehlig wrote: On 11/3/22 05:13, Andrea Bolognani wrote: + # Needed when running the RHEL/CentOS version of libvirt and QEMU + # inside a privileged container on a Debian/Ubuntu host +

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On 11/4/22 11:05 AM, Andrea Bolognani wrote: On Fri, Nov 04, 2022 at 08:23:52PM +0600, Oleg Vasilev wrote: On 04.11.2022 20:19, Andrea Bolognani wrote: Additionally, after this change it would be impossible to create a q35 VM *without* the additional bridge. Most users of the q35 machine type

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On 11/4/22 10:01 AM, Denis V. Lunev wrote: On 11/4/22 14:41, Daniel P. Berrangé wrote: On Fri, Nov 04, 2022 at 01:03:52PM +0100, Peter Krempa wrote: On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: Hotplugging PCI devices on pc-i440fx machines is supported without additional

[libvirt PATCH v3 02/24] cpu_x86: Ignore alias names

A later patch will add alias names to the feature map. They will be used in virQEMUCapsCPUFeatureTranslate and for synchronizing the list with QEMU. Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu/cpu_x86.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

[libvirt PATCH v3 12/24] cpu_map: Add missing x86 features "sgx-..."

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 17 + 1 file changed, 17 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 00d4677c3b..0ceaa1bec5 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 14/24] cpu_map: Add missing x86 feature "pks"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ tests/domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 1 +

[libvirt PATCH v3 10/24] cpu_map: Add missing x86 feature "sgx1"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index d6a576092f..2fec7c54c5 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -411,6

[libvirt PATCH v3 15/24] cpu_map: Add missing x86 feature "avx512-vp2intersect"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index f4ae4e0f26..08694edbf5 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 22/24] cpu_map: Add missing x86 feature "avic"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 +

[libvirt PATCH v3 18/24] cpu_map: Add missing x86 feature "tsx-ldtrk"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index c7591d88bf..fd4a499b22 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 23/24] cpu_map: Add missing x86 feature "v-vmsave-vmload"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 +

[libvirt PATCH v3 17/24] cpu_map: Add missing x86 feature "serialize"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index eb1b2728aa..c7591d88bf 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 20/24] cpu_map: Add missing x86 feature "xfd"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 3cef2822a0..25a0ed8e2c 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 16/24] cpu_map: Add missing x86 feature "avx512-fp16"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 08694edbf5..eb1b2728aa 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 24/24] cpu_map: Add missing x86 feature "vgif"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 +

[libvirt PATCH v3 19/24] cpu_map: Add missing x86 feature "arch-lbr"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index fd4a499b22..3cef2822a0 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 21/24] cpu_map: Add missing x86 feature "intel-pt-lip"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 5 + tests/cputestdata/x86_64-cpuid-Atom-P5362-disabled.xml | 1 + tests/cputestdata/x86_64-cpuid-Atom-P5362-guest.xml| 1 +

[libvirt PATCH v3 13/24] cpu_map: Add missing x86 feature "bus-lock-detect"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 0ceaa1bec5..5fca78595a 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 04/24] cpu_map: Add script to sync from QEMU i386 cpu features

This script is intended to help in synchronizing i386 QEMU cpu feature definitions with libvirt. QEMU's attribute list for the "max-x86_64-cpu" contains non-cpu-feature items and needs to be filtered before being useful. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_features_i386.py

[libvirt PATCH v3 08/24] cpu_map: Add missing x86 feature "sgxlc"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml| 3 +++ tests/cputestdata/x86_64-cpuid-Core-i7-8700-disabled.xml| 2 +- tests/cputestdata/x86_64-cpuid-Core-i7-8700-guest.xml | 1 +

[libvirt PATCH v3 05/24] cpu_map: Rename sync_qemu_i386.py

This makes the naming more consistent beween the two scripts synching the feature list and the model list. Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/{sync_qemu_i386.py => sync_qemu_models_i386.py} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename

[libvirt PATCH v3 09/24] cpu_map: Add missing x86 feature "sgx-exinfo"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 9e04d8fb37..d6a576092f 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 11/24] cpu_map: Add missing x86 feature "sgx2"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 2fec7c54c5..00d4677c3b 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -414,6

[libvirt PATCH v3 06/24] cpu_map: Add missing x86 feature alias names

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 925185f2f6..cba4faede6 100644 --- a/src/cpu_map/x86_features.xml +++

[libvirt PATCH v3 07/24] cpu_map: Add missing x86 feature "sgx"

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml| 3 +++ tests/cputestdata/x86_64-cpuid-Core-i7-7600U-disabled.xml | 2 +- tests/cputestdata/x86_64-cpuid-Core-i7-7600U-guest.xml | 1 +

[libvirt PATCH v3 03/24] cpu: make x86 feature alias names machine readable

Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- src/cpu_map/x86_features.xml | 55 +--- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 4cf3ff0804..925185f2f6 100644

[libvirt PATCH v3 01/24] cpu-data.py: Allow for more than child in feature nodes

cpu-data.py assumes that all "feature" nodes have exactly one child. This assumption will no longer be true when the cpumap includes alias- names for features. Signed-off-by: Tim Wiederhake Reviewed-by: Jiri Denemark --- tests/cputestdata/cpu-data.py | 11 +++ 1 file changed, 7

[libvirt PATCH v3 00/24] Synchronize x86 cpu features from qemu

V1: https://listman.redhat.com/archives/libvir-list/2022-October/235007.html V2: https://listman.redhat.com/archives/libvir-list/2022-October/235247.html Changes since V2: * Added explanation where the currently ignored "alias" names will be used in the future to the commit message (patch 1). *

Re: [libvirt PATCH v3 12/12] docs/manpages: add checklist of problems for SEV attestation

On a Wednesday in 2022, Daniel P. Berrangé wrote: Despite efforts to make the virt-qemu-sev-validate tool friendly, it is a certainty that almost everyone who tries it will hit false negative results, getting a failure despite the VM being trustworthy. Diagnosing these problems is no easy

Re: [libvirt PATCH v3 11/12] scripts: add systemtap script for capturing SEV-ES VMSA

On a Wednesday in 2022, Daniel P. Berrangé wrote: In general we expect to be able to construct a SEV-ES VMSA blob from knowledge about the AMD achitectural CPU register defaults, KVM setup and QEMU setup. If any of this unexpectedly changes, figuring out what's wrong could be horrible. This

Re: [libvirt PATCH v3 10/12] docs/kbase: describe attestation for SEV guests

On a Wednesday in 2022, Daniel P. Berrangé wrote: Expand the SEV guest kbase guide with information about how to configure a SEV/SEV-ES guest when attestation is required, and mention the use of virt-qemu-sev-validate as a way to confirm it. Signed-off-by: Daniel P. Berrangé ---

Re: [libvirt PATCH v3 09/12] tools: support generating SEV secret injection tables

On a Wednesday in 2022, Daniel P. Berrangé wrote: It is possible to build OVMF for SEV with an embedded Grub that can fetch LUKS disk secrets. This adds support for injecting secrets in the required format. Signed-off-by: Daniel P. Berrangé --- docs/manpages/virt-qemu-sev-validate.rst | 83

Re: [libvirt PATCH v3 08/12] tools: load CPU count and CPU SKU from libvirt

On a Wednesday in 2022, Daniel P. Berrangé wrote: When validating a SEV-ES guest, we need to know the CPU count and VMSA state. We can get the CPU count directly from libvirt's guest info. The VMSA state can be constructed automatically if we query the CPU SKU from host capabilities XML. Neither

Re: [PATCH] cpu_map: Add cpu feature amx

On Fri, Nov 04, 2022 at 05:11:10AM +, Yang, Lin A wrote: On Thu, Sep 22, 2022 at 04:35:51PM +0200, Martin Kletzander wrote: >On Tue, Sep 13, 2022 at 12:30:31PM -0700, Lin Yang wrote: >>AMX was introduced in QEMU commit 1f16764f7d4515bfd5e4ae0aae814fa280a7d0c8 >>and following commits. >

Re: [libvirt PATCH] spec: libvirt-daemon: Add optional dependency on *-client

On Thu, Nov 03, 2022 at 05:24:18PM +0100, Jiri Denemark wrote: The libvirt-daemon subpackage contains libvirt-guests.sh script (used by libvirt-guests service), which requires virsh to actually work. But since dynamic libraries were separated from libvirt-client to libvirt-libs more than 6 years

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On Fri, Nov 04, 2022 at 08:23:52PM +0600, Oleg Vasilev wrote: > On 04.11.2022 20:19, Andrea Bolognani wrote: > > Additionally, after this change it would be impossible to create a > > q35 VM *without* the additional bridge. Most users of the q35 machine > > type are likely using PCIe devices

[PATCH] qemu: fix vcpu clearing when multiple vcpu hotunplugs timeout

Problem: libvirt has a 5 second timeout (generally) for hotplug/unplug operations which can time out due to heavy load in guest. vcpu hotunplug occurs one vcpu at a time. But, if we perform hotplug-unplug repeatedly, there is a situation where qemu has multiple timedout vcpu unplug operations

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On 11/4/22 15:11, Daniel P. Berrangé wrote: On Fri, Nov 04, 2022 at 03:01:38PM +0100, Denis V. Lunev wrote: On 11/4/22 14:41, Daniel P. Berrangé wrote: On Fri, Nov 04, 2022 at 01:03:52PM +0100, Peter Krempa wrote: On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: Hotplugging PCI

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On 04.11.2022 20:19, Andrea Bolognani wrote: On Fri, Nov 04, 2022 at 01:03:52PM +0100, Peter Krempa wrote: On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: Hotplugging PCI devices on pc-i440fx machines is supported without additional configuration. On q35, pcie-to-pci-bridge

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On Fri, Nov 04, 2022 at 01:03:52PM +0100, Peter Krempa wrote: > On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: > > Hotplugging PCI devices on pc-i440fx machines is supported without > > additional configuration. On q35, pcie-to-pci-bridge needs to be added > > prior to the machine

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On Fri, Nov 04, 2022 at 03:01:38PM +0100, Denis V. Lunev wrote: > On 11/4/22 14:41, Daniel P. Berrangé wrote: > > On Fri, Nov 04, 2022 at 01:03:52PM +0100, Peter Krempa wrote: > > > On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: > > > > Hotplugging PCI devices on pc-i440fx machines is

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On Fri, Nov 04, 2022 at 03:01:38PM +0100, Denis V. Lunev wrote: > On 11/4/22 14:41, Daniel P. Berrangé wrote: > > On Fri, Nov 04, 2022 at 01:03:52PM +0100, Peter Krempa wrote: > > > On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: > > > > Hotplugging PCI devices on pc-i440fx machines is

Re: [libvirt PATCH v3 07/12] tools: support automatically constructing SEV-ES vCPU state

On a Wednesday in 2022, Daniel P. Berrangé wrote: The VMSA files contain the expected CPU register state for the VM. Their content varies based on a few pieces of the stack - AMD CPU architectural initial state - KVM hypervisor VM CPU initialization - QEMU userspace VM CPU initialization -

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On 11/4/22 14:41, Daniel P. Berrangé wrote: On Fri, Nov 04, 2022 at 01:03:52PM +0100, Peter Krempa wrote: On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: Hotplugging PCI devices on pc-i440fx machines is supported without additional configuration. On q35, pcie-to-pci-bridge needs to

Re: [libvirt PATCH v3 06/12] tools: support validating SEV-ES initial vCPU state measurements

On a Wednesday in 2022, Daniel P. Berrangé wrote: With the SEV-ES policy the VMSA state of each vCPU must be included in the measured data. The VMSA state can be generated using the 'sevctl' tool, by telling it a QEMU VMSA is required, and passing the hypevisor's CPU SKU (family, model,

Re: [libvirt PATCH v3 05/12] tools: load direct kernel config from libvirt

On a Wednesday in 2022, Daniel P. Berrangé wrote: When connected to libvirt we can validate that the guest configuration has the kernel hashes property enabled, otherwise including the kernel GUID table in our expected measurements is not likely to match the actual measurement. When running

Re: [libvirt PATCH v3 04/12] tools: support validating SEV direct kernel boot measurements

On a Wednesday in 2022, Daniel P. Berrangé wrote: When doing direct kernel boot we need to include the kernel, initrd and cmdline in the measurement. Signed-off-by: Daniel P. Berrangé --- docs/manpages/virt-qemu-sev-validate.rst | 43 + tools/virt-qemu-sev-validate | 108

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On Fri, Nov 04, 2022 at 01:03:52PM +0100, Peter Krempa wrote: > On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: > > Hotplugging PCI devices on pc-i440fx machines is supported without > > additional configuration. On q35, pcie-to-pci-bridge needs to be added > > prior to the machine

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On Fri, Nov 04, 2022 at 14:16:44 +0100, Denis V. Lunev wrote: > On 11/4/22 13:03, Peter Krempa wrote: > > On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: > > > Hotplugging PCI devices on pc-i440fx machines is supported without > > > additional configuration. On q35, pcie-to-pci-bridge

Re: [libvirt PATCH v3 03/12] tools: load guest config from libvirt

On a Wednesday in 2022, Daniel P. Berrangé wrote: Accept information about a connection to libvirt and a guest on the command line. Talk to libvirt to obtain the running guest state and automatically detect as much configuration as possible. It will refuse to use a libvirt connection that is

FOR GSOC

Hello Sir, My Self Arpan Gupta percieving B.Tech from RKGIT ghaziabad for Cse(Ai-Ml) , I have been intrested in Developing Apps using Android firebase framework and studying solana block chain with rust and trying to implement with saga. And if i am having knowledge of technology you work for

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On 11/4/22 13:03, Peter Krempa wrote: On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: Hotplugging PCI devices on pc-i440fx machines is supported without additional configuration. On q35, pcie-to-pci-bridge needs to be added prior to the machine startup in order to support hotplug

Re: [libvirt PATCH v3 02/12] tools: support validating SEV firmware boot measurements

On a Wednesday in 2022, Daniel P. Berrangé wrote: The virt-qemu-sev-validate program will compare a reported SEV/SEV-ES domain launch measurement, to a computed launch measurement. This determines whether the domain has been tampered with during launch. This initial implementation requires all

Re: [libvirt PATCH v3 01/12] build-aux: only forbid gethostname in C files

On a Wednesday in 2022, Daniel P. Berrangé wrote: This function is fine to use in other languages Signed-off-by: Daniel P. Berrangé --- build-aux/syntax-check.mk | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Ján Tomko Jano

Re: [PATCH] qemu: add pcie-to-pci-bridge for q35 machines

On Fri, Nov 04, 2022 at 16:43:00 +0600, Oleg Vasilev wrote: > Hotplugging PCI devices on pc-i440fx machines is supported without > additional configuration. On q35, pcie-to-pci-bridge needs to be added > prior to the machine startup in order to support hotplug [1]. > > The idea is to support the

[PATCH] qemu: add pcie-to-pci-bridge for q35 machines

Hotplugging PCI devices on pc-i440fx machines is supported without additional configuration. On q35, pcie-to-pci-bridge needs to be added prior to the machine startup in order to support hotplug [1]. The idea is to support the same workflow for creating VMs in q35, as was in pc. Namely, do not

Re: [PATCH] qemu: Drop NULL checks guarding g_slist_free_full()

On a Friday in 2022, Michal Privoznik wrote: The g_slist_free_full() function is perfectly capable of handling NULL (in which case it's NOP), therefore there's no need to check passed pointers for NULL. We have them though in couple of places. Drop them. Signed-off-by: Michal Privoznik ---

Re: [PATCH 15/15] qemu: Retire QEMU_CAPS_OBJECT_MEMORY_FILE_ALIGN

On a Thursday in 2022, Michal Privoznik wrote: Now that nothing uses this capability, it can be retired. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [PATCH 14/15] qemu_capabilities: Stop detecting QEMU_CAPS_OBJECT_MEMORY_FILE_ALIGN

On a Thursday in 2022, Michal Privoznik wrote: All supported QEMUs have this capability. Stop detecting it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 1 - tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 - [...]

Re: [PATCH 13/15] qemu: Assume QEMU_CAPS_OBJECT_MEMORY_FILE_ALIGN

On a Thursday in 2022, Michal Privoznik wrote: Introduced in QEMU's commit of v2.12.0-rc0~148^2~4 the .align attribute of memory-backend-file is always available for all QEMU versions we support (4.2.0, currently). Therefore, we can assume the capability is always set and thus doesn't need to be

Re: [PATCH 12/15] qemu: Retire QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD

On a Thursday in 2022, Michal Privoznik wrote: Now that nothing uses this capability, it can be retired. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [PATCH 11/15] qemu_capabilities: Stop detecting QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD

On a Thursday in 2022, Michal Privoznik wrote: All supported QEMUs have this capability. Stop detecting it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 1 - tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 - [...]

Re: [PATCH 10/15] qemu: Assume QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD

On a Thursday in 2022, Michal Privoznik wrote: Introduced in QEMU's commit of v2.11.0-rc0~95^2~9 the .discard attribute of memory-backend-file is always available for all QEMU versions we support (4.2.0, currently). Therefore, we can assume the capability is always set and thus doesn't need to

Re: [PATCH 09/15] qemu: Retire QEMU_CAPS_OBJECT_MEMORY_FILE

On a Thursday in 2022, Michal Privoznik wrote: Now that nothing uses this capability, it can be retired. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [PATCH 08/15] qemu_capabilities: Stop detectin QEMU_CAPS_OBJECT_MEMORY_FILE

In the commit summary: *detecting On a Thursday in 2022, Michal Privoznik wrote: All supported QEMUs have this capability. Stop detecting it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 1 - [...] tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml

Re: [PATCH 07/15] qemu: Assume QEMU_CAPS_OBJECT_MEMORY_FILE

On a Thursday in 2022, Michal Privoznik wrote: Introduced in QEMU's commit of v2.1.0-rc0~41^2~26 only for Linux, and later in v3.1.0-rc0~71^2~10 for all POSIX, the memory-backend-file is going to be present for all QEMU versions we support (4.2.0, currently). Therefore, we can assume the

Re: [PATCH 06/15] qemu: Retire QEMU_CAPS_OBJECT_MEMORY_RAM

On a Thursday in 2022, Michal Privoznik wrote: Now that nothing uses this capability, it can be retired. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [PATCH 05/15] qemu_capabilities: Stop detecting QEMU_CAPS_OBJECT_MEMORY_RAM

On a Thursday in 2022, Michal Privoznik wrote: All supported QEMUs have this capability. Stop detecting it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 1 - tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -

Re: [PATCH 04/15] qemu: Assume QEMU_CAPS_OBJECT_MEMORY_RAM

On a Thursday in 2022, Michal Privoznik wrote: Introduced in QEMU's commit of v2.1.0-rc0~41^2~104 the memory-backend-ram is going to be present for all QEMU versions we support (4.2.0, currently). Therefore, we can assume the capability is always set and thus doesn't need to be checked for.

Re: [PATCH 02/15] qemuxml2xmltest: Convert hugepages related tests to _CAPS_LATEST

On a Thursday in 2022, Michal Privoznik wrote: Currently, we have maybe a dozen tests for hugepages related stuff in qemuxml2xmltest. In all cases DO_TEST() is used, which means we have to enumerate all capabilities needed (though, it's usually just QEMU_CAPS_OBJECT_MEMORY_RAM and

[PATCH] qemu: Drop NULL checks guarding g_slist_free_full()

The g_slist_free_full() function is perfectly capable of handling NULL (in which case it's NOP), therefore there's no need to check passed pointers for NULL. We have them though in couple of places. Drop them. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 8 +++-

Re: [PATCH 01/15] qemuxml2argvtest: Convert hugepages related tests to _CAPS_LATEST

On a Thursday in 2022, Michal Privoznik wrote: Currently, we have maybe a dozen tests for hugepages related stuff in qemuxml2argvtest. In all cases DO_TEST() is used, which means we have to enumerate all capabilities needed (though, it's usually just QEMU_CAPS_OBJECT_MEMORY_RAM and

Re: [PATCH 03/15] qemuxml2argvtest: Drop cpu-numa-memshared-1 test case

On a Thursday in 2022, Michal Privoznik wrote: The aim of this test case it to make sure we error out when QEMU_CAPS_OBJECT_MEMORY_RAM is missing. Well, it's never going to be missing. Drop the test case. Signed-off-by: Michal Privoznik --- tests/qemuxml2argvdata/cpu-numa-memshared-1.err | 1 -