Re: [libvirt PATCH v3] tools: add virt-qemu-qmp-proxy for proxying QMP via libvirt QEMU guests

2022-12-06 Thread Andrea Bolognani
On Tue, Dec 06, 2022 at 05:15:43PM +, Daniel P. Berrangé wrote: > On Mon, Nov 28, 2022 at 08:33:27AM -0800, Andrea Bolognani wrote: > > It appears to me that the primary reason to want this (and now > > virt-qemu-sev-validate) to be in a separate package is really the > > dependency on Python,

Re: [libvirt PATCH v3] tools: add virt-qemu-qmp-proxy for proxying QMP via libvirt QEMU guests

2022-12-06 Thread Daniel P . Berrangé
On Mon, Nov 28, 2022 at 08:33:27AM -0800, Andrea Bolognani wrote: > On Wed, Oct 05, 2022 at 11:51:05AM +0100, Daniel P. Berrangé wrote: > > Since this tool introduces a python dependency it is not desirable > > to include it in any of the existing RPMs in libvirt. This tool is > > also QEMU specifi

Re: [PATCH] spec: Remove extra blank lines

2022-12-06 Thread Michal Prívozník
On 12/2/22 23:59, Jim Fehlig wrote: > The spec file contains inconsistent use of blank lines. While trying to > make significant changes to the file, I found it hurts both readability > and maintainability. Remove blank lines that interrupt the overall flow > and consistency. > > Signed-off-by: Ji

Re: [libvirt PATCH 0/2] examples: Install amd-sev-es-vmsa.stp

2022-12-06 Thread Ján Tomko
On a Tuesday in 2022, Andrea Bolognani wrote: Andrea Bolognani (2): examples: Sort list examples: Install amd-sev-es-vmsa.stp examples/systemtap/meson.build | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

[libvirt PATCH 1/2] examples: Sort list

2022-12-06 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- examples/systemtap/meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/systemtap/meson.build b/examples/systemtap/meson.build index f31187e187..e9874846e6 100644 --- a/examples/systemtap/meson.build +++ b/examples/syst

[libvirt PATCH 0/2] examples: Install amd-sev-es-vmsa.stp

2022-12-06 Thread Andrea Bolognani
Andrea Bolognani (2): examples: Sort list examples: Install amd-sev-es-vmsa.stp examples/systemtap/meson.build | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.38.1

[libvirt PATCH 2/2] examples: Install amd-sev-es-vmsa.stp

2022-12-06 Thread Andrea Bolognani
Fixes: d154b49a7e813245ff2ef1061c89edff9db0e119 Signed-off-by: Andrea Bolognani --- examples/systemtap/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/systemtap/meson.build b/examples/systemtap/meson.build index e9874846e6..865df3bff9 100644 --- a/examples/systemtap/meson

Re: [libvirt PATCH v3] tools: add virt-qemu-qmp-proxy for proxying QMP via libvirt QEMU guests

2022-12-06 Thread Andrea Bolognani
On Mon, Nov 28, 2022 at 08:33:27AM -0800, Andrea Bolognani wrote: > On Wed, Oct 05, 2022 at 11:51:05AM +0100, Daniel P. Berrangé wrote: > > Since this tool introduces a python dependency it is not desirable > > to include it in any of the existing RPMs in libvirt. This tool is > > also QEMU specifi

Re: [PATCH v2 0/2] qemu: refresh state after reset

2022-12-06 Thread Ján Tomko
On a Tuesday in 2022, Kristina Hanicova wrote: v1: https://listman.redhat.com/archives/libvir-list/2022-November/235913.html diff to v1: * calling refresh state unconditionally (suggested by Martin) * improved commit message Kristina Hanicova (2): qemu: refresh internal domain state after rese

[PATCH v2 2/2] qemu: refresh state after reboot initiated from the guest

2022-12-06 Thread Kristina Hanicova
Internal domain state needs to be refreshed after reset from the guest side because it may be inconsistent with the internal qemu state. Signed-off-by: Kristina Hanicova --- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 16 src/qemu/qe

[PATCH v2 0/2] qemu: refresh state after reset

2022-12-06 Thread Kristina Hanicova
v1: https://listman.redhat.com/archives/libvir-list/2022-November/235913.html diff to v1: * calling refresh state unconditionally (suggested by Martin) * improved commit message Kristina Hanicova (2): qemu: refresh internal domain state after reset qemu: refresh state after reboot initiated f

[PATCH v2 1/2] qemu: refresh internal domain state after reset

2022-12-06 Thread Kristina Hanicova
Internal domain state may change during the reset and qemu does not always send events about it. In case it happens, internal state of the domain in libvirt would be inconsistent with the internal state in qemu which could cause additional problems (e.g. cdrom tray state can change from open to cl

Re: [PATCH 7/7] qemu: Reserve bootIndexSpecified when update device

2022-12-06 Thread Jiang Jiacheng
On 2022/11/22 23:53, Peter Krempa wrote: > On Thu, Nov 17, 2022 at 10:05:33 +0800, Jiang Jiacheng wrote: >> If the 'boot order' is not specified in the xml, we cancel its >> bootindex setting and set it to '0'. However, the bootIndexSpecified >> will be set to false because we cannot parse boot

Re: [PATCH 5/7] qemu: Support update net's bootindex

2022-12-06 Thread Jiang Jiacheng
On 2022/11/22 23:40, Peter Krempa wrote: > On Thu, Nov 17, 2022 at 10:05:31 +0800, Jiang Jiacheng wrote: >> Support to update the net's bootindex using 'virsh update-device'. >> Using flag --config or --persistent to change the boot index and the >> change will be affected after reboot. With --p

Re: [PATCH 6/7] qemu: Support add bootindex = 0 to boothash when its bootIndexSpecified is true

2022-12-06 Thread Jiang Jiacheng
On 2022/11/22 23:52, Peter Krempa wrote: > On Thu, Nov 17, 2022 at 10:05:32 +0800, Jiang Jiacheng wrote: >> Support add bootindex = 0 to boothash and return 0 if duplicated bootindex = >> 0 is set. >> It is nessary to add bootindex = 0 into boothash, otherwise libvirt will >> auto set boot dev

Re: [PATCH 4/7] qemu: Support update disk's bootindex

2022-12-06 Thread Jiang Jiacheng
On 2022/11/22 23:17, Peter Krempa wrote: > On Thu, Nov 17, 2022 at 10:05:30 +0800, Jiang Jiacheng wrote: >> Support to update the disk's bootindex using 'virsh update-device'. >> Using flag --config or --persistent to change the boot index and the >> change will be affected after reboot. With --

Re: [PATCH 3/7] qemu: Introduce qemuCheckBootIndex and qemuChangeDiskBootIndex API

2022-12-06 Thread Jiang Jiacheng
On 2022/11/22 23:06, Peter Krempa wrote: > On Thu, Nov 17, 2022 at 10:05:29 +0800, Jiang Jiacheng wrote: >> Introduce qemuCheckBootIndex to check the new bootindex and is it nessary >> to update the bootindex. Introduce qemuChangeDiskBootIndex to support update >> disk's bootindex according to d

Re: [PATCH 2/7] qemu: Add bootIndexSpecified and support set bootIndex to '0'

2022-12-06 Thread Jiang Jiacheng
On 2022/11/22 23:02, Peter Krempa wrote: > On Thu, Nov 17, 2022 at 10:05:28 +0800, Jiang Jiacheng wrote: >> Add a bool bootIndexSpecified into _virDomainDeviceInfo, which means whether >> the bootindex could be update or not. BootIndexSpecified will be set to >> true if bootindex is set in XML.

Re: [PATCH 1/7] qemu: Introduce qemuDomainChangeBootIndex API

2022-12-06 Thread Jiang Jiacheng
On 2022/11/22 22:36, Peter Krempa Wrote: > On Thu, Nov 17, 2022 at 10:05:27 +0800, Jiang Jiacheng wrote: >> Introduce qemuDomainChangeBootIndex api to support update device's bootindex. >> These function will be used in following patches to support change device's >> (support cdrom, disk and net