[libvirt PATCH] ci: integration: Set an expiration on logs artifacts

2023-01-11 Thread Erik Skultety
The default expiry time is 30 days. Since the RPM artifacts coming from the previous pipeline stages are set to expire in 1 day we can set the failed integration job log artifacts to the same value. The sentiment here is that if an integration job legitimately failed (i.e. not with an

[PATCH] docs: drvqemu: Fix a typo

2023-01-11 Thread Han Han
Fixes: a677ea92 Signed-off-by: Han Han --- docs/drvqemu.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvqemu.rst b/docs/drvqemu.rst index fa23912937..22d7e6502b 100644 --- a/docs/drvqemu.rst +++ b/docs/drvqemu.rst @@ -295,7 +295,7 @@ to

Re: [PATCH V8 05/13] spec: Rename the libvirt-lock-sanlock subpackage

2023-01-11 Thread Jim Fehlig
On 1/11/23 15:05, Jim Fehlig wrote: The new name "libvirt-daemon-plugin-sanlock" provides consistency with the newly introduced "libvirt-daemon-plugin-lockd" subpackage. It's also a good opportunity to taking ownership of %{_libdir}/libvirt/lock-driver/, removing the need for a dependency on

[PATCH V8 01/13] spec: Move virtlockd to a new subpackage libvirt-daemon-lock

2023-01-11 Thread Jim Fehlig
Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrea Bolognani --- libvirt.spec.in | 61 +++-- 1 file changed, 44 insertions(+), 17 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 77b274b6f9..bb0bfb5f35

[PATCH V8 07/13] spec: Add module-init-tools dependency to nodedev and lxc drivers

2023-01-11 Thread Jim Fehlig
Both the nodedev and lxc drivers can load kernel modules. Add a module-init-tools dependency to the drivers and remove the dependency from libvirt-daemon. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrea Bolognani --- libvirt.spec.in | 6 -- 1 file changed, 4

[PATCH V8 12/13] kbase: Update rpm-deployment.rst with new subpackages

2023-01-11 Thread Jim Fehlig
Signed-off-by: Jim Fehlig Reviewed-by: Andrea Bolognani --- docs/kbase/rpm-deployment.rst | 36 --- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst index 7685ee1291..26fe1be8e6 100644

[PATCH V8 10/13] spec: Remove libvirt-daemon dependency from primary drivers

2023-01-11 Thread Jim Fehlig
To avoid needlessly installing the monolithic daemon, replace the libvirt-daemon dependency with libvirt-daemon-common in the primary drivers. The qemu and libxl drivers need additional adjustment to break the dependency on libvirt-daemon. The virtqemud systemd service file has a hard dependency

[PATCH V8 04/13] spec: Move lockd plugin to a new subpackage

2023-01-11 Thread Jim Fehlig
Introduce the libvirt-daemon-plugin-lockd subpackage to provide the client-side lockd plugin for virtlockd. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrea Bolognani --- libvirt.spec.in | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff

[PATCH V8 09/13] spec: Remove libvirt-daemon dependency from secondary drivers

2023-01-11 Thread Jim Fehlig
To avoid needlessly installing the monolithic daemon, replace the libvirt-daemon dependency with libvirt-daemon-common in the secondary drivers. The common subpackage contains all the utilities and files needed by the secondary drivers. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé

[PATCH V8 11/13] spec: Remove libvirt-daemon dependency from hypervisor subpackages

2023-01-11 Thread Jim Fehlig
Remove the libvirt-daemon dependency from the various libvirt-daemon- subpackages, replacing it with a set of the new sub subpackages providing similar functionality. When libvirt is build with modular daemons, the hypervisor subpackages no longer include the traditional, monolithic libvirt

[PATCH V8 08/13] spec: Add numad dependency to qemu and lxc drivers

2023-01-11 Thread Jim Fehlig
Both drivers use numad via virNumaGetAutoPlacementAdvice. Drop the numad dependency from libvirt-daemon. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrea Bolognani --- libvirt.spec.in | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH V8 13/13] NEWS: Mention split of libvirt-daemon subpackage

2023-01-11 Thread Jim Fehlig
Signed-off-by: Jim Fehlig Reviewed-by: Andrea Bolognani --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 768208ed03..af7d1054d4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -39,6 +39,12 @@ v9.0.0 (unreleased) With sufficiently new QEMU (v7.1.0)

[PATCH V8 02/13] spec: Move virtlogd to a new subpackage libvirt-daemon-log

2023-01-11 Thread Jim Fehlig
Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrea Bolognani --- libvirt.spec.in | 53 +++-- 1 file changed, 38 insertions(+), 15 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index bb0bfb5f35..19a3c8465c

[PATCH V8 00/13] spec: Decompose the daemon subpackage

2023-01-11 Thread Jim Fehlig
This is V8 of https://listman.redhat.com/archives/libvir-list/2023-January/236919.html The end goal is to remove the libvirt-dameon dependency on the various libvirt-daemon-driver-foo subpackages, allowing installation of a modular daemon configuration without the traditional monolithic

[PATCH V8 06/13] spec: Move common files and dependencies to libvirt-daemon-common

2023-01-11 Thread Jim Fehlig
Introduce a new subpackage libvirt-daemon-common and move virt-admin, virt-host-validate, virt-ssh-helper, libvirt-guests and miscellaneous files/directories to it. Also move common dependencies to the new subpackage. These files, utilities, and dependecies are used by other core libvirt daemons

[PATCH V8 03/13] spec: Move virtproxyd to a new subpackage libvirt-daemon-proxy

2023-01-11 Thread Jim Fehlig
Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrangé Reviewed-by: Andrea Bolognani --- libvirt.spec.in | 68 - 1 file changed, 45 insertions(+), 23 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 19a3c8465c..6072ac2c1c

[PATCH V8 05/13] spec: Rename the libvirt-lock-sanlock subpackage

2023-01-11 Thread Jim Fehlig
The new name "libvirt-daemon-plugin-sanlock" provides consistency with the newly introduced "libvirt-daemon-plugin-lockd" subpackage. It's also a good opportunity to taking ownership of %{_libdir}/libvirt/lock-driver/, removing the need for a dependency on the libvirt-daemon package.

Re: [libvirt PATCH] NEWS: document external swtpm backend addition

2023-01-11 Thread Andrea Bolognani
On Wed, Jan 11, 2023 at 04:04:37PM +0100, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- > NEWS.rst | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH V7 09/12] spec: Remove libvirt-daemon dependency from drivers

2023-01-11 Thread Jim Fehlig
On 1/11/23 11:21, Andrea Bolognani wrote: On Wed, Jan 11, 2023 at 05:35:01PM +, Daniel P. Berrangé wrote: On Wed, Jan 11, 2023 at 09:24:09AM -0800, Andrea Bolognani wrote: Based on the fact that virtlogd is opt-out and virtlockd is opt-in, can we leave the Requires=virtlogd.socket

Re: Entering freeze for libvirt-9.0.0

2023-01-11 Thread Daniel P . Berrangé
On Tue, Jan 10, 2023 at 09:28:22AM +0100, Jiri Denemark wrote: > I have just tagged v9.0.0-rc1 in the repository and pushed signed > tarballs and source RPMs to https://libvirt.org/sources/ > > Please give the release candidate some testing and in case you find a > serious issue which should have

Re: Entering freeze for libvirt-9.0.0

2023-01-11 Thread Daniel P . Berrangé
On Tue, Jan 10, 2023 at 09:28:22AM +0100, Jiri Denemark wrote: > I have just tagged v9.0.0-rc1 in the repository and pushed signed > tarballs and source RPMs to https://libvirt.org/sources/ > > Please give the release candidate some testing and in case you find a > serious issue which should have

Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-11 Thread Daniel P . Berrangé
On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: > Initial support for network devices using passt (https://passt.top) > for the backend connection will require: > > * new attributes of the subelement: > * "type" that can have the value "passt" (to differentiate from > slirp,

Re: [PATCH V7 09/12] spec: Remove libvirt-daemon dependency from drivers

2023-01-11 Thread Andrea Bolognani
On Wed, Jan 11, 2023 at 05:35:01PM +, Daniel P. Berrangé wrote: > On Wed, Jan 11, 2023 at 09:24:09AM -0800, Andrea Bolognani wrote: > > Based on the fact that virtlogd is opt-out and virtlockd is opt-in, > > can we leave the Requires=virtlogd.socket relationship alone and add > > a dependency

Re: [PATCH V7 09/12] spec: Remove libvirt-daemon dependency from drivers

2023-01-11 Thread Daniel P . Berrangé
On Wed, Jan 11, 2023 at 09:24:09AM -0800, Andrea Bolognani wrote: > On Wed, Jan 11, 2023 at 04:42:49PM +, Daniel P. Berrangé wrote: > > On Wed, Jan 11, 2023 at 08:24:08AM -0800, Andrea Bolognani wrote: > > > I think we might need to weaken these relationship from Requires to > > > Wants, as

Re: [PATCH V7 09/12] spec: Remove libvirt-daemon dependency from drivers

2023-01-11 Thread Andrea Bolognani
On Wed, Jan 11, 2023 at 04:42:49PM +, Daniel P. Berrangé wrote: > On Wed, Jan 11, 2023 at 08:24:08AM -0800, Andrea Bolognani wrote: > > I think we might need to weaken these relationship from Requires to > > Wants, as that should still ensure that the corresponding sockets are > > activated

Re: [PATCH V7 09/12] spec: Remove libvirt-daemon dependency from drivers

2023-01-11 Thread Daniel P . Berrangé
On Wed, Jan 11, 2023 at 08:24:08AM -0800, Andrea Bolognani wrote: > On Tue, Jan 10, 2023 at 04:55:03PM -0700, Jim Fehlig wrote: > > On 1/9/23 10:42, Jim Fehlig wrote: > > > %package daemon-driver-qemu > > > Summary: QEMU driver plugin for the libvirtd daemon > > > -Requires: libvirt-daemon =

Re: [PATCH V7 09/12] spec: Remove libvirt-daemon dependency from drivers

2023-01-11 Thread Andrea Bolognani
On Tue, Jan 10, 2023 at 04:55:03PM -0700, Jim Fehlig wrote: > On 1/9/23 10:42, Jim Fehlig wrote: > > %package daemon-driver-qemu > > Summary: QEMU driver plugin for the libvirtd daemon > > -Requires: libvirt-daemon = %{version}-%{release} > > +Requires: libvirt-daemon-common =

Re: Zoned storage support in libvirt

2023-01-11 Thread Stefan Hajnoczi
On Tue, Jan 10, 2023 at 03:29:47PM +, Daniel P. Berrangé wrote: > On Tue, Jan 10, 2023 at 10:19:51AM -0500, Stefan Hajnoczi wrote: > > Hi Peter, > > Zoned storage support > > (https://zonedstorage.io/docs/introduction/zoned-storage) is being added > > to QEMU. Given a zoned host block device,

[libvirt PATCH] NEWS: document external swtpm backend addition

2023-01-11 Thread Ján Tomko
Signed-off-by: Ján Tomko --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 768208ed03..8482c49b3c 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -33,6 +33,11 @@ v9.0.0 (unreleased) ... + * QEMU: add external backend for swtpm + +

Re: [libvirt PATCH 0/2] Coverity inspired fixes for qemuPasstStart

2023-01-11 Thread Erik Skultety
On Wed, Jan 11, 2023 at 10:44:57AM +0100, Jiri Denemark wrote: > Jiri Denemark (2): > qemu: Don't check pidfile in qemuPasstStart > qemu: Change some gotos in qemuPasstStart to direct return > > src/qemu/qemu_passt.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > -- >

[libvirt PATCH 1/2] qemu: Don't check pidfile in qemuPasstStart

2023-01-11 Thread Jiri Denemark
The pidfile is guaranteed to be non-NULL (thanks to glib allocation functions) and it's dereferenced two lines above anyway. Reported by coverity: /src/qemu/qemu_passt.c: 278 in qemuPasstStart() 272 return 0; 273 274 error: 275

[libvirt PATCH 2/2] qemu: Change some gotos in qemuPasstStart to direct return

2023-01-11 Thread Jiri Denemark
Jumping to the error label and reading the pidfile does not make sense until we reached qemuSecurityCommandRun which creates the pidfile. Signed-off-by: Jiri Denemark --- src/qemu/qemu_passt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_passt.c

[libvirt PATCH 0/2] Coverity inspired fixes for qemuPasstStart

2023-01-11 Thread Jiri Denemark
Jiri Denemark (2): qemu: Don't check pidfile in qemuPasstStart qemu: Change some gotos in qemuPasstStart to direct return src/qemu/qemu_passt.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.39.0

Re: [libvirt PATCH] conf: Avoid NULL dereference in virDomainNetPortForwardFree

2023-01-11 Thread Pavel Hrdina
On Wed, Jan 11, 2023 at 09:49:51AM +0100, Jiri Denemark wrote: > In our current code the function is not called with NULL argument, but > we should follow our common practice and make it safe anyway. > > Reported by coverity: > > /src/conf/domain_conf.c: 2635 in virDomainNetPortForwardFree()

[libvirt PATCH] conf: Avoid NULL dereference in virDomainNetPortForwardFree

2023-01-11 Thread Jiri Denemark
In our current code the function is not called with NULL argument, but we should follow our common practice and make it safe anyway. Reported by coverity: /src/conf/domain_conf.c: 2635 in virDomainNetPortForwardFree() 2629 { 2630 size_t i; 2631 2632 if