On 1/18/23 10:07, Andrea Bolognani wrote:
On Wed, Jan 18, 2023 at 08:59:23AM -0700, Jim Fehlig wrote:
On 1/18/23 03:45, Andrea Bolognani wrote:
Jim, it looks like you came up with exactly the same solution as
me, despite concerns about the size of the resulting hammer. Any
other ideas, or shoul
On Wed, Jan 18, 2023 at 08:59:23AM -0700, Jim Fehlig wrote:
> On 1/18/23 03:45, Andrea Bolognani wrote:
> > Jim, it looks like you came up with exactly the same solution as
> > me, despite concerns about the size of the resulting hammer. Any
> > other ideas, or should we just go ahead and merge thi
On 1/18/23 02:43, Andrea Bolognani wrote:
CC'ing AppArmor experts to get their input :)
This is a farily big hammer, but unfortunately I don't think it's
possible to tell AppArmor "let the driver use umount, but only if
it's running inside a namespace".
Andrea Bolognani (1):
apparmor: Allow
On 1/18/23 03:45, Andrea Bolognani wrote:
On Wed, Jan 18, 2023 at 11:00:33AM +0100, Michal Prívozník wrote:
On 1/18/23 10:43, Andrea Bolognani wrote:
Commit 379c0ce4bfed introduced a call to umount(/dev) performed
inside the namespace that we run QEMU in.
As a result of this, on machines using
Somehow I neglected to fully update the example for the interface
passt backend when the design changed during development. This fixes
the example to reflect what is in the code.
Signed-off-by: Laine Stump
---
docs/formatdomain.rst | 20 ++--
1 file changed, 10 insertions(+), 10
The 'containers: false' key was originally intend to be a way to tell
libvirt-ci to generate the dockerfiles, but not generate any container
jobs. This concept was never implemented. Instead we should be using
the 'allow-failure: true' key to allow the container job to fail. The
builds job can stil
Daniel P. Berrangé (2):
ci: treat centos-stream9 as non-gating job
ci: remove non-existant 'containers: false' key usage
ci/gitlab/builds.yml | 64
ci/gitlab/containers.yml | 32 ++--
ci/manifest.yml | 31 +--
Over the time we've had it running, the centos stream 9 job has broken
way too often due to bugs in the infrastructure and/or content being
published. It is clearly not suitable for production usage, so we want
to change the CI job to non-gating, to prevent our pipelines being
blocked by frequent p
On 2023/1/18 0:13, Jiri Denemark wrote:
> On Tue, Jan 17, 2023 at 21:58:39 +0800, Jiang Jiacheng wrote:
>>
>>
>> On 2023/1/17 16:44, Claudio Fontana wrote:
>>> Hi,
>>>
>>> On 1/16/23 14:42, Jiang Jiacheng wrote:
Add public API VIR_MIGRATE_PARAM_PARALLEL_COMPRESSION,
VIR_MIGRATE_PARAM_P
On Wed, Jan 18, 2023 at 12:55:08PM +, Daniel P. Berrangé wrote:
> This fixes a bug in
>
> commit fda53ab3a536647192dd088672dcb6f4a6820e51
> Author: Daniel P. Berrangé
> Date: Thu Dec 22 10:29:32 2022 -0500
>
> remote: use VIR_LOCK_GUARD in client code
>
> Signed-off-by: Daniel P
This fixes a bug in
commit fda53ab3a536647192dd088672dcb6f4a6820e51
Author: Daniel P. Berrangé
Date: Thu Dec 22 10:29:32 2022 -0500
remote: use VIR_LOCK_GUARD in client code
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 1 +
1 file changed, 1 insertion(+)
dif
On Wed, Jan 18, 2023 at 12:57:26PM +0100, Erik Skultety wrote:
> Fixes: 62448c1a4927682f999fecf55e896de4625e46f6
>
> Signed-off-by: Erik Skultety
> ---
>
> The commit in question broke many integration tests:
> https://gitlab.com/libvirt/libvirt/-/jobs/3620679044
>
> src/remote/remote_driver.c
Fixes: 62448c1a4927682f999fecf55e896de4625e46f6
Signed-off-by: Erik Skultety
---
The commit in question broke many integration tests:
https://gitlab.com/libvirt/libvirt/-/jobs/3620679044
src/remote/remote_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/remote/r
On Wed, Jan 18, 2023 at 11:00:33AM +0100, Michal Prívozník wrote:
> On 1/18/23 10:43, Andrea Bolognani wrote:
> > Commit 379c0ce4bfed introduced a call to umount(/dev) performed
> > inside the namespace that we run QEMU in.
> >
> > As a result of this, on machines using AppArmor, VM startup now
> >
On 1/18/23 10:46, Daniel P. Berrangé wrote:
> The CURLOPT_PUT constant causes a deprecation warning when compiling on
> Alpine Edge. The docs indicate it is deprecated since 7.2.1
>
> https://curl.se/libcurl/c/CURLOPT_PUT.html
>
> We already use CURLOPT_UPLOAD in the ESX driver, so this brings
On 1/18/23 10:43, Andrea Bolognani wrote:
> Commit 379c0ce4bfed introduced a call to umount(/dev) performed
> inside the namespace that we run QEMU in.
>
> As a result of this, on machines using AppArmor, VM startup now
> fails with
>
> internal error: Process exited prior to exec: libvirt:
>
On Wed, Jan 18, 2023 at 09:46:55AM +, Daniel P. Berrangé wrote:
> The CURLOPT_PUT constant causes a deprecation warning when compiling on
> Alpine Edge. The docs indicate it is deprecated since 7.2.1
>
> https://curl.se/libcurl/c/CURLOPT_PUT.html
I should also mention here that 7.87 introd
Firstly, the virProcessGetStatInfo() does not fail really. But
even if it did, it sets correct errno only sometimes (and even
that is done in a helper it's calling - virProcessGetStat() and
even there it's the case only in very few error paths).
Therefore, using virReportSystemError() to report er
We have virDomainGetCPUStats() API which offers querying
statistics on host CPU usage by given guest. And it works in two
modes: getting overall stats (@start_cpu == -1, @ncpus == 1) or
getting per host CPU usage.
For the QEMU driver it is implemented by looking into values
stored in corresponding
Yeah, we've already seen this commit (v8.0.0-rc2~4) and also its
revert (v8.1.0-rc1~345). While the original idea was sound, the
implementation was less so and it changed behaviour of some
public APIs (e.g. whilst getting stats for a running guest was
best effort it started to return errors).
Sign
v2 of:
https://listman.redhat.com/archives/libvir-list/2023-January/237113.html
diff to v1:
- Make virProcessGetStatInfo() return an error, per Martin's review
Michal Prívozník (3):
src: Don't use virReportSystemError() on virProcessGetStatInfo()
failure
virprocess: Make virProcessGetSta
On Fri, Jan 13, 2023 at 12:21:59PM -0700, Jim Fehlig wrote:
> Remove the libvirt-daemon dependency from the various
> libvirt-daemon- subpackages, replacing it with a set of the
> new sub subpackages providing similar functionality. When libvirt is build
> with modular daemons, the hypervisor subpa
On Fri, Jan 13, 2023 at 12:21:58PM -0700, Jim Fehlig wrote:
> To avoid needlessly installing the monolithic daemon, replace the
> libvirt-daemon dependency with libvirt-daemon-common in the primary
> drivers.
>
> The qemu driver also needs a dependency on libvirt-daemon-log since
> the virtqemud s
On Fri, Jan 13, 2023 at 12:21:57PM -0700, Jim Fehlig wrote:
> The systemd service files of the qemu and libxl driver currently have a
> 'Requires' dependency on virtlockd, which is too strong since virtlockd
> is not enabled by default in either driver. Change the dependency to a
> 'Wants' to avoid
On Fri, Jan 13, 2023 at 12:21:53PM -0700, Jim Fehlig wrote:
> Introduce a new subpackage libvirt-daemon-common and move virt-admin,
> virt-host-validate, virt-ssh-helper, libvirt-guests and miscellaneous
> files/directories to it. Also move common dependencies to the new
> subpackage. These files,
On Fri, Jan 13, 2023 at 12:21:52PM -0700, Jim Fehlig wrote:
> The new name "libvirt-daemon-plugin-sanlock" provides consistency with the
> newly introduced "libvirt-daemon-plugin-lockd" subpackage.
>
> It's also a good opportunity to taking ownership of
> %{_libdir}/libvirt/lock-driver/, removing
The CURLOPT_PUT constant causes a deprecation warning when compiling on
Alpine Edge. The docs indicate it is deprecated since 7.2.1
https://curl.se/libcurl/c/CURLOPT_PUT.html
We already use CURLOPT_UPLOAD in the ESX driver, so this brings the CH
driver into line.
Signed-off-by: Daniel P. Berr
On Tue, Jan 17, 2023 at 06:58:39PM +, Daniel P. Berrangé wrote:
> On Tue, Jan 17, 2023 at 11:50:10AM -0700, Jim Fehlig wrote:
> > All patches in this series contain a R-B from Andrea or Daniel. Andrea, can
> > this be pushed now or did you want a final blessing from Daniel?
>
> I have no furthe
CC'ing AppArmor experts to get their input :)
This is a farily big hammer, but unfortunately I don't think it's
possible to tell AppArmor "let the driver use umount, but only if
it's running inside a namespace".
Andrea Bolognani (1):
apparmor: Allow umount(/dev)
src/security/apparmor/usr.sbin
Commit 379c0ce4bfed introduced a call to umount(/dev) performed
inside the namespace that we run QEMU in.
As a result of this, on machines using AppArmor, VM startup now
fails with
internal error: Process exited prior to exec: libvirt:
QEMU Driver error: failed to umount devfs on /dev: Permis
Ping
On 1/10/23 08:31, Daniel Henrique Barboza wrote:
Hi,
This series updates RISC-V QEMU caps that weren't being updated since
QEMU 5.0.0.
To do that I had to add a RISC-V stub driver in src/cpu to avoid test
failures after the caps update. This is a very bare-bone driver that
is basically a
31 matches
Mail list logo
