Ping...
在 2023/1/10 19:29, Jiang Jiacheng 写道:
> Define and use g_autoptr() for virNWFilterDef and virNWFilterRuleDef,
> and remove unnecessary label/variable.
>
> Those patches are followup with:
> https://gitlab.com/libvirt/libvirt/-/commit/a9027d447be789cd11c0aa18ceb83ed79f677f86
>
> diff to
On Wed, Jan 18, 2023 at 21:52:30 +0800, Jiang Jiacheng wrote:
> > I think we should just be able to use the existing
> > VIR_MIGRATE_PARAM_COMPRESSION to specify the method. We know whether
> > we're asking for parallel migration from VIR_MIGRATE_PARALLEL flag. We
> > might need to add checks for
The field is no longer used so we can remove it and the code filling it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.h | 3 ---
src/qemu/qemu_process.c | 24
2 files changed, 27 deletions(-)
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index
All callers pass 'false' so we no longer need it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_alias.c | 13 -
src/qemu/qemu_alias.h | 3 +--
src/qemu/qemu_hotplug.c | 2 +-
3 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_alias.c
Peter Krempa (3):
qemu: hotplug: Remove legacy quirk for 'dimm' address generation
qemu: alias: Remove 'oldAlias' argument of qemuAssignDeviceMemoryAlias
qemu: Remove 'memAliasOrderMismatch' field from VM private data
src/qemu/qemu_alias.c | 13 -
src/qemu/qemu_alias.h | 3
Commit b7798a07f93 (in fall of 2016) changed the way we generate aliases
for 'dimm' memory devices as the alias itself is part of the migration
stream section naming and thus must be treated as ABI.
The code added compatibility layer for VMs with memory hotplug started
with the old scheme to
On Wed, Jan 18, 2023 at 10:58:19AM +0100, Michal Privoznik wrote:
We have virDomainGetCPUStats() API which offers querying
statistics on host CPU usage by given guest. And it works in two
modes: getting overall stats (@start_cpu == -1, @ncpus == 1) or
getting per host CPU usage.
For the QEMU
On Wed, Jan 18, 2023 at 10:58:18AM +0100, Michal Privoznik wrote:
Yeah, we've already seen this commit (v8.0.0-rc2~4) and also its
revert (v8.1.0-rc1~345). While the original idea was sound, the
implementation was less so and it changed behaviour of some
public APIs (e.g. whilst getting stats
On Thu, Jan 19, 2023 at 01:36:55PM +0100, Vasily Ulyanov wrote:
Looking at the code now.
src/util/virnetdevtap.c (qemuInterfaceEthernetConnect):
if (net->managed_tap == VIR_TRISTATE_BOOL_NO) {
...
} else {
...
tap_create_flags |= VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING;
Looking at the code now.
src/util/virnetdevtap.c (qemuInterfaceEthernetConnect):
if (net->managed_tap == VIR_TRISTATE_BOOL_NO) {
...
} else {
...
tap_create_flags |= VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING;
...
}
Shouldn't it be the other way around?
Hi All,
I am now trying to run our downstream KubeVirt build with a recent libvirt 9.0.0
and I see a problem that libvirt refuses to start a VM if it is configured to
use a pre-created tap device:
virError(Code=55, Domain=0, Message='Requested operation is not valid: The
tap0 interface already
On Wed, Jan 18, 2023 at 02:19:08PM +, Daniel P. Berrangé wrote:
>
>
> Daniel P. Berrangé (2):
> ci: treat centos-stream9 as non-gating job
> ci: remove non-existant 'containers: false' key usage
>
> ci/gitlab/builds.yml | 64
>
12 matches
Mail list logo
