On 02/03/2023 23.16, Philippe Mathieu-Daudé wrote:
On 2/3/23 17:31, Thomas Huth wrote:
qemu-system-aarch64 is a proper superset of qemu-system-arm,
and the latter was mainly still required for 32-bit KVM support.
But this 32-bit KVM arm support has been dropped in the Linux
kernel a couple of
On 3/2/23 07:43, Andrea Bolognani wrote:
On Thu, Feb 23, 2023 at 11:13:28AM -0700, Jim Fehlig wrote:
+++ b/src/security/apparmor/libvirt-qemu
@@ -91,7 +91,7 @@
/usr/share/proll/** r,
/usr/share/qemu-efi/** r,
/usr/share/qemu-kvm/** r,
- /usr/share/qemu/** r,
+ /usr/share/qemu/**
On 2/3/23 17:31, Thomas Huth wrote:
qemu-system-aarch64 is a proper superset of qemu-system-arm,
and the latter was mainly still required for 32-bit KVM support.
But this 32-bit KVM arm support has been dropped in the Linux
kernel a couple of years ago already, so we don't really need
On 2/3/23 17:31, Thomas Huth wrote:
We're struggling quite badly with our CI minutes on the shared
gitlab runners, so we urgently need to think of ways to cut down
our supported build and target environments. qemu-system-i386 and
qemu-system-arm are not really required anymore, since nobody uses
On 2/3/23 17:31, Thomas Huth wrote:
Hardly anybody still uses 32-bit arm environments for running QEMU,
so let's stop wasting our scarce CI minutes with these jobs.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/crossbuilds.yml | 14 --
1 file changed, 14 deletions(-)
On Mon, Feb 06, 2023 at 02:53:14PM +0100, Erik Skultety wrote:
> Unless we run it as 'sh ci/build.sh' in .gitlab-ci.yml recipes and
> instead opt into doing 'chmod +x && ci/build.sh' it will cause meson
> dist build to fail with a fatal error about having uncommitted changes
> in the repo.
On Mon, Feb 06, 2023 at 02:53:06PM +0100, Erik Skultety wrote:
> It is quite confusing seeing these two in a call like this one:
> $ meson build $MESON_OPTS $MESON_ARGS
>
> One has to ask 'how are they different' and 'shouldn't these be
> merged'. In fact, these variables hold very different
On Mon, Feb 06, 2023 at 02:53:04PM +0100, Erik Skultety wrote:
> Although it is currently consistent with the other variables we define
> when running ci in a local container environment, it isn't consistent
> with the variable naming we use in GitLab recipes. Since the idea is
> to unite the two,
On Mon, Feb 06, 2023 at 02:53:03PM +0100, Erik Skultety wrote:
> There's no harm in always building in system mode, i.e. setting the
> right paths.
>
> Signed-off-by: Erik Skultety
> ---
> ci/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
On Mon, Feb 06, 2023 at 02:53:02PM +0100, Erik Skultety wrote:
> Even though 'setup' is assumed when no other command is given, we're
> being explicit in our GitLab recipes, so do the same for the local
> build.sh script too.
It is actually gouing to become mandatory soon based
on the warnings
On Mon, Feb 06, 2023 at 02:53:01PM +0100, Erik Skultety wrote:
> build.sh is not the place where this should be mentioned as the
> official entrypoint for this script locally is ci/helper which can
> download the right image from our upstream CI registry. Since the idea
> is to ultimately drop the
On Mon, Feb 06, 2023 at 02:53:00PM +0100, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> .gitlab-ci.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-
On Mon, Feb 06, 2023 at 02:52:59PM +0100, Erik Skultety wrote:
> You can specify multiple targets at once for the 'compile' command.
>
> Signed-off-by: Erik Skultety
> ---
> .gitlab-ci.yml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/.gitlab-ci.yml
On Mon, Feb 06, 2023 at 02:52:58PM +0100, Erik Skultety wrote:
> This is continuation of what commit b56e2be68e3 started. If we stick to
> only calling meson commands directly, we can achieve much better
> consistency in passing arguments to meson especially if we unify the
> recipes run in gitlab
On Thu, Mar 02, 2023 at 05:31:06PM +0100, Thomas Huth wrote:
> Hardly anybody still uses 32-bit arm environments for running QEMU,
> so let's stop wasting our scarce CI minutes with these jobs.
>
> Signed-off-by: Thomas Huth
> ---
> .gitlab-ci.d/crossbuilds.yml | 14 --
> 1 file
On Thu, Mar 02, 2023 at 05:31:05PM +0100, Thomas Huth wrote:
> For running QEMU in system emulation mode, the user needs a rather
> strong host system, i.e. not only an embedded low-frequency controller.
> All recent beefy arm host machines should support 64-bit now, it's
> unlikely that anybody
On Thu, Mar 02, 2023 at 05:31:03PM +0100, Thomas Huth wrote:
> Hardly anybody still uses 32-bit x86 environments for running QEMU,
> so let's stop wasting our scarce CI minutes with these jobs.
>
> Signed-off-by: Thomas Huth
> ---
> .gitlab-ci.d/crossbuilds.yml | 16
> 1 file
On Thu, Mar 02, 2023 at 05:31:04PM +0100, Thomas Huth wrote:
> qemu-system-aarch64 is a proper superset of qemu-system-arm,
> and the latter was mainly still required for 32-bit KVM support.
> But this 32-bit KVM arm support has been dropped in the Linux
> kernel a couple of years ago already, so
On Thu, Mar 02, 2023 at 05:31:02PM +0100, Thomas Huth wrote:
> Hardly anybody still uses 32-bit x86 hosts today, so we should start
> deprecating them to stop wasting our time and CI minutes here.
> For example, there are also still some unresolved problems with these:
> When emulating 64-bit
On Thu, Mar 02, 2023 at 05:31:01PM +0100, Thomas Huth wrote:
> Hardly anybody really requires the i386 binary anymore, since the
> qemu-system-x86_64 binary is a proper superset. So let's deprecate
> the 32-bit variant now, so that we can finally stop wasting our time
> and CI minutes with this.
qemu-system-aarch64 is a proper superset of qemu-system-arm,
and the latter was mainly still required for 32-bit KVM support.
But this 32-bit KVM arm support has been dropped in the Linux
kernel a couple of years ago already, so we don't really need
qemu-system-arm anymore, thus deprecated it now.
Hardly anybody still uses 32-bit x86 environments for running QEMU,
so let's stop wasting our scarce CI minutes with these jobs.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/crossbuilds.yml | 16
1 file changed, 16 deletions(-)
diff --git a/.gitlab-ci.d/crossbuilds.yml
For running QEMU in system emulation mode, the user needs a rather
strong host system, i.e. not only an embedded low-frequency controller.
All recent beefy arm host machines should support 64-bit now, it's
unlikely that anybody is still seriously using QEMU on a 32-bit arm
CPU, so we deprecate the
Hardly anybody still uses 32-bit arm environments for running QEMU,
so let's stop wasting our scarce CI minutes with these jobs.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/crossbuilds.yml | 14 --
1 file changed, 14 deletions(-)
diff --git a/.gitlab-ci.d/crossbuilds.yml
Hardly anybody still uses 32-bit x86 hosts today, so we should start
deprecating them to stop wasting our time and CI minutes here.
For example, there are also still some unresolved problems with these:
When emulating 64-bit binaries in user mode, TCG does not honor atomicity
for 64-bit accesses,
We're struggling quite badly with our CI minutes on the shared
gitlab runners, so we urgently need to think of ways to cut down
our supported build and target environments. qemu-system-i386 and
qemu-system-arm are not really required anymore, since nobody uses
KVM on the corresponding systems for
Hardly anybody really requires the i386 binary anymore, since the
qemu-system-x86_64 binary is a proper superset. So let's deprecate
the 32-bit variant now, so that we can finally stop wasting our time
and CI minutes with this.
With regards to 32-bit KVM support in the x86 Linux kernel,
the
On 2/15/23 11:42, Andrea Bolognani wrote:
> Move all the boot related parts of qemuDomainDefPostParse()
> to a separate helper.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/qemu/qemu_domain.c | 37 -
> 1 file changed, 24 insertions(+), 13 deletions(-)
>
>
On 2/15/23 11:41, Andrea Bolognani wrote:
> Motivation for these changes can be found in the commit message
> for patch 20 ("qemu: Move firmware selection from startup to
> postparse") as well as [RHBZ#2161965].
>
>
> Patches 01-17 are preparatory fixes/improvements/cleanups.
>
> Patches 19-20
On a Thursday in 2023, Peter Krempa wrote:
We now always assume support for polling mode of iothreads.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
On Wed, Mar 01, 2023 at 19:04:42 +0100, Andrea Bolognani wrote:
> Commit 068efae5b1a9 created a copy of this code instead of
> simply moving it.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/qemu/qemu_conf.c | 6 --
> 1 file changed, 6 deletions(-)
Reviewed-by: Peter Krempa
On a Wednesday in 2023, Peter Krempa wrote:
This new version doesn't bother looking for properties of -machine but
uses data added to output of 'query-machines' to do proper decision when
to use -machine acpi and also adds validation.
Required qemu patch:
On Thu, Feb 23, 2023 at 11:13:28AM -0700, Jim Fehlig wrote:
> +++ b/src/security/apparmor/libvirt-qemu
> @@ -91,7 +91,7 @@
>/usr/share/proll/** r,
>/usr/share/qemu-efi/** r,
>/usr/share/qemu-kvm/** r,
> - /usr/share/qemu/** r,
> + /usr/share/qemu/** rk,
>/usr/share/seabios/** r,
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 -
Introduce a new sub-element of disk's which will
allow configuring multiple iothreads and also map them to specific
virt-queues of virtio devices.
Signed-off-by: Peter Krempa
---
docs/formatdomain.rst | 23 +-
src/conf/domain_conf.c| 76
Remove disks which are not necessary to demonstrate iothread config.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/iothreads-disk.x86_64-latest.args| 5 +
tests/qemuxml2argvdata/iothreads-disk.xml | 6 --
.../iothreads-ids-partial.x86_64-latest.args
iothread polling mode and the corresponding properties were added in
qemu-2.9 ( 0d9d86fb4df4882b ). We can always assume that qemu supports
them.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/qemu/qemu_driver.c
Implement the support for the persisted poll parameters and remove
restrictions on saving config when modifying them during runtime.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 18 +++
src/qemu/qemu_driver.c| 30
Add validation and formatting of the commandline.
Note that this is based on Stefan's RFC series which only adds the qemu
interface:
https://lists.gnu.org/archive/html/qemu-devel/2023-01/msg04090.html
---
src/qemu/qemu_command.c | 45 +++
src/qemu/qemu_validate.c
---
.../caps_8.0.0.x86_64.replies | 197 +-
.../caps_8.0.0.x86_64.xml | 2 +-
2 files changed, 102 insertions(+), 97 deletions(-)
diff --git a/tests/qemucapabilitiesdata/caps_8.0.0.x86_64.replies
The new helper is similar to virXPathNode list but for cases where we
want to get subelements directly rather than using XPath.
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
src/util/virxml.c| 29 +
src/util/virxml.h| 4
3
'iothreads-disk' covers everything that 'iothreads' did in addition to
actually using the iothread.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/iothreads.args | 35 -
tests/qemuxml2argvdata/iothreads.xml | 31 --
tests/qemuxml2argvtest.c
Remove the cputune-iothreads, cputune-iothreadsched-zeropriority,
cputune-iothreadsched test files by moving the relevant elements into
the cputune case as we can setup scheduler settings for multiple objects
and thus test everything in one go.
Signed-off-by: Peter Krempa
---
The capability represents the support for mapping virtqueues to
iothreads for the 'virtio-blk' device.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
Currently we allow configuring the 'poll-max-ns', 'poll-grow', and
'poll-shrink' parameters of qemu iothreads only during runtime and they
are not persisted. Add XML machinery to persist them.
Signed-off-by: Peter Krempa
---
docs/formatdomain.rst | 11 -
Indent the example XML block so that it belongs to the paragraph talking
about it.
Signed-off-by: Peter Krempa
---
docs/formatdomain.rst | 42 --
1 file changed, 20 insertions(+), 22 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
We now always assume support for polling mode of iothreads.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 -
Use latest caps for the tests even though the original test case didn't
need any capabilities.
Signed-off-by: Peter Krempa
---
...ch.err => cputune-iothreadsched-toomuch.x86_64-latest.err} | 0
...verlap.err => cputune-vcpusched-overlap.x86_64-latest.err} | 0
tests/qemuxml2argvtest.c
iothreads were introduced in qemu-2.0 and can't be compiled out thus we
can always assume qemu supports them.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_driver.c | 21 +
src/qemu/qemu_process.c | 23 ---
Use DO_TEST_CAPS_LATEST for cputune-numatune, cputune-zero-shares,
cputune, and vcpu-placement-static cases. Do the necessary tweaks to
work with actual data.
Signed-off-by: Peter Krempa
---
...gs => cputune-numatune.x86_64-latest.args} | 13 ---
...=>
The argv counterparts are already modernized.
Signed-off-by: Peter Krempa
---
...ccw.xml => iothreads-disk-virtio-ccw.s390x-latest.xml} | 4
...ccw.xml => iothreads-virtio-scsi-ccw.s390x-latest.xml} | 4
...ci.xml => iothreads-virtio-scsi-pci.x86_64-latest.xml} | 5 -
Use DO_TEST_CAPS_LATEST for the basic tests. The emulator needed to be
tweaked to work with the real caps data.
Signed-off-by: Peter Krempa
---
...args => iothreads-disk.x86_64-latest.args} | 21 +++
tests/qemuxml2argvdata/iothreads-disk.xml | 4 ++--
...
All supported QEMU versions now support iothreads thus upcoming patches
will be removing the capability checks. Remove the 'iothreads-nocap'
case which will become invalid.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/iothreads-nocap.err | 1 -
This series:
0) cleans up various things (patches 1, 16)
1) Fixes and modernizes testing of iothreads (patches 2-9)
2) Cleans up unneeded iothread capabilities (patches 10 - 13)
3) Adds XML and commandline support for iothread polling attributes
(patches 14-15)
4) Contains a RFC for adding
The function doesn't use XPath at all. Don't pass the context to it.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 39ddfb7db0..ad2b44b610 100644
---
On 2/23/23 19:13, Jim Fehlig wrote:
> SUSE installs edk2 firmwares for both x86_64 and aarch64 in /usr/share/qemu.
> Add support for this path in virt-aa-helper and allow locking files within
> the path in the libvirt qemu abstraction.
>
> Signed-off-by: Jim Fehlig
> ---
>
> FYI, I'm fine
56 matches
Mail list logo
