[libvirt PATCH 1/8] bhyve: fix typo in error message

2023-03-18 Thread Ján Tomko
Use the same string as in qemu_process. Signed-off-by: Ján Tomko --- src/bhyve/bhyve_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index eee0c4bf1d..f8f072ff03 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/b

[libvirt PATCH 6/8] util: xml: remove function names from error messages

2023-03-18 Thread Ján Tomko
The function name is already logged, and these can happen only as a result of a programmer error. Signed-off-by: Ján Tomko --- src/util/virxml.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index c0789c062c..a84048e14a 100644 ---

[libvirt PATCH 8/8] vbox: unify "unable to get hard disk id" message

2023-03-18 Thread Ján Tomko
Signed-off-by: Ján Tomko --- src/vbox/vbox_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 7aed421390..4a4b635fe2 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -5220,7 +5220,7 @@ vboxSnaps

[libvirt PATCH 7/8] Unify error message when namespaces are unsupported

2023-03-18 Thread Ján Tomko
Some helpers used a period at the end, others did not. Signed-off-by: Ján Tomko --- src/qemu/qemu_namespace.c | 2 +- src/util/virprocess.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_namespace.c b/src/qemu/qemu_namespace.c index 89d631ee5a..ab50f

[libvirt PATCH 3/8] bhyve: unify error message for UUID generation

2023-03-18 Thread Ján Tomko
All the other places spell UUID in all caps. Signed-off-by: Ján Tomko --- src/bhyve/bhyve_parse_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_command.c index 2a5959ba1d..4b0aaab056 100644 --- a/src/bhyve/bhyv

[libvirt PATCH 2/8] src: unify symlink creation error message

2023-03-18 Thread Ján Tomko
In some places, one quote got dropped by accident. Signed-off-by: Ján Tomko --- src/libxl/libxl_driver.c | 2 +- src/lxc/lxc_driver.c | 2 +- src/qemu/qemu_driver.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c

[libvirt PATCH 5/8] vbox: remove unreachable error in virVBoxSnapshotConfSaveVboxFile

2023-03-18 Thread Ján Tomko
Both callers in the VirtualBox driver handle the error and only call this function with a non-NULL argument. Signed-off-by: Ján Tomko --- src/vbox/vbox_snapshot_conf.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c index a6e5

[libvirt PATCH 4/8] vbox: remove unreachable error in virVBoxSnapshotConfLoadVboxFile

2023-03-18 Thread Ján Tomko
Both callers in the VirtualBox driver error out if the path can't be fetched via VirtualBox APIs and abort on coversion error from UTF-16 to UTF-8. Signed-off-by: Ján Tomko --- src/vbox/vbox_snapshot_conf.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/vbox/vbox_snapshot_conf.c b/

[libvirt PATCH 0/8] Slightly reduce the number of translatable strings

2023-03-18 Thread Ján Tomko
*** BLURB HERE *** Ján Tomko (8): bhyve: fix typo in error message src: unify symlink creation error message bhyve: unify error message for UUID generation vbox: remove unreachable error in virVBoxSnapshotConfLoadVboxFile vbox: remove unreachable error in virVBoxSnapshotConfSaveVboxFile