Re: [PATCH] Revert "ci: Disable optimization on macos-12"

2023-03-24 Thread Michal Prívozník
On 3/24/23 16:54, Martin Kletzander wrote: > This reverts commit 1f76b5365ec78b1e9a36038db8e13ec0025bbe7a. > > There were two issues with this commit. First is the missing propagation > of CFLAGS into the build environment and second is the fact that this is > not enough to disable the check for

[PATCH] Revert "ci: Disable optimization on macos-12"

2023-03-24 Thread Martin Kletzander
This reverts commit 1f76b5365ec78b1e9a36038db8e13ec0025bbe7a. There were two issues with this commit. First is the missing propagation of CFLAGS into the build environment and second is the fact that this is not enough to disable the check for -fsemantic-interposition. The proper fix would

Re: [PATCH] virt-host-validate: Detect SMMU support on ARMs

2023-03-24 Thread Ján Tomko
On a Wednesday in 2023, Michal Privoznik wrote: In vir-host-validate we do two checks related to IOMMU: 1) hardware support, and 2) kernel support. While users are usually interested in the latter, the former also makes sense. And for the former (hardware support) we have this huge if-else

Re: [PATCH] ci: Disable optimization on macos-12

2023-03-24 Thread Michal Prívozník
On 3/24/23 13:26, Martin Kletzander wrote: > This enables our CI to run tests on on macos-12 after commit > 7944700b4037. > > Signed-off-by: Martin Kletzander > --- > The pipeline can be seen here: > > https://gitlab.com/nertpinx/libvirt/-/pipelines/816876889 > > ci/gitlab/builds.yml | 1 + >

Re: [PATCH] esx: Change the default username when connecting to VCenter

2023-03-24 Thread Martin Kletzander
On Fri, Mar 24, 2023 at 12:11:23PM +0100, Michal Privoznik wrote: While it's true that the default username is: administrator@${SSO-Domain} in majority of cases the ${SSO-Domain} is "vsphere.local". But our code (and what virsh displays then) says it's just "administrator". This is wrong

Re: [PATCH] vfio/pci: Propagate ACPI notifications to the user-space

2023-03-24 Thread Grzegorz Jaszczyk
czw., 23 mar 2023 o 18:07 Alex Williamson napisał(a): > > On Thu, 9 Mar 2023 14:41:23 +0100 > Grzegorz Jaszczyk wrote: > > > czw., 9 mar 2023 o 00:38 Alex Williamson > > napisał(a): > > > > > > On Wed, 8 Mar 2023 14:44:28 -0800 > > > Dominik Behr wrote: > > > > > > > On Wed, Mar 8, 2023 at

[PATCH] ci: Disable optimization on macos-12

2023-03-24 Thread Martin Kletzander
This enables our CI to run tests on on macos-12 after commit 7944700b4037. Signed-off-by: Martin Kletzander --- The pipeline can be seen here: https://gitlab.com/nertpinx/libvirt/-/pipelines/816876889 ci/gitlab/builds.yml | 1 + ci/manifest.yml | 2 ++ 2 files changed, 3 insertions(+)

Re: [PATCH] ci: Refresh CI files with current lcitool

2023-03-24 Thread Michal Prívozník
On 3/24/23 09:42, Martin Kletzander wrote: > This updates to FreeBSD 12.4 which has clang that supports > -fsemantic-interposition, plus of course updates the system. > > Signed-off-by: Martin Kletzander > --- > ci/gitlab/builds.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[PATCH] esx: Change the default username when connecting to VCenter

2023-03-24 Thread Michal Privoznik
While it's true that the default username is: administrator@${SSO-Domain} in majority of cases the ${SSO-Domain} is "vsphere.local". But our code (and what virsh displays then) says it's just "administrator". This is wrong also from a different POV: the username must contain the suffix no

Re: [PATCH] meson: Don't build tests when CLang lacks -fsemantic-interposition

2023-03-24 Thread Martin Kletzander
On Fri, Mar 24, 2023 at 11:35:52AM +0100, Michal Prívozník wrote: On 3/24/23 08:33, Martin Kletzander wrote: On Tue, Mar 21, 2023 at 05:47:19PM +0100, Michal Privoznik wrote: There are some CLang versions that do not support -fsemantic-interposition. If that's the case, the code is optimized

Re: [PATCH] meson: Don't build tests when CLang lacks -fsemantic-interposition

2023-03-24 Thread Michal Prívozník
On 3/24/23 08:33, Martin Kletzander wrote: > On Tue, Mar 21, 2023 at 05:47:19PM +0100, Michal Privoznik wrote: >> There are some CLang versions that do not support >> -fsemantic-interposition. If that's the case, the code is >> optimized so much that our mocking no longer works. >> >> Therefore,

[PATCH] ci: Refresh CI files with current lcitool

2023-03-24 Thread Martin Kletzander
This updates to FreeBSD 12.4 which has clang that supports -fsemantic-interposition, plus of course updates the system. Signed-off-by: Martin Kletzander --- ci/gitlab/builds.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index

Re: [PATCH] meson: Don't build tests when CLang lacks -fsemantic-interposition

2023-03-24 Thread Martin Kletzander
On Tue, Mar 21, 2023 at 05:47:19PM +0100, Michal Privoznik wrote: There are some CLang versions that do not support -fsemantic-interposition. If that's the case, the code is optimized so much that our mocking no longer works. Therefore, disable tests and produce a warning. Signed-off-by: