Re: [PATCH] virauth: Report error on empty auth result

On Mon, Mar 27, 2023 at 01:21:51PM +0200, Michal Privoznik wrote: When opening a connection, it may be necessary to provide user credentials, or some additional info (e.g. whether to trust an ssh key). We have a special API for that: virConnectOpenAuth() where and additional callback can be passe

Re: [PATCH] tests: Compile virgdbusmock.c with GIO_COMPILATION enabled

On Mon, Mar 27, 2023 at 02:47:40PM +0200, Michal Privoznik wrote: There are couple of g_dbus_*() functions we provide an alternative implementation for in our virgdbusmock.c. However, these functions are declared in gio/gdbusconnection.h as: GIO_AVAILABLE_IN_ALL GDBusConnection *g_bus_get_syn

Re: [RFC] Seeking advice on support for generic vDPA device

On Sat, Mar 25, 2023 at 9:14 PM jiangdongxu wrote: > > vDPA devices allow high-performance devices in a virtual machine by > providing a wire-speed data path. These devices require a vendor-specific host > driver but the data path follows the virtio specification. > > The support for generic-vdpa

Possible Bug in Libvirt::StorageVol in ruby-libvirt?

Dear Support Team I want to kindly ask for help I am running almalinux with the packages libvirt libvirt-devel I installed the gem 'libvirt-ruby' When running the following script the execution breaks with: ./libvirt-test.rb:25:in `name': Expected Connection object (ArgumentError) from ./libvirt-

[libvirt PATCH 0/3] qemu: Fix firmware selection backwards compatibility

Andrea Bolognani (3): tests: Introduce DO_TEST_CAPS_ARCH_LATEST_ABI_UPDATE() tests: Add firmware-auto-efi-abi-update-aarch64 test case qemu: Default to raw firmware for existing domains src/qemu/qemu_domain.c | 17 + ...irmware-auto-efi-aarch64.aa

[libvirt PATCH 3/3] qemu: Default to raw firmware for existing domains

The changes to the output files are the exact opposite of those from commit 22207713cf8e: this is proof that the fix is working as intended, and that existing domains will keep using raw firmware images regardless of whether or not qcow2 images are available on the system and have higher priority.

[libvirt PATCH 2/3] tests: Add firmware-auto-efi-abi-update-aarch64 test case

The input is identical to that of the existing firmware-auto-efi-aarch64 test, but in this case we want to cover the scenario in which that input is used to define a new domain rather than loading the definition of an existing domain from disk. Signed-off-by: Andrea Bolognani --- ...efi-abi-upda

[libvirt PATCH 1/3] tests: Introduce DO_TEST_CAPS_ARCH_LATEST_ABI_UPDATE()

Signed-off-by: Andrea Bolognani --- tests/qemuxml2argvtest.c | 5 + tests/qemuxml2xmltest.c | 5 + 2 files changed, 10 insertions(+) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index bd3f46fbe0..cc85790017 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2ar

Re: [PATCH v1 0/4] Introduce virsh hypervisor-cpu-models

On 3/22/23 2:11 PM, Collin Walling wrote: On 3/22/23 1:00 PM, Tim Wiederhake wrote: On Wed, 2023-03-22 at 11:39 -0400, Collin Walling wrote: Allows for the query of hypervisor-known CPU models via the simple command: virsh hypervisor-cpu-models. For the QEMU driver, the models are queried via t

Re: [libvirt PATCH] NEWS: document my user-visible bugfixes

On Mon, Mar 27, 2023 at 01:02:37PM +0200, Ján Tomko wrote: > + * rpc: fix typo in admin code generation > + > +Fix the bug in the remote `virt-admin` code generator, that resulted > +in a crash. Introduced in libvirt 9.1.0. > + > + * qemu: relax shared memory check for vhostuser daemons >

Re: [libvirt PATCH 00/51] Use permutable format strings in translations

On Mon, Mar 27, 2023 at 01:08:09PM +0200, Jiri Denemark wrote: > On Fri, Mar 10, 2023 at 17:14:32 +, Daniel P. Berrangé wrote: > > Even if fixed, it might be worth switching the .pot file anyway, but > > this can't be done without us bulk updating the translations, and > > bulk re-importing the

Re: [libvirt PATCH 00/51] Use permutable format strings in translations

On Mon, Mar 27, 2023 at 01:08:09PM +0200, Jiri Denemark wrote: > On Fri, Mar 10, 2023 at 17:14:32 +, Daniel P. Berrangé wrote: > > Even if fixed, it might be worth switching the .pot file anyway, but > > this can't be done without us bulk updating the translations, and > > bulk re-importing the

Re: [libvirt PATCH 06/51] conf/domain_conf: Update format strings in translated messages

On Fri, Mar 10, 2023 at 05:09:22PM +0100, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/conf/domain_conf.c | 874 ++--- > 1 file changed, 391 insertions(+), 483 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > i

[PATCH] tests: Compile virgdbusmock.c with GIO_COMPILATION enabled

There are couple of g_dbus_*() functions we provide an alternative implementation for in our virgdbusmock.c. However, these functions are declared in gio/gdbusconnection.h as: GIO_AVAILABLE_IN_ALL GDBusConnection *g_bus_get_sync (GBusTypebus_type,

[PATCH] virauth: Report error on empty auth result

When opening a connection, it may be necessary to provide user credentials, or some additional info (e.g. whether to trust an ssh key). We have a special API for that: virConnectOpenAuth() where and additional callback can be passed. This callback is then called with _virConnectCredential struct fi

Re: [libvirt PATCH 00/51] Use permutable format strings in translations

On Fri, Mar 10, 2023 at 17:14:32 +, Daniel P. Berrangé wrote: > Even if fixed, it might be worth switching the .pot file anyway, but > this can't be done without us bulk updating the translations, and > bulk re-importing them, which will be challenging. We'll almost > certainly want to try this

[libvirt PATCH] NEWS: document my user-visible bugfixes

Signed-off-by: Ján Tomko --- NEWS.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index c187d35d3b..cc32fb948e 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -60,6 +60,17 @@ v9.2.0 (unreleased) so, as affinity to NUMA nodes inaccessible to emulator thread mi

Re: [libvirt PATCH] qemu_snapshot: external: don't error out when updating metadata

On a Monday in 2023, Pavel Hrdina wrote: Attaching disk into running VM the offilne definition may not be updated and we will end up with that disk existing only in live definition. Creating snapshot with this state saves both live and offline definition into snapshot metadata. When we are delet

[libvirt PATCH] qemu_snapshot: external: don't error out when updating metadata

Attaching disk into running VM the offilne definition may not be updated and we will end up with that disk existing only in live definition. Creating snapshot with this state saves both live and offline definition into snapshot metadata. When we are deleting an external snapshot we are updating th

Re: libvirt-shim: libvirt to run qemu in a different container

On Sun, Mar 26, 2023 at 03:57:00PM +0300, Itamar Holder wrote: > Hey all, > > I'm Itamar Holder, a Kubevirt developer. > Lately we came across a problem w.r.t. properly supporting VMs with > dedicated CPUs on Kubernetes. The full details can be seen in this PR >

Re: libvirt-shim: libvirt to run qemu in a different container

On Sun, Mar 26, 2023 at 03:57:00PM +0300, Itamar Holder wrote: Hey all, I'm Itamar Holder, a Kubevirt developer. Lately we came across a problem w.r.t. properly supporting VMs with dedicated CPUs on Kubernetes. The full details can be seen in this PR

Entering freeze for libvirt-9.2.0

I have just tagged v9.2.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

libvirt-shim: libvirt to run qemu in a different container

Hey all, I'm Itamar Holder, a Kubevirt developer. Lately we came across a problem w.r.t. properly supporting VMs with dedicated CPUs on Kubernetes. The full details can be seen in this PR [1], but to make a very long story short, we would like to us

[RFC] Seeking advice on support for generic vDPA device

vDPA devices allow high-performance devices in a virtual machine by providing a wire-speed data path. These devices require a vendor-specific host driver but the data path follows the virtio specification. The support for generic-vdpa device was recently added to qemu in v8.0.0-rc version. https: