Re: [PATCH 00/31] qemu capability testing cleanups and improvements (part 3)

On a Thursday in 2023, Peter Krempa wrote: This series applies on top of 'part2' fetch everything from my repo: git fetch https://gitlab.com/pipo.sk/libvirt.git ppc-send In this part: - caps code is refactored to simplify error paths - vircapstest is removed - qemumemlocktest is converted to

Re: [PATCH 07/31] virQEMUCapsInitGuest: Refactor cleanup and remove return value

On a Thursday in 2023, Peter Krempa wrote: Use automatic pointer freeing, remove 'ret' variable and also remove return value completely. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git

Re: [libvirt PATCH 0/3] tests: Don't use GIO_COMPILATION

On Thu, Mar 30, 2023 at 04:59:38PM +0200, Ján Tomko wrote: > On a Thursday in 2023, Andrea Bolognani wrote: > > tests: Drop dead code > > tests: Don't build virgdbusmock on Windows > > tests: Don't use GIO_COMPILATION > > > > tests/meson.build | 11 ++- > > tests/virfirewalltest.c

Re: [libvirt PATCH 0/3] tests: Don't use GIO_COMPILATION

On a Thursday in 2023, Andrea Bolognani wrote: See patch 3/3 for the rationale. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/823120265 Andrea Bolognani (3): tests: Drop dead code tests: Don't build virgdbusmock on Windows tests: Don't use GIO_COMPILATION tests/meson.build

Re: [libvirt PATCH 0/3] tests: Don't use GIO_COMPILATION

On 3/30/23 9:39 AM, Andrea Bolognani wrote: See patch 3/3 for the rationale. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/823120265 Andrea Bolognani (3): tests: Drop dead code tests: Don't build virgdbusmock on Windows tests: Don't use GIO_COMPILATION

Re: [PATCH 00/24] qemu capability testing cleanups and improvements (part 2)

On a Thursday in 2023, Peter Krempa wrote: This part focuses on getting rid of the fake-caps infrastructure for testing qemu accelerated via HVF on OSX. Note: The test data that I'm using are based on the linux test data we have in the repository. It'll be great to get a real dump of qemu

Re: [PATCH 21/24] qemuxml2(argv|xml): Convert "hvf-aarch64-virt-headless" test case to real capapilities

*capabilities Jano On a Thursday in 2023, Peter Krempa wrote: Rather than using fake data and faking the host use the newly introduced support for test variants to test the OSX HVF qemu version with real data. Signed-off-by: Peter Krempa --- ...-aarch64-virt-headless.aarch64-latest.args | 53

Re: [PATCH 20/24] qemuxml2(argv|xml): Convert "hvf-x86_64-q35-headless" test case to real capapilities

s/capapilities/capabilities/ in the commit summary Jano On a Thursday in 2023, Peter Krempa wrote: Rather than using fake data and faking the host use the newly introduced support for test variants to test the OSX HVF qemu version with real data. Signed-off-by: Peter Krempa ---

Re: [PATCH 08/24] tests: qemucapabilitiesdata: Add README file

On a Thursday in 2023, Peter Krempa wrote: Explain what the purpose of these files is as well as how they are named, captured, used and modified. Signed-off-by: Peter Krempa --- tests/qemucapabilitiesdata/README.rst | 94 +++ tests/qemucapabilitiestest.c | 18

[libvirt PATCH 2/3] tests: Don't build virgdbusmock on Windows

All of the tests that use this mock (networkxml2firewalltest, virsystemdtest, virpolkittest) are either no-ops on Windows, or are not compiled at all on the target. Signed-off-by: Andrea Bolognani --- tests/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[libvirt PATCH 3/3] tests: Don't use GIO_COMPILATION

This flag is intended to be used exclusively in the context of building GLib itself and should not be passed to the compiler by a third-party project such as libvirt. Reverts: 77d1fa5 ("tests: Compile virgdbusmock.c with GIO_COMPILATION enabled") Signed-off-by: Andrea Bolognani ---

[libvirt PATCH 1/3] tests: Drop dead code

Left behind by commit 35eb484 ("tests: remove firewalld backend tests from virfirewalltest.c"). Signed-off-by: Andrea Bolognani --- tests/virfirewalltest.c | 4 1 file changed, 4 deletions(-) diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c index 51c8006331..e676a434c8

[libvirt PATCH 0/3] tests: Don't use GIO_COMPILATION

See patch 3/3 for the rationale. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/823120265 Andrea Bolognani (3): tests: Drop dead code tests: Don't build virgdbusmock on Windows tests: Don't use GIO_COMPILATION tests/meson.build | 11 ++-

[PATCH 11/31] tests: Remove 'vircapstest'

Technically for the LXC capabilities lookup we don't have another test case, but given that it shares the implementation with qemu and thus the only thing we are missing out on is testing of filling of the fake capabilities which doesn't make sense testing. Remove vircapstest. Signed-off-by:

[PATCH 28/31] qemuValidateDomainDefPSeriesFeature: Simplify machine validation logic

Return early and reformat the error message. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 83e4ca757e..793990c4ca 100644 ---

[PATCH 30/31] qemuxml2argvtest: Use real capabilities for negative test cases for ppc64 architecture

Convert the last outstanding test cases for ppc64 to use real capabilities. In couple cases this actually fixes the test case to test what it was intending to do. Signed-off-by: Peter Krempa --- ...r => aarch64-gic-not-arm.ppc64-latest.err} | 0 ... cpu-hotplug-granularity.ppc64-latest.err} |

[PATCH 26/31] qemuValidateDomainDefPSeriesFeature: Remove obsolete checks

The features: QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE QEMU_CAPS_MACHINE_PSERIES_CAP_HTM QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC QEMU_CAPS_MACHINE_PSERIES_CAP_IBS are supported

[PATCH 23/31] qemuxml2xmltest: Modernize all remaining 'ppc64' test cases

Switch them to use latest caps. Signed-off-by: Peter Krempa --- ...memory-hotplug-nvdimm-ppc64-abi-update.xml | 3 +- ...ory-hotplug-nvdimm-ppc64.ppc64-latest.xml} | 3 +- ...memory-hotplug-ppc64-nonuma-abi-update.xml | 3 ++ ...mory-hotplug-ppc64-nonuma.ppc64-latest.xml | 42

[PATCH 24/31] qemuxml2argvtest: Add '4.2.0' version of 'pseries-features' test case

Add an example case showing that every feature in the 'pseries-features' test works also with the oldest supported qemu version. Signed-off-by: Peter Krempa --- .../pseries-features.ppc64-4.2.0.args | 30 +++ tests/qemuxml2argvtest.c | 1 + 2 files

[PATCH 22/31] qemuxml2argvtest: Modernize all 'ppc64' remaining test cases

Switch them to use latest caps. Signed-off-by: Peter Krempa --- ...emory-hotplug-nvdimm-ppc64-abi-update.args | 13 ...ry-hotplug-nvdimm-ppc64.ppc64-latest.args} | 13 ...emory-hotplug-ppc64-nonuma-abi-update.args | 15 ++ ...ry-hotplug-ppc64-nonuma.ppc64-latest.args}

[PATCH 13/31] testQemuGetRealCaps: Integrate fetching of QMP schema

Move the lookup of the corresponding QMP schema used for validation of QMP commands from 'testCompareXMLToArgvValidateSchema' to testQemuGetRealCaps as an optional step. This will simplify using QMP command validation in other tests which will use testQemuGetRealCaps. 'testutilsqemuschema'

[PATCH 21/31] qemuhotplugtest: Make the test more useful by validating used commands against QMP schema

qemuhotplugtest validates only that a given command is used but not the arguments of the command. With this patch we'll validate the arguments against the QMP schema thus we can catch possible issues with deprecated commands. Signed-off-by: Peter Krempa --- tests/qemuhotplugtest.c | 5 +++-- 1

[PATCH 12/31] testutilsqemu: Extract fetching of real virQEMUCaps into testQemuGetRealCaps

'testQemuInfoInitArgs' contains the logic to fetch and use the capabilities for tests using 'struct testQemuInfo'. As in certain cases use of 'struct testQemuInfo' is an overkill extract the code to fetch the capabilities into a standalone helper. Signed-off-by: Peter Krempa ---

[PATCH 31/31] testutilsqemu: Drop fake capability testing infrastructure for 'ppc64'

Now that all tests were converted to use real capabilities we don't need it any more. Remove it so that no new tests are added with it. Signed-off-by: Peter Krempa --- tests/testutilsqemu.c | 16 1 file changed, 16 deletions(-) diff --git a/tests/testutilsqemu.c

[PATCH 29/31] qemuValidateDomainDefPSeriesFeature: Simplify feature validation

Unify validation of VIR_DOMAIN_FEATURE_HTM, VIR_DOMAIN_FEATURE_NESTED_HV, VIR_DOMAIN_FEATURE_CCF_ASSIST and remove temporary string. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 33 ++--- 1 file changed, 6 insertions(+), 27 deletions(-) diff --git

[PATCH 16/31] qemuhotplugtestdomain: Move all i686 test cases to x86_64

Signed-off-by: Peter Krempa --- tests/qemuhotplugtestdomains/qemuhotplug-disk-cdrom.xml | 4 ++-- .../qemuhotplug-graphics-spice-listen-network.xml | 4 ++-- .../qemuhotplug-graphics-spice-timeout.xml| 4 ++--

[PATCH 27/31] qemu: capabilities: Retire obsolete 'pseries' capabilities

Retire: QEMU_CAPS_MACHINE_PSERIES_CAP_HPT_MAX_PAGE_SIZE QEMU_CAPS_MACHINE_PSERIES_CAP_HTM QEMU_CAPS_MACHINE_PSERIES_CAP_NESTED_HV QEMU_CAPS_MACHINE_PSERIES_CAP_CCF_ASSIST QEMU_CAPS_MACHINE_PSERIES_CAP_CFPC QEMU_CAPS_MACHINE_PSERIES_CAP_SBBC

[PATCH 15/31] qemuhotplugtest: Don't fetch capabilities when they are not used

Signed-off-by: Peter Krempa --- tests/qemuhotplugtest.c | 9 - 1 file changed, 9 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 6a36856d8a..804e32279d 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -319,7 +319,6 @@

[PATCH 25/31] qemuxml2argvtest: Drop negative test cases for 'pseries' machine features

All of the tested features are always present in the 'pseries' machine with oldest-supported qemu-4.2, thus the tests don't make sense any more. Signed-off-by: Peter Krempa --- tests/qemuxml2argvdata/pseries-features-ccf.err | 1 - tests/qemuxml2argvdata/pseries-features-ccf.xml | 14

[PATCH 19/31] qemuhotplugtest: Refactor calling of testQemuHotplugCpuPrepare

Pass in the whole struct rather than splitting out individual members. Signed-off-by: Peter Krempa --- tests/qemuhotplugtest.c | 41 ++--- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index

[PATCH 20/31] qemuhotplugtest: Use real 'latest' capabilities for hotplug testing

Rather than test with synthetic capabilities which might get outdated reuse testQemuGetRealCaps to fetch latest capabilities and use those. Signed-off-by: Peter Krempa --- tests/qemuhotplugtest.c | 231 +- .../ppc64-modern-bulk-result-conf.xml | 5

[PATCH 18/31] qemuhotplugtest: Assert QEMU_CAPS_SET_ACTION

With modern qemu we use 'set-action' instead of 'watchdog-set-action'. Switch to it so that later qemuhotplugtest can be switched to use real capabilities. Signed-off-by: Peter Krempa --- tests/qemuhotplugtest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 03/31] virCapabilitiesAllocMachines: Use NULL-terminated list as argument and return count

Simplify use of the function by determining the number of elements inside the function. Signed-off-by: Peter Krempa --- src/conf/capabilities.c| 12 +++- src/conf/capabilities.h| 2 +- src/libxl/libxl_capabilities.c | 9 + tests/testutilsqemu.c | 23

[PATCH 17/31] qemuhotplugtest: Enable 'lsilogic' SCSI controller

All real qemus support the 'lsilogic' controller and thus would pick it as the default rather than virtio-scsi. Since lsilogic is limited in some aspects we should test it with the proper default model. In the future the fake capabilities will be replaced by real capabilities so this test would

[PATCH 09/31] vircapstest: Remove 'qemu' testing

We have testing based on real capabilities in 'qemucaps2xmltest' for qemu guest related data and 'vircaps2xmltest' tests the host data gathering. The testing done here makes no sense. Signed-off-by: Peter Krempa --- tests/vircapstest.c | 74 - 1 file

[PATCH 14/31] qemumemlocktest: Use real capabilities

Use testQemuGetRealCaps to fetch real capabilities and use it in place of the faked caps. Signed-off-by: Peter Krempa --- tests/qemumemlocktest.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/tests/qemumemlocktest.c b/tests/qemumemlocktest.c

[PATCH 06/31] virQEMUCapsInitGuestFromBinary: Remove return value

The function always returns 0. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 11 --- src/qemu/qemu_capabilities.h | 8 tests/qemucaps2xmltest.c | 8 +--- 3 files changed, 9 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[PATCH 05/31] virQEMUCapsInitGuestFromBinary: Refactor cleanup

Remove useless call to virCapabilitiesFreeMachines as the pointers were cleared and the unneeded 'ret' variable. Since we don't need to clear the 'machines' pointer now, remove that as well. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 10 +- 1 file changed, 1

[PATCH 07/31] virQEMUCapsInitGuest: Refactor cleanup and remove return value

Use automatic pointer freeing, remove 'ret' variable and also remove return value completely. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

[PATCH 10/31] tests: vircaps: Remove pointless testing of virCapabilitiesHostNUMAGetCpus

The test case doesn't validate the returned map of cpus, just checks that it didn't fail. We test the returned value indirectly via qemuxml2argvtest. Signed-off-by: Peter Krempa --- tests/vircapstest.c | 26 -- 1 file changed, 26 deletions(-) diff --git

[PATCH 04/31] virQEMUCapsGetMachineTypesCaps: Remove return value

The function always returns 0. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 6355c80f30..0201f288b3 100644 ---

[PATCH 02/31] libxlCapsInitGuests: Rework insane use of ternary operators

Get rid of nested ternaries by adding a few helper variables and more explicit if conditions to fill them appropriately. Note that 'virCapabilitiesAllocMachines' doesn't require return value check any more as it can't fail. Signed-off-by: Peter Krempa --- src/libxl/libxl_capabilities.c | 38

[PATCH 08/31] virCapabilitiesFreeMachines: Remove unused function

Signed-off-by: Peter Krempa --- src/conf/capabilities.c | 19 --- src/conf/capabilities.h | 3 --- src/libvirt_private.syms | 1 - 3 files changed, 23 deletions(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 6d2f6e282d..c1d5d6cd6e 100644 ---

[PATCH 00/31] qemu capability testing cleanups and improvements (part 3)

This series applies on top of 'part2' fetch everything from my repo: git fetch https://gitlab.com/pipo.sk/libvirt.git ppc-send In this part: - caps code is refactored to simplify error paths - vircapstest is removed - qemumemlocktest is converted to use real caps - qemuhotplugtest is

[PATCH 01/31] qemu: capabilities: Drop 'kvmVersion' field

It's never set to any real value. Remove it along with the caching code. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c| 17 - src/qemu/qemu_capabilities.h| 1 - .../qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 1 -

Re: [PATCH 0/3] Fix crash when hot-unplugging a hostdev-interface

On a Thursday in 2023, Peter Krempa wrote: Peter Krempa (3): conf: Clear pointer to freed bitmap holding hostdev's 'origstates' conf: Unexport virDomainHostdevDefClear virDomainHostdevDefClear: Fix and shorten comment src/conf/domain_conf.c | 129 +++

Re: [PATCH 3/3] virDomainHostdevDefClear: Fix and shorten comment

On a Thursday in 2023, Peter Krempa wrote: There's more stuff than device info to clear nowadays. Drop the misleading comment. Shorten the comment saying that device info is freed elsewhere when 'parentnet' is present. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 8 +--- 1 file

Re: [PATCH 2/3] conf: Unexport virDomainHostdevDefClear

On a Thursday in 2023, Peter Krempa wrote: Move it before it's first usage and make it static. *its Jano Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 135 --- src/conf/domain_conf.h | 1 - src/libvirt_private.syms | 1 - 3 files

[PATCH 2/3] conf: Unexport virDomainHostdevDefClear

Move it before it's first usage and make it static. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 135 --- src/conf/domain_conf.h | 1 - src/libvirt_private.syms | 1 - 3 files changed, 69 insertions(+), 68 deletions(-) diff --git

[PATCH 1/3] conf: Clear pointer to freed bitmap holding hostdev's 'origstates'

'virDomainHostdevDefClear' must clear the pointers too as it can be invoked multiple times on the same object e.g. inside qemuDomainRemoveHostDevice once via virDomainHostdevDefFree which skips freeing the object if it's used via and thus has a 'net' definition corresponding to it, and then

[PATCH 3/3] virDomainHostdevDefClear: Fix and shorten comment

There's more stuff than device info to clear nowadays. Drop the misleading comment. Shorten the comment saying that device info is freed elsewhere when 'parentnet' is present. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-)

[PATCH 0/3] Fix crash when hot-unplugging a hostdev-interface

Peter Krempa (3): conf: Clear pointer to freed bitmap holding hostdev's 'origstates' conf: Unexport virDomainHostdevDefClear virDomainHostdevDefClear: Fix and shorten comment src/conf/domain_conf.c | 129 +++ src/conf/domain_conf.h | 1 -

Re: [PATCH 17/24] qemucapabilitiesdata: Add (fake) '+hvf' variant of x86_64 data

On Thu, Mar 30, 2023 at 10:40:37 +0100, Daniel P. Berrangé wrote: > On Tue, Mar 28, 2023 at 04:53:13PM +0200, Peter Krempa wrote: > > On Tue, Mar 21, 2023 at 16:13:22 +0100, Martin Kletzander wrote: > > > On Thu, Mar 16, 2023 at 05:11:46PM +0100, Peter Krempa wrote: > > > > The data is based on

Re: [libvirt PATCH] ci: Regenerate files

On Thu, Mar 30, 2023 at 12:01:12PM +0200, Andrea Bolognani wrote: > This unbreaks the various $CROSS-$NAME-local-env jobs. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

[libvirt PATCH] ci: Regenerate files

This unbreaks the various $CROSS-$NAME-local-env jobs. Signed-off-by: Andrea Bolognani --- Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/822671796 ci/buildenv/debian-11-cross-aarch64.sh| 4 ++-- ci/buildenv/debian-11-cross-armv6l.sh | 4 ++--

Re: [PATCH 17/24] qemucapabilitiesdata: Add (fake) '+hvf' variant of x86_64 data

On Tue, Mar 28, 2023 at 04:53:13PM +0200, Peter Krempa wrote: > On Tue, Mar 21, 2023 at 16:13:22 +0100, Martin Kletzander wrote: > > On Thu, Mar 16, 2023 at 05:11:46PM +0100, Peter Krempa wrote: > > > The data is based on the generic variant of the 7.2.0 data on x86_64. > > > > > > Only

Re: [PATCH 17/24] qemucapabilitiesdata: Add (fake) '+hvf' variant of x86_64 data

On Thu, Mar 30, 2023 at 09:11:03AM +0200, Peter Krempa wrote: > On Tue, Mar 28, 2023 at 16:53:13 +0200, Peter Krempa wrote: > > On Tue, Mar 21, 2023 at 16:13:22 +0100, Martin Kletzander wrote: > > > On Thu, Mar 16, 2023 at 05:11:46PM +0100, Peter Krempa wrote: > > > > The data is based on the

Re: [libvirt PATCH 00/51] Use permutable format strings in translations

On Mon, Mar 27, 2023 at 15:37:34 +0100, Daniel P. Berrangé wrote: > On Mon, Mar 27, 2023 at 01:08:09PM +0200, Jiri Denemark wrote: > > On Fri, Mar 10, 2023 at 17:14:32 +, Daniel P. Berrangé wrote: > > > Even if fixed, it might be worth switching the .pot file anyway, but > > > this can't be

Re: [PATCH 17/24] qemucapabilitiesdata: Add (fake) '+hvf' variant of x86_64 data

On Thu, Mar 30, 2023 at 09:11:03AM +0200, Peter Krempa wrote: On Tue, Mar 28, 2023 at 16:53:13 +0200, Peter Krempa wrote: On Tue, Mar 21, 2023 at 16:13:22 +0100, Martin Kletzander wrote: > On Thu, Mar 16, 2023 at 05:11:46PM +0100, Peter Krempa wrote: > > The data is based on the generic variant

Re: [libvirt PATCH 0/2] A few fixes in error messages

On a Thursday in 2023, Jiri Denemark wrote: These fixes were separated from my "Use permutable format strings in translations" series. There are more VIR_PCI_DEVICE_ADDRESS_FMT cases fixed here compared to the format strings series as not all of them were identified by either syntax check or

[libvirt PATCH 1/2] Drop excess whitespace from error messages

Signed-off-by: Jiri Denemark --- src/conf/domain_conf.c | 3 +-- src/util/virnetdevvportprofile.c | 3 +-- src/util/virsocketaddr.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt PATCH 2/2] Do not use VIR_PCI_DEVICE_ADDRESS_FMT in translations

xgettext cannot handle strings concatenated with cpp macros. Signed-off-by: Jiri Denemark --- src/conf/domain_conf.c | 3 +-- src/libxl/libxl_driver.c | 15 +-- src/qemu/qemu_hotplug.c | 14 -- 3 files changed, 10 insertions(+), 22 deletions(-) diff --git

[libvirt PATCH 0/2] A few fixes in error messages

These fixes were separated from my "Use permutable format strings in translations" series. There are more VIR_PCI_DEVICE_ADDRESS_FMT cases fixed here compared to the format strings series as not all of them were identified by either syntax check or libvirt-pot-check. Jiri Denemark (2): Drop

Re: [PATCH 17/24] qemucapabilitiesdata: Add (fake) '+hvf' variant of x86_64 data

On Tue, Mar 28, 2023 at 16:53:13 +0200, Peter Krempa wrote: > On Tue, Mar 21, 2023 at 16:13:22 +0100, Martin Kletzander wrote: > > On Thu, Mar 16, 2023 at 05:11:46PM +0100, Peter Krempa wrote: > > > The data is based on the generic variant of the 7.2.0 data on x86_64. > > > > > > Only