Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Laine Stump
On 4/18/23 1:18 PM, Nick Guenther wrote: April 18, 2023 3:37 AM, "Peter Krempa" wrote: cases of code style not being aligned from what libvirt does normally ... I'm very happy to conform my style as needed. I just want my users to be able to use libvirt (if they can't I'll teach them to

Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Nick Guenther
April 18, 2023 3:37 AM, "Peter Krempa" wrote: > cases of code style not being aligned from what libvirt does normally ... I'm very happy to conform my style as needed. I just want my users to be able to use libvirt (if they can't I'll teach them to use qemu directly I suppose but that's

Re: [libvirt] [RFC] support vhost-user-scsi configuration

2023-04-18 Thread wangjian
On 2023/4/18 21:50, wangjian (AN) wrote: > > On 4/15/23 15:48, wangjian (AN) wrote: >> Hi Guys, >> >> >> >> Currently qemu and spdk already support vhost-user-scsi, but there is >> no vhost-user-scsi configuration in libvirt. >> >> We hope that libvirt supports the following configurations

Re: [PATCH] meson: Work around configure_file(copy:true) deprecation

2023-04-18 Thread Michal Prívozník
On 3/23/23 17:01, Michal Privoznik wrote: > Polite ping. Michal

Re: [libvirt PATCH] conf: Restrict use of to the passt backend

2023-04-18 Thread Laine Stump
On 4/18/23 9:43 AM, Ján Tomko wrote: On a Tuesday in 2023, Andrea Bolognani wrote: On Tue, Apr 18, 2023 at 03:19:45PM +0200, Ján Tomko wrote: On a Tuesday in 2023, Andrea Bolognani wrote: > That's already the case in practice, but it's a better > experience for the user if we reject this

Re: [libvirt PATCH] conf: Restrict use of to the passt backend

2023-04-18 Thread Andrea Bolognani
On Tue, Apr 18, 2023 at 03:43:41PM +0200, Ján Tomko wrote: > On a Tuesday in 2023, Andrea Bolognani wrote: > > On Tue, Apr 18, 2023 at 03:19:45PM +0200, Ján Tomko wrote: > > > On a Tuesday in 2023, Andrea Bolognani wrote: > > > > That's already the case in practice, but it's a better > > > >

Re: [libvirt PATCH] conf: Restrict use of to the passt backend

2023-04-18 Thread Ján Tomko
On a Tuesday in 2023, Andrea Bolognani wrote: On Tue, Apr 18, 2023 at 03:19:45PM +0200, Ján Tomko wrote: On a Tuesday in 2023, Andrea Bolognani wrote: > That's already the case in practice, but it's a better > experience for the user if we reject this configuration > outright instead of

Re: [libvirt PATCH] conf: Restrict use of to the passt backend

2023-04-18 Thread Andrea Bolognani
On Tue, Apr 18, 2023 at 03:19:45PM +0200, Ján Tomko wrote: > On a Tuesday in 2023, Andrea Bolognani wrote: > > That's already the case in practice, but it's a better > > experience for the user if we reject this configuration > > outright instead of silently ignoring part of it. > > > >

Re: [libvirt PATCH] conf: Restrict use of to the passt backend

2023-04-18 Thread Ján Tomko
On a Tuesday in 2023, Andrea Bolognani wrote: That's already the case in practice, but it's a better experience for the user if we reject this configuration outright instead of silently ignoring part of it. Signed-off-by: Andrea Bolognani --- src/conf/domain_validate.c| 9

Re: [PATCH 0/5] qemu: Fix chardev hotplug and deny live detach

2023-04-18 Thread Ján Tomko
On a Wednesday in 2023, Michal Privoznik wrote: While trying to make live detach of work, I've accumulated couple of patches. The most reasonable ones made it into this patch set as paches 1-4. And after nearly losing my sanity, I've decided it's not worth supporting live detach of since

Re: [PATCH 1/5] qemuDomainChrInsertPreAlloced: Fix adding implicit console

2023-04-18 Thread Ján Tomko
On a Wednesday in 2023, Michal Privoznik wrote: When hotpluging a device, we might need to add a device with it (because of some crazy backcompat). Now, hotplugging is done in several phases. In one of them, qemuDomainChrPreInsert() allocates space for both devices, and then

Re: [PATCH] tests: viracpitest only works on little endian

2023-04-18 Thread Michal Prívozník
On 4/18/23 11:53, Boris Fiuczynski wrote: > Commit fc216db4fb789cbd309 introduced a mocked test with binary test data > which fails on big endian machines. > Therefore build the viracpitest test only on little endian machines. > > Fixes: fc216db4fb789cbd30917be036d0b94d965bdf7f > >

Re: [PATCH] tests: viracpitest only works on little endian

2023-04-18 Thread Marc Hartmayer
Boris Fiuczynski writes: > Commit fc216db4fb789cbd309 introduced a mocked test with binary test data > which fails on big endian machines. > Therefore build the viracpitest test only on little endian machines. > > Fixes: fc216db4fb789cbd30917be036d0b94d965bdf7f > > Signed-off-by: Boris

[PATCH] tests: viracpitest only works on little endian

2023-04-18 Thread Boris Fiuczynski
Commit fc216db4fb789cbd309 introduced a mocked test with binary test data which fails on big endian machines. Therefore build the viracpitest test only on little endian machines. Fixes: fc216db4fb789cbd30917be036d0b94d965bdf7f Signed-off-by: Boris Fiuczynski --- tests/meson.build | 7 ++-

Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-18 Thread Peter Maydell
On Tue, 18 Apr 2023 at 09:05, Richard Henderson wrote: > > On 4/17/23 18:40, Peter Maydell wrote: > > @@ -219,8 +221,8 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool > > value, Error **errp) > > { > > TCGState *s = TCG_STATE(obj); > > s->one_insn_per_tb = value; > > -

[libvirt PATCH] conf: Restrict use of to the passt backend

2023-04-18 Thread Andrea Bolognani
That's already the case in practice, but it's a better experience for the user if we reject this configuration outright instead of silently ignoring part of it. Signed-off-by: Andrea Bolognani --- src/conf/domain_validate.c| 9 +

[PATCH 2/3] qemu: migration: implement zstd compression

2023-04-18 Thread Oleg Vasilev
QEMU now supports multifd-compression=zstd for migration with enabled multifd. Bring the support to libvirt as well. Signed-off-by: Oleg Vasilev --- include/libvirt/libvirt-domain.h | 10 ++ src/qemu/qemu_migration.h| 1 + src/qemu/qemu_migration_params.c | 32

[PATCH 0/3] qemu: migration: implement zstd compression

2023-04-18 Thread Oleg Vasilev
QEMU now supports multifd-compression=zstd for migration with enabled multifd. Bring the support to libvirt as well. Claudio Fontana (1): qemu: migration: expose qemuMigrationParamsSetString Oleg Vasilev (2): qemu: migration: implement zstd compression tests: qemumigparams: test for zstd

[PATCH 1/3] qemu: migration: expose qemuMigrationParamsSetString

2023-04-18 Thread Oleg Vasilev
From: Claudio Fontana change from static to external linkage, and move the function close to the other similar ones, near qemuMigrationParamsSetULL. Signed-off-by: Claudio Fontana Signed-off-by: Oleg Vasilev --- src/qemu/qemu_migration_params.c | 47 +++-

[PATCH 3/3] tests: qemumigparams: test for zstd compression

2023-04-18 Thread Oleg Vasilev
Here we add one more way to test migration parameters, namely: from vir params. This allows to test the logic of (libvirt) compression->(qemu) multifd-compression Signed-off-by: Oleg Vasilev --- tests/qemumigparamsdata/zstd.json | 4 ++ tests/qemumigparamsdata/zstd.reply | 7 +++

Re: [PATCH V2 0/3] Change default machine type for ARM and RISC-V

2023-04-18 Thread Andrea Bolognani
On Mon, Apr 17, 2023 at 10:52:01AM -0600, Jim Fehlig wrote: > Jim Fehlig (3): > qemu: Change default machine type for ARM > qemu: Change default machine type for RISC-V > NEWS: Mention change of default machine type for ARM and RISC-V Nit in 3/3 to be taken care of before pushing.

Re: [PATCH V2 3/3] NEWS: Mention change of default machine type for ARM and RISC-V

2023-04-18 Thread Andrea Bolognani
On Mon, Apr 17, 2023 at 10:52:04AM -0600, Jim Fehlig wrote: > * **Improvements** > > +* qemu: Change default machine type for ARM and RISC-V > + > +ARM and RISC-V architectures now use the ``virt`` machine type by > default. > +The previous defaults were nearly unusable and had to be

Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Daniel P . Berrangé
On Tue, Apr 18, 2023 at 02:59:26AM -0400, Nick Guenther wrote: > The qemu driver creates IPC sockets using absolute paths, > but under POSIX socket paths are constrained pretty tightly. > On systems with homedirs on an unusual mount point, like > network homedirs, or just particularly long

Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-18 Thread Richard Henderson
On 4/17/23 18:40, Peter Maydell wrote: The 'singlestep' member of StatusInfo has never done what the QMP documentation claims it does. What it actually reports is whether TCG is working in "one guest instruction per translation block" mode. We no longer need this field for the HMP 'info

Re: [PATCH v3 07/10] accel/tcg: Report one-insn-per-tb in 'info jit', not 'info status'

2023-04-18 Thread Richard Henderson
On 4/17/23 18:40, Peter Maydell wrote: Currently we report whether the TCG accelerator is in 'one-insn-per-tb' mode in the 'info status' output. This is a pretty minor piece of TCG specific information, and we want to deprecate the 'singlestep' field of the associated QMP command. Move the

Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-18 Thread Richard Henderson
On 4/17/23 18:40, Peter Maydell wrote: The only place left that looks at the old 'singlestep' global variable is the TCG curr_cflags() function. Replace the old global with a new 'one_insn_per_tb' which is defined in tcg-all.c and declared in accel/tcg/internal.h. This keeps it restricted to

Re: [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global

2023-04-18 Thread Richard Henderson
On 4/17/23 18:40, Peter Maydell wrote: @@ -219,8 +221,8 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool value, Error **errp) { TCGState *s = TCG_STATE(obj); s->one_insn_per_tb = value; -/* For the moment, set the global also: this changes the behaviour */ -

Re: [libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Peter Krempa
On Tue, Apr 18, 2023 at 02:59:26 -0400, Nick Guenther wrote: > The qemu driver creates IPC sockets using absolute paths, > but under POSIX socket paths are constrained pretty tightly. > On systems with homedirs on an unusual mount point, like > network homedirs, or just particularly long

[libvirt PATCH] qemu: Allow sockets in long or deep paths.

2023-04-18 Thread Nick Guenther
The qemu driver creates IPC sockets using absolute paths, but under POSIX socket paths are constrained pretty tightly. On systems with homedirs on an unusual mount point, like network homedirs, or just particularly long usernames, this could make starting VMs under qemu:///session impossible.