Re: [PATCH V3 0/3] migration: add qemu parallel migration options

2023-04-25 Thread Jiang Jiacheng
On 2023/4/24 18:57, Jiri Denemark wrote: > On Fri, Apr 21, 2023 at 17:39:12 +0800, Jiang Jiacheng wrote: >> >> Thank you for your reply and review, I'd appreciate for you to do that. >> >> And I'd also like to confirm that we have the following usages after the >> modification. >> for non-parallel

Re: [libvirt PATCH] run: add ability to set selinux context

2023-04-25 Thread Erik Skultety
On Tue, Apr 25, 2023 at 10:40:45AM -0500, Jonathon Jongsma wrote: > On 4/25/23 9:43 AM, Jonathon Jongsma wrote: > > On 4/25/23 8:11 AM, Erik Skultety wrote: > > > On Mon, Apr 24, 2023 at 03:50:48PM -0500, Jonathon Jongsma wrote: > > > > When running libvirt from the build directory with the 'run'

Re: [libvirt PATCH] run: add ability to set selinux context

2023-04-25 Thread Erik Skultety
On Tue, Apr 25, 2023 at 09:43:38AM -0500, Jonathon Jongsma wrote: > On 4/25/23 8:11 AM, Erik Skultety wrote: > > On Mon, Apr 24, 2023 at 03:50:48PM -0500, Jonathon Jongsma wrote: > > > When running libvirt from the build directory with the 'run' script, it > > > will run as unconfined_t. This can

Re: [libvirt PATCH] run: add ability to set selinux context

2023-04-25 Thread Jonathon Jongsma
On 4/25/23 9:43 AM, Jonathon Jongsma wrote: On 4/25/23 8:11 AM, Erik Skultety wrote: On Mon, Apr 24, 2023 at 03:50:48PM -0500, Jonathon Jongsma wrote: When running libvirt from the build directory with the 'run' script, it will run as unconfined_t. This can result in unexpected behavior when

Re: [libvirt PATCH] run: add ability to set selinux context

2023-04-25 Thread Jonathon Jongsma
On 4/25/23 8:11 AM, Erik Skultety wrote: On Mon, Apr 24, 2023 at 03:50:48PM -0500, Jonathon Jongsma wrote: When running libvirt from the build directory with the 'run' script, it will run as unconfined_t. This can result in unexpected behavior when selinux is enforcing due to the fact that the

Re: [libvirt PATCH] run: add ability to set selinux context

2023-04-25 Thread Erik Skultety
On Mon, Apr 24, 2023 at 03:50:48PM -0500, Jonathon Jongsma wrote: > When running libvirt from the build directory with the 'run' script, it > will run as unconfined_t. This can result in unexpected behavior when > selinux is enforcing due to the fact that the selinux policies are > written

Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-25 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 25 Apr 2023 at 13:10, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > -# Notes: @singlestep is enabled through the GDB stub >> > +# Notes: @singlestep is enabled on the command line with >> > +#'-accel tcg,one-insn-per-tb=on', or with the

Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

2023-04-25 Thread Peter Maydell
On Tue, 25 Apr 2023 at 13:10, Markus Armbruster wrote: > > Peter Maydell writes: > > > -# Notes: @singlestep is enabled through the GDB stub > > +# Notes: @singlestep is enabled on the command line with > > +#'-accel tcg,one-insn-per-tb=on', or with the HMP > > +#

Entering freeze for libvirt-9.3.0

2023-04-25 Thread Jiri Denemark
I have just tagged v9.3.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

[PATCH] docs: Fix missing backtick in formatdomain.rst

2023-04-25 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- Pushed as trivial docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 8420f5f99c3a..3b9251547e84 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@

Re: [PATCH v2 5/9] qemu: Deny all but VFIO PCI backends in hostdev prepare phase

2023-04-25 Thread Martin Kletzander
On Tue, Apr 25, 2023 at 10:56:43AM +0200, Michal Prívozník wrote: On 4/24/23 13:11, Martin Kletzander wrote: On Mon, Apr 24, 2023 at 12:41:44PM +0200, Michal Privoznik wrote: We used to support KVM and VFIO style of PCI assignment. The former was dropped in v5.7.0-rc1~103 and thus we only

Re: [PATCH v2 5/9] qemu: Deny all but VFIO PCI backends in hostdev prepare phase

2023-04-25 Thread Michal Prívozník
On 4/24/23 13:11, Martin Kletzander wrote: > On Mon, Apr 24, 2023 at 12:41:44PM +0200, Michal Privoznik wrote: >> We used to support KVM and VFIO style of PCI assignment. The >> former was dropped in v5.7.0-rc1~103 and thus we only support >> VFIO. All other backends lead to an error (see >>

Re: [PATCH 0/2] lxc: Couple of almost trivial fixes

2023-04-25 Thread Ján Tomko
On a Tuesday in 2023, Michal Privoznik wrote: *** BLURB HERE *** Michal Prívozník (2): lxc: Make lxcCreateHostdevDef() less versatile lxc: Fix access to hostdev capabilities src/lxc/lxc_controller.c | 2 +- src/lxc/lxc_hostdev.c| 4 ++-- src/lxc/lxc_native.c | 14 +- 3

[PATCH 0/2] lxc: Couple of almost trivial fixes

2023-04-25 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (2): lxc: Make lxcCreateHostdevDef() less versatile lxc: Fix access to hostdev capabilities src/lxc/lxc_controller.c | 2 +- src/lxc/lxc_hostdev.c| 4 ++-- src/lxc/lxc_native.c | 14 +- 3 files changed, 8 insertions(+), 12

[PATCH 1/2] lxc: Make lxcCreateHostdevDef() less versatile

2023-04-25 Thread Michal Privoznik
Usually, we want a function to be as reusable as possible. But in this specific case, when it's used just once we don't need that. The lxcCreateHostdevDef() function is meant to create a hostdev. The first argument selects the hostdev mode (caps/subsys) and the second argument selects the type of

[PATCH 2/2] lxc: Fix access to hostdev capabilities

2023-04-25 Thread Michal Privoznik
In a few places, where a capabilities is processed, a wrong union member is access: def->source.subsys.type instead of def->source.caps.type. Fortunately, both union members have .type as the very first member so no real harm is done. Nevertheless, we should access the correct union member.

Re: [PATCH v2] vfio/pci: Propagate ACPI notifications to user-space via eventfd

2023-04-25 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Grzegorz-Jaszczyk/vfio-pci-Propagate-ACPI-notifications-to-user-space-via-eventfd/20230425-002935 base

Re: [PATCH v2] vfio/pci: Propagate ACPI notifications to user-space via eventfd

2023-04-25 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Grzegorz-Jaszczyk/vfio-pci-Propagate-ACPI-notifications-to-user-space-via-eventfd/20230425-002935 base

Re: [PATCH v2] vfio/pci: Propagate ACPI notifications to user-space via eventfd

2023-04-25 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Grzegorz-Jaszczyk/vfio-pci-Propagate-ACPI-notifications-to-user-space-via-eventfd/20230425-002935 base