Re: [libvirt PATCH 06/28] util: make netfilter action a proper typedefed (virFirewall) enum

On 5/3/23 11:59 AM, Daniel P. Berrangé wrote: On Sun, Apr 30, 2023 at 11:19:21PM -0400, Laine Stump wrote: and take advantage of this to replace all the ternary operators when calling virFirewallAddRule() with virIptablesActionTypeToString(). (NB: the VIR_ENUM declaration uses

Re: [libvirt PATCH 05/28] util: move backend-agnostic virNetfilter*() functions to their own file

On 5/3/23 11:56 AM, Daniel P. Berrangé wrote: On Sun, Apr 30, 2023 at 11:19:20PM -0400, Laine Stump wrote: These function are all moved into virnetfilter.[ch]. The only functions from viriptables.[ch] that are still called from the consumer (network bridge driver) are

Re: [libvirt PATCH 04/28] util: rename iptables helpers that will become the frontend for ip

On 5/3/23 11:54 AM, Daniel P. Berrangé wrote: On Sun, Apr 30, 2023 at 11:19:19PM -0400, Laine Stump wrote: These toplevel functions have no iptables-specific code, except that they each call a lower-level internal function that *is* iptables specific. As a preparation to supporting use of

Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

On 5/4/23 4:33 AM, Andrea Bolognani wrote: On Wed, May 03, 2023 at 04:26:21PM +0100, Daniel P. Berrangé wrote: On Sun, Apr 30, 2023 at 11:19:30PM -0400, Laine Stump wrote: and include it in BuildRequires and Requires of the rpm specfile to make sure it's available when doing official distro

Re: [libvirt PATCH] util: Improve comment for workaround

On a Thursday in 2023, Andrea Bolognani wrote: Now that a version of GLib that contains the fix has been released, it's more useful to record that information. Adding a TODO annotation makes the whole thing easily greppable. Signed-off-by: Andrea Bolognani --- src/util/virfile.c | 3 +-- 1 file

[libvirt PATCH] util: Improve comment for workaround

Now that a version of GLib that contains the fix has been released, it's more useful to record that information. Adding a TODO annotation makes the whole thing easily greppable. Signed-off-by: Andrea Bolognani --- src/util/virfile.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] qemu: Fix error message

The spelling is slightly different from another otherwise identical error message in the same file. Signed-off-by: Andrea Bolognani --- Pushed as trivial. src/qemu/qemu_dbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c index

Re: [PATCH v2 1/1] cpu_riscv64.c: add update() implementation

On Fri, Apr 28, 2023 at 04:57:28PM -0300, Daniel Henrique Barboza wrote: > At this moment it is not possible to launch a 'riscv64' domain if a CPU > definition is presented in the domain. For example, adding this CPU > definition: > > > rv64 > > > Will trigger the following error: > > $

[PATCH 0/2] gitlab: Adapt name of CI job building the web page to 'pages'

The subject is deliberately chosen so that it does not imply that we actually want to host libvirt.org via gitlab pages at this time. It's not possible as gitlab pages don't allow redirects to different domains: https://gitlab.com/gitlab-org/gitlab-pages/-/issues/601 The merit of this change

[PATCH 2/2] docs: Add redirects configuration for gitlab pages

Adapt the configuration of redirects from the server hosting libvirt.org The redirect to the 'libvirt-console-proxy' Golang module is not adapted as it doesn't exist on the current server. NOTES: - The redirects are currently configured for hosting via the 'gitlab.io/libvirt' URI. For

[PATCH 1/2] gitlab-ci: Configure website build to be published via gitlab pages

Modify the build process of the web page to publish the contents of the web page also via gitlab pages. This is achieved by the following steps: - the artifact is now named 'pages' - on push to the default branch a new job 'pages' is used - otherwise the old job names are used Signed-off-by:

Re: [libvirt PATCH 00/28] native support for nftables in virtual network driver

On Sun, Apr 30, 2023 at 11:19:15PM -0400, Laine Stump wrote: > This patch series enables libvirt to use nftables rules rather than > iptables *when setting up virtual networks* (it does *not* add > nftables support to the nwfilter driver). It accomplishes this by > abstracting several iptables

Re: [libvirt PATCH 18/28] util: new functions to support adding individual rollback rules

On Sun, Apr 30, 2023 at 11:19:33PM -0400, Laine Stump wrote: > In the past virFirewall required all rollback rules for a group (those > commands necessary to "undo" any rules that had been added in that > group in case of a later failure) to be manually added by switching > into "rollback mode"

Re: [libvirt PATCH 19/28] util: check for 0 args when applying iptables rule

On Sun, Apr 30, 2023 at 11:19:34PM -0400, Laine Stump wrote: > In normal practice a firewall rule should never have 0 args by the > time it gets to the Apply stage, but at some time while debugging > auto-rollback exactly that happened (due to a bug that was since > squashed), and having a check

Re: [libvirt PATCH 15/28] build: add nft to the list of binaries we attempt to locate

On Wed, May 03, 2023 at 04:26:21PM +0100, Daniel P. Berrangé wrote: > On Sun, Apr 30, 2023 at 11:19:30PM -0400, Laine Stump wrote: > > and include it in BuildRequires and Requires of the rpm specfile to > > make sure it's available when doing official distro builds. > > This new dep will need