[libvirt PATCH 0/3] qemu: Find dbus-daemon at runtime

2023-05-10 Thread Andrea Bolognani
Same as the changes made recently for QEMU helpers, except even more straightforward. Andrea Bolognani (3): qemu: Find dbus-daemon at runtime meson: Stop looking for dbus-daemon qemu: Update documentation for dbus_daemon qemu.conf key meson.build| 12

[libvirt PATCH 3/3] qemu: Update documentation for dbus_daemon qemu.conf key

2023-05-10 Thread Andrea Bolognani
Reflect the new default value, and explain that a runtime lookup will be performed if the value is not an absolute path. Signed-off-by: Andrea Bolognani --- src/qemu/qemu.conf.in | 4 +++- src/qemu/test_libvirtd_qemu.aug.in | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-)

[libvirt PATCH 1/3] qemu: Find dbus-daemon at runtime

2023-05-10 Thread Andrea Bolognani
Don't bother looking at /usr/libexec, since every distro ships dbus-daemon in $PATH. Note that it's still possible for the administrator to prevent this lookup and use an arbitrary binary by setting the appropriate key in qemu.conf. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_dbus.c | 14

[libvirt PATCH 2/3] meson: Stop looking for dbus-daemon

2023-05-10 Thread Andrea Bolognani
Now that we're performing the lookup at runtime, doing it at build time is no longer necessary. Signed-off-by: Andrea Bolognani --- meson.build | 12 src/qemu/qemu_conf.c | 1 + 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/meson.build b/meson.build index

[RFC PATCH] hostdev:Introduce vDPA device to hostdev subsystem as a new subtype

2023-05-10 Thread libai (G)
ping 在 2023/4/24 11:36, libai 写道: The following is the xml of vdpa device: And the command line passed to QEMU is as follows: -device {"driver":"vhost-vdpa-device-pci","vhostdev":"/dev/vhost-vdpa-0"} This solution is selected according to the previous discussion on the

[RFC PATCH] hostdev:Introduce vDPA device to hostdev subsystem as a new subtype

2023-05-10 Thread libai
The following is the xml of vdpa device: And the command line passed to QEMU is as follows: -device {"driver":"vhost-vdpa-device-pci","vhostdev":"/dev/vhost-vdpa-0"} This solution is selected according to the previous discussion on the solution of supporting the vDPA device.

[no subject]

2023-05-10 Thread daggs
Greetings, I'm trying to boot a VM with pi of the on sound card and the gpu using libvirt[1] and qemu I have a script that loads the needed KVM mods, starts libvirt and press the HDD Then starts the VM with virus. I've configured qemu hooks to run scripts in the relevant events. In prepare, I

[RFC PATCH] hostdev:Introduce vDPA device to hostdev subsystem as a new subtype

2023-05-10 Thread libai
The following is the xml of vdpa device: And the command line passed to QEMU is as follows: -device {"driver":"vhost-vdpa-device-pci","vhostdev":"/dev/vhost-vdpa-0"} This solution is selected according to the previous discussion on the solution of supporting the vDPA device.

Re: [libvirt PATCH] rpm: Don't require qemu-img at build time

2023-05-10 Thread Martin Kletzander
On Wed, May 10, 2023 at 06:01:28AM -0700, Andrea Bolognani wrote: On Wed, May 10, 2023 at 02:40:38PM +0200, Peter Krempa wrote: On Wed, May 10, 2023 at 05:28:56 -0700, Andrea Bolognani wrote: > Peter, is there a reason why we're still calling 'qemu-img create' > for those specific images? Or

[libvirt PATCH v2] rpm: Explain BuildRequires on qemu-img

2023-05-10 Thread Andrea Bolognani
It's not used as part of the build process or searched for at build time, and the QEMU driver detects its path at runtime, so one could think that the BuildRequires is unnecessary. But we actually need it to be present at build time in order to run the full test suite. Signed-off-by: Andrea

Re: [libvirt PATCH] rpm: Don't require qemu-img at build time

2023-05-10 Thread Andrea Bolognani
On Wed, May 10, 2023 at 02:40:38PM +0200, Peter Krempa wrote: > On Wed, May 10, 2023 at 05:28:56 -0700, Andrea Bolognani wrote: > > Peter, is there a reason why we're still calling 'qemu-img create' > > for those specific images? Or could we replace those calls with > > preformatted images as

Re: [PATCH 2/2] virfirewallmock: Replace virFindFileInPath() with virFirewallDIsRegistered()

2023-05-10 Thread Martin Kletzander
On Wed, May 03, 2023 at 11:00:55AM +0200, Michal Privoznik wrote: Neither of tests that use virfirewallmock.c (networkxml2firewalltest, nwfilterebiptablestest, nwfilterxml2firewalltest, virfirewalltest) really call virFindFileInPath(). But at least networkxml2firewalltest calls

Re: [PATCH 1/2] util: include virfirewall.h in virfirewalld.h

2023-05-10 Thread Martin Kletzander
On Wed, May 03, 2023 at 11:00:54AM +0200, Michal Privoznik wrote: The virfirewalld.h file provides a declaration for virFirewallDApplyRule() which accepts an argument of type virFirewallLayer. But the typedef lives in virfirewall.h and thus including just virfirewalld.h is not sufficient.

Re: [libvirt PATCH] rpm: Don't require qemu-img at build time

2023-05-10 Thread Peter Krempa
On Wed, May 10, 2023 at 05:28:56 -0700, Andrea Bolognani wrote: > On Wed, May 10, 2023 at 12:01:03PM +0200, Martin Kletzander wrote: > > On Fri, May 05, 2023 at 08:05:05PM +0200, Andrea Bolognani wrote: > > > It's not used as part of the build process or even searched for > > > at build time. The

Re: [libvirt PATCH] rpm: Don't require qemu-img at build time

2023-05-10 Thread Andrea Bolognani
On Wed, May 10, 2023 at 12:01:03PM +0200, Martin Kletzander wrote: > On Fri, May 05, 2023 at 08:05:05PM +0200, Andrea Bolognani wrote: > > It's not used as part of the build process or even searched for > > at build time. The QEMU driver detects its path at runtime. > > But we do run tests at

Re: [PATCH 0/2] Fix mocking around networkxml2firewalltest

2023-05-10 Thread Kristina Hanicova
On Wed, May 3, 2023 at 11:01 AM Michal Privoznik wrote: > *** BLURB HERE *** > > Michal Prívozník (2): > util: include virfirewall.h in virfirewalld.h > virfirewallmock: Replace virFindFileInPath() with > virFirewallDIsRegistered() > > src/util/virfirewalld.h | 2 ++ >

Re: [libvirt PATCH] rpm: Don't require qemu-img at build time

2023-05-10 Thread Martin Kletzander
On Fri, May 05, 2023 at 08:05:05PM +0200, Andrea Bolognani wrote: It's not used as part of the build process or even searched for at build time. The QEMU driver detects its path at runtime. But we do run tests at build time and virstoragetest.c is looking for qemu-img and using it. Without

Re: [libvirt PATCH 18/28] util: new functions to support adding individual rollback rules

2023-05-10 Thread Daniel P . Berrangé
On Fri, May 05, 2023 at 02:06:12PM -0400, Laine Stump wrote: > On 5/4/23 6:44 AM, Daniel P. Berrangé wrote: > > On Sun, Apr 30, 2023 at 11:19:33PM -0400, Laine Stump wrote: > > > In the past virFirewall required all rollback rules for a group (those > > > commands necessary to "undo" any rules

Re: [libvirt PATCH] rpm: Don't require qemu-img at build time

2023-05-10 Thread Ján Tomko
On a Friday in 2023, Andrea Bolognani wrote: It's not used as part of the build process or even searched for at build time. The QEMU driver detects its path at runtime. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt PATCH 0/5] qemu: Find helpers at runtime

2023-05-10 Thread Martin Kletzander
On Fri, May 05, 2023 at 08:01:41PM +0200, Andrea Bolognani wrote: This removes the need to have them present in the build environment and makes things more flexible. Note that we currently *do not* have the helpers available in most CI environments, or have BuildRequires for them in the spec