Re: [PATCH 0/4] Introduce ARM MTE feature

On Tue, May 16, 2023 at 12:54:12PM +0200, Michal Privoznik wrote: > Michal Prívozník (4): > conf: Introduce MTE domain feature > qemu:: Introduce QEMU_CAPS_MACHINE_VIRT_MTE capability > qemu: Validate MTE feature > qemu: Generate command line for MTE feature I wish I'd managed to see this

Re: [PATCH 08/12] css: mobile: Fix hiding of big logo in mobile layout

On a Tuesday in 2023, Peter Krempa wrote: Use the '#index' id to select the proper page as the body element doesn't have 'index' class. Signed-off-by: Peter Krempa --- docs/css/mobile.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) For patches 2 to 8: Reviewed-by: Ján Tomko Jano

Re: [PATCH 01/12] css: Drop styles for '#projects' id

On a Tuesday in 2023, Peter Krempa wrote: There's nothing with such element id. The last mention was removed in 28183590754. Please drop the trailing period or rephrase the sentence to make it the commit id easier to select. Signed-off-by: Peter Krempa --- docs/css/libvirt.css | 73

[PATCH 10/12] css: Fix styling of the "3 panel" pages

Use the same 'margin-bottom' bot for the normal and mobile layout fixing one of the panels touching the footer. Use same font size both for and used as the column titles as rst2html5 based on version can generate either of them. Signed-off-by: Peter Krempa --- docs/css/libvirt.css | 2 ++

[PATCH 12/12] docs: index: Convert to 'rst'

Final piece of conversion of our non-generated pages to 'rst'. Special raw HTML is used for adding the appropriate code to fetch the blog planet. Signed-off-by: Peter Krempa --- docs/css/libvirt.css | 35 +++--- docs/css/mobile.css | 8 ++-- docs/index.html.in | 87

[PATCH 11/12] docs: acl: Convert to 'rst'

The only special bit about the 'acl' page was the inclusion of the objects and permissions tables. We can do that by the '.. raw::' directive. One reference from 'aclpolkit.rst' needed to be updated to go with the new header anchor naming. Signed-off-by: Peter Krempa --- docs/acl.html.in |

[PATCH 07/12] css: mobile: Fix responsive design of 'docs' and 'knowledgebase' pages

When the pages were converted to rST it required changes to how the panels are created. This change was not reproduced in the specific media override for narrow displays and thus made those pages unusable. Note that two lines per document are needed as some rst2html5 versions format a and others

[PATCH 03/12] css: Drop style for 'p.image' selector

Last use was removed in b51afd97e56a6d9436f8706f952ebc6af647773c Signed-off-by: Peter Krempa --- docs/css/libvirt.css | 4 1 file changed, 4 deletions(-) diff --git a/docs/css/libvirt.css b/docs/css/libvirt.css index 7ebe77c04b..ee3ec3a29c 100644 --- a/docs/css/libvirt.css +++

[PATCH 01/12] css: Drop styles for '#projects' id

There's nothing with such element id. The last mention was removed in 28183590754. Signed-off-by: Peter Krempa --- docs/css/libvirt.css | 73 1 file changed, 73 deletions(-) diff --git a/docs/css/libvirt.css b/docs/css/libvirt.css index

[PATCH 08/12] css: mobile: Fix hiding of big logo in mobile layout

Use the '#index' id to select the proper page as the body element doesn't have 'index' class. Signed-off-by: Peter Krempa --- docs/css/mobile.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/css/mobile.css b/docs/css/mobile.css index 1a2ea6fcc3..43ca7ca482 100644 ---

[PATCH 09/12] css: mobile: Make colums in "3 column" mobile layout wider

Use the full width of the parent box and drop the unnecessarily bigger margin. Signed-off-by: Peter Krempa --- docs/css/mobile.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/css/mobile.css b/docs/css/mobile.css index 43ca7ca482..daa459352b 100644 ---

[PATCH 06/12] css: mobile: Replace tabs with spaces

Signed-off-by: Peter Krempa --- docs/css/mobile.css | 124 ++-- 1 file changed, 62 insertions(+), 62 deletions(-) diff --git a/docs/css/mobile.css b/docs/css/mobile.css index ae833b6eea..c538f953fb 100644 --- a/docs/css/mobile.css +++

[PATCH 05/12] css: Drop styles for '.gitmirror' class

Last use was removed in 11850158bdae1572d587b10ea8cb7c12d4f61527 Signed-off-by: Peter Krempa --- docs/css/libvirt.css | 9 - 1 file changed, 9 deletions(-) diff --git a/docs/css/libvirt.css b/docs/css/libvirt.css index ebe8ada60d..e198f63fb8 100644 --- a/docs/css/libvirt.css +++

[PATCH 04/12] css: Drop styles for '.mail' class

Use was removed in 5042a5def6d2d088ed19b10a08e5f40b11b2c58d Signed-off-by: Peter Krempa --- docs/css/libvirt.css | 15 --- 1 file changed, 15 deletions(-) diff --git a/docs/css/libvirt.css b/docs/css/libvirt.css index ee3ec3a29c..ebe8ada60d 100644 --- a/docs/css/libvirt.css +++

[PATCH 02/12] css: Drop style for '#changelog' id

The corresponding element was removed in 5e0211e0d3d7d01d5a49 Signed-off-by: Peter Krempa --- docs/css/libvirt.css | 5 - 1 file changed, 5 deletions(-) diff --git a/docs/css/libvirt.css b/docs/css/libvirt.css index f1705ab944..7ebe77c04b 100644 --- a/docs/css/libvirt.css +++

[PATCH 00/12] docs: Finish conversion of non-generated docs to rST and fix and cleanup CSS

Browse the results at: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/4294950526/artifacts/website/index.html Peter Krempa (12): css: Drop styles for '#projects' id css: Drop style for '#changelog' id css: Drop style for 'p.image' selector css: Drop styles for '.mail' class css: Drop

Re: [PATCH 0/4] Introduce ARM MTE feature

On Tue, May 16, 2023 at 12:54:12PM +0200, Michal Privoznik wrote: *** BLURB HERE *** Michal Prívozník (4): conf: Introduce MTE domain feature qemu:: Introduce QEMU_CAPS_MACHINE_VIRT_MTE capability qemu: Validate MTE feature qemu: Generate command line for MTE feature With the two points

Re: [PATCH 4/4] qemu: Generate command line for MTE feature

On Tue, May 16, 2023 at 12:54:16PM +0200, Michal Privoznik wrote: This is pretty trivia, just append "mte=on/off" to -machine *trivial arguments. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c| 6 ++ tests/qemuxml2argvdata/aarch64-gic-v3.args | 2 +- 2

Re: [PATCH 3/4] qemu: Validate MTE feature

On Tue, May 16, 2023 at 12:54:15PM +0200, Michal Privoznik wrote: The MTE feature is not supported by all QEMUs, only those with QEMU_CAPS_MACHINE_VIRT_MTE capability. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 25 + 1 file changed, 17 insertions(+),

Re: [PATCH 2/3] qemu: Generate cmd line for pipewire audio backend

On Tue, May 16, 2023 at 12:49:02PM +0200, Michal Prívozník wrote: On 5/16/23 11:52, Martin Kletzander wrote: On Thu, May 11, 2023 at 02:14:51PM +0200, Michal Privoznik wrote: This is mostly straightforward, except for a teensy-weensy detail: usually, there's no system wide daemon running, no

Re: [PATCH 2/2] qemu: Drop @forceVFIO argument of qemuDomainGetMemLockLimitBytes() and qemuDomainAdjustMaxMemLock()

On Tue, May 09, 2023 at 04:38:53PM +0200, Michal Privoznik wrote: After previous cleanup, there's not a single caller that would call either qemuDomainGetMemLockLimitBytes() or qemuDomainAdjustMaxMemLock() with @forceVFIO set. All callers pass false. Drop the unneeded argument from both

Re: [PATCH 1/2] qemu_domin: Account for NVMe disks when calculating memlock limit on hotplug

s/domin/domain/ in $SUBJ On Tue, May 09, 2023 at 04:38:52PM +0200, Michal Privoznik wrote: During hotplug of a NVMe disk we need to adjust the memlock limit. The computation of the limit is handled by qemuDomainGetMemLockLimitBytes() which looks at given domain definition and accounts for

[PATCH 4/4] qemu: Generate command line for MTE feature

This is pretty trivia, just append "mte=on/off" to -machine arguments. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c| 6 ++ tests/qemuxml2argvdata/aarch64-gic-v3.args | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH 1/4] conf: Introduce MTE domain feature

The Memory Tagging Extensions are hardware acceleration present in some ARM processors that allow memory error detection [1]. Introduce a domain XML knob that turns them on or off. 1: https://www.arm.com/blogs/blueprint/memory-safety-arm-memory-tagging-extension Signed-off-by: Michal Privoznik

[PATCH 3/4] qemu: Validate MTE feature

The MTE feature is not supported by all QEMUs, only those with QEMU_CAPS_MACHINE_VIRT_MTE capability. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_validate.c

[PATCH 2/4] qemu:: Introduce QEMU_CAPS_MACHINE_VIRT_MTE capability

The MTE feature (introduced in QEMU commit of v5.1.0-rc1~8^2~11) is detectable via 'qom-list-properties' for 'virt' machine type. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 +

[PATCH 0/4] Introduce ARM MTE feature

*** BLURB HERE *** Michal Prívozník (4): conf: Introduce MTE domain feature qemu:: Introduce QEMU_CAPS_MACHINE_VIRT_MTE capability qemu: Validate MTE feature qemu: Generate command line for MTE feature docs/formatdomain.rst | 7 + src/conf/domain_conf.c

Re: [PATCH 2/3] qemu: Generate cmd line for pipewire audio backend

On 5/16/23 11:52, Martin Kletzander wrote: > On Thu, May 11, 2023 at 02:14:51PM +0200, Michal Privoznik wrote: >> This is mostly straightforward, except for a teensy-weensy >> detail: usually, there's no system wide daemon running, no system >> wide available socket that anybody could connect to.

Re: [PATCH 2/3] qemu: Generate cmd line for pipewire audio backend

On Thu, May 11, 2023 at 02:14:51PM +0200, Michal Privoznik wrote: This is mostly straightforward, except for a teensy-weensy detail: usually, there's no system wide daemon running, no system wide available socket that anybody could connect to. PipeWire uses a per user daemon approach instead.

Re: [PATCH 0/2] conf: Fix formatting of 'associativity' and 'policy' cache attributes

On 5/16/23 10:33, Peter Krempa wrote: > Peter Krempa (2): > virDomainNumaDefNodeCacheParseXML: Refactor parsing of cache XML > conf: numa: Allow formatting 'none' values for 'associativity' and > 'policy' of cache > > src/conf/numa_conf.c | 73 +--

[PATCH 1/2] virDomainNumaDefNodeCacheParseXML: Refactor parsing of cache XML

Use virXMLProp* helpers to simplify the code. Signed-off-by: Peter Krempa --- src/conf/numa_conf.c | 60 +++- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index b21671f587..c2e3045280 100644

[PATCH 2/2] conf: numa: Allow formatting 'none' values for 'associativity' and 'policy' of cache

The parser makes the values mandatory and also the qemu code implements actions for those values. The formatter skips them though. Since format+parse is used to copy the XML at startup a definition with those values can't be started. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2203709

[PATCH 0/2] conf: Fix formatting of 'associativity' and 'policy' cache attributes

Peter Krempa (2): virDomainNumaDefNodeCacheParseXML: Refactor parsing of cache XML conf: numa: Allow formatting 'none' values for 'associativity' and 'policy' of cache src/conf/numa_conf.c | 73 +-- .../numatune-hmat-none.x86_64-latest.args |

Re: [libvirt PATCH] docs: Fix broken link to Windows MSI downloads

On Mon, May 15, 2023 at 04:02:12PM +0100, Daniel P. Berrangé wrote: > On Mon, May 15, 2023 at 04:47:54PM +0200, Kashyap Chamarthy wrote: > > On Mon, May 15, 2023 at 04:41:12PM +0200, Kashyap Chamarthy wrote: > > > Right now the URL is 404 due to missing .html. > > > > To think of it, should we