Re: Revisiting the virsh hypervisor-cpu-models/definitions commands

2023-05-30 Thread Collin Walling
On 5/26/23 7:35 AM, Daniel P. Berrangé wrote: On Wed, May 17, 2023 at 05:34:46PM -0400, Collin Walling wrote: Daniel, Tim, (and others on the upstream list that'd like to chime in) Harken back to a few months ago when I presented a few patches to introduce the virsh hypervisor-cpu-models

Re: [libvirt PATCH] conf: node_device: use separate variable for parsing an integer

2023-05-30 Thread Martin Kletzander
On Tue, May 30, 2023 at 05:02:26PM +0200, Ján Tomko wrote: In virNodeDeviceGetSCSIHostCaps, there is a pattern of reusing a tmp value and stealing the pointer. But in one case it is not stolen. Use a separate variable for it to avoid mixing autofree with manual free() calls. Actually in two

[libvirt PATCH] conf: node_device: use separate variable for parsing an integer

2023-05-30 Thread Ján Tomko
In virNodeDeviceGetSCSIHostCaps, there is a pattern of reusing a tmp value and stealing the pointer. But in one case it is not stolen. Use a separate variable for it to avoid mixing autofree with manual free() calls. Fixes: 8a0cb5f73ade3900546718eabe70cb064c6bd22c Signed-off-by: Ján Tomko ---

libvirt-9.4.0 release candidate 2

2023-05-30 Thread Jiri Denemark
I have just tagged v9.4.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to

Re: [PATCH] NEWS: Document my contributions for upcoming release

2023-05-30 Thread Jiri Denemark
On Tue, May 30, 2023 at 09:51:05 +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 37 + > 1 file changed, 37 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 1b85ef6d37..1ee932db72 100644 > --- a/NEWS.rst > +++

[PATCH] NEWS: Document my contributions for upcoming release

2023-05-30 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- NEWS.rst | 37 + 1 file changed, 37 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1b85ef6d37..1ee932db72 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -23,8 +23,45 @@ v9.4.0 (unreleased) * **Improvements** + * Adapt

Re: [PATCH 06/18] qemuMonitorTestAddItemExpect: Remove unused helper

2023-05-30 Thread Ján Tomko
On a Thursday in 2023, Peter Krempa wrote: Signed-off-by: Peter Krempa --- tests/qemumonitortestutils.c | 95 tests/qemumonitortestutils.h | 7 --- 2 files changed, 102 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 05/18] qemuMonitorJSONTestAttachOneChardev: Rewrite using qemuMonitorTestAddItemVerbatim

2023-05-30 Thread Ján Tomko
On a Thursday in 2023, Peter Krempa wrote: 'qemuMonitorTestAddItemExpect' doesn't do QMP schema validation. Since it's the only use we can reimplement it using 'qemuMonitorTestAddItemVerbatim' which does schema validation and remove the old code instead. Signed-off-by: Peter Krempa ---

Re: [PATCH 04/18] testQemuMonitorJSONAttachChardev: Move all setup code under virTestRun

2023-05-30 Thread Ján Tomko
On a Thursday in 2023, Peter Krempa wrote: Any failure which happens outside is hard to debug as errors will be reset and not raised. Signed-off-by: Peter Krempa --- tests/qemumonitorjsontest.c | 60 ++--- 1 file changed, 29 insertions(+), 31 deletions(-)

Re: [PATCH 02/18] qemuMonitorTestAddHandler: Remove return value

2023-05-30 Thread Ján Tomko
On a Thursday in 2023, Peter Krempa wrote: The function always returns 0. Remove the return value and fix callers. Signed-off-by: Peter Krempa --- tests/qemuagenttest.c| 39 -- tests/qemumonitortestutils.c | 54 +---

Re: [PATCH 01/18] qemuMonitorTestAddItemVerbatim: Simplify cleanup

2023-05-30 Thread Ján Tomko
On a Thursday in 2023, Peter Krempa wrote: Reformat the JSON string before allocating the test data structure so that we don't have to free it if the reformatting fails. Signed-off-by: Peter Krempa --- tests/qemumonitortestutils.c | 13 + 1 file changed, 5 insertions(+), 8