Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Alex Williamson
On Wed, 31 May 2023 17:46:50 -0300 Jason Gunthorpe wrote: > On Wed, May 31, 2023 at 02:40:01PM -0600, Alex Williamson wrote: > > > Also note that we're saying "vfio" not "vfio-pci". Only the mdev > > interface has the device_api attribute to indicate the exported vfio > > device interface.

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Jason Gunthorpe
On Wed, May 31, 2023 at 02:40:01PM -0600, Alex Williamson wrote: > Also note that we're saying "vfio" not "vfio-pci". Only the mdev > interface has the device_api attribute to indicate the exported vfio > device interface. The "vfio_pci:" match in modalias indicates a vfio > PCI driver, not

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Alex Williamson
On Wed, 31 May 2023 14:30:52 -0300 Jason Gunthorpe wrote: > On Wed, May 31, 2023 at 01:18:44PM -0400, Laine Stump wrote: > > On 5/31/23 10:31 AM, Jason Gunthorpe wrote: > > > On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: > > > > Hey Laine, > > > > > > > > On 23/08/2022

Re: [PATCH v6 05/11] docs/deprecated: move QMP events bellow QMP command section

2023-05-31 Thread Eric Blake
In the subject: s/bellow/below/ On Fri, May 26, 2023 at 05:53:55PM +0100, Alex Bennée wrote: > Also rename the section to make the fact this is part of the > management protocol even clearer. > > Suggested-by: Markus Armbruster > Signed-off-by: Alex Bennée > --- > docs/about/deprecated.rst |

[PULL 02/11] trace-events: remove the remaining vcpu trace events

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée While these are all in helper functions being designated vcpu events complicates the removal of the dynamic vcpu state code. TCG plugins allow you to instrument vcpu_[init|exit|idle]. We rename cpu_reset and make it a normal trace point. Reviewed-by: Stefan Hajnoczi

[PULL 09/11] tcg: remove the final vestiges of dstate

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée Now we no longer have dynamic state affecting things we can remove the additional fields in cpu.h and simplify the TB hash calculation. For the benchmark: hyperfine -w 2 -m 20 \ "./arm-softmmu/qemu-system-arm -cpu cortex-a15 \ -machine type=virt,highmem=off

[PULL 08/11] trace: remove control-vcpu.h

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée Now we no longer have vcpu controlled trace events we can excise the code that allows us to query its status. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-id:

[PULL 05/11] docs/deprecated: move QMP events bellow QMP command section

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée Also rename the section to make the fact this is part of the management protocol even clearer. Suggested-by: Markus Armbruster Signed-off-by: Alex Bennée Message-id: 20230526165401.574474-6-alex.ben...@linaro.org Signed-off-by: Stefan Hajnoczi --- docs/about/deprecated.rst

[PULL 07/11] trace: remove code that depends on setting vcpu

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée Now we no longer have any events that are for vcpus we can start excising the code from the trace control. As the vcpu parameter is encoded as part of QMP we just stub out the has_vcpu/vcpu parameters rather than alter the API. Reviewed-by: Stefan Hajnoczi Reviewed-by:

[PULL 01/11] *-user: remove the guest_user_syscall tracepoints

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée This is pure duplication now. Both bsd-user and linux-user have builtin strace support and we can also track syscalls via the plugins system. Reviewed-by: Warner Losh Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé

[PULL 11/11] accel/tcg: include cs_base in our hash calculations

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée We weren't using cs_base in the hash calculations before. Since the arm front end moved a chunk of flags in a378206a20 (target/arm: Move mode specific TB flags to tb->cs_base) they comprise of an important part of the execution state. Widen the tb_hash_func to include cs_base

[PULL 10/11] hw/9pfs: use qemu_xxhash4

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée No need to pass zeros as we have helpers that do that for us. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Christian Schoenebeck Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-id:

[PULL 06/11] qapi: make the vcpu parameters deprecated for 8.1

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée I don't think I can remove the parameters directly but certainly mark them as deprecated. Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-id: 20230526165401.574474-7-alex.ben...@linaro.org

[PULL 04/11] scripts/qapi: document the tool that generated the file

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée This makes it a little easier for developers to find where things where being generated. Reviewed-by: Richard Henderson Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Alex Bennée Message-id:

[PULL 03/11] trace: remove vcpu_id from the TraceEvent structure

2023-05-31 Thread Stefan Hajnoczi
From: Alex Bennée This does involve temporarily stubbing out some helper functions before we excise the rest of the code. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-id:

[PULL 00/11] Tracing patches

2023-05-31 Thread Stefan Hajnoczi
The following changes since commit 51bdb0b57a2d9e84d6915fbae7b5d76c8820cf3c: Merge tag 'pull-tcg-20230530' of https://gitlab.com/rth7680/qemu into staging (2023-05-30 13:25:18 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for

[libvirt PATCHv3 for 9.4.0] conf: node_device: use separate variables for parsing integers

2023-05-31 Thread Ján Tomko
In virNodeDeviceGetSCSIHostCaps, there is a pattern of reusing a tmp value and stealing the pointer. But in two case it is not stolen. Use separate variables for them to avoid mixing autofree with manual free() calls. This fixes the memory leak of the "max_npiv_vports" string. (The other gets

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Jason Gunthorpe
On Wed, May 31, 2023 at 01:18:44PM -0400, Laine Stump wrote: > On 5/31/23 10:31 AM, Jason Gunthorpe wrote: > > On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: > > > Hey Laine, > > > > > > On 23/08/2022 15:11, Laine Stump wrote: > > > > ping. > > > > > > > > I have a different

Re: [PATCH v6 00/11] tracing: remove dynamic vcpu state

2023-05-31 Thread Stefan Hajnoczi
On Fri, May 26, 2023 at 05:53:50PM +0100, Alex Bennée wrote: > Hi Stefan, > > The references dynamic vcpu tracing support was removed when the > original TCG trace points where removed. However there was still a > legacy of dynamic trace state to track this in cpu.h and extra hash > variables to

Re: [PATCH for 9.4.0] include: Fix 'Since' for new VIR_MIGRATE_PARAM_COMPRESSION_* macros

2023-05-31 Thread Andrea Bolognani
On Wed, May 31, 2023 at 11:02:21AM +0200, Michal Privoznik wrote: > In v9.3.0-98-g150ae3e62b two new macros were introduced: > VIR_MIGRATE_PARAM_COMPRESSION_ZLIB_LEVEL and > VIR_MIGRATE_PARAM_COMPRESSION_ZSTD_LEVEL. But both list 9.1.0 as > the version they were introduced in (this is because the

Re: [libvirt PATCH] ci: refresh with latest lcitool manifest

2023-05-31 Thread Andrea Bolognani
On Wed, May 31, 2023 at 11:37:01AM +0200, Erik Skultety wrote: > Adds Alpine 3.17 and 3.18 targets. I only see Alpine 3.17 being added, and Alpine 3.15 being removed. If that was the intention, then the commit message needs to express that more clearly... -- Andrea Bolognani / Red Hat /

Re: [PATCH v6 05/11] docs/deprecated: move QMP events bellow QMP command section

2023-05-31 Thread Stefan Hajnoczi
On Fri, May 26, 2023 at 05:53:55PM +0100, Alex Bennée wrote: > Also rename the section to make the fact this is part of the > management protocol even clearer. > > Suggested-by: Markus Armbruster > Signed-off-by: Alex Bennée > --- > docs/about/deprecated.rst | 18 +- > 1 file

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Laine Stump
On 5/31/23 10:31 AM, Jason Gunthorpe wrote: On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: Hey Laine, On 23/08/2022 15:11, Laine Stump wrote: ping. I have a different version of this patch where I do read the modules.alias file rather than just checking the name of the driver,

Re: [PATCH v4] vfio/pci: Propagate ACPI notifications to user-space via eventfd

2023-05-31 Thread Grzegorz Jaszczyk
czw., 25 maj 2023 o 22:41 Alex Williamson napisał(a): > > On Mon, 22 May 2023 16:58:11 + > Grzegorz Jaszczyk wrote: > > > To allow pass-through devices receiving ACPI notifications, permit to > > register ACPI notify handler (via VFIO_DEVICE_SET_IRQS) for a given > > device. The handler role

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Joao Martins
On 31/05/2023 15:31, Jason Gunthorpe wrote: > On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: >> Hey Laine, >> >> On 23/08/2022 15:11, Laine Stump wrote: >>> ping. >>> >>> I have a different version of this patch where I do read the modules.alias >>> file >>> rather than just

[PATCH 2/4] docs: page.xsl: Drop passhrough of

2023-05-31 Thread Peter Krempa
No generated headers have inline javascript. Signed-off-by: Peter Krempa --- docs/page.xsl | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/page.xsl b/docs/page.xsl index c92ceffec7..e3112fc9f8 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -56,7 +56,6 @@

[PATCH 0/4] docs: Move 'golang' metadata headers into rST files and further XSL cleanups

2023-05-31 Thread Peter Krempa
Pipeline: https://gitlab.com/pipo.sk/libvirt/-/jobs/4385932520 Impacted HTML files from pipeline: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/4385932520/artifacts/website/libvirt-go.html https://pipo.sk.gitlab.io/-/libvirt/-/jobs/4385932520/artifacts/website/libvirt-go-xml.html

[PATCH 3/4] docs: go: Add 'go-import' metadata via rST

2023-05-31 Thread Peter Krempa
The '.. meta::' rST directive allows adding header metadata. Move the specific metadata from page.xsl into the individual files and pass them trhough into the header from page.xsl. Signed-off-by: Peter Krempa --- docs/go/libvirt.rst | 3 +++ docs/go/libvirtxml.rst | 3 +++

[PATCH 4/4] docs: Use '--exit-status=' option for 'rst2html5'

2023-05-31 Thread Peter Krempa
Ensure that also 'non-halting' messages stop the build process. Signed-off-by: Peter Krempa --- docs/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/meson.build b/docs/meson.build index 2f0ecb2272..201fd4c984 100644 --- a/docs/meson.build +++

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Joao Martins
Hey Laine, On 23/08/2022 15:11, Laine Stump wrote: > ping. > > I have a different version of this patch where I do read the modules.alias > file > rather than just checking the name of the driver, but that also requires > "double > mocking" open() in the unit test, which wasn't working

[PATCH 1/4] docs: newapi: Remove unused 'docomponents' template

2023-05-31 Thread Peter Krempa
Never used since introduction in b38893c3eaa56617a3ef313c45e505da6e50 Signed-off-by: Peter Krempa --- docs/newapi.xsl | 18 -- 1 file changed, 18 deletions(-) diff --git a/docs/newapi.xsl b/docs/newapi.xsl index cafe49f61f..19a440bb09 100644 --- a/docs/newapi.xsl +++

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-05-31 Thread Jason Gunthorpe
On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: > Hey Laine, > > On 23/08/2022 15:11, Laine Stump wrote: > > ping. > > > > I have a different version of this patch where I do read the modules.alias > > file > > rather than just checking the name of the driver, but that also

Re: [PATCH python] virDomainMigrate3Params: Add missing params

2023-05-31 Thread Michal Prívozník
On 5/31/23 09:17, Han Han wrote: > Add these missing migrate params: > - VIR_MIGRATE_PARAM_DISKS_URI, since libvirt v6.8.0(49186372db) > - VIR_MIGRATE_PARAM_TLS_DESTINATION, since libvirt v6.0.0(1b8af37213e) > - VIR_MIGRATE_PARAM_COMPRESSION_ZLIB_LEVEL and >

[libvirt PATCH] ci: refresh with latest lcitool manifest

2023-05-31 Thread Erik Skultety
Adds Alpine 3.17 and 3.18 targets. Signed-off-by: Erik Skultety --- ci/buildenv/{alpine-315.sh => alpine-317.sh} | 1 + .../{alpine-315.Dockerfile => alpine-317.Dockerfile} | 3 ++- ci/gitlab/builds.yml | 12 ++--

[PATCH for 9.4.0] include: Fix 'Since' for new VIR_MIGRATE_PARAM_COMPRESSION_* macros

2023-05-31 Thread Michal Privoznik
In v9.3.0-98-g150ae3e62b two new macros were introduced: VIR_MIGRATE_PARAM_COMPRESSION_ZLIB_LEVEL and VIR_MIGRATE_PARAM_COMPRESSION_ZSTD_LEVEL. But both list 9.1.0 as the version they were introduced in (this is because the patch was sent in that release time frame). Change the version to the

[PATCH python] virDomainMigrate3Params: Add missing params

2023-05-31 Thread Han Han
Add these missing migrate params: - VIR_MIGRATE_PARAM_DISKS_URI, since libvirt v6.8.0(49186372db) - VIR_MIGRATE_PARAM_TLS_DESTINATION, since libvirt v6.0.0(1b8af37213e) - VIR_MIGRATE_PARAM_COMPRESSION_ZLIB_LEVEL and VIR_MIGRATE_PARAM_COMPRESSION_ZSTD_LEVEL, since libvirt v9.4.0(150ae3e62b9)

[libvirt PATCHv2] conf: node_device: use separate variables for parsing integers

2023-05-31 Thread Ján Tomko
In virNodeDeviceGetSCSIHostCaps, there is a pattern of reusing a tmp value and stealing the pointer. But in two case it is not stolen. Use separate variables for them to avoid mixing autofree with manual free() calls. Fixes: 8a0cb5f73ade3900546718eabe70cb064c6bd22c Signed-off-by: Ján Tomko ---