Re: [PATCH] qemu: Set proper PCI backend for -s that are actually hostdevs

2023-06-01 Thread Michal Prívozník
On 6/1/23 15:26, Michal Privoznik wrote: > When starting a domain, it's done so in two steps (actually more, > but lets focus on just the following two): > > 1) qemuProcessPrepareDomain(), followed by > > 2) qemuProcessPrepareHost(). > > Now, in the first step (PrepareDomain()), PCI

[PULL v2 05/11] docs/deprecated: move QMP events bellow QMP command section

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée Also rename the section to make the fact this is part of the management protocol even clearer. Suggested-by: Markus Armbruster Signed-off-by: Alex Bennée Message-id: 20230526165401.574474-6-alex.ben...@linaro.org Signed-off-by: Stefan Hajnoczi --- docs/about/deprecated.rst

[PULL v2 03/11] trace: remove vcpu_id from the TraceEvent structure

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée This does involve temporarily stubbing out some helper functions before we excise the rest of the code. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-id:

[PULL v2 08/11] trace: remove control-vcpu.h

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée Now we no longer have vcpu controlled trace events we can excise the code that allows us to query its status. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-id:

[PULL v2 07/11] trace: remove code that depends on setting vcpu

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée Now we no longer have any events that are for vcpus we can start excising the code from the trace control. As the vcpu parameter is encoded as part of QMP we just stub out the has_vcpu/vcpu parameters rather than alter the API. Reviewed-by: Stefan Hajnoczi Reviewed-by:

[PULL v2 09/11] tcg: remove the final vestiges of dstate

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée Now we no longer have dynamic state affecting things we can remove the additional fields in cpu.h and simplify the TB hash calculation. For the benchmark: hyperfine -w 2 -m 20 \ "./arm-softmmu/qemu-system-arm -cpu cortex-a15 \ -machine type=virt,highmem=off

[PULL v2 10/11] hw/9pfs: use qemu_xxhash4

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée No need to pass zeros as we have helpers that do that for us. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Christian Schoenebeck Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-id:

[PULL v2 11/11] accel/tcg: include cs_base in our hash calculations

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée We weren't using cs_base in the hash calculations before. Since the arm front end moved a chunk of flags in a378206a20 (target/arm: Move mode specific TB flags to tb->cs_base) they comprise of an important part of the execution state. Widen the tb_hash_func to include cs_base

[PULL v2 06/11] qapi: make the vcpu parameters deprecated for 8.1

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée I don't think I can remove the parameters directly but certainly mark them as deprecated. Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-id: 20230526165401.574474-7-alex.ben...@linaro.org

[PULL v2 02/11] trace-events: remove the remaining vcpu trace events

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée While these are all in helper functions being designated vcpu events complicates the removal of the dynamic vcpu state code. TCG plugins allow you to instrument vcpu_[init|exit|idle]. We rename cpu_reset and make it a normal trace point. Reviewed-by: Stefan Hajnoczi

[PULL v2 04/11] scripts/qapi: document the tool that generated the file

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée This makes it a little easier for developers to find where things where being generated. Reviewed-by: Richard Henderson Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Alex Bennée Message-id:

[PULL v2 00/11] Tracing patches

2023-06-01 Thread Stefan Hajnoczi
The following changes since commit c6a5fc2ac76c5ab709896ee1b0edd33685a67ed1: decodetree: Add --output-null for meson testing (2023-05-31 19:56:42 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to

[PULL v2 01/11] *-user: remove the guest_user_syscall tracepoints

2023-06-01 Thread Stefan Hajnoczi
From: Alex Bennée This is pure duplication now. Both bsd-user and linux-user have builtin strace support and we can also track syscalls via the plugins system. Reviewed-by: Warner Losh Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2] util: basic support for VFIO variant drivers

2023-06-01 Thread Jason Gunthorpe
On Wed, May 31, 2023 at 03:34:11PM -0600, Alex Williamson wrote: > device. It does not guarantee the vfio device API exposed to userspace > is vfio-pci. Therefore management tools should be cautious to make > assumptions about the type of device the VM will see even though we've > got vfio-pci

[PATCH] qemu: Set proper PCI backend for -s that are actually hostdevs

2023-06-01 Thread Michal Privoznik
When starting a domain, it's done so in two steps (actually more, but lets focus on just the following two): 1) qemuProcessPrepareDomain(), followed by 2) qemuProcessPrepareHost(). Now, in the first step (PrepareDomain()), PCI backends for all hostdevs is set (qemuProcessPrepareDomain() ->

Re: [PATCH] qemu_passt: Format portForward device even without address

2023-06-01 Thread Ján Tomko
On a Thursday in 2023, Michal Privoznik wrote: It's almost like we've anticipated this. Our XML parser and formatter handles @address and @dev attributes of element completely independent of each other. And as of commit 2023_03_29.b10b983~3 passt allows handling these two separately too. All

[PATCH] qemu_passt: Format portForward device even without address

2023-06-01 Thread Michal Privoznik
It's almost like we've anticipated this. Our XML parser and formatter handles @address and @dev attributes of element completely independent of each other. And as of commit 2023_03_29.b10b983~3 passt allows handling these two separately too. All that's left is generate the cmd line according to

Release of libvirt-9.4.0

2023-06-01 Thread Jiri Denemark
The 9.4.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing

Re: [libvirt PATCH v2] ci: refresh with latest lcitool manifest

2023-06-01 Thread Andrea Bolognani
On Thu, Jun 01, 2023 at 10:59:11AM +0200, Erik Skultety wrote: > Main lcitool changes: > - added Alpine 3.17 and 3.18 targets > - dropped Alpine 3.15 and 3.16 > > Note that we're not actively testing all Alpine targets due to CI > quota, so only 3.17 is used as a replacement for 3.15 in this

[libvirt PATCH v2] ci: refresh with latest lcitool manifest

2023-06-01 Thread Erik Skultety
Main lcitool changes: - added Alpine 3.17 and 3.18 targets - dropped Alpine 3.15 and 3.16 Note that we're not actively testing all Alpine targets due to CI quota, so only 3.17 is used as a replacement for 3.15 in this patch. Signed-off-by: Erik Skultety --- ci/buildenv/{alpine-315.sh =>

Re: [PATCH 0/4] docs: Move 'golang' metadata headers into rST files and further XSL cleanups

2023-06-01 Thread Martin Kletzander
On Wed, May 31, 2023 at 05:08:33PM +0200, Peter Krempa wrote: Pipeline: https://gitlab.com/pipo.sk/libvirt/-/jobs/4385932520 Impacted HTML files from pipeline: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/4385932520/artifacts/website/libvirt-go.html

Re: [PATCH 3/4] docs: go: Add 'go-import' metadata via rST

2023-06-01 Thread Martin Kletzander
On Wed, May 31, 2023 at 05:08:36PM +0200, Peter Krempa wrote: The '.. meta::' rST directive allows adding header metadata. Move the specific metadata from page.xsl into the individual files and pass them trhough into the header from page.xsl. through Signed-off-by: Peter Krempa ---

Re: [PATCH] qemu: add unmap stats to all domain stats

2023-06-01 Thread Peter Krempa
On Thu, Jun 01, 2023 at 12:44:19 +0600, Oleg Vasilev wrote: > From: Nikolay Shirokovskiy > > Unmap stats are useful for debugging how efficient qemu is in freeing host > disk space. "debugging [..] qemu" seems a bit too weak of a justification. Do you have any better usage for this data? > >

[PATCH] qemu: add unmap stats to all domain stats

2023-06-01 Thread Oleg Vasilev
From: Nikolay Shirokovskiy Unmap stats are useful for debugging how efficient qemu is in freeing host disk space. Signed-off-by: Oleg Vasilev --- src/qemu/qemu_driver.c | 3 +++ src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 3 +++ 3 files changed, 9 insertions(+)

Re: [libvirt PATCHv3 for 9.4.0] conf: node_device: use separate variables for parsing integers

2023-06-01 Thread Michal Prívozník
On 5/31/23 20:50, Ján Tomko wrote: > In virNodeDeviceGetSCSIHostCaps, there is a pattern of reusing > a tmp value and stealing the pointer. > > But in two case it is not stolen. Use separate variables for them > to avoid mixing autofree with manual free() calls. > > This fixes the memory leak of