Re: [PATCH 2/2] virstring: Prefer strtoll_l() and strtoull_l() whenever possible

2023-06-19 Thread Daniel P . Berrangé
On Mon, Jun 19, 2023 at 02:45:57PM +0200, Michal Prívozník wrote: > On 6/19/23 14:31, Daniel P. Berrangé wrote: > > On Mon, Jun 19, 2023 at 02:03:48PM +0200, Michal Privoznik wrote: > >> It's weird that in 2023 there's no reliable and portable way to > >> parse strings, but okay. > >> > >> We start

Re: [PATCH 2/2] virstring: Prefer strtoll_l() and strtoull_l() whenever possible

2023-06-19 Thread Michal Prívozník
On 6/19/23 14:31, Daniel P. Berrangé wrote: > On Mon, Jun 19, 2023 at 02:03:48PM +0200, Michal Privoznik wrote: >> It's weird that in 2023 there's no reliable and portable way to >> parse strings, but okay. >> >> We started with strtol(). Except, it doesn't work the same on >> Linux and Windows. On

Re: [PATCH 2/2] virstring: Prefer strtoll_l() and strtoull_l() whenever possible

2023-06-19 Thread Daniel P . Berrangé
On Mon, Jun 19, 2023 at 02:03:48PM +0200, Michal Privoznik wrote: > It's weird that in 2023 there's no reliable and portable way to > parse strings, but okay. > > We started with strtol(). Except, it doesn't work the same on > Linux and Windows. On Windows it behaves a bit different when it > come

[PATCH 1/2] virstring: Move locale wrappers at the beginning

2023-06-19 Thread Michal Privoznik
We will soon need the virLocaleRaw variable. Move it and functions around it at the beginning of the file, so that later code doesn't need to introduce forward declarations. Signed-off-by: Michal Privoznik --- src/util/virstring.c | 157 ++- 1 file changed

[PATCH 0/2] virstring: Fix string parsing. Again.

2023-06-19 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (2): virstring: Move locale wrappers at the beginning virstring: Prefer strtoll_l() and strtoull_l() whenever possible meson.build | 1 + src/util/virstring.c | 239 --- 2 files changed, 158 insertions(+),

[PATCH 2/2] virstring: Prefer strtoll_l() and strtoull_l() whenever possible

2023-06-19 Thread Michal Privoznik
It's weird that in 2023 there's no reliable and portable way to parse strings, but okay. We started with strtol(). Except, it doesn't work the same on Linux and Windows. On Windows it behaves a bit different when it comes to parsing strings with base = 0. So we've switched to g_ascii_strtoll() whi

network: firewalld: native support for NAT/routed

2023-06-19 Thread Hervé Werner
Hello I'd like to revive the thread started by Eric Garver at the end of last year that aims to bring native Firewalld support to libvirtd [1]. Currently the Firewalld configuration set up by libvirtd is based on a quirk [2] that makes it a bit puzzling for users. The aforementioned patches im