Re: [PATCH 2/2] virstring: Prefer strtoll_l() and strtoull_l() whenever possible

2023-06-20 Thread Daniel P . Berrangé
On Tue, Jun 20, 2023 at 01:25:23PM +0200, Michal Prívozník wrote: > On 6/19/23 17:02, Daniel P. Berrangé wrote: > > On Mon, Jun 19, 2023 at 02:45:57PM +0200, Michal Prívozník wrote: > >> On 6/19/23 14:31, Daniel P. Berrangé wrote: > >>> On Mon, Jun 19, 2023 at 02:03:48PM +0200, Michal Privoznik wro

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-20 Thread Peter Xu
On Tue, Jun 20, 2023 at 01:10:55PM +0100, Daniel P. Berrangé wrote: > In some cases it is worth having a convenience option for user friendliness. > > In this case, however, users are already needing to use QMP/HMP on the > source side to set migration parameters. I think it is reasonable to say >

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-20 Thread Daniel P . Berrangé
On Mon, Jun 12, 2023 at 05:19:40PM -0400, Peter Xu wrote: > On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: > > Peter Xu wrote: > > > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > > >> Only "defer" is recommended. After setting all migation parameters, > > >> sta

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-20 Thread Daniel P . Berrangé
On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > >> Only "defer" is recommended. After setting all migation parameters, > >> start incoming migration with "migrate-incoming uri" command. > >> > >

Re: [RFC 3/6] migration: migrate 'blk' command option is deprecated.

2023-06-20 Thread Daniel P . Berrangé
On Mon, Jun 12, 2023 at 09:33:41PM +0200, Juan Quintela wrote: > Use 'migrate_set_capability block true' instead. > > Signed-off-by: Juan Quintela > --- > docs/about/deprecated.rst | 7 +++ > qapi/migration.json | 11 +++ > migration/migration.c | 5 + > 3 files chang

Re: [RFC 2/6] migration: migrate 'inc' command option is deprecated.

2023-06-20 Thread Daniel P . Berrangé
On Mon, Jun 12, 2023 at 09:33:40PM +0200, Juan Quintela wrote: > Use 'migrate_set_parameter block_incremental true' instead. > > Signed-off-by: Juan Quintela > --- > docs/about/deprecated.rst | 7 +++ > qapi/migration.json | 11 +-- > migration/migration.c | 5 + > 3

Re: [RFC 1/6] migration: skipped field is really obsolete.

2023-06-20 Thread Daniel P . Berrangé
On Mon, Jun 12, 2023 at 09:33:39PM +0200, Juan Quintela wrote: > Has return zero for more than 10 years. Just mark it deprecated. Specifically we introduced the field in 1.5.0 commit f1c72795af573b24a7da5eb52375c9aba8a37972 Author: Peter Lieven Date: Tue Mar 26 10:58:37 2013 +0100 migrat

Re: [PATCH 2/2] virstring: Prefer strtoll_l() and strtoull_l() whenever possible

2023-06-20 Thread Michal Prívozník
On 6/19/23 17:02, Daniel P. Berrangé wrote: > On Mon, Jun 19, 2023 at 02:45:57PM +0200, Michal Prívozník wrote: >> On 6/19/23 14:31, Daniel P. Berrangé wrote: >>> On Mon, Jun 19, 2023 at 02:03:48PM +0200, Michal Privoznik wrote: It's weird that in 2023 there's no reliable and portable way to >

[RFC] Adding timestamp to guest's serial console log

2023-06-20 Thread Shaleen Bathla
Hi, Need some comments regarding the following feature : Addition of timestamp support for serial console logs of a guest. We can implement it as a configurable attribute in xml. For example : We can add a timestamp after every '\n' character received from qemu. Can I have some c