Thomas Huth wrote:
> On 12/06/2023 21.33, Juan Quintela wrote:
>> Only "defer" is recommended. After setting all migation parameters,
>> start incoming migration with "migrate-incoming uri" command.
>> Signed-off-by: Juan Quintela
>> ---
>> docs/about/deprecated.rst | 7 +++
>> softmmu/vl
When running libvirt from the build directory with the 'run' script, it
will run as unconfined_t. This can result in unexpected behavior when
selinux is enforcing due to the fact that the selinux policies are
written assuming that libvirt is running with the
system_u:system_r:virtd_t context. This
On 6/13/23 10:42 AM, Boris Fiuczynski wrote:
Update capabilities for QEMU 8.1 on s390x, add a new capability
async-teardown and make use of it when running on s390x hosts to improve
memory reclaiming.
Is this really something that should be enabled unconditionally on all
s390x guests, or shoul
On Wed, Jun 21, 2023 at 04:09:10PM +0200, Michal Privoznik wrote:
> As of commit v5.9-rc1~160^2~3 the Linux kernel has close_range()
> syscall, which closes not just one FD but whole range. In glibc
> this is exposed by automatically generated wrapper of the same
> name. In musl, this is not expose
On Wed, Jun 21, 2023 at 04:09:09PM +0200, Michal Privoznik wrote:
> As of commit v5.9-rc1~160^2~3 the Linux kernel has close_range()
> syscall, which closes not just one FD but whole range. Then, in
> its commit glibc-2.34~115 glibc introduced closefrom() which is
> just a wrapper over close_range(
On Wed, Jun 21, 2023 at 04:09:11PM +0200, Michal Privoznik wrote:
> This should not be needed, but here's what's happening:
> virStrToLong_*() family of functions was switched from strtol*()
> to g_ascii_strtol*() in order to handle corner cases on Windows
> (most notably parsing hex numbers with b
This is basically a v2 of:
https://listman.redhat.com/archives/libvir-list/2023-June/240320.html
But after discussion with Dan and most importantly, once he found the
root cause we can do proper fixes instead of papering over the issue.
Michal Prívozník (3):
vircommand: Use closefrom() more of
This should not be needed, but here's what's happening:
virStrToLong_*() family of functions was switched from strtol*()
to g_ascii_strtol*() in order to handle corner cases on Windows
(most notably parsing hex numbers with base=0) - see
v9.4.0-61-g2ed41d7cd9. But what we did not realize back then,
As of commit v5.9-rc1~160^2~3 the Linux kernel has close_range()
syscall, which closes not just one FD but whole range. Then, in
its commit glibc-2.34~115 glibc introduced closefrom() which is
just a wrapper over close_range(), but it allows us to use
FreeBSD-only implementation on Linux too, as bo
As of commit v5.9-rc1~160^2~3 the Linux kernel has close_range()
syscall, which closes not just one FD but whole range. In glibc
this is exposed by automatically generated wrapper of the same
name. In musl, this is not exposed, yet, but we can call the
syscall() directly. In either case, we have to
Historically we wanted to check if logind was actually running, not
merely activatable, because on systems where systemd is installed,
but the OS is booted into non-systemd init, we want to fallback to
pm-utils.
Requiring logind to be running, however, forces us to serialize libvirtd
startup on st
All services are ordered after local-fs.target unless they have set
DefaultDependencies=no, which we do not do.
https://gitlab.com/libvirt/libvirt/-/issues/489
Signed-off-by: Daniel P. Berrangé
---
src/ch/virtchd.service.in | 1 -
src/interface/virtinterfaced.service.in | 1 -
src/
Signed-off-by: Daniel P. Berrangé
---
src/util/virnodesuspend.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c
index 01f387d6fa..91a7f10eb9 100644
--- a/src/util/virnodesuspend.c
+++ b/src/util/virnodesuspend.c
@@ -249,6 +249,7 @@ virN
After the previous commit we no longer require that logind is actually
running, it merely has to be activatable.
https://gitlab.com/libvirt/libvirt/-/issues/489
Signed-off-by: Daniel P. Berrangé
---
src/ch/virtchd.service.in | 1 -
src/lxc/virtlxcd.service.in| 1 -
src/qemu/virtqemud.se
The unit files both have After=network.target, and this in turn implies
After=network-pre.target. Both iptables.service & ip6tables.service have
Before=network-pre.target since Fedora >= 35 and RHEL >= 8.4.
When we first added the deps on ip[6]tables.service in
commit 0756415f147dda15a417bd79ee
None of our daemons use select(), so it is safe to raise the max file
limit to its maximum on startup.
https://gitlab.com/libvirt/libvirt/-/issues/489
Signed-off-by: Daniel P. Berrangé
---
src/rpc/virnetdaemon.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/rpc/virnetdaemon.c b/src/
These wrappers added no semantic difference over calling the system
function directly.
Signed-off-by: Daniel P. Berrangé
---
src/util/virprocess.c | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/src/util/virprocess.c b/src/util/virprocess.c
index 2fd9b
Since systemd 240, all services get an open file hard limit of
500k, and a soft limit of 1024. This limit means apps are safe
to use select() by default which is limited to 1024 FDs. Apps
which don't use select() are expected to simply set their soft
limit to match the hard limit during startup.
W
These were suggested by Lennart in
https://gitlab.com/libvirt/libvirt/-/issues/489
Daniel P. Berrangé (9):
src: remove After=local-fs.target from systemd units
src: remote deps on ip[6]tables/firewalld.service from systemd units
util: remove pointless wrappers for setrlimit/getrlimit
u
Historically the max files limit for processes has always been 1024,
because going beyond this is incompatible with the select() function.
None the less most apps these days will use poll() so should not be
limited in this way.
Since systemd >= 240, the hard limit will be 500k, while the soft
limi
On 13/06/2023 17.42, Boris Fiuczynski wrote:
Enablement of asynchronous teardown on s390x and add a new test for
asynchronous teardown not supported.
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_command.c | 15 +
.../balloon-ccw-deflate.s390x-latest.args
On Mon, Jun 12, 2023 at 09:33:43PM +0200, Juan Quintela wrote:
> It is obsolete. It is better to use driver_mirror+NBD instead.
>
> CC: Kevin Wolf
> CC: Eric Blake
> CC: Stefan Hajnoczi
> CC: Hanna Czenczek
>
> Signed-off-by: Juan Quintela
>
> ---
>
> Can any of you give one example of ho
On Mon, Jun 12, 2023 at 09:33:44PM +0200, Juan Quintela wrote:
> Signed-off-by: Juan Quintela
> ---
> docs/about/deprecated.rst | 8
> qapi/migration.json | 92 ---
> migration/options.c | 13 ++
> 3 files changed, 79 insertions(+), 34 del
On 12/06/2023 21.33, Juan Quintela wrote:
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 8
qapi/migration.json | 92 ---
migration/options.c | 13 ++
3 files changed, 79 insertions(+), 34 deletions(-)
diff --git a/doc
On 12/06/2023 21.33, Juan Quintela wrote:
Only "defer" is recommended. After setting all migation parameters,
start incoming migration with "migrate-incoming uri" command.
Signed-off-by: Juan Quintela
---
docs/about/deprecated.rst | 7 +++
softmmu/vl.c | 2 ++
2 files chan
25 matches
Mail list logo
