Re: [libvirt] [PATCH RESEND 1/4] conf: Introduce notify VM exit feature

2023-07-05 Thread Daniel P . Berrangé
On Mon, Jul 03, 2023 at 02:30:28PM +0800, Lin Ma wrote: > VMX(kernel v6.0) supports Notification VM exit feature under commit 2f4073e0. > QEMU supports it as well since v7.2 under commit e2e69f6b. > > Add this feature into libvirt now. > > An example of Domain XML snippet to configure this

Re: [libvirt] [PATCH RESEND 2/4] qemu: Validate notify VM exit feature is available only on x86

2023-07-05 Thread Jonathon Jongsma
On 7/3/23 1:30 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- src/qemu/qemu_validate.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index a53729d349..6ec5af0028 100644 --- a/src/qemu/qemu_validate.c +++

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Daniel P . Berrangé
On Wed, Jul 05, 2023 at 05:21:21PM +0200, Thomas Huth wrote: > On 05/07/2023 16.35, Daniel P. Berrangé wrote: > > On Wed, Jul 05, 2023 at 03:29:39PM +0200, Claudio Imbrenda wrote: > > > On Wed, 5 Jul 2023 14:08:27 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Wed, Jul 05, 2023 at

Re: [libvirt] [PATCH RESEND 1/4] conf: Introduce notify VM exit feature

2023-07-05 Thread Jonathon Jongsma
On 7/3/23 1:30 AM, Lin Ma wrote: VMX(kernel v6.0) supports Notification VM exit feature under commit 2f4073e0. QEMU supports it as well since v7.2 under commit e2e69f6b. Add this feature into libvirt now. An example of Domain XML snippet to configure this feature:

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Thomas Huth
On 05/07/2023 16.35, Daniel P. Berrangé wrote: On Wed, Jul 05, 2023 at 03:29:39PM +0200, Claudio Imbrenda wrote: On Wed, 5 Jul 2023 14:08:27 +0100 Daniel P. Berrangé wrote: On Wed, Jul 05, 2023 at 02:46:03PM +0200, Claudio Imbrenda wrote: On Wed, 5 Jul 2023 13:26:32 +0100 Daniel P. Berrangé

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Daniel P . Berrangé
On Wed, Jul 05, 2023 at 04:27:46PM +0200, Boris Fiuczynski wrote: > On 7/5/23 3:08 PM, Daniel P. Berrangé wrote: > > On Wed, Jul 05, 2023 at 02:46:03PM +0200, Claudio Imbrenda wrote: > > > On Wed, 5 Jul 2023 13:26:32 +0100 > > > Daniel P. Berrangé wrote: > > > > > > [...] > > > > > > > > > I

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Daniel P . Berrangé
On Wed, Jul 05, 2023 at 03:29:39PM +0200, Claudio Imbrenda wrote: > On Wed, 5 Jul 2023 14:08:27 +0100 > Daniel P. Berrangé wrote: > > > On Wed, Jul 05, 2023 at 02:46:03PM +0200, Claudio Imbrenda wrote: > > > On Wed, 5 Jul 2023 13:26:32 +0100 > > > Daniel P. Berrangé wrote: > > > > > > [...] >

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Boris Fiuczynski
On 7/5/23 3:08 PM, Daniel P. Berrangé wrote: On Wed, Jul 05, 2023 at 02:46:03PM +0200, Claudio Imbrenda wrote: On Wed, 5 Jul 2023 13:26:32 +0100 Daniel P. Berrangé wrote: [...] I rather think mgmt apps need to explicitly opt-in to async teardown, so they're aware that they need to take

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Claudio Imbrenda
On Wed, 5 Jul 2023 14:08:27 +0100 Daniel P. Berrangé wrote: > On Wed, Jul 05, 2023 at 02:46:03PM +0200, Claudio Imbrenda wrote: > > On Wed, 5 Jul 2023 13:26:32 +0100 > > Daniel P. Berrangé wrote: > > > > [...] > > > > > > > I rather think mgmt apps need to explicitly opt-in to async

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Daniel P . Berrangé
On Wed, Jul 05, 2023 at 02:46:03PM +0200, Claudio Imbrenda wrote: > On Wed, 5 Jul 2023 13:26:32 +0100 > Daniel P. Berrangé wrote: > > [...] > > > > > I rather think mgmt apps need to explicitly opt-in to async teardown, > > > > so they're aware that they need to take account of delayed RAM > >

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Thomas Huth
On 05/07/2023 14.46, Claudio Imbrenda wrote: On Wed, 5 Jul 2023 13:26:32 +0100 Daniel P. Berrangé wrote: [...] I rather think mgmt apps need to explicitly opt-in to async teardown, so they're aware that they need to take account of delayed RAM availablity in their accounting / guest

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Claudio Imbrenda
On Wed, 5 Jul 2023 13:26:32 +0100 Daniel P. Berrangé wrote: [...] > > > I rather think mgmt apps need to explicitly opt-in to async teardown, > > > so they're aware that they need to take account of delayed RAM > > > availablity in their accounting / guest placement logic. > > > > what would

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Claudio Imbrenda
On Wed, 5 Jul 2023 10:18:37 +0100 Daniel P. Berrangé wrote: > On Wed, Jul 05, 2023 at 08:20:27AM +0200, Boris Fiuczynski wrote: > > Enable by default asynchronous teardown on S390 hosts and add tests for > > asynchronous teardown autogeneration support. > > On S390 hosts, Secure Execution guests

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Daniel P . Berrangé
On Wed, Jul 05, 2023 at 02:22:37PM +0200, Claudio Imbrenda wrote: > On Wed, 5 Jul 2023 10:18:37 +0100 > Daniel P. Berrangé wrote: > > > On Wed, Jul 05, 2023 at 08:20:27AM +0200, Boris Fiuczynski wrote: > > > Enable by default asynchronous teardown on S390 hosts and add tests for > > >

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Daniel P . Berrangé
On Wed, Jul 05, 2023 at 08:20:27AM +0200, Boris Fiuczynski wrote: > Enable by default asynchronous teardown on S390 hosts and add tests for > asynchronous teardown autogeneration support. > On S390 hosts, Secure Execution guests can take a long time to shutdown, > since the memory cleanup can take

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Boris Fiuczynski
On 7/5/23 8:20 AM, Boris Fiuczynski wrote: @@ -6694,6 +6706,13 @@ qemuDomainDefFormatBufInternal(virQEMUDriver *driver, } } } + +/* Remove asynchronous teardown enablement for backwards compatibility + * on S390 as it gets autogenerated

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Boris Fiuczynski
On 7/5/23 8:45 AM, Thomas Huth wrote: On 05/07/2023 08.20, Boris Fiuczynski wrote: Enable by default asynchronous teardown on S390 hosts and add tests for asynchronous teardown autogeneration support. On S390 hosts, Secure Execution guests can take a long time to shutdown, since the memory

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Thomas Huth
On 05/07/2023 08.20, Boris Fiuczynski wrote: Enable by default asynchronous teardown on S390 hosts and add tests for asynchronous teardown autogeneration support. On S390 hosts, Secure Execution guests can take a long time to shutdown, since the memory cleanup can take a long time. Since there

[libvirt PATCH v3 4/5] qemu: allow use of async teardown in domain

2023-07-05 Thread Boris Fiuczynski
Asynchronous teardown can be specified if the QEMU binary supports it by adding in the domain XML ... ... By default this new feature is disabled. Signed-off-by: Boris Fiuczynski Reviewed-by: Thomas Huth --- docs/formatdomain.rst | 6 +++

[libvirt PATCH v3 1/5] tests: remove acpi support from s390x ccw hotplug tests

2023-07-05 Thread Boris Fiuczynski
In newer QEMU libvirt combinations acpi support is no longer tolerated and ignored. Therfore before upgrading the test capabilities to QEMU 8.1.0 replies removing the acpi feature from the domain XMLs. Signed-off-by: Boris Fiuczynski Reviewed-by: Peter Krempa ---

[libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-05 Thread Boris Fiuczynski
Enable by default asynchronous teardown on S390 hosts and add tests for asynchronous teardown autogeneration support. On S390 hosts, Secure Execution guests can take a long time to shutdown, since the memory cleanup can take a long time. Since there is no practical way to determine whether a S390

[libvirt PATCH v3 3/5] qemu: add run-with async-teardown capability

2023-07-05 Thread Boris Fiuczynski
QEMU capability is looking in query-command-line-options response for ... { "parameters": [ { "name": "async-teardown", "type": "boolean" } ], "option": "run-with" } ... allow to use the QEMU option -run-with async-teardown=on|off

[libvirt PATCH v3 0/5] Enable asynchronous teardown

2023-07-05 Thread Boris Fiuczynski
Update capabilities for QEMU 8.1 on s390x, add a new capability async-teardown and make use of it when running on s390x hosts to improve memory reclaiming. v3: - rebased on upstream master - split QEMU hotplug input XML test file changes into separate patch - added missing slash in XML example