Re: [PATCH] node_device: Enclose Linux specific code in ifdef __linux__

2023-07-11 Thread Kristina Hanicova
On Tue, Jul 11, 2023 at 4:39 PM Michal Privoznik wrote: > Our CI started to enable udev backend on FreeBSD. And while there > is udev on FreeBSD some parts of our code are highly Linux > specific, e.g. translating SCSI device type to string (from an > integer obtained from the sysfs). Obviously,

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-11 Thread Claudio Imbrenda
On Tue, 11 Jul 2023 15:33:02 +0100 Daniel P. Berrangé wrote: > On Tue, Jul 11, 2023 at 04:22:12PM +0200, Claudio Imbrenda wrote: > > On Tue, 11 Jul 2023 14:57:45 +0100 > > Daniel P. Berrangé wrote: > > > > > On Tue, Jul 11, 2023 at 03:48:25PM +0200, Claudio Imbrenda wrote: > > > > On Tue, 1

[PATCH] node_device: Enclose Linux specific code in ifdef __linux__

2023-07-11 Thread Michal Privoznik
Our CI started to enable udev backend on FreeBSD. And while there is udev on FreeBSD some parts of our code are highly Linux specific, e.g. translating SCSI device type to string (from an integer obtained from the sysfs). Obviously, this doesn't work anywhere else. This is the reason why we need to

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-11 Thread Daniel P . Berrangé
On Tue, Jul 11, 2023 at 04:22:12PM +0200, Claudio Imbrenda wrote: > On Tue, 11 Jul 2023 14:57:45 +0100 > Daniel P. Berrangé wrote: > > > On Tue, Jul 11, 2023 at 03:48:25PM +0200, Claudio Imbrenda wrote: > > > On Tue, 11 Jul 2023 09:17:00 +0100 > > > Daniel P. Berrangé wrote: > > > > > > [...] >

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-11 Thread Claudio Imbrenda
On Tue, 11 Jul 2023 14:57:45 +0100 Daniel P. Berrangé wrote: > On Tue, Jul 11, 2023 at 03:48:25PM +0200, Claudio Imbrenda wrote: > > On Tue, 11 Jul 2023 09:17:00 +0100 > > Daniel P. Berrangé wrote: > > > > [...] > > > > > > We could add additional time depending on the guest memory size BUT

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-11 Thread Daniel P . Berrangé
On Tue, Jul 11, 2023 at 03:48:25PM +0200, Claudio Imbrenda wrote: > On Tue, 11 Jul 2023 09:17:00 +0100 > Daniel P. Berrangé wrote: > > [...] > > > > We could add additional time depending on the guest memory size BUT with > > > Secure Execution the timeout would need to be increased by factors (

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-11 Thread Claudio Imbrenda
On Tue, 11 Jul 2023 09:17:00 +0100 Daniel P. Berrangé wrote: [...] > > We could add additional time depending on the guest memory size BUT with > > Secure Execution the timeout would need to be increased by factors (two > > digits). Also for libvirt it is not possible to detect if the guest is i

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-11 Thread Daniel P . Berrangé
On Mon, Jul 10, 2023 at 11:57:34AM +0200, Boris Fiuczynski wrote: > On 7/5/23 4:47 PM, Daniel P. Berrangé wrote: > > On Wed, Jul 05, 2023 at 04:27:46PM +0200, Boris Fiuczynski wrote: > > > On 7/5/23 3:08 PM, Daniel P. Berrangé wrote: > > > > On Wed, Jul 05, 2023 at 02:46:03PM +0200, Claudio Imbrend

Add blocksize properties to libvirt

2023-07-11 Thread Андрей Ячменёв
Hello! I want to make patch for exposing min_io_size and opt_io_size properties toexport block topology information to the guest. This is needed to set optimali/o alignment for storages in underlay. This option already exists in qemu but haven't been implemented yet in libvirt. It is assumed if you