Re: [PATCH] qemu: don't add --mac-addr option to passt commandline

On 7/13/23 18:30, Laine Stump wrote: > When I implemented passt support in libvirt, I saw the --mac-addr > option on the passt commandline, immediately assumed that this was > used for setting the guest interface's mac address somewhere within > passt, and read no further. As a result,

[PATCH] qemu: don't add --mac-addr option to passt commandline

When I implemented passt support in libvirt, I saw the --mac-addr option on the passt commandline, immediately assumed that this was used for setting the guest interface's mac address somewhere within passt, and read no further. As a result, "--mac-addr" is always added to the passt commandline,

[PATCH] qemu: Add NUMA node automatically for memory hotplug

Up until v2.11.0-rc2~19^2~3 QEMU used to require at least one NUMA node to be configured when memory hotplug was enabled. After that commit, QEMU automatically adds a NUMA node if none was specified on the cmd line. Reflect this in domain XML, i.e. explicitly add a NUMA node into our domain

Re: [PATCH] qemu_domain: Deduplicate targetNode check in qemuDomainDefValidateMemoryHotplugDevice()

On Thu, Jul 13, 2023 at 4:05 PM Michal Privoznik wrote: > If a domain has NUMA configured, then all devices > (except for 'virtio-pmem') need to have targetNode set. There are > two checks inside of qemuDomainDefValidateMemoryHotplugDevice() > for this: one inside of big switch() statement,

[libvirt PATCH 03/10] docs: Link main "contributing" from programming-specific guide

There are two guides to contributing: `hacking.rst` is focused on code contributions, and `contributing.rst` is more general. Clarify scope of `hacking.rst` and link to the general guide in its references. Signed-off-by: Tim Small --- docs/hacking.rst | 3 ++- 1 file changed, 2 insertions(+), 1

[libvirt PATCH 4/6] cpu_map: Add missing feature "psdp-no"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 3352e6a83c..b871059c99 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -766,6

[libvirt PATCH 01/10] docs: Link to main docs directory from Quick Links

Whilst the "docs" documentation map is linked in the navigation bar, users may scroll down and lose sight of this, so also place at the bottom of the "Quick Links" section. Signed-off-by: Tim Small --- docs/index.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/index.rst

Re: [PATCH 1/2] libxl: Don't attempt to resume domain on canceled migration

On Wed, Jul 12, 2023 at 03:26:14PM -0600, Jim Fehlig wrote: > For unknown reasons, the libxl driver attempts to resume a domain in the > confirm phase when a migration operation has been canceled. This has shown > to be problematic when simulating scenarios that result in a canceled > migration.

Re: [PATCH 00/10] More real qemu capability testing cleanups

On 7/4/23 15:40, Peter Krempa wrote: > Few other patches to move towards purely real qemu-caps testing. > > Peter Krempa (10): > testutils: Print number of failed tests > domaincapstest: Use obviously fake firmware name in capabilities > testQemuGetRealCaps: Strip the default machine alias

[libvirt PATCH 10/10] docs: Reword ninja invocation note to clarify build directory

Minor rewording to clarify purpose of the -C flag in the ninja invocation, whilst retaining previous meaning. Signed-off-by: Tim Small --- docs/compiling.rst | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/compiling.rst b/docs/compiling.rst index

[libvirt PATCH 00/10] A set of minor doc updates for new contributors

As a prospective contributor, whilst the documentation is generally very helpful, I found a few minor gaps and inconsistencies. I thought I would strike while the iron was hot, and attempt to make some improvements. The changes are mostly minor clarifications, and additional internal references

Re: [PATCH 2/2] libxl: Advertise support for VIR_MIGRATE_CHANGE_PROTECTION

On Wed, Jul 12, 2023 at 03:26:15PM -0600, Jim Fehlig wrote: > The libxl driver has basic support for VIR_MIGRATE_CHANGE_PROTECTION > by starting and stopping modify jobs in the begin/confirm and prepare/finish > phases of migration, but it doesn't advertise that support. This can result > in

[libvirt PATCH 05/10] docs: Add config instructions for clangd with libvirt

In build environments which use gcc as the default compiler, use of the clangd LSP server (for enhanced code editing and navigation etc.) with libvirt requires some additional configuration. Detail this and link from `hacking.rst`. Signed-off-by: Tim Small --- docs/clangd.rst | 51

Re: [libvirt PATCH] docs: index: Add a quick link to Submitting patches

On Tue, Jul 4, 2023 at 10:26 AM Erik Skultety wrote: > We still get MRs in Gitlab from individual contributors on a regular > basis which in some ways just makes maintainer's or reviewer's life > just a bit more complicated. This ultimately means our guidelines are > probably not visible enough

[libvirt PATCH 2/6] cpu_map: Add missing feature "sbdr-ssdp-no"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 8c89de3344..ebc43be8ce 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -760,6

[libvirt PATCH 09/10] docs: Fix deprecated use of implicit meson "setup" command

Use the explicit meson "setup" command instead of the deprecated implicit invocation. The implied setup usage generates a warning with meson version 1.0.1: WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated. Additionally the

[libvirt PATCH 5/6] cpu_map: Add missing feature "pbrsb-no"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b871059c99..5845a2331b 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -772,6

[libvirt PATCH 1/6] cpu_map: Add missing feature "mcdt-no"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 4 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 3a90a4c9de..8c89de3344 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -448,6

Re: [PATCH 02/10] domaincapstest: Use obviously fake firmware name in capabilities

On 7/4/23 15:40, Peter Krempa wrote: > The domain capabilities data feature a firmware section which is filled > by few entries. The entries used until now looked real and it was > suspicious that a x86_64 host was listing aarch64 firmware images which > should not happen. > > Fill it by an

[libvirt PATCH 06/10] docs: Reword "Preparing Patches" to clarify

Clarify that patches should apply cleanly to the master branch. Give guidance for typical bug fix process for existing releases. Signed-off-by: Tim Small --- docs/hacking.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/hacking.rst b/docs/hacking.rst index

[libvirt PATCH 02/10] docs: Missing "full-stop"/"period" on some bullet items

Signed-off-by: Tim Small --- docs/contribute.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/contribute.rst b/docs/contribute.rst index 6ed5426b8a..c1d57a8584 100644 --- a/docs/contribute.rst +++ b/docs/contribute.rst @@ -25,19 +25,19 @@ to libvirt. If you have

[libvirt PATCH 0/6] Sync cpu features with qemu

This brings libvirt in sync qith qemu commit 6f05a92ddc73ac8aa16cfd6188f907b30b0501e3. Tim Wiederhake (6): cpu_map: Add missing feature "mcdt-no" cpu_map: Add missing feature "sbdr-ssdp-no" cpu_map: Add missing feature "fbsdp-no" cpu_map: Add missing feature "psdp-no" cpu_map: Add

[libvirt PATCH 3/6] cpu_map: Add missing feature "fbsdp-no"

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index ebc43be8ce..3352e6a83c 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -763,6

[libvirt PATCH 07/10] docs: Advise running CI tests prior to submission

In the preparing patches section, note that it is possible to run CI tests via gitlab prior to submitting patches. Signed-off-by: Tim Small --- docs/hacking.rst | 8 1 file changed, 8 insertions(+) diff --git a/docs/hacking.rst b/docs/hacking.rst index 85918c9176..c2e79e4501 100644

[libvirt PATCH 6/6] sync_qemu_models_i386.py: Add missing features

This brings the tool's list of features in sync with qemu commit 6f05a92ddc73ac8aa16cfd6188f907b30b0501e3. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_models_i386.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/cpu_map/sync_qemu_models_i386.py

[libvirt PATCH 04/10] docs: Point to compiling guide from code contribution guide

The "hacking" doc details where to find the code, but not how to compile it - link to the instructions contained in `compiling.rst`. Signed-off-by: Tim Small --- docs/hacking.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/hacking.rst b/docs/hacking.rst index

[libvirt PATCH 08/10] docs: Point to mailing list archives from submitting-patches

Suggest that new contributors should review past patch submissions for typical style, feedback etc. prior to submitting. Link to archives. Signed-off-by: Tim Small --- docs/submitting-patches.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/submitting-patches.rst

Re: [PATCH] qemu: Adapt to new way of specifying PC speaker

On 6/26/23 14:13, Michal Privoznik wrote: > Historically, the way to set PC speaker for a guest was to pass: > > -soundhw pcspk > > but as of QEMU commit v5.1.0-rc0~28^2~3 this is deprecated and we > should use: > > -machine pcspk-audiodev=$id > > instead. The old way was then removed in

[PATCH] qemu_domain: Deduplicate targetNode check in qemuDomainDefValidateMemoryHotplugDevice()

If a domain has NUMA configured, then all devices (except for 'virtio-pmem') need to have targetNode set. There are two checks inside of qemuDomainDefValidateMemoryHotplugDevice() for this: one inside of big switch() statement, which only checks 'dimm' and 'nvdimm' cases, and the other at the end

PING [PATCH 0/2] fix use-after-free in network IO

On 04/07/2023 13:10, Oleg Vasilev wrote: Found by repeatedly created and destroyed channels with guest agent. More details in the patch. Oleg Vasilev (2): net: add debug logs remote: fix stream use-after-free src/remote/remote_daemon_stream.c | 13 +++--