Re: [libvirt PATCH v3 2/8] util: add stub driver name to virPCIDevice object

2023-08-23 Thread Laine Stump
On 8/23/23 3:52 AM, Michal Prívozník wrote: On 8/21/23 21:32, Laine Stump wrote: There can be many different drivers that are of the type "VFIO", so add the driver name to the object and allow getting/setting it. Signed-off-by: Laine Stump --- src/libvirt_private.syms | 2 ++

Re: [libvirt PATCH v3 7/8] node_device: support binding other drivers with virNodeDeviceDetachFlags()

2023-08-23 Thread Laine Stump
On 8/23/23 3:52 AM, Michal Prívozník wrote: On 8/21/23 21:32, Laine Stump wrote: In the past, the only allowable values for the "driver" field of virNodeDeviceDetachFlags() were "kvm" or "vfio" for the QEMU driver, and "xen" for the libxl driver. Then "kvm" was deprecated and removed, so the

Re: [libvirt PATCH v6 35/36] run: add ability to set selinux context

2023-08-23 Thread Jonathon Jongsma
On 8/23/23 2:29 AM, Erik Skultety wrote: On Tue, Aug 22, 2023 at 03:24:03PM +0200, Peter Krempa wrote: On Thu, Jul 20, 2023 at 17:20:02 -0500, Jonathon Jongsma wrote: When running libvirt from the build directory with the 'run' script, it will run as unconfined_t. This can result in unexpected

Re: [libvirt PATCH v3 8/8] qemu: turn two multiline log messages into single line

2023-08-23 Thread Laine Stump
On 8/23/23 3:52 AM, Michal Prívozník wrote: On 8/21/23 21:32, Laine Stump wrote: Normally I wouldn't bother with a change like this, but I was touching the function anyway, and wanted to leave it looking nice and tidy. Signed-off-by: Laine Stump --- src/qemu/qemu_driver.c | 6 ++ 1

Re: [PATCH v2 0/5] Improve closing of FDs for child processes

2023-08-23 Thread Ján Tomko
On a Tuesday in 2023, Michal Privoznik wrote: This is a v2 of: https://listman.redhat.com/archives/libvir-list/2023-June/240351.html Hopefully, I've implemented all Dan's suggestions. Michal Prívozník (5): virfile: Introduce virCloseRange() virfile: Introduce virCloseFrom() vircommand:

Re: [PATCH 1/5] virfile: Introduce virCloseRange()

2023-08-23 Thread Ján Tomko
On a Tuesday in 2023, Michal Privoznik wrote: Linux gained new close_range() syscall (in v5.9) that allows closing a range of FDs in a single syscall. Ideally, we would use it to close FDs when spawning a process (e.g. via virCommand module). Glibc has close_range() wrapper over the syscall,

Re: [libvirt PATCH v3 0/8] Support for VFIO variant drivers, Part 1

2023-08-23 Thread Joao Martins
On 21/08/2023 20:32, Laine Stump wrote: > A "VFIO variant" driver is a kernel driver for a device that supports > all the APIs of the basic vfio-pci driver (which enables assigning a > host PCI device to a QEMU guest) plus "some extra stuff" (e.g. to > enable things like saving/restoring device

Re: [libvirt PATCH 09/20] ci: build.sh: Join MESON_ARGS and MESON_OPTS

2023-08-23 Thread Erik Skultety
On Mon, Aug 21, 2023 at 05:17:06AM -0700, Andrea Bolognani wrote: > Resurrecting this thread now what you've pushed some of the patches. > > On Mon, Feb 06, 2023 at 02:53:06PM +0100, Erik Skultety wrote: > > +# $MESON_ARGS correspond to meson's setup args, i.e. configure args. It's > > +#

Re: [libvirt PATCH v3 1/8] util: use "stubDriverType" instead of just "stubDriver"

2023-08-23 Thread Michal Prívozník
On 8/21/23 21:32, Laine Stump wrote: > In the past we just kept track of the type of the "stub driver" (the > driver that is bound to a device in order to assign it to a > guest). The next commit will add a stubDriverName to go along with > type, so lets use stubDriverType for the existing enum to

Re: [libvirt PATCH v3 4/8] util: permit existing binding to VFIO variant driver

2023-08-23 Thread Michal Prívozník
On 8/21/23 21:32, Laine Stump wrote: > Before a PCI device can be assigned to a guest with VFIO, that device > must be bound to the vfio-pci driver rather than to the device's > normal host driver. The vfio-pci driver provides APIs that permit QEMU > to perform all the necessary operations to make

Re: [libvirt PATCH v3 2/8] util: add stub driver name to virPCIDevice object

2023-08-23 Thread Michal Prívozník
On 8/21/23 21:32, Laine Stump wrote: > There can be many different drivers that are of the type "VFIO", so > add the driver name to the object and allow getting/setting it. > > Signed-off-by: Laine Stump > --- > src/libvirt_private.syms | 2 ++ > src/util/virpci.c| 16

Re: [libvirt PATCH v3 7/8] node_device: support binding other drivers with virNodeDeviceDetachFlags()

2023-08-23 Thread Michal Prívozník
On 8/21/23 21:32, Laine Stump wrote: > In the past, the only allowable values for the "driver" field of > virNodeDeviceDetachFlags() were "kvm" or "vfio" for the QEMU driver, > and "xen" for the libxl driver. Then "kvm" was deprecated and removed, > so the driver name became essentially irrelevant

Re: [libvirt PATCH v3 8/8] qemu: turn two multiline log messages into single line

2023-08-23 Thread Michal Prívozník
On 8/21/23 21:32, Laine Stump wrote: > Normally I wouldn't bother with a change like this, but I was touching > the function anyway, and wanted to leave it looking nice and tidy. > > Signed-off-by: Laine Stump > --- > src/qemu/qemu_driver.c | 6 ++ > 1 file changed, 2 insertions(+), 4

Re: [libvirt PATCH v3 0/8] Support for VFIO variant drivers, Part 1

2023-08-23 Thread Michal Prívozník
On 8/21/23 21:32, Laine Stump wrote: > A "VFIO variant" driver is a kernel driver for a device that supports > all the APIs of the basic vfio-pci driver (which enables assigning a > host PCI device to a QEMU guest) plus "some extra stuff" (e.g. to > enable things like saving/restoring device state

Re: [libvirt PATCH v6 35/36] run: add ability to set selinux context

2023-08-23 Thread Erik Skultety
On Tue, Aug 22, 2023 at 03:24:03PM +0200, Peter Krempa wrote: > On Thu, Jul 20, 2023 at 17:20:02 -0500, Jonathon Jongsma wrote: > > When running libvirt from the build directory with the 'run' script, it > > will run as unconfined_t. This can result in unexpected behavior when > > selinux is

Re: [PATCH] qemuValidateDomainVCpuTopology: Remove misconfiguration warning

2023-08-23 Thread Michal Prívozník
On 8/22/23 15:09, Peter Krempa wrote: > Since commit baca59a5384 the NUMA definition is automatically fixed if > the vCPU count mismatches the NUMA cpu count so that this warning will > never be triggered. > > Additionally VIR_WARN of a misconfiguration of a VM would not really > be seen in most