On a Thursday in 2023, Andrea Bolognani wrote:
Initially reported in
https://listman.redhat.com/archives/libvir-list/2023-August/241307.html
Andrea Bolognani (2):
ci: Fix precedence between arguments passed to meson
ci: Fix quoting and option name
ci/build.sh | 10 ++
1 file
update the manpage for the virsh nodedev-detach --driver option, and add a
blurb to the NEWS file for the upcoming release
Laine Stump (2):
docs: update description of virsh nodedev-detach --driver option
NEWS: document support for VFIO variant drivers
NEWS.rst| 11
Signed-off-by: Laine Stump
---
NEWS.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 3571c01b29..e40c8ac259 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -17,6 +17,17 @@ v9.7.0 (unreleased)
* **New features**
+ * qemu: basic support for use of "VFIO
--driver can now be used to specify a specific driver to bind to the
device being detached from the host driver (e.g. vfio-pci-igbvf), not
just the *type* of driver (e.g. "vfio" or "xen", which are unnecessary
anyway, since they are implicit in which hypervisor driver is in use)
Signed-off-by:
On Thu, Aug 24, 2023 at 18:21:40 +0200, Pavel Hrdina wrote:
> Libvirt supports creating snapshots for a long time but the wording of
> the feature may imply that libvirt supports external snapshots in
> general but that is not true as users were not able to use APIs to
> delete or revert external
On Thu, Aug 24, 2023 at 18:21:41 +0200, Pavel Hrdina wrote:
> Now that deleting and reverting external snapshots is implemented we can
> report that in capabilities so management applications can use that
> information and start using external snapshots.
>
> Signed-off-by: Pavel Hrdina
> ---
>
Now that deleting and reverting external snapshots is implemented we can
report that in capabilities so management applications can use that
information and start using external snapshots.
Signed-off-by: Pavel Hrdina
---
docs/formatcaps.rst| 6 ++
Libvirt supports creating snapshots for a long time but the wording of
the feature may imply that libvirt supports external snapshots in
general but that is not true as users were not able to use APIs to
delete or revert external snapshots.
Signed-off-by: Pavel Hrdina
---
docs/formatcaps.rst |
Pavel Hrdina (2):
capabilities: reword disksnapshot feature to mention creating
snapshots
capabilities: report full external snapshot support
docs/formatcaps.rst| 12 +---
src/conf/capabilities.c| 1 +
src/conf/capabilities.h
On Thu, Aug 24, 2023 at 05:44:32PM +0200, Peter Krempa wrote:
> On Thu, Aug 24, 2023 at 17:29:49 +0200, Pavel Hrdina wrote:
> > Now that deleting and reverting external snapshots is implemented we can
> > report that in capabilities so management applications can use that
> > information and start
On Wed, Aug 23, 2023 at 11:38:17AM +0200, Erik Skultety wrote:
> On Mon, Aug 21, 2023 at 05:17:06AM -0700, Andrea Bolognani wrote:
> > On Mon, Feb 06, 2023 at 02:53:06PM +0100, Erik Skultety wrote:
> > > -meson setup build --werror -Dsystem=true $MESON_OPTS $MESON_ARGS || \
> > >
Commit 9c9848f955fd merged $MESON_OPTS into $MESON_ARGS, and
while doing so changed their behavior: while until then the
contents of $MESON_ARGS had precedence over those of $MESON_OPTS,
now the opposite is true. Restore the original behavior and
document it.
The argument for merging the two
Multiple values passed to --meson-args need to be quoted so that
the shell will interpret them correctly. The option's name was
also reported incorrectly, so fix that as well.
Signed-off-by: Andrea Bolognani
---
ci/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Initially reported in
https://listman.redhat.com/archives/libvir-list/2023-August/241307.html
Andrea Bolognani (2):
ci: Fix precedence between arguments passed to meson
ci: Fix quoting and option name
ci/build.sh | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
--
On Thu, Aug 24, 2023 at 17:29:49 +0200, Pavel Hrdina wrote:
> Now that deleting and reverting external snapshots is implemented we can
> report that in capabilities so management applications can use that
> information and start using external snapshots.
>
> Signed-off-by: Pavel Hrdina
> ---
>
Now that deleting and reverting external snapshots is implemented we can
report that in capabilities so management applications can use that
information and start using external snapshots.
Signed-off-by: Pavel Hrdina
---
docs/formatcaps.rst| 6 ++
On a Thursday in 2023, Peter Krempa wrote:
Peter Krempa (5):
qemuxml2xmltest: Rework file name generation in 'testInfoSetPaths'
qemuxml2xmltest: Use DO_TEST_CAPS_ARCH_LATEST_FULL for arm GIC tests
qemuxml2argvtest: Pass expected state via struct testQemuInfo's
'flags' member
Use real capabilities for these last few tests that were not modernized
due to use of 'WHEN_INACTIVE'.
Signed-off-by: Peter Krempa
---
...el-dynamic-baselabel-inactive.x86_64-latest.xml} | 5 -
...el-dynamic-labelskip-inactive.x86_64-latest.xml} | 5 -
Peter Krempa (5):
qemuxml2xmltest: Rework file name generation in 'testInfoSetPaths'
qemuxml2xmltest: Use DO_TEST_CAPS_ARCH_LATEST_FULL for arm GIC tests
qemuxml2argvtest: Pass expected state via struct testQemuInfo's
'flags' member
qemuxml2xmltest: Modernize rest of 'seclabel-*' tests
Pass the state-based suffix directly as string.
Document the logic how the filename is chosen.
Signed-off-by: Peter Krempa
---
tests/qemuxml2xmltest.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
Rather than having a separate argument to DO_TEST pass the state via
newly added flags 'FLAG_SKIP_CONFIG_ACTIVE'. The '_INACTIVE' equivalent
was not added as there's no test which'd use it.
Remove the old 'WHEN_' flags and move the decision logic out of the
DO_TEST macro as any addition to the
Now all tests invoke a real-capability version. Remove DO_TEST.
Signed-off-by: Peter Krempa
---
tests/qemuxml2xmltest.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index f6be677694..895e24d522 100644
Use the new macro instead of open coding it.
Signed-off-by: Peter Krempa
---
tests/qemuxml2xmltest.c | 84 +++--
1 file changed, 21 insertions(+), 63 deletions(-)
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index ccf9cfcef0..c67909404f
On a Thursday in 2023, Peter Krempa wrote:
Peter Krempa (2):
tests: chxml2xmlin: Fix path format for fake paths
virschematest: Validate files in 'chxml2xmlin' and 'chxml2xmlout'
directories
tests/chxml2xmlin/basic.xml | 4 ++--
tests/virschematest.c | 2 ++
2 files changed, 4
The test files for the 'ch' driver were not validated against the schema
and thus also didn't conform to the schema.
Signed-off-by: Peter Krempa
---
tests/virschematest.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/virschematest.c b/tests/virschematest.c
index
Our XML schema requires absolute paths for the and disk source
values. Fix the 'ch' test to have absolute paths.
Signed-off-by: Peter Krempa
---
tests/chxml2xmlin/basic.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/chxml2xmlin/basic.xml
Peter Krempa (2):
tests: chxml2xmlin: Fix path format for fake paths
virschematest: Validate files in 'chxml2xmlin' and 'chxml2xmlout'
directories
tests/chxml2xmlin/basic.xml | 4 ++--
tests/virschematest.c | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.41.0
On Thu, Aug 24, 2023 at 10:57 AM Michal Privoznik
wrote:
> See 2/6 for explanation.
>
> Michal Prívozník (6):
> nodedevmdevctltest: Rename mdevctl-list-empty test case
> nodeDeviceParseMdevctlJSON: Accept empty string
> nodedevmdevctltest: Introduce a test case for empty mdevctl output
>
On 8/24/23 12:57, Kristina Hanicova wrote:
> Add missing ABI stability check for blockio properties for disk
> devices.
>
> Signed-off-by: Kristina Hanicova
> ---
> src/conf/domain_conf.c | 25 +
> 1 file changed, 25 insertions(+)
>
Reviewed-by: Michal Privoznik
On Thu, Aug 24, 2023 at 10:57 AM Michal Privoznik
wrote:
> It is possible for 'mdevctl' to output nothing, an empty string
> (e.g. when no mediated devices are defined on the host). What is
> weird is that when passing '--defined' then 'mdevctl' outputs an
> empty JSON array instead.
Add missing ABI stability check for blockio properties for disk
devices.
Signed-off-by: Kristina Hanicova
---
src/conf/domain_conf.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 2e60927799..71bd49bf95 100644
After 'mdevctl' was ran, its stdout is captured in @output which
is then compared against NULL and if it is NULL a negative value
is returned (to indicate error to the caller). But this is
effectively a dead code, because virCommand (specifically
virCommandProcessIO()) makes sure both stdout and
Previous commits were all about empty strings and empty JSON
arrays. Introduce a test case for "[]" to make sure we pare it
correctly.
Signed-off-by: Michal Privoznik
---
tests/virjsontest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/virjsontest.c b/tests/virjsontest.c
index
We have virMdevctlListDefined() to list defined mdevs, and
virMdevctlListActive() to list active mdevs. Both have the same
body except for one boolean argument passed to
nodeDeviceGetMdevctlListCommand(). Join the two functions under
virMdevctlList() name and introduce @defined argument that is
It is possible for 'mdevctl' to output nothing, an empty string
(e.g. when no mediated devices are defined on the host). What is
weird is that when passing '--defined' then 'mdevctl' outputs an
empty JSON array instead. Nevertheless, we should accept both and
threat them the same, i.e. as no
The mdevctl-list-empty test case is there to test whether an
empty JSON array "[]" is handled correctly by mdevctl handling
code. Well, mdevctl can output both, an empty JSON array or no
output at all.
Therefore, rename "mdevctl-list-empty" test case to
"mdevctl-list-empty-array" which is more
As explained earlier, 'mdevctl' can output nothing. Add a test
case to nodedevmdevctltest which covers this situation.
Signed-off-by: Michal Privoznik
---
tests/nodedevmdevctldata/mdevctl-list-empty.json| 0
tests/nodedevmdevctldata/mdevctl-list-empty.out.xml | 0
tests/nodedevmdevctltest.c
See 2/6 for explanation.
Michal Prívozník (6):
nodedevmdevctltest: Rename mdevctl-list-empty test case
nodeDeviceParseMdevctlJSON: Accept empty string
nodedevmdevctltest: Introduce a test case for empty mdevctl output
node_device_driver: Deduplicate mediated devices listing
On Tue, Aug 22, 2023 at 3:35 PM Michal Privoznik
wrote:
> This is a v2 of:
>
> https://listman.redhat.com/archives/libvir-list/2023-June/240351.html
>
> Hopefully, I've implemented all Dan's suggestions.
>
> Michal Prívozník (5):
> virfile: Introduce virCloseRange()
> virfile: Introduce
On 8/23/23 22:06, Laine Stump wrote:
> On 8/23/23 3:52 AM, Michal Prívozník wrote:
>> On 8/21/23 21:32, Laine Stump wrote:
>>> Normally I wouldn't bother with a change like this, but I was touching
>>> the function anyway, and wanted to leave it looking nice and tidy.
>>>
>>> Signed-off-by: Laine
40 matches
Mail list logo
