[libvirt PATCH 07/33] ci: build.sh: Add a helper function to create the dist tarball

This helper function does not correspond to a particular GitLab job, it just logically separates the necessary step of creating a dist tarball from the RPM build job that takes over. One notable change here is the need to update git's file index which causes issues in local container executions

[libvirt PATCH 21/33] .gitlab-ci.yml: Convert the potfile job to the build.sh usage

Individual shell command executions are replaced by respective functions in the ci/build.sh base script. This will make sure we use the same recipes in GitLab jobs as well as in local executions. Signed-off-by: Erik Skultety --- .gitlab-ci.yml | 5 ++--- 1 file changed, 2 insertions(+), 3

[libvirt PATCH 27/33] ci: helper: Add Python code hangling git clones

This helper will be utilized by a future patch which will add the lcitool container execution logic. The reason why the required_deps decorator isn't being used here is because this is a property. Signed-off-by: Erik Skultety --- ci/helper | 9 + 1 file changed, 9 insertions(+) diff

[libvirt PATCH 30/33] ci: helper: Add an action to run the container workload via lcitool

Just like with the other CLI sub-commands, add an action to run a GitLab spec job in a local container via lcitool. Signed-off-by: Erik Skultety --- ci/helper | 4 1 file changed, 4 insertions(+) diff --git a/ci/helper b/ci/helper index 887e64ece1..7385d3b95c 100755 --- a/ci/helper +++

[libvirt PATCH 26/33] ci: helper: Add a required_deps higher order helper/decorator

Since we'll depend on GitPython for repo cloning, we need to make sure to emit a user friendly error if the module is not installed. This patch introduces a helper which future patches will use as a decorator. Inspiration for this helper has been taken out of lcitool where we use an identical

[libvirt PATCH 12/33] ci: build.sh: Add a wrapper function over the 'website' job

This helper is a shell function transcript of its original GitLab CI counterpart. Signed-off-by: Erik Skultety --- ci/build.sh | 8 1 file changed, 8 insertions(+) diff --git a/ci/build.sh b/ci/build.sh index 30f4712e4b..6673ec6b18 100644 --- a/ci/build.sh +++ b/ci/build.sh @@ -105,3

[libvirt PATCH 18/33] .gitlab-ci.yml: Convert the cross build job to the build.sh usage

Individual shell command executions are replaced by respective functions in the ci/build.sh base script. This will make sure we use the same recipes in GitLab jobs as well as in local executions. Signed-off-by: Erik Skultety --- .gitlab-ci.yml | 10 ++ 1 file changed, 6 insertions(+), 4

[libvirt PATCH 06/33] ci: build.sh: Add a wrapper function over the 'build' job

This helper is a shell function transcript of its original GitLab CI counterpart. Signed-off-by: Erik Skultety --- ci/build.sh | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ci/build.sh b/ci/build.sh index d4fbf0ab37..c2f54707ce 100644 --- a/ci/build.sh +++ b/ci/build.sh @@ -47,3

[libvirt PATCH 20/33] .gitlab-ci.yml: Convert the codestyle job to the build.sh usage

Individual shell command executions are replaced by respective functions in the ci/build.sh base script. This will make sure we use the same recipes in GitLab jobs as well as in local executions. Signed-off-by: Erik Skultety --- .gitlab-ci.yml | 6 ++ 1 file changed, 2 insertions(+), 4

[libvirt PATCH 32/33] ci: helper: Drop the --meson-args/--ninja-args CLI options

These originally allowed customizing the ci/Makefile script which was the core of the local container executions. The problem was that however flexible this may have been, it never mirrored what was being done as part of the GitLab jobs. Motivated by the effort of mirroring GitLab jobs locally,

[libvirt PATCH 23/33] ci: helper: Don't make ':' literal a static part of the image tag

':' is just a connecting character, we can add it to the appropriate place later in the Python script later, but it doesn't make sense to be part of the image 'tag' string. Signed-off-by: Erik Skultety --- ci/helper | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/helper

[libvirt PATCH 33/33] ci: helper: Drop the _make_run method

We've successfully migrated over to lcitool to take care of the container workload execution, so dropping this 'make' prep code is a prerequisite of finally getting rid of the ci/Makefile script. Signed-off-by: Erik Skultety --- ci/helper | 25 - 1 file changed, 25

[libvirt PATCH 08/33] ci: build.sh: Add a wrapper function over the 'test' job

This helper is a shell function transcript of its original GitLab CI counterpart. Signed-off-by: Erik Skultety --- ci/build.sh | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ci/build.sh b/ci/build.sh index c56e45f51f..ab471f2741 100644 --- a/ci/build.sh +++ b/ci/build.sh @@ -66,3

[libvirt PATCH 31/33] ci: helper: Drop original actions

Previous patches added a single 'run' command parametrized with GitLab job specs via '--job' that cover all of these original actions, adding some more in the process. Drop the original actions as we don't need them anymore. Signed-off-by: Erik Skultety --- ci/helper | 36

[libvirt PATCH 28/33] ci: helper: Add a helper to create a local repo clone Pythonic way

A proper Python equivalent of 'git clone --local'. Signed-off-by: Erik Skultety --- ci/helper | 4 1 file changed, 4 insertions(+) diff --git a/ci/helper b/ci/helper index 2a51ce1786..d704d1f711 100755 --- a/ci/helper +++ b/ci/helper @@ -211,6 +211,10 @@ class Application: if

[libvirt PATCH 19/33] .gitlab-ci.yml: Convert the website build job to the build.sh usage

Individual shell command executions are replaced by respective functions in the ci/build.sh base script. This will make sure we use the same recipes in GitLab jobs as well as in local executions. Signed-off-by: Erik Skultety --- .gitlab-ci.yml | 5 ++--- 1 file changed, 2 insertions(+), 3

[libvirt PATCH 11/33] ci: build.sh: Add a wrapper function over the 'rpmbuild' job

This helper is a shell function transcript of its original GitLab CI counterpart. Signed-off-by: Erik Skultety --- ci/build.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ci/build.sh b/ci/build.sh index 6990f2d171..30f4712e4b 100644 --- a/ci/build.sh +++ b/ci/build.sh @@

[libvirt PATCH 25/33] ci: helper: Add a job argparse subparser

The idea behind this subcommand is to follow whatever build job we have defined in the GitLab CI pipeline, so that we only have a single source of truth for the recipes. Adds 'shell' as an extra option for interactive container build debugging. Signed-off-by: Erik Skultety --- ci/helper | 15

[libvirt PATCH 22/33] ci: helper: Drop _lcitool_get_targets method

This method unused anywhere, so drop it. Signed-off-by: Erik Skultety --- ci/helper | 4 1 file changed, 4 deletions(-) diff --git a/ci/helper b/ci/helper index fb562d55e1..8986772153 100755 --- a/ci/helper +++ b/ci/helper @@ -163,10 +163,6 @@ class Application: output =

[libvirt PATCH 24/33] ci: helper: Add --lcitool-path CLI option

We'll soon be relying solely on lcitool so we need to be able to run it from a user-provided location if it's not installed in a known location. Signed-off-by: Erik Skultety --- ci/helper | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ci/helper b/ci/helper index

[libvirt PATCH 16/33] gitlab-ci.yml: Add 'after_script' stage to prep for artifact collection

This is one of the preparation steps that if not done would otherwise collide with local container executions where we: 1) don't collect artifacts 2) are not limited by GitLab's environment and hence moving build artifacts to unusual places would only cause confusion when doing local build

[libvirt PATCH 29/33] ci: helper: Rework _lcitool_run method logic

This method wasn't even utilized before this patch. This patch adds all the necessary logic to successfully execute a container workload via lcitool (which will later allow us to ditch ci/Makefile). Because container executions via lcitool creates the following inside the container: $ ls

[libvirt PATCH 17/33] .gitlab-ci.yml: Convert the native build job to the build.sh usage

Individual shell command executions are replaced by respective functions in the ci/build.sh base script. This will make sure we use the same recipes in GitLab jobs as well as in local executions. Signed-off-by: Erik Skultety --- .gitlab-ci.yml | 10 -- 1 file changed, 4 insertions(+), 6

[libvirt PATCH 10/33] ci: build.sh: Add a wrapper function over the 'potfile' job

This helper is a shell function transcript of its original GitLab CI counterpart. There's one notable difference such that we pass '-j1' to the meson compile command otherwise we'd have to execute the 'run_build' function twice, passing 'libvirt-pot-dep' and 'libvirt-pot' targets in a serial

[libvirt PATCH 14/33] ci: build.sh: Drop direct invocation of meson/ninja commands

We've moved all invocations to the respective helper function which we'll execute both from gitlab CI jobs and local environments so we don't need to have them on the global level as it would also not work with "sourcing" this file to populate the environment with function definitions.

[libvirt PATCH 15/33] ci: build.sh: Drop MESON_ARGS definition from global level

Signed-off-by: Erik Skultety --- ci/build.sh | 10 -- 1 file changed, 10 deletions(-) diff --git a/ci/build.sh b/ci/build.sh index b075c49af3..5eef53f8d1 100644 --- a/ci/build.sh +++ b/ci/build.sh @@ -8,16 +8,6 @@ export VIR_TEST_VERBOSE="1" export VIR_TEST_DEBUG="1" GIT_ROOT="$(git

[libvirt PATCH 13/33] ci: build.sh: Drop changing working directory to CI_CONT_DIR

Firstly, this would mangle with "sourcing" this file in either execution environment later down the road. Secondly, we won't need this as future ci/helper patches will generate a throwaway script that will take care of a correct execution of a build job in a similar fashion as if the job ran in a

[libvirt PATCH 09/33] ci: build.sh: Add a wrapper function over the 'codestyle' job

This helper is a shell function transcript of its original GitLab CI counterpart. Signed-off-by: Erik Skultety --- ci/build.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/ci/build.sh b/ci/build.sh index ab471f2741..b2891a0c0f 100644 --- a/ci/build.sh +++ b/ci/build.sh @@ -73,3

[libvirt PATCH 05/33] ci: build.sh: Add a wrapper function executing 'shell' commands

This would normally be not needed at all, but the problem here is the Shell-in-YAML which GitLab interprets. It outputs every command that appears as a line in the 'script' segment in a color-coded fashion for easy identification of problems. Well, that useful feature is lost when there's

[libvirt PATCH 04/33] ci: build.sh: Add a wrapper function over meson's setup

The reason for this wrapper is that all job functions introduced in future patches will refer to this one instead of open-coding the same 'meson setup' invocation N times. It also prevents 'setup' to be called multiple times as some future job functions might actually do just that in a transitive

[libvirt PATCH 02/33] ci: build.sh: Add GIT_ROOT env helper variable

We'll use this one in many of the job functions future patches will introduce, it's a neat shortcut to avoid using relative paths. Signed-off-by: Erik Skultety --- ci/build.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ci/build.sh b/ci/build.sh index d5586f457c..152c44 100644 ---

[libvirt PATCH 03/33] ci: build.sh: Don't mention that MESON_ARGS are available via CLI

Previous patches have removed the code that allowed injecting arbitrary meson arguments, same for ninja args. Signed-off-by: Erik Skultety --- ci/build.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ci/build.sh b/ci/build.sh index 152c44..82016ba29c 100644 ---

[libvirt PATCH 00/33] ci: Unify the GitLab CI jobs with local executions && adopt lcitool container executions

Technically a v2 of: https://listman.redhat.com/archives/libvir-list/2023-February/237552.html However, the approach here is slightly different and what that series said about migration to lcitool container executions as a replacement for ci/Makefile is actually done here. One of the core

[libvirt PATCH 01/33] ci: build.sh: Add variables from .gitlab-ci.yml

These are common variables we wish to use in containerized environments both in GitLab and locally. Having these defined in a single place rather than twice is highly preferable. Signed-off-by: Erik Skultety --- ci/build.sh | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [libvirt PATCH v2 5/7] Add virNetworkObj Get and Set Methods for Metadata

My previous misunderstanding was exactly as you mentioned, to group commits on a file to file basis. Now I have understood what a semantic change should be like, with your provided example. You are not asking for much, your corrections help me a lot in my learning journey and I am very grateful

[PATCH] NEWS: Announcing Network Metadata APIs

Ref to patchset implementing the above: https://listman.redhat.com/archives/libvir-list/2023-August/241250.html Signed-off-by: K Shiva Kiran --- NEWS.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 73571f0019..01df22ef03 100644 ---

[PATCH] REFACTOR: Eliminate newlines in messages and fixes a typo

Removes newlines of error message strings in metadata unit tests, libvirt-domain.c and libvirt-network.c Fixes a minor typo in libvirt-domain.c Signed-off-by: K Shiva Kiran --- include/libvirt/libvirt-domain.h | 2 +- src/libvirt-domain.c | 3 +-- src/libvirt-network.c|

Re: [PATCH v3 0/2] add support for discard_granularity

On Fri, Aug 25, 2023 at 14:50:30 +0200, Kristina Hanicova wrote: > v3 of: > https://listman.redhat.com/archives/libvir-list/2023-August/241452.html > > diff to v2 (suggested by Peter): > * added note to the first commit > * enabled qemuxml2xmltest for blockio > * moved one hunk to the first

[libvirt PATCH 1/2] tools: fix handling of CPU family/model/stepping in SEV validation

The SEV-ES boot measurement includes the initial CPU register state (VMSA) and one of the fields includes the CPU identification. When building a VMSA blob we get the CPU family/model/stepping from the host capabilities, however, the VMSA must reflect the guest CPU not host CPU. Thus using host

[libvirt PATCH 0/2] tools: some fixes to VMSA construction when validating SEV boot

Daniel P. Berrangé (2): tools: fix handling of CPU family/model/stepping in SEV validation tools: fix VMSA construction with explicit CPU family/model/stepping tools/virt-qemu-sev-validate | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) -- 2.41.0

[libvirt PATCH 2/2] tools: fix VMSA construction with explicit CPU family/model/stepping

If the CPU family/model/stepping are provided on the command line, but the firmware is being automatically extracted from the libvirt guest, we try to build the VMSA too early. This leads to an exception trying to parse the firmware that has not been loaded yet. We must delay building the VMSA in

[PATCH v3 1/2] conf: add support for discard_granularity

This introduces the ability to set the discard granularity option for a disk. It defines the smallest amount of data that can be discarded in a single operation (useful for managing and optimizing storage). However, most hypervisors automatically set the proper discard granularity and users

[PATCH v3 2/2] qemu: add support for discard_granularity

This commit adds building of `discard_granularity` disk option for qemu commandline. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1849570 Signed-off-by: Kristina Hanicova --- src/qemu/qemu_command.c | 2 + .../disk-blockio.x86_64-latest.args | 2 +-

[PATCH v3 0/2] add support for discard_granularity

v3 of: https://listman.redhat.com/archives/libvir-list/2023-August/241452.html diff to v2 (suggested by Peter): * added note to the first commit * enabled qemuxml2xmltest for blockio * moved one hunk to the first commit Kristina Hanicova (2): conf: add support for discard_granularity qemu:

Re: [PATCH] docs: Improve documentation of

On a Friday in 2023, Peter Krempa wrote: Note the implications and caveats of . Closes: https://gitlab.com/libvirt/libvirt/-/issues/519 Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 18 ++ 1 file changed, 18 insertions(+) Reviewed-by: Ján Tomko Jano

Re: [PATCH] docs: Improve documentation of

On Fri, Aug 25, 2023 at 02:34:04PM +0200, Peter Krempa wrote: > Note the implications and caveats of . > > Closes: https://gitlab.com/libvirt/libvirt/-/issues/519 > Signed-off-by: Peter Krempa > --- > docs/formatdomain.rst | 18 ++ > 1 file changed, 18 insertions(+)

[PATCH] docs: Improve documentation of

Note the implications and caveats of . Closes: https://gitlab.com/libvirt/libvirt/-/issues/519 Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cd9cb02bf8..9787933d4d

[PATCH (pushed)] qemucapabilitiesdata: Final update of capability test data for qemu-8.1.0 release

Signed-off-by: Peter Krempa --- Pushed as trivial. tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies | 6 +++--- tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_8.1.0_x86_64.replies

Re: [PATCH v2 2/2] qemu: add support for discard_granularity

On Fri, Aug 25, 2023 at 13:52:15 +0200, Kristina Hanicova wrote: > This commit adds building of `discard_granularity` disk option > for qemu commandline. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1849570 > > Signed-off-by: Kristina Hanicova > --- > src/qemu/qemu_command.c

Re: [PATCH v2 1/2] conf: add support for discard_granularity

On Fri, Aug 25, 2023 at 13:52:14 +0200, Kristina Hanicova wrote: > This introduces the ability to set the discard granularity option > for a disk. It defines the smallest amount of data that can be > discarded in a single operation (useful for managing and > optimizing storage). > >

[PATCH v2 2/2] qemu: add support for discard_granularity

This commit adds building of `discard_granularity` disk option for qemu commandline. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1849570 Signed-off-by: Kristina Hanicova --- src/qemu/qemu_command.c| 2 ++ src/vz/vz_utils.c

[PATCH v2 0/2] add support for discard_granularity

This is v2 (or rather the first 2 patches) of: https://listman.redhat.com/archives/libvir-list/2023-August/241076.html diff to v1: * added ABI stability check (noticed by Peter) * splitting the series into two parts Kristina Hanicova (2): conf: add support for discard_granularity qemu: add

[PATCH v2 1/2] conf: add support for discard_granularity

This introduces the ability to set the discard granularity option for a disk. It defines the smallest amount of data that can be discarded in a single operation (useful for managing and optimizing storage). Signed-off-by: Kristina Hanicova --- docs/formatdomain.rst | 6 +-

[PATCH] virsh-network: Drop unused variables in cmdNetworkMetadata()

In one of recent commits two variable were introduced (@ctxt and @doc) that are not used. This breaks a build with clang who's able to identify that. Signed-off-by: Michal Privoznik --- Pushed under trivial and build breaker rules. tools/virsh-network.c | 3 +-- 1 file changed, 1

Re: [PATCH 00/27] Move error messages onto a single line

On 8/25/23 12:14, Pavel Hrdina wrote: > On Fri, Aug 25, 2023 at 09:39:57AM +0200, Michal Privoznik wrote: >> This is inspired by the following discussion: >> >> https://listman.redhat.com/archives/libvir-list/2023-August/241361.html > > We have it covered by coding style document so it would be

Re: [libvirt PATCH 0/2] Document basic VFIO variant driver support

On 8/25/23 06:23, Laine Stump wrote: > update the manpage for the virsh nodedev-detach --driver option, and add a > blurb to the NEWS file for the upcoming release > > Laine Stump (2): > docs: update description of virsh nodedev-detach --driver option > NEWS: document support for VFIO

Re: [libvirt PATCH v2 4/7] virsh exposure of Network Metadata APIs

On 8/16/23 20:47, K Shiva Kiran wrote: > Adds two new commands and a new option: > - 'net-desc' to show/modify network title and description. > - 'net-metadata' to show/modify network metadata. > - Option '--title' for 'net-list' to print corresponding > network titles in an additional column. >

Re: [libvirt PATCH v2 0/7] Introduce new Metadata fields for Network object with corresponding APIs

On 8/16/23 20:47, K Shiva Kiran wrote: > This commit adds the following: > - Introduction of and fields to the Network Object. > - Introduction of Get and Set Public APIs for the aforementioned fields. > - virsh exposure of the aforementioned Public APIs. > - Adds implementation in test driver

Re: [libvirt PATCH v2 5/7] Add virNetworkObj Get and Set Methods for Metadata

On 8/16/23 20:47, K Shiva Kiran wrote: > - Introduces virNetworkObjGetMetadata() and > virNetworkObjSetMetadata(). > - These functions implement common behaviour that can be reused by > network drivers. > - Introduces virNetworkObjUpdateModificationImpact() among other > helper functions

Re: [PATCH 00/27] Move error messages onto a single line

On Fri, Aug 25, 2023 at 09:39:57AM +0200, Michal Privoznik wrote: > This is inspired by the following discussion: > > https://listman.redhat.com/archives/libvir-list/2023-August/241361.html We have it covered by coding style document so it would be nice to make a syntax-check for it as well so

CPU pinning implementation through libvirt

I'll be direct. After learning that QEMU itself has never officially implemented options such as "-vcpu", "-vcpupin", or similar, remaining only as unimplemented commits at their mailing lists, I felt the need of asking here once and for all: How does libvirt actually implements CPU pinning

[PATCH 11/27] node_device: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/node_device/node_device_udev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c

[PATCH 18/27] storage: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/storage/storage_backend_disk.c | 3 +- src/storage/storage_backend_fs.c | 3 +- src/storage/storage_backend_zfs.c | 3 +- src/storage/storage_driver.c | 21

[PATCH 16/27] rpc: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/rpc/virnetclient.c| 9 +++ src/rpc/virnetlibsshsession.c | 28 +++--- src/rpc/virnetserver.c| 9 +++ src/rpc/virnetserverclient.c | 3

[PATCH 27/27] tools: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- tools/virsh-domain-event.c | 15 +- tools/virsh-domain.c| 36 +++-- tools/virsh-host.c | 9 +++--

[PATCH 23/27] vmware: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/vmware/vmware_conf.c | 9 +++-- src/vmware/vmware_driver.c | 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/vmware/vmware_conf.c

[PATCH 14/27] qemu: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/qemu/qemu_agent.c| 18 +-- src/qemu/qemu_capabilities.c | 45 +++ src/qemu/qemu_command.c | 42 ++- src/qemu/qemu_conf.c | 5 +-

[PATCH 08/27] locking: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/locking/lock_driver_sanlock.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sanlock.c index

[PATCH 05/27] esx: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/esx/esx_driver.c | 21 +++-- src/esx/esx_network_driver.c | 3 +-- src/esx/esx_storage_backend_vmfs.c | 3 +-- src/esx/esx_util.c

[PATCH 22/27] vbox: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/vbox/vbox_snapshot_conf.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/vbox/vbox_snapshot_conf.c b/src/vbox/vbox_snapshot_conf.c index

[PATCH 21/27] util: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/util/vircgroupv2devices.c| 13 - src/util/vircommand.c| 3 +-- src/util/virfile.c | 3 +-- src/util/virhostcpu.c| 3 +--

[PATCH 26/27] src: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/libvirt-domain.c | 54 +++- 1 file changed, 18 insertions(+), 36 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c

[PATCH 15/27] remote: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/remote/remote_daemon.c | 3 +-- src/remote/remote_driver.c | 27 +-- src/remote/remote_sockets.c | 3 +-- 3 files changed, 11 insertions(+), 22

[PATCH 25/27] vz: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/vz/vz_driver.c | 15 ++--- src/vz/vz_sdk.c| 135 +++-- src/vz/vz_utils.c | 66 -- 3 files changed, 72

[PATCH 12/27] nwfilter: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/nwfilter/nwfilter_dhcpsnoop.c | 12 src/nwfilter/nwfilter_learnipaddr.c | 8 ++-- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git

[PATCH 20/27] test: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/test/test_driver.c | 39 +-- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c

[PATCH 13/27] openvz: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/openvz/openvz_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 69e4c9899b..1bd96dfb56

[PATCH 24/27] vmx: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/vmx/vmx.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 5c6925be22..26b89776e1 100644 ---

[PATCH 17/27] security: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index

[PATCH 19/27] storage_file: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/storage_file/storage_source.c | 3 +- .../storage_source_backingstore.c | 36 +++ 2 files changed, 13 insertions(+), 26 deletions(-)

[PATCH 10/27] network: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 14 -- src/network/bridge_driver_linux.c | 10 +- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git

[PATCH 09/27] lxc: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/lxc/lxc_container.c | 3 +-- src/lxc/lxc_driver.c| 3 +-- src/lxc/lxc_native.c| 3 +-- src/lxc/lxc_process.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-)

[PATCH 07/27] libxl: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/libxl/libxl_conf.c | 12 src/libxl/libxl_driver.c| 6 ++ src/libxl/libxl_migration.c | 11 --- 3 files changed, 10 insertions(+), 19

[PATCH 06/27] hypervisor: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/hypervisor/domain_cgroup.c | 3 +-- src/hypervisor/virhostdev.c| 9 +++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/hypervisor/domain_cgroup.c

[PATCH 02/27] ch: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/ch/ch_driver.c | 3 +-- src/ch/ch_monitor.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index

[PATCH 01/27] bhyve: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/bhyve/bhyve_command.c | 31 ++- src/bhyve/bhyve_domain.c | 3 +-- src/bhyve/bhyve_driver.c | 3 +-- 3 files changed, 12 insertions(+), 25

[PATCH 04/27] cpu: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/cpu/cpu_x86.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index b9513e24d5..7a7f3b409d 100644 ---

[PATCH 03/27] conf: Move error messages onto a single line

Error messages are exempt from the 80 columns rule. Move them onto one line. Signed-off-by: Michal Privoznik --- src/conf/cpu_conf.c | 9 +- src/conf/domain_addr.c | 3 +- src/conf/domain_conf.c | 138 +++

[PATCH 00/27] Move error messages onto a single line

This is inspired by the following discussion: https://listman.redhat.com/archives/libvir-list/2023-August/241361.html And ideally I'd present a green pipeline but for some reason, I can't: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/981105262 But the problem is not with my code

[PING] Patches Pending review

A gentle reminder, the following patch set has been pending review since 9 days. Link to Patch set: https://listman.redhat.com/archives/libvir-list/2023-August/241250.html Thanks