Change example logfile path and clarify how complicated all things passt
are. I chose not to create the non-existing directory because it could
open a whole new can of worms.
Also explain missing `dev` attribute of ``
Resolves: https://issues.redhat.com/browse/RHEL-1833
Signed-off-by: Martin
They represent nanoseconds, and we accept such values already. Not that
anyone would use such values in the wild, but even one person testing
QEMU could put in a bigger value and will be bothered with validation
errors after every `virsh edit`. Also add a test for it.
Resolves:
On 8/16/23 4:19 PM, Jonathon Jongsma wrote:
On 8/8/23 6:00 AM, Stefano Garzarella wrote:
On Mon, Aug 07, 2023 at 03:41:21PM +0200, Peter Krempa wrote:
On Thu, Aug 03, 2023 at 09:48:01 +0200, Stefano Garzarella wrote:
On Wed, Aug 2, 2023 at 10:33 PM Jonathon Jongsma
wrote:
> On 7/24/23 8:05
On Thu, Aug 31, 2023 at 05:45:05PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:09PM +0200, Erik Skultety wrote:
> > These are common variables we wish to use in containerized environments
> > both in GitLab and locally. Having these defined in a single place
> > rather than
When we parse we keep that in memory
and pass it down to the hypervisor. However, that MAC address is not
strictly valid as it is not marked as locally administered (bit 0x02)
but it is not even globally unique. It is also used for loopback device
on Linux, for example. And QEMU sees such MAC
The test does not use VIR_TEST_DIFFERENT anyway, so it's probably a
leftover.
Signed-off-by: Martin Kletzander
---
Pushed as trivial
tests/genericxml2xmloutdata/device-backenddomain.xml | 1 -
1 file changed, 1 deletion(-)
delete mode 12
On a Wednesday in 2023, K Shiva Kiran wrote:
Ref to patchset implementing the above:
https://listman.redhat.com/archives/libvir-list/2023-August/241250.html
Signed-off-by: K Shiva Kiran
---
This is a v2 of:
https://listman.redhat.com/archives/libvir-list/2023-August/241469.html
Diff to v1:
-
This NEWS entry announcing the new metadata APIs for network object in
version 9.7.0 seems to have been missed for the release.
Link to patch:
https://listman.redhat.com/archives/libvir-list/2023-August/241592.html
- Shiva
On Fri, Sep 01, 2023 at 11:10:43AM +0200, Peter Krempa wrote:
> On Fri, Sep 01, 2023 at 10:32:12 +0200, Pavel Hrdina wrote:
> > We need to skip all disks that have snapshot type other than 'external'.
>
> Since the commit message is vague on the specific problem details ...
>
> > Signed-off-by:
The 9.7.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://download.libvirt.org/
https://download.libvirt.org/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing
On Fri, Sep 01, 2023 at 11:12:40 +0100, Daniel P. Berrangé wrote:
> When the projects were archived, their pipelines were all purged, and
> no new ones will be run. There is no point in continuing to display
> them on the CI dashboard.
>
> Signed-off-by: Daniel P. Berrangé
> ---
>
On Fri, Sep 01, 2023 at 10:46:06AM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 31, 2023 at 03:30:23PM +0100, Daniel P. Berrangé wrote:
> > On Fri, Aug 25, 2023 at 07:55:13PM +0200, Erik Skultety wrote:
> > > This would normally be not needed at all, but the problem here is the
> > >
When the projects were archived, their pipelines were all purged, and
no new ones will be run. There is no point in continuing to display
them on the CI dashboard.
Signed-off-by: Daniel P. Berrangé
---
docs/ci-dashboard.rst | 35 ---
1 file changed, 35
On Fri, Sep 01, 2023 at 10:41:26AM +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 01, 2023 at 11:39:34AM +0200, Erik Skultety wrote:
> > On Fri, Sep 01, 2023 at 02:15:59AM -0700, Andrea Bolognani wrote:
> > > On Thu, Aug 31, 2023 at 04:53:47PM +0100, Daniel P. Berrangé wrote:
> > > > I'm also
On Thu, Aug 31, 2023 at 23:46:57 +0530, K Shiva Kiran wrote:
> Fixes the following bug:
> Command: `net-desc --config [--title] my_network`
> Expected Output: Title/Description of persistent config
> Output: Title/Description of live config
>
> This was caused due to the usage
On Thu, Aug 31, 2023 at 03:30:23PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:13PM +0200, Erik Skultety wrote:
> > This would normally be not needed at all, but the problem here is the
> > Shell-in-YAML which GitLab interprets. It outputs every command that
> > appears as a
On Fri, Sep 01, 2023 at 11:24:28 +0200, Peter Krempa wrote:
> On Fri, Sep 01, 2023 at 10:32:17 +0200, Pavel Hrdina wrote:
> > Reverting external snapshot for running VM doesn't work correctly so we
> > should not report this capability until it is fixed.
> >
> > This reverts commit
On Fri, Sep 01, 2023 at 11:39:34AM +0200, Erik Skultety wrote:
> On Fri, Sep 01, 2023 at 02:15:59AM -0700, Andrea Bolognani wrote:
> > On Thu, Aug 31, 2023 at 04:53:47PM +0100, Daniel P. Berrangé wrote:
> > > I'm also strongly inclined to archive the following:
> > >
> > > * libvirt-cim
> > >
On Fri, Sep 01, 2023 at 10:32:15 +0200, Pavel Hrdina wrote:
> Original code assumed that the memory state file is only migration
> stream but it has additional metadata stored by libvirt. To correctly
> load the memory state file we need to reuse code that is used when
> restoring domain from
On Thu, Aug 31, 2023 at 16:55:05 +0200, Pavel Hrdina wrote:
> Original code assumed that the memory state file is only migration
> stream but it has additional metadata stored by libvirt. To correctly
> load the memory state file we need to reuse code that is used when
> restoring domain from
On Fri, Sep 01, 2023 at 02:15:59AM -0700, Andrea Bolognani wrote:
> On Thu, Aug 31, 2023 at 04:53:47PM +0100, Daniel P. Berrangé wrote:
> > I'm also strongly inclined to archive the following:
> >
> > * libvirt-cim
> > * libvirt-appdev-guide-python
> > * libvirt-publican
> > *
On Thu, Aug 31, 2023 at 16:55:03 +0200, Pavel Hrdina wrote:
> When used with internal snapshots there is no header to be used and no
> memory state to be decompressed.
This ...
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_saveimage.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
On Thu, Aug 31, 2023 at 16:55:02 +0200, Pavel Hrdina wrote:
> When called from snapshot code we will need to pass snapshot object in
> order to make internal snapshots work correctly.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_saveimage.c | 6 --
> src/qemu/qemu_saveimage.h | 1 +
On Thu, Aug 31, 2023 at 16:55:01 +0200, Pavel Hrdina wrote:
> When called by snapshot code we will need to use different reason.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_saveimage.c | 6 --
> src/qemu/qemu_saveimage.h | 1 +
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
On Thu, Aug 31, 2023 at 16:55:00 +0200, Pavel Hrdina wrote:
> Part of qemuSaveImageStartVM() function will be used when reverting
> external snapshots. To avoid duplicating code and logic extract the
> shared bits into separate function.
>
> Signed-off-by: Pavel Hrdina
> ---
>
On Fri, Sep 01, 2023 at 11:21:04AM +0200, Erik Skultety wrote:
> On Thu, Aug 31, 2023 at 05:17:13PM +0100, Daniel P. Berrangé wrote:
> > On Fri, Aug 25, 2023 at 07:55:08PM +0200, Erik Skultety wrote:
> > > Technically a v2 of:
> > >
On Fri, Sep 01, 2023 at 10:32:17 +0200, Pavel Hrdina wrote:
> Reverting external snapshot for running VM doesn't work correctly so we
> should not report this capability until it is fixed.
>
> This reverts commit de71573bfec7f3acd22ec74794318de121716e21.
>
> Signed-off-by: Pavel Hrdina
> ---
On Fri, Sep 01, 2023 at 10:32:16 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> NEWS.rst | 8
> 1 file changed, 8 insertions(+)
Reviewed-by: Peter Krempa
On Fri, Sep 01, 2023 at 10:32:15 +0200, Pavel Hrdina wrote:
> Original code assumed that the memory state file is only migration
> stream but it has additional metadata stored by libvirt. To correctly
> load the memory state file we need to reuse code that is used when
> restoring domain from
On Thu, Aug 31, 2023 at 05:17:13PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:08PM +0200, Erik Skultety wrote:
> > Technically a v2 of:
> > https://listman.redhat.com/archives/libvir-list/2023-February/237552.html
> >
> > However, the approach here is slightly different and
On Fri, Sep 01, 2023 at 11:16:09AM +0200, Erik Skultety wrote:
> On Fri, Sep 01, 2023 at 10:10:55AM +0100, Daniel P. Berrangé wrote:
> > On Fri, Aug 25, 2023 at 07:55:13PM +0200, Erik Skultety wrote:
> > > This would normally be not needed at all, but the problem here is the
> > > Shell-in-YAML
On Fri, Sep 01, 2023 at 09:29:13AM +0200, Erik Skultety wrote:
> On Thu, Aug 31, 2023 at 05:55:54PM +0100, Daniel P. Berrangé wrote:
> > On Fri, Aug 25, 2023 at 07:55:19PM +0200, Erik Skultety wrote:
> > > This helper is a shell function transcript of its original GitLab CI
> > > counterpart.
> >
On Fri, Sep 01, 2023 at 10:10:55AM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:13PM +0200, Erik Skultety wrote:
> > This would normally be not needed at all, but the problem here is the
> > Shell-in-YAML which GitLab interprets. It outputs every command that
> > appears as a
On Thu, Aug 31, 2023 at 04:53:47PM +0100, Daniel P. Berrangé wrote:
> I'm also strongly inclined to archive the following:
>
> * libvirt-cim
> * libvirt-appdev-guide-python
> * libvirt-publican
> * libvirt-sandbox
> * libvirt-sandbox-image
> * libvirt-designer
Sounds good to me. It
On Fri, Sep 01, 2023 at 10:32:14 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_saveimage.c | 2 +-
> src/qemu/qemu_saveimage.h | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
Also squashable into the previous commit since you need both for the
same
On Fri, Sep 01, 2023 at 10:32:13 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_saveimage.c | 17 -
> src/qemu/qemu_saveimage.h | 17 +
> 2 files changed, 17 insertions(+), 17 deletions(-)
Reviewed-by: Peter Krempa
On Fri, Aug 25, 2023 at 07:55:13PM +0200, Erik Skultety wrote:
> This would normally be not needed at all, but the problem here is the
> Shell-in-YAML which GitLab interprets. It outputs every command that
> appears as a line in the 'script' segment in a color-coded fashion for
> easy
On Fri, Sep 01, 2023 at 10:32:12 +0200, Pavel Hrdina wrote:
> We need to skip all disks that have snapshot type other than 'external'.
Since the commit message is vague on the specific problem details ...
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_snapshot.c | 12
> 1
On Fri, Aug 25, 2023 at 07:55:19PM +0200, Erik Skultety wrote:
> This helper is a shell function transcript of its original GitLab CI
> counterpart.
>
> Signed-off-by: Erik Skultety
> ---
> ci/build.sh | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/ci/build.sh
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 17 -
src/qemu/qemu_saveimage.h | 17 +
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index 41310d6a9a..eca47171c2 100644
---
Original code assumed that the memory state file is only migration
stream but it has additional metadata stored by libvirt. To correctly
load the memory state file we need to reuse code that is used when
restoring domain from saved image.
This duplicates some necessary parts of
Signed-off-by: Pavel Hrdina
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e40c8ac259..a3be76d6cc 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -28,6 +28,14 @@ v9.7.0 (unreleased)
2) pre-binding the variant driver using the ``--driver`` option
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 2 +-
src/qemu/qemu_saveimage.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index eca47171c2..44ab263144 100644
--- a/src/qemu/qemu_saveimage.c
+++
Reverting external snapshot for running VM doesn't work correctly so we
should not report this capability until it is fixed.
This reverts commit de71573bfec7f3acd22ec74794318de121716e21.
Signed-off-by: Pavel Hrdina
---
docs/formatcaps.rst| 7 ---
We need to skip all disks that have snapshot type other than 'external'.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index d943281e35..ff85d56572 100644
---
This fixes reverting external snapshots to not error out in cases where
it should work and makes it correctly load the memory state when
reverting to snapshot of running VM.
Last patch is not part of the fix, it is alternative solution to remove
the capability as we are close to releasing libvirt
On Thu, Aug 31, 2023 at 06:28:16PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:08PM +0200, Erik Skultety wrote:
> > Technically a v2 of:
> > https://listman.redhat.com/archives/libvir-list/2023-February/237552.html
> >
> > However, the approach here is slightly different and
On Thu, Aug 31, 2023 at 17:59:27 +0200, Pavel Hrdina wrote:
> On Thu, Aug 31, 2023 at 05:43:35PM +0200, Peter Krempa wrote:
> > On Thu, Aug 31, 2023 at 16:55:03 +0200, Pavel Hrdina wrote:
> > > When used with internal snapshots there is no header to be used and no
> > > memory state to be
On Thu, Aug 31, 2023 at 05:59:26PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:22PM +0200, Erik Skultety wrote:
> > We've moved all invocations to the respective helper function which
> > we'll execute both from gitlab CI jobs and local environments so we
> > don't need to
On Thu, Aug 31, 2023 at 05:55:54PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:19PM +0200, Erik Skultety wrote:
> > This helper is a shell function transcript of its original GitLab CI
> > counterpart.
> >
> > Signed-off-by: Erik Skultety
> > ---
> > ci/build.sh | 11
On Thu, Aug 31, 2023 at 05:55:21PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:18PM +0200, Erik Skultety wrote:
> > This helper is a shell function transcript of its original GitLab CI
> > counterpart. There's one notable difference such that we pass '-j1' to
> > the meson
51 matches
Mail list logo
