[libvirt PATCH v4] ch: Fix cloud-hypervisor version processing

2023-09-08 Thread Praveen K Paladugu
Refactor the version processing logic in ch driver to support versions from non-release cloud-hypervisor binaries. This version also supports versions with branch prefixes in them. Signed-off-by: Praveen K Paladugu --- src/ch/ch_conf.c | 34 -- 1 file changed, 32

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-09-08 Thread Peter Krempa
On Fri, Sep 08, 2023 at 14:51:14 -0500, Jonathon Jongsma wrote: > On 7/24/23 8:05 AM, Peter Krempa wrote: > > As I've promised a long time ago I gave your patches some testing in > > regards of cooperation with blockjobs and snapshots. > > > > Since the new version of the patches was not yet

Re: [libvirt PATCH 5/5] qemu: Implement support for vDPA block devices

2023-09-08 Thread Jonathon Jongsma
On 7/24/23 8:05 AM, Peter Krempa wrote: As I've promised a long time ago I gave your patches some testing in regards of cooperation with blockjobs and snapshots. Since the new version of the patches was not yet posted on the list I'm replying here including my observations from testing patches

[PATCH v2] interface: fix udev_device_get_sysattr_value return value check

2023-09-08 Thread Dmitry Frolov
Reviewing the code I found that return value of function udev_device_get_sysattr_value() is dereferenced without a check. udev_device_get_sysattr_value() may return NULL by number of reasons. v2: VIR_DEBUG added, replaced STREQ(NULLSTR()) with STREQ_NULLABLE() Signed-off-by: Dmitry Frolov ---

Re: [PATCH] interface: fix udev_device_get_sysattr_value return value check

2023-09-08 Thread Peter Krempa
On Fri, Sep 08, 2023 at 13:06:43 +0300, Dmitry Frolov wrote: > Reviewing the code I found that return value of function > udev_device_get_sysattr_value() is dereferenced without a check. > udev_device_get_sysattr_value() may return NULL by number of reasons. > > Signed-off-by: Dmitry Frolov >

[PATCH] interface: fix udev_device_get_sysattr_value return value check

2023-09-08 Thread Dmitry Frolov
Reviewing the code I found that return value of function udev_device_get_sysattr_value() is dereferenced without a check. udev_device_get_sysattr_value() may return NULL by number of reasons. Signed-off-by: Dmitry Frolov --- src/interface/interface_backend_udev.c | 11 ++- 1 file

Re: [PATCH] virnetdevopenvswitch: Propagate OVS error messages

2023-09-08 Thread Martin Kletzander
On Fri, Sep 08, 2023 at 11:04:38AM +0200, Michal Privoznik wrote: When configuring OVS interfaces/bridges we spawn 'ovs-vsctl' with appropriate arguments and if it exited with a non-zero status we report a generic error message, like "Unable to add port vnet0 to OVS bridge ovsbr0". This is all

[PATCH] virnetdevopenvswitch: Propagate OVS error messages

2023-09-08 Thread Michal Privoznik
When configuring OVS interfaces/bridges we spawn 'ovs-vsctl' with appropriate arguments and if it exited with a non-zero status we report a generic error message, like "Unable to add port vnet0 to OVS bridge ovsbr0". This is all cool, but the real reason why operation failed is hidden in (debug)