Re: [libvirt PATCH v2 0/5] Add support for vDPA block devices

2023-09-12 Thread Jonathon Jongsma
On 9/12/23 7:00 AM, Peter Krempa wrote: On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote: see https://bugzilla.redhat.com/show_bug.cgi?id=1900770. Changes in v2: - Don't use virStorageSource->path for vdpa device path to avoid clashing with existing path functionality -

[PATCH] fix uint64 underflow

2023-09-12 Thread Dmitry Frolov
According to previous statement, 'free_mem' is less than 'needed_mem'. So, the subtraction 'free_mem - needed_mem' is negative, and will raise uint64 underflow. Signed-off-by: Dmitry Frolov --- src/libxl/libxl_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt PATCHv1 8/8] docs: virtiofs: add section about ID remapping

2023-09-12 Thread Daniel P . Berrangé
On Tue, Sep 12, 2023 at 04:05:04PM +0200, Ján Tomko wrote: > On a Monday in 2023, Daniel P. Berrangé wrote: > > On Mon, Sep 11, 2023 at 03:51:28PM +0200, Ján Tomko wrote: > > > Signed-off-by: Ján Tomko > > > --- > > > docs/kbase/virtiofs.rst | 29 + > > > 1 file

Re: [libvirt PATCHv1 8/8] docs: virtiofs: add section about ID remapping

2023-09-12 Thread Ján Tomko
On a Monday in 2023, Daniel P. Berrangé wrote: On Mon, Sep 11, 2023 at 03:51:28PM +0200, Ján Tomko wrote: Signed-off-by: Ján Tomko --- docs/kbase/virtiofs.rst | 29 + 1 file changed, 29 insertions(+) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst

Re: [libvirt PATCHv1 0/8] support running virtiofsd in session mode

2023-09-12 Thread Ján Tomko
On a Monday in 2023, Michal Prívozník wrote: On 9/11/23 15:51, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=2034630 https://gitlab.com/libvirt/libvirt/-/issues/535 https://gitlab.gnome.org/GNOME/gnome-boxes/-/issues/292 Ján Tomko (8): qemu: fix indentation conf: move idmap

[PATCH v3] interface: fix udev_device_get_sysattr_value return value check

2023-09-12 Thread Dmitry Frolov
Reviewing the code I found that return value of function udev_device_get_sysattr_value() is dereferenced without a check. udev_device_get_sysattr_value() may return NULL by number of reasons. v2: VIR_DEBUG added, replaced STREQ(NULLSTR()) with STREQ_NULLABLE() v3: More checks added, to skip

Re: [libvirt PATCH v2 0/5] Add support for vDPA block devices

2023-09-12 Thread Peter Krempa
On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote: > see https://bugzilla.redhat.com/show_bug.cgi?id=1900770. > > Changes in v2: > - Don't use virStorageSource->path for vdpa device path to avoid clashing > with >existing path functionality > - Move vdpa device opening to the

Re: [PATCH v1 0/9] query & cache host-recommended CPU model

2023-09-12 Thread Peter Krempa
On Mon, Sep 11, 2023 at 17:07:07 -0400, Collin Walling wrote: > Notes: > https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg02518.html > - For information regarding the QEMU "static-recommended" (aka > host-recommended) >CPU model, please see the analogous QEMU patches: > >

Re: [PATCH v1 2/9] qemu: capabilities: add static-recommended capability

2023-09-12 Thread Peter Krempa
On Mon, Sep 11, 2023 at 17:07:09 -0400, Collin Walling wrote: > Check for the QEMU capability to query for a static-recommended CPU > model via CPU model expansion. Cache this capability for later. > > Signed-off-by: Collin Walling > Reviewed-by: Boris Fiuczynski > --- >